1. 03 Jul, 2000 1 commit
    • Morten Welinder's avatar
      Don't add one to the number of lines if the last line is empty. · 332034ff
      Morten Welinder authored
      2000-07-03  Morten Welinder  <terra@diku.dk>
      	* src/stf-parse.c (stf_parse_get_rowcount): Don't add one to the
       	number of lines if the last line is empty.
      	* src/sheet.c (sheet_cell_set_text): Plug leak.
      	* src/workbook-format-toolbar.c
       	(do_sheet_selection_apply_number_format): Avoid double translation
       	of format.
      	* src/mstyle.c (mstyle_set_format_text): Renamed from
      	(mstyle_set_format): New function taking a StyleFormat *.
  2. 14 Jun, 2000 2 commits
    • Morten Welinder's avatar
      Partially fix space stripping. Fields must still be selected · accb8d3d
      Morten Welinder authored
      right-to-left, :-(
      2000-06-13  Morten Welinder  <terra@diku.dk>
      	* src/stf-parse.c (trim_spaces_inplace): New function.
      	(stf_parse_fixed_cell): Don't trim spaces here.
      	(stf_parse_fixed_line): Trim here.
      	(stf_parse_csv_cell): Don't trim spaces here.
      	(stf_parse_csv_line): Trim here.
      2000-06-13  Morten Welinder  <terra@diku.dk>
      	* dialog-stf-format-page.c (format_page_format_changed): Plug
    • Jody Goldberg's avatar
      Patch a leak. fix a typo. · 634456bb
      Jody Goldberg authored
      Patch a leak.
      fix a typo.
  3. 27 May, 2000 1 commit
    • Almer. S. Tigelaar's avatar
      New function. (stf_parse_csv_cell): Modified so it can trim spaces in · c20793a2
      Almer. S. Tigelaar authored
      2000-05-27  Almer. S. Tigelaar.  <almer1@dds.nl>
      	* src/dialogs/stf-parse.c:
      	(stf_parse_options_set_trim_spaces): New function.
      	(stf_parse_csv_cell): Modified so it can trim spaces in
      	several ways
      	(stf_parse_fixed_cell): Ditto.
      	(stf_parse_get_longest_row_width) : Fixed small bug which
      	caused incorrect width to be returned.
      	* src/dialogs/dialog-stf.glade:
      	Added trim spaces option and did some general polishing.
      	* src/dialogs/dialog-stf.h:
      	Added new member to DruidPageData_t which indicates weather
      	the user wants to trim spaces and in which way.
      	* src/dialogs/dialog-stf-main-page.c:
      	(stf_dialog_main_page_init): Modified so it loads the trim optionmenu.
      	(main_page_trim_menu_deactivate): New.
      	* src/dialogs/dialog-stf-csv-page.c:
      	(stf_dialog_csv_page_prepare): Now sets the trim member of the parse
      	options struct.
      	* src/dialogs/dialog-stf-fixed-page.c:
      	(stf_dialog_fixed_page_prepare): Now sets the trim member of the
      	parse options struct.
      	(stf_dialog_fixed_page_prepare): Did not honor the from/to line
      	(fixed_page_remove_clicked): Added gnumeric_clist_moveto to make
      	selection visible.
      	(fixed_page_add_clicked): Ditto.
      	* src/dialogs/dialog-stf-format-page.c:
      	(format_page_canvas_button_press_event): Modified to use
      	(format_page_collist_select_row): Ditto.
      	(format_page_format_changed): Ditto.
      	(stf_dialog_format_page_prepare): Ditto.
      	* src/gnumeric-util.c, src/gnumeric-util.h:
      	(gnumeric_option_menu_get_selected_index): New function, Returns
      	the selected index of a GtkOptionMenu. (Originally from
      	* src/dialogs/dialog-stf-export-format-page.c:
      	(stf_export_dialog_option_menu_index): Removed.
      	(sheet_page_separator_menu_deactivate): Modified to use the new
      	(stf_export_dialog_format_page_result): Ditto.
      	* doc/stf-parser.txt:
      	Update documentation.
  4. 08 May, 2000 1 commit
  5. 06 May, 2000 1 commit
    • Almer. S. Tigelaar's avatar
      Add the form feed character (\f) as valid text character. · 9f058999
      Almer. S. Tigelaar authored
      2000-05-06  Almer. S. Tigelaar.  <almer1@dds.nl>
      	* src/stf-parse.c (stf_parse_is_valid_data) : Add
      	the form feed character (\f) as valid text character.
      	(stf_parse_convert_to_unix) : In addition to CRLF and CR,
      	remove form feeds (\f) from data.
      	* src/stf.c (stf_read_workbook) : Add a workbook_recalc just
      	to be sure.
  6. 20 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Reorg cell contents and assignment. · bedb925b
      Jody Goldberg authored
      Fixs lots of usability details.
      2000-04-20  Jody Goldberg <jgoldberg@home.com>
      	* src/dialogs/dialog-cell-format.c : Use the edit_pos as the example
      	  not the top left corner.
      	* src/functions/fn-stat.c (gnumeric_ftest) : Use eval_pos_cellref
      	  to help localize the strangeness.
      	(gnumeric_ttest) : Ditto.
      	* src/xml-io.c (xml_write_cell_and_position) : If this is an array
      	  expression and we are the top left then add attributes to indicate
      	  size of array.  Ignore the rest of the array.
      	(xml_not_used_old_array_spec) : New routinr to handle the old array format.
      	(xml_cell_set_array_expr) : store an array.
      	(xml_read_cell) : Handle the old and the new array formats.
      	* src/workbook.c (workbook_close_if_user_permits) : Accept input
      	(wb_edit_key_pressed) : Handle array formulas here.
      	(workbook_detach_sheet) : Do not recalc all if we are exiting.
      	(workbook_start_editing_at_cursor) : When we start editing an
      	  array formula display just the formula not all the extra {}()[][] crap.
      	* src/sheet.c (SheetPrivate) : Add a recompute_spans flag.
      	(sheet_calc_spans) : New routine.
      	(sheet_cell_calc_span) : New routine.
      	(sheet_range_calc_spans) : Renamed and extended from
      	(sheet_update) : Use sheet_calc_spans when necessary.
      	  Update the location region when the edit_pos changes.
      	(cb_recalc_spans_in_col) : Renamed from cb_collect_cells_in_col.
      	  Recalcs spans directly, no need to collect first.
      	(cb_set_cell_content) : New routine to set expr, or expr_and_value.
      	(sheet_range_set_text) : Use cb_set_cell_content, and remember
      	  chosen format with the cell rather than overriding the assigned
      	(sheet_cell_set_text) : Renamed from sheet_set_text.  Be more specific
      	  about how spans, rendering and the rest are handled.
      	(sheet_cell_set_expr) : New routine.
      	(sheet_cell_set_value) : Ditto.
      	(sheet_load_cell_val) : When displaying an array formula add {%s}()[][].
      	(sheet_redraw_cell_region) : Honour spans when redrawing.
      	(sheet_redraw_partial_row) : New routine.
      	(sheet_redraw_cell) : Ditto.
      	(sheet_is_cell_array) : Use cell_is_array.
      	(sheet_range_splits_array) : Renamed from sheet_check_for_partial_array.
      	(sheet_cell_add_to_hash) :  Do not touch spans at this point.
      	(sheet_cell_insert) : Rename from sheet_cell_add made recalc span
      	(sheet_cell_new) : New routine that does not touch spans.
      	(sheet_cell_remove) : Made redraw optional.
      	(cb_clear_cell_comments) : Remove the cell if there is no comment.
      	(sheet_clear_region) : Remove the cell if there are no comments or
      	  contents.  Flag an update of the status region.
      	* src/sheet-view.c (cb_colrow_resize) : New function.
      	(sheet_view_col_size_changed) : Resize all rows, irrespective of
      	(sheet_view_row_size_changed) : existing cells.
      	(sheet_view_redraw_cell_region) : This no longer honours spans.
      	* src/sheet-style.c (sheet_style_attach) : Removed call to redraw.
      	sheet_cells_update : rename to sheet_range_calc_spans and move to
      	* src/sheet-autofill.c (autofill_cell) : Use sheet_cell_set_value
      	  rather than set_text.
      	* src/selection.c (sheet_selection_changed_hook) : Delete.
      	(sheet_selection_extend_to) : Update the status region to display the
      	  new size.
      	(sheet_selection_cut) : Use sheet_range_splits_array.
      	(selection_check_for_array) : New routine.
      	* src/parser.y : Remove icky array formula parsing that conflicted
      	  with array entries.
      	* src/number-match.c (format_match) : Return a Value * rather than a
      	* src/mstyle.c (mstyle_set_font_size) : Do not allow font sizes < 1.
      	* src/main.c (gnumeric_main) : Do NOT create an empty workbook
      	  then delete it if things are successfully loaded.  This causes
      	  a global recalc.  Instead add a flag to disable exit when the
      	  number of workbooks go to zero.  Then only enable the flag AFTER
      	  we have attempted to load the initial workbooks.
      	* src/item-grid.c (item_grid_event) : Update the status_region when
      	  button-1 is release.  It should display the edit_pos.
      	* src/gutils.c : Move cell_name, col_name, col_from_name,
      	  parse_cell_name, parse_cell_name_or_range and parse_cell_name_list,
      	  to parse-util.c.
      	* src/gnumeric.h  : Add RenderedValue.
      	* src/gnumeric-util.c (gnumeric_char_start_expr_p) : Move
      	  to parse-util.c
      	* src/file.c (workbook_read) : Remove freese thaw usage.
      	  Move call to update AFTER mark clean.
      	* src/expr.c (eval_pos_init) : Take a cellpos.
      	(parse_pos_evalpos) : New routine.
      	(eval_pos_cellref) : There is some questionable code scattered in the
      	  functions.  This routing localizes the odd bits for correction.
      	* src/eval.c (cell_eval_content) : Use sheet_redraw_cell,
      	  and rendered_value_calc_size.
      	(cell_get_dependencies) : Improve constness.
      	* src/corba-sheet.c : Remove the freeze thaw operations.
      	(Sheet_cell_set_formula) : Deleted.
      	(Sheet_range_set_formula) : Delete.
      	* src/commands.c : Adjust so that registration of command auto
      	  calls redo.  Add misc checks for splitting arrays.
      	* src/clipboard.h : Move the CellCopy types here from cell.h
      	* src/clipboard.c (paste_cell) : Use cell_has_expr.
      	  Don't insert the new cell till after its contents are assigned.
      	* src/cellspan.c (cell_register_span) : Improve constness.
      	(cell_unregister_span) : Ditto.
      	(row_cell_get_displayed_at) : Delete.
      	(cell_calc_span) : Moved here from cell.c
      	* src/dialogs/dialog-stf.glade : Adjust the header background colour
      	  to match the purdy new icon.  Add the icon.
      	* src/cell-draw.c : Use the rendered_value routines.
      	  Improve constness.
      	* src/analysis-tools.c (set_cell) : Use sheet_cell_fetch.
      	    cell_set_* -> sheet_cell_set_
      	    cell_set_*_simple -> cell_set_
      	    Cell::{row,col} -> Cell::{row,col}_info
      	    cell_get_text -> cell_get_entered_text
      	    cell_get_content -> cell_get_entered_text
      	    cell_name -> cell_coord_name
      	    cell_get_formatted_val -> cell_get_rendered_text
      	    cell_get_content -> cell_get_entered_text
      	* src/cell.c :
      	(cell_dirty) : Renamed from cell_modified.  Use
      	(cell_formula_changed) : Make the queuing of the recalc optional.
      	(cell_cleanout) : Handle union of expression and entered_text,
      	  and remove the rendered value.
      	(cell_copy) : Ditto.
      	(cell_destroy) : handle cell_modified -> cell_dirty.
      	(cell_set_text) : Use parse_text_value_or_expr and store the prefered
      	(cell_set_text_and_value) : New routine.
      	(cell_assign_value) : New routine.
      	(cell_set_value) : Support formats.
      	(cell_set_expr_and_value) : New routine.
      	(cell_set_expr_internal) : Split from cell_set_expr.
      	(cell_set_expr) : Divide to allow for not queuing a recalc.
      	(cell_set_array_formula) : Use cell_set_expr_internal.
      	(cell_is_array) : New utility.
      	(cell_is_partial_array) : New utility.
      	(cell_has_expr) : New utility.
      	(cell_render_value) : Use rendered_value_*.
      	Move all comment routines into cell-comment.[ch].
      	* idl/Gnumeric.idl : Remove cell_set_formula, and range_set_formula.
      	  These were identical to set_text.  Made Workbook embeddable.
  7. 08 Apr, 2000 1 commit
    • Almer. S. Tigelaar's avatar
      Result of gtk_editable_get_chars was not freed. (2x) · 41906667
      Almer. S. Tigelaar authored
      2000-04-08  Almer. S. Tigelaar.  <almer1@dds.nl>
      	* src/dialogs/dialog-stf-csv-page.c
      	(csv_page_global_change) : Result of gtk_editable_get_chars was not
      	freed. (2x)
      	* src/stf-parse.c
      	(stf_parse_region) : Only the last item of the GSList's would be
      	(stf_parse_sheet) : ditto
  8. 06 Apr, 2000 1 commit
  9. 02 Apr, 2000 1 commit
    • Jody Goldberg's avatar
      Add description of double quote handling. Init indicator_2x_is_single and · 527ca0cf
      Jody Goldberg authored
      2000-04-02  Jody Goldberg <jgoldberg@home.com>
      	* doc/stf-parser.txt : Add description of double quote handling.
              * src/stf-parse.c (stf_parse_options_new) : Init
      	  indicator_2x_is_single and duplicates.
      	(stf_parse_options_csv_set_indicator_2x_is_single) : New function.
      	(stf_parse_csv_cell) : Add logic to optionaly treat double quotes as a
      	  single escaped quote.
      	* src/dialogs/dialog-stf-csv-page.c : Add the double quote checkbox.
      	* src/dialogs/dialog-stf.glade : Ditto.
  10. 24 Mar, 2000 1 commit
    • Morten Welinder's avatar
      Stabilise regression tool -- still does not work. · a26a4a65
      Morten Welinder authored
      2000-04-23  Morten Welinder  <terra@diku.dk>
      	* src/regression.c (general_linear_regression): Don't do
       	extra_stat in case of error.
      	(general_linear_regression): Zero extra_stat.
      	* src/history.c (history_menu_remove_items): Warning killer.
      	* src/item-edit.c (scan_at): Fix usual signed/unsigned problem.
      	* src/stf-parse.c (stf_parse_csv_is_separator): Ditto.
      	(stf_parse_is_valid_data): Ditto.
  11. 21 Feb, 2000 1 commit
    • Almer. S. Tigelaar's avatar
      : csv_page_custom_toggled was called twice, removed one. · 39d5acca
      Almer. S. Tigelaar authored
      2000-02-21 Almer. S. Tigelaar.  <almer1@dds.nl>
      	* src/dialogs/dialog-stf-csv-page.c :
      	(csv_page_prepare) : csv_page_custom_toggled was called twice, removed one.
      	* src/stf.c, src/dialogs/dialog-stf.c, src/dialogs/dialog-stf-main-page.c,
      	* src/dialogs/dialog-stf-csv-page.c, src/dialogs/dialog-stf-fixed-page.c,
      	* src/dialogs/dialog-stf-format-page.c, src/dialogs/dialog-stf-preview.c
      	Fixed incorrect comments and added function comment headers where they
      	didn't exist. Also moved some includes.
      	* src/dialogs/dialog-stf.h
      	Removed TEXT_VOFFSET, because it is no langer required.
      	* src/dialogs/dialog-stf-preview.h
      	Changed the colours to match the current gnumeric sheet selection color
      	* src/dialogs/dialog-stf-format-page.c
      	(format_page_collist_select_row) : Makes selected row visible
      	(format_page_prepare) : Corrected minor error which caused the format entry to stay empty
      	* src/dialogs/dialog-stf.glade, src/dialogs/dialog-stf.c, src/dialogs/dialog-stf.h
      	Completely removed the "finish" page of the druid.
      	* src/dialogs/dialog-stf.glade, src/stf-parse.h, src/stf-parse.c
      	Fixed support for colon and added support for new separator
      	symbols : semicolon, pipe, slash, hyphen, bang.
      	separators are now also displayed on the csv page.
      	* src/stf-parse.c
      	(stf_parse_get_colcount) : last line wasn't counted
      	(stf_parse_get_colwidth) : idem
      	* src/stf.h :
      	Removed obsoleted FileSource_t struct type definition.
      	* src/stf.c :
      	(stf_read_workbook) : Detach sheet on parse error.
  12. 18 Feb, 2000 1 commit
    • Miguel de Icaza's avatar
      Remove stf plugin from here. And from here. · 86a1dc8b
      Miguel de Icaza authored
      2000-02-18  Miguel de Icaza  <miguel@gnu.org>
      	* configure.in (EXTRA_GNOME_CFLAGS): Remove stf plugin from here.
      	* plugins/Makefile.am (SUBDIRS): And from here.
      	* src/stf.c (stf_open_and_read): Use malloc instead of g_malloc0
      	because g_malloc aborts execution if the buffer is too large
      	(which it might likely be).
      	(stf_read_workbook): Release using free, not g_free here.
      	(stf_read_workbook): Fix sheet object memory leak.
      	(stf_init): Kill old and unused code.