1. 25 Feb, 2002 1 commit
    • Andreas J. Guelzow's avatar
      set flags (cb_fmt_dialog_set_focus) : remove code now in · 254d3db2
      Andreas J. Guelzow authored
      2002-02-25  Andreas J. Guelzow <aguelzow@taliesin.ca>
      
      	* dialog-cell-format.c (fmt_dialog_init_validation_expr_entry) :
      	  set flags
      	(cb_fmt_dialog_set_focus) : remove code now in wbcg_edit_attach_guru
      	* dialog-cell-sort.c (dialog_set_focus) : deleted
      	* dialog-consolidate.c (cb_dialog_set_focus) : deleted
      	(setup_widgets) : set expr entry flags
      	* dialog-define-names.c (cb_name_guru_set_focus) : deleted
      	(name_guru_init) : set expr entry flags
      	* dialog-goal-seek.c (dialog_set_focus) : deleted
      	* dialog-printer-setup.c (cb_do_print_set_focus) : deleted
      	* dialog-search-replace.c (set_focus) : deleted
      	* dialog-search.c (set_focus) : deleted
      	* dialog-solver.c (dialog_set_focus) : deleted
      	* dialog-tabulate.c (set_focus) : deleted
      
      2002-02-25  Andreas J. Guelzow <aguelzow@taliesin.ca>
      
      	* src/sheet-object-widget.c (cb_scrollbar_set_focus) : remove code
      	  now handeld in wbcg_edit_attach_guru
      	(cb_checkbox_set_focus) : ditto
      	(sheet_widget_scrollbar_user_config) : rearrange signal callbacks
      	(sheet_widget_checkbox_user_config) : ditto
      
      2002-02-25  Andreas J. Guelzow <aguelzow@taliesin.ca>
      
      	* gnumeric-expr-entry.c (gee_focus_in_event, gee_focus_out_event) :
      	  deleted
      	(gnumeric_expr_entry_new) remove ref to gee_focus_*_event
      254d3db2
  2. 15 Feb, 2002 1 commit
    • Jody Goldberg's avatar
      We can now make distcheck · f84a08c5
      Jody Goldberg authored
      Requires a GAL update, and a gtk+ update
      
      2002-02-15  Jody Goldberg <jody@gnome.org>
      
      	* src/item-cursor.c (item_cursor_tip_setlabel) : enable now that the
      	  canvas bug is fixed.
      
      	* src/sheet-control-gui.c (cb_hscrollbar_adjust_bounds) : new.
      	(cb_vscrollbar_adjust_bounds) : new.
      
      	* src/gui-util.c (gtk_button_stock_alignment_set) : new.
      	(gnumeric_init_help_button) : new.
      
      	* src/gnumeric-canvas.h : Move declaration of
      	  GnumericCanvasSlideHandler here.
      
      	* src/gnumeric-canvas.c (gnm_canvas_guru_key) : forward to the entry,
      	  not the GnumericExprEntry wrapper.
      	(gnm_canvas_key_mode_sheet) : ditto.
      
      	* src/formats.c (cell_format_classify) : handle general.
      
      	* src/file-priv.h : Inherit from GObject.
      
      	* src/complete-sheet.c (complete_sheet_finalize) : call class_peek
      	  here to avoid potential reference problems.
      
      	* src/commands.c (cmd_set_text) : doh!  fix multi-line text.
      	(cmd_autoformat) : const.
      
      	* src/cell.c (cell_relocate) : const.
      	* src/clipboard.c (paste_cell_with_operation) : const.
      	(paste_cell) : ditto.
      
      	* src/application.c (application_init) : add jimmac's expr-entry icon.
      
      	* src/Makefile.am : distribute the marshaller.list
      
      	s/GtkType/GType/
      	s/GtkSignalFunc/GCallback/
      	s/gtk_signal_connect/g_signal_connect/  + reformating.
      	s/GTK_CHECK_CAST/G_TYPE_CHECK_INSTANCE_CAST/
      	s/GTK_CHECK_TYPE/G_TYPE_CHECK_CLASS_CAST/
      	s/GTK_CHECK_CLASS_CAST/G_TYPE_CHECK_INSTANCE_TYPE/
      	s/GTK_CHECK_CLASS_TYPE/G_TYPE_CHECK_CLASS_TYPE/
      
      2002-02-11  Jody Goldberg <jody@gnome.org>
      
      	* src/stf.c (stf_init) : Make the names of the text import/export
      	  clearer.
      f84a08c5
  3. 04 Feb, 2002 1 commit
    • Jody Goldberg's avatar
      don't actually store the value, just start editing with it. · 167c36d3
      Jody Goldberg authored
      2002-02-03  Jody Goldberg <jody@gnome.org>
      
      	* src/workbook-control-gui.c (cb_insert_current_date) : don't actually
      	  store the value, just start editing with it.
      	(cb_insert_current_time) : ditto.
      
      2002-02-03  Jody Goldberg <jody@gnome.org>
      
      	* src/value.c (value_new_*) : init Value*::fmt
      	(value_duplicate) : ref the fmt too.
      	(value_set_fmt) : new.
      
      	* src/cell.c (cell_cleanout) : no more format.
      	(cell_copy) : ditto.
      	(cell_set_text) : ditto.
      	(cell_set_expr_internal) : ditto.
      	(cell_set_expr_unsafe) : ditto.
      	(cell_get_format) : ditto.
      
      	Change all callers.
      	* src/sheet.c (sheet_cell_set_value) : remove format assingment.
      	* src/cell.c (cell_set_expr_and_value) : remove format assignment.
      	(cell_assign_value) : ditto.
      	(cell_set_value) : ditto.
      	(cell_set_expr) : ditto.
      	* src/parser.y (expr_parse_str) : remove arg to return the suggested
      	  format.  That will be handled at run time.
      	* src/number-match.c (format_match) : remove arg to return the parse
      	  formula.  Store it in the value instead.
      167c36d3
  4. 26 Jan, 2002 1 commit
    • Andreas J. Guelzow's avatar
      fix all calls to gnumeric_notice ditto ditto ditto ditto ditto ditto ditto · 8b236ce4
      Andreas J. Guelzow authored
      2002-01-25  Andreas J. Guelzow <aguelzow@taliesin.ca>
      
      	* dialog-advanced-filter.c : fix all calls to gnumeric_notice
      	* dialog-analysis-tools.c : ditto
      	* dialog-autocorrect.c : ditto
      	* dialog-autosave.c : ditto
      	* dialog-cell-sort.c : ditto
      	* dialog-consolidate.c : ditto
      	* dialog-define-names.c : ditto
      	* dialog-goal-seek.c : ditto
      	* dialog-search-replace.c : ditto
      	* dialog-search.c : ditto
      	* dialog-solver.c : ditto
      	* dialog-tabulate.c : ditto
      
      2002-01-25  Andreas J. Guelzow <aguelzow@taliesin.ca>
      
      	* src/gui-util.c (gnumeric_dialog_run) : use GTK functions
      	(gnumeric_notice) : create GTK_Message_Dialog
      	* src/gui-util.h (gnumeric_notice) : change type of second argument
      	* src/gui-file.c : fix all calls to gnumeric_notice
      	* src/print.c : ditto
      	* src/style.c : ditto
      	* src/workbook-cmd-format.c : ditto
      	* src/workbook-control-gui.c : ditto
      8b236ce4
  5. 24 Jan, 2002 1 commit
  6. 23 Jan, 2002 1 commit
  7. 25 Dec, 2001 1 commit
    • Jody Goldberg's avatar
      it is ok to not rewrite the expression here. (cb_name_invalidate_sheet) : · 1dde747a
      Jody Goldberg authored
      2001-12-25  Jody Goldberg <jody@gnome.org>
      
      	* src/eval.c (invalidate_refs) : it is ok to not rewrite the
      	  expression here.
      	(cb_name_invalidate_sheet) : new.
      	(do_deps_destroy) : use here.
      
      	* src/expr-name.c (expr_name_invalidate_refs_sheet) : delete.
      	(expr_name_invalidate_refs_wb) : delete.
      	(expr_name_handle_references) : new.
      	(expr_name_set_expr) : use it here.
      	(expr_name_add) : Use expr_name_set_expr.
      	(expr_name_unref) : and here.
      	(expr_name_link_deps) : if the dependent being updated is going to be
      	  deleted do not relink or queue for recalc.
      1dde747a
  8. 21 Dec, 2001 1 commit
  9. 12 Dec, 2001 1 commit
    • Jody Goldberg's avatar
      gtk_entry_get_text const. (el_edit_sync) : ditto. ditto. ditto. · a9117e4d
      Jody Goldberg authored
      2001-12-12  Jody Goldberg <jody@gnome.org>
      
      	* widget-editable-label.c (el_entry_activate) : gtk_entry_get_text const.
      	(el_edit_sync) : ditto.
      	* widget-font-selector.c (size_changed) : ditto.
      	* gnumeric-combo-text.c (cb_entry_activate) : ditto.
      
      	* gnumeric-toolbar.c (gnumeric_toolbar_get_type) : Delete finalize it
      	  was a NOP.
      
      2001-12-12  Jody Goldberg <jody@gnome.org>
      
      	* dialog-solver.c (cb_dialog_solve_clicked) : gtk_entry_get_text const.
      	* dialog-printer-setup.c (do_fetch_page) : ditto.
      	(paper_size_changed) : ditto.
      	* dialog-goal-seek.c (cb_dialog_apply_clicked) : ditto.
      	* dialog-formula-guru.c (formula_guru_set_expr) : ditto.
      	* dialog-autocorrect.c (cb_add_clicked) : ditto.
      	* dialog-analysis-tools.c (entry_to_float) : ditto.
      	(entry_to_int) : ditto.
      	(gnumeric_expr_entry_parse_to_value) : ditto.
      	(gnumeric_expr_entry_parse_to_list) : ditto.
      	* dialog-advanced-filter.c (dialog_advanced_filter) : ditto.
      
      2001-12-12  Jody Goldberg <jody@gnome.org>
      
      	* src/file-autoft.c (category_group_list_find_category_by_name) : make
      	  const.
      	* src/plugin-service.c (gnum_plugin_file_opener_probe) : const.
      	* src/workbook-view.c (wb_view_attach_control) : ditto.
      	* src/workbook.c (workbook_attach_view) : ditto.
      	* src/workbook-edit.c (entry_changed) : ditto.
      	* src/workbook-edit.c (auto_complete_matches) : ditto.
      a9117e4d
  10. 27 Nov, 2001 1 commit
  11. 26 Nov, 2001 1 commit
    • Jody Goldberg's avatar
      add OPER_SET. ditto. ditto. (expr_tree_equal) : ditto. (expr_eval_real) : · 217a63bd
      Jody Goldberg authored
      2001-11-25  Jody Goldberg <jody@gnome.org>
      
      	* src/eval.c (handle_tree_deps) : add OPER_SET.
      	* src/expr-name.c (name_refer_circular) :  ditto.
      	* src/expr.c (do_expr_tree_unref) : ditto.
      	(expr_tree_equal) : ditto.
      	(expr_eval_real) : ditto.
      	(expr_rewrite) : ditto.
      	(do_expr_tree_as_string) : ditto.
      	(expr_tree_new_funcall) : use ExprList.
      	(expr_parse_string) : delete.
      	(expr_tree_new_set) : new.
      	(expr_list_unref) : new.
      	(expr_list_equal) : new.
      	(expr_list_as_string) : new.
      
      	* src/gnumeric.h : Add ExprList and ExprSet
      
      	* src/parser.y (expr_parse_str) : renamed from gnumeric_expr_parser.
      	  Add support for multiple expressions.
      	(line) : add support for multiple expressions.
      
      	* src/ranges.c (global_range_parse) : Use expr_parse_str
      	(global_range_list_parse) : rewrite to use expr_parse_str and use the
      	  new multi-expression support in the parser.
      
      	* src/commands.c (cmd_area_set_text_redo) : Use expr_parse_str.
      	* src/xml-io.c (xml_read_style_condition_chain) : ditto.
      	(xml_cell_set_array_expr) : ditto.
      	* src/workbook-view.c (wb_view_auto_expr) : ditto.
      	* src/workbook-edit.c (wbcg_edit_finish) : ditto.
      	* src/sheet-object-widget.c (sheet_widget_checkbox_read_xml) : ditto.
      	* src/parse-util.c (parse_text_value_or_expr) : ditto.
      
      	* src/auto-format.c (do_af_suggest) : Use ExprList instead of GList
      	(do_af_suggest_list) : ditto.
      	* src/collect.c (collect_floats) : ditto.
      	(collect_floats_value) : ditto.
      	(float_range_function) : ditto.
      	* src/consolidate.c (simple_consolidate) : ditto.
      	(colrow_formula_args_build) : ditto.
      	(consolidate_apply) : ditto.
      217a63bd
  12. 22 Nov, 2001 1 commit
  13. 01 Nov, 2001 1 commit
  14. 29 Oct, 2001 1 commit
    • Jody Goldberg's avatar
      add support for referencing names in other workbooks. · 22a7ee1a
      Jody Goldberg authored
      2001-10-29  Jody Goldberg <jgoldberg@home.com>
      
      	* src/parser.y : add support for referencing names in other workbooks.
      
      	* src/expr.c (expr_tree_new_name) : take an optional sheet and
      	  workbook as scoping info.
      	(expr_eval_real) : handle inactive names.
      	(do_expr_tree_to_string) : improve scoping.
      	(expr_rewrite) : handle inactives and scope changes.
      
      	* src/expr-name.c (expr_name_lookup) : add the notion of active and a
      	  ref count so that we can do a delayed destruction and invalidation.
      	(expr_name_add) : make it clearer that the return is not meant
      	  to be freed.
      	(expr_name_create) : don't free the result of expr_name_lookup.
      	(expr_name_ref) : generalize.
      	(expr_name_unref) : ditto.
      	(expr_name_remove) : deactivate the name.
      22a7ee1a
  15. 28 Oct, 2001 1 commit
  16. 26 Oct, 2001 1 commit
    • Jody Goldberg's avatar
      remove the loops, and recursions. match against formatted values before · fea69d08
      Jody Goldberg authored
      2001-10-26  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-edit.c (wbcg_edit_finish) : remove the loops, and
      	  recursions.  match against formatted values before expressions, then
      	  fall back to strings.
      
      	* src/parse-util.c (parse_text_value_or_expr) : match against
      	  formatted values before expressions, then fall back to strings.
      
      	* src/cell.c (cell_set_text) : parse_text_value_or_expr takes a ParsePos.
      	* src/sheet.c (sheet_cell_set_text) : ditto.
      	* src/widgets/gnumeric-expr-entry.c
      	  (gnumeric_expr_entry_key_press_event) : ditto.
      	* src/commands.c (cmd_area_set_text_redo) : ditto.
      	(cmd_area_set_text) : ditto.
      	(cmd_search_replace_do_cell) : create a tmp EvalPos to avoid changing
      	  the search data structures.
      
      	* src/expr.c (expr_tree_get_range) : renamed from range_from_expr_tree.
      	  add support for singletons.
      
      	* src/ranges.c (global_range_parse) : tweak slightly.
      
      2001-10-26  Jody Goldberg <jgoldberg@home.com>
      
      	* src/number-match.c (format_match_init) : don't include text in the
      	  stock set of formats they should only match numbers.
      fea69d08
  17. 25 Oct, 2001 1 commit
    • Wayne Schuller's avatar
      New canvas based header and footer preview widget. The customize · f0770524
      Wayne Schuller authored
      2001-10-21  Wayne Schuller <k_wayne@linuxpower.org>
      
      	* dialog-printer-setup.c : New canvas based header and footer preview
      	  widget. The customize header/footer widget now also uses a
      	  GnomePropertyBox for UI consistency.
      	* print.glade : Updated.
      	* hf-config.glade : Updated.
      
      2001-10-25  Jody Goldberg <jgoldberg@home.com>
      
      	* src/ranges.c (range_trim) : decrease lobotomization factor.
      
      2001-10-23  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr-name.c (named_expr_new) : renamed from add_real, simplified
      	  interface.
      	(expr_name_add) : take and store a parse position.
      	(expr_name_create) : ditto.
      	(expr_name_destroy) : adjust to stored parsepos.
      	(expr_name_unlink) : ditto.
      	(expr_name_sheet2wb) : ditto.
      	(expr_name_init) : ditto.
      	(expr_name_as_string) : renamed from expr_name_value.
      	(expr_name_eval) : renamed from eval_expr_name.
      
      	s/eval_expr/expr_eval/
      
      	* src/expr.c (do_expr_tree_to_string) : Use value_as_string in most
      	  places.
      	* src/value-sheet.c (value_cellrange_get_as_string) : delete bogus
      	  useless arg.
      	(encode_cellref) : delete redundant.
      
      	* src/parse-util.c (cellref_name) : ICK!  XL wraps relative references
      	  that are out of bounds.
      f0770524
  18. 22 Oct, 2001 1 commit
    • Jody Goldberg's avatar
      actually display the returned error. · 57d5df3c
      Jody Goldberg authored
      2001-10-22  Jody Goldberg <jgoldberg@home.com>
      
      	* dialog-define-names.c (cb_name_guru_add) : actually display the
      	  returned error.
      
      2001-10-22  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr-name.c (name_refer_circular) : fix.
      57d5df3c
  19. 24 Aug, 2001 2 commits
    • Jody Goldberg's avatar
      Rename gnumeric-utils.h gui-utils.h to be more accurate. · d531765d
      Jody Goldberg authored
      Clean out a bunch includes.
      d531765d
    • Chyla Zbigniew's avatar
      Replace mega-include <gnome.h> with something smaller. · ac93e10a
      Chyla Zbigniew authored
      * src/analysis-tools.c, src/application.c, src/bonobo-io.c,
      src/clipboard.c, src/cmd-edit.c, src/command-context.c,
      src/commands.c, src/corba-args.c, src/corba-workbook-factory.c,
      src/dates.c, src/dialogs/dialog-about.c,
      src/dialogs/dialog-advanced-filter.c,
      src/dialogs/dialog-analysis-tools.c, src/dialogs/dialog-autocorrect.c,
      src/dialogs/dialog-autoformat.c, src/dialogs/dialog-autosave.c,
      src/dialogs/dialog-cell-comment.c, src/dialogs/dialog-cell-format.c,
      src/dialogs/dialog-cell-sort.c, src/dialogs/dialog-consolidate.c,
      src/dialogs/dialog-define-names.c, src/dialogs/dialog-delete-cells.c,
      src/dialogs/dialog-function-wizard.c, src/dialogs/dialog-goal-seek.c,
      src/dialogs/dialog-goto-cell.c, src/dialogs/dialog-graph-guru.c,
      src/dialogs/dialog-insert-cells.c, src/dialogs/dialog-paste-special.c,
      src/dialogs/dialog-plugin-manager.c,
      src/dialogs/dialog-printer-setup.c,
      src/dialogs/dialog-search-replace.c, src/dialogs/dialog-sheet-order.c,
      src/dialogs/dialog-simple-input.c, src/dialogs/dialog-solver.c,
      src/dialogs/dialog-stf-export-private.h,
      src/dialogs/dialog-stf-export-sheet-page.c,
      src/dialogs/dialog-stf-export.c, src/dialogs/dialog-stf-preview.h,
      src/dialogs/dialog-stf.c, src/dialogs/dialog-stf.h,
      src/dialogs/dialog-summary.c, src/dialogs/dialog-validate.c,
      src/dialogs/dialog-workbook-attr.c, src/dialogs/dialog-zoom.c,
      src/dialogs/utils-dialog.c, src/expr-name.c, src/expr.c,
      src/file-autoft.c, src/format-template.c, src/format.c, src/formats.c,
      src/func.c, src/global-gnome-font.c, src/gnumeric-util.h,
      src/gui-clipboard.c, src/gui-file.c, src/gui-gnumeric.h, src/gutils.c,
      src/history.c, src/item-bar.c, src/item-cursor.c, src/item-debug.c,
      src/main.c, src/normal-args.c, src/number-match-test.c,
      src/number-match.c, src/parse-util.c, src/parser.y, src/pattern.h,
      src/preview-grid.c, src/print-cell.c, src/print-info.c, src/print.c,
      src/search.c, src/selection.c, src/sheet-autofill.c,
      src/sheet-merge.c, src/sheet-object-bonobo.c,
      src/sheet-object-container.c, src/sheet-object-graphic.c,
      src/sheet-object-item.c, src/sheet-object-widget.c,
      src/sheet-object.c, src/sheet.c, src/stf-parse.h, src/stf.c,
      src/style-color.c, src/style.c, src/test-format.c, src/value-sheet.c,
      src/value.c, src/widgets/gnumeric-dashed-canvas-line.h,
      src/widgets/gnumeric-hscrollbar.c, src/widgets/gnumeric-toolbar.c,
      src/widgets/gnumeric-vscrollbar.c,
      src/widgets/widget-editable-label.c,
      src/widgets/widget-font-selector.c, src/workbook-cmd-format.c,
      src/workbook-control.c, src/workbook-format-toolbar.c,
      src/workbook-object-toolbar.c, src/workbook-private.h,
      src/xml-io-autoft.c, src/xml-io.c:
      Replace mega-include <gnome.h> with something smaller.
      ac93e10a
  20. 14 Aug, 2001 1 commit
    • Jody Goldberg's avatar
      new routine. · 6fead70d
      Jody Goldberg authored
      2001-08-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr.c (expr_to_graph_vector) : new routine.
      
      2001-08-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/item-edit.c (item_edit_draw_text) : ignore leading newlines.
      	(recalc_spans) : handle embedded newlines.
      
      	* src/workbook-control-gui.c (wb_edit_key_pressed) : delete, and
      	  move this logic from here.
      	(workbook_setup_edit_area) : don't hook up wb_edit_key_pressed.
      	  Use a GnumericExprEntry instead.
      
      	* src/widgets/gnumeric-expr-entry.c (gnumeric_expr_entry_key_press_event) :
      	  Move the magic embedded newline and Abs/Rel handling here.
      	(gnumeric_expr_entry_new) : Take a wbcg.
      6fead70d
  21. 16 May, 2001 1 commit
  22. 15 May, 2001 1 commit
    • Jon K Hellan's avatar
      Define menu state enums for print setup, search/replace and define names · a4a97170
      Jon K Hellan authored
      2001-05-15  Jon K Hellan  <hellan@acm.org>
      
       	* src/workbook-control.h: Define menu state enums for print setup,
       	search/replace and define names and a define for the lot.
      
       	* src/workbook-control-gui-priv.h (struct _WorkbookControlGUI):
       	Add menu_item_print_setup, menu_item_search_replace,
       	menu_item_define_name members.
      
       	* src/workbook-edit.c (workbook_edit_attach_guru,
       	workbook_edit_detach_guru): Update Update print setup,
       	search/replace and define names sensitivity according to whether
       	or not we have guru.
      
       	* src/workbook-control-gui.c (wbcg_menu_state_update): Ditto. This
       	is where it's actually implemented.
      
       	* src/dialogs/dialog-define-names.c (dialog_define_names):
       	Ensure only one guru per workbook.
      
       	* src/dialogs/dialog-search-replace.c (dialog_search_replace):
              Ditto.
      
       	* src/dialogs/dialog-printer-setup.c (dialog_printer_setup):
              Ditto.
      a4a97170
  23. 03 May, 2001 1 commit
    • Jon K Hellan's avatar
      New callback function. Removes object data from wbcg when dialog is · ccb86658
      Jon K Hellan authored
      2001-05-03  Jon K Hellan  <hellan@acm.org>
      
      	* src/gnumeric-util.c (cb_remove_object_data): New callback
      	function. Removes object data from wbcg when dialog is destroyed.
      	(gnumeric_keyed_dialog): New function. Make dialog a transient
      	child of wbcg, attaching to wbcg object data to identify the
      	dialog.
      	(gnumeric_dialog_raise_if_exists): New function: Raise the dialog
      	identified by key if it is registered on the wbcg.
      
      	* src/gnumeric-util.h (gnumeric_dialog_make_unique,
      	gnumeric_dialog_raise_if_exists): Declare.
      
       	* src/about.c (dialog_about): Use gnumeric_keyed_dialog.
      	Use gnumeric_dialog_raise_if_exists to ensure that only one sheet
      	object config dialog at a time can be displayed for a wbcg.
      
       	* src/sheet-object-widget.c (sheet_widget_checkbox_user_config):
      	Ditto.
      
      2001-05-03  Jon K Hellan  <hellan@acm.org>
      
      	* src/dialogs/dialog-define-names.c (name_guru_init): Use
      	gnumeric_keyed_dialog rather than gnumeric_non_modal_dialog.
      	(dialog_define_names): Use (gnumeric_dialog_raise_if_exists to
      	ensure that only one instance at a time can be displayed for a
      	wbcg.
      ccb86658
  24. 23 Apr, 2001 1 commit
    • Almer S. Tigelaar's avatar
      Give focus to the edit line when an error is encountered. Don't store the · 78d888e3
      Almer S. Tigelaar authored
      2001-04-23  Almer S. Tigelaar  <almer@gnome.org>
      
      	* src/workbook-edit.c (workbook_finish_editing): Give focus
      	to the edit line when an error is encountered.
      	* src/workbook-control-gui.c
      	(wbcg_close_control) : Don't store the partially entered expression
      	when we are going to close.
      	(cb_file_quit) : Idem.
      	(cb_notebook_switch_page) : Idem, for switching between tabs
      	when we are _not_ in a subexpression.
      
      	* src/parser.y : Correct off-by-one glitches and strtod exponent
      	out of range error problem.
      
      	* src/expr.[ch] (expr_parse_string): Use a ParseError struct
      	instead of an error string.
      
      	* src/commands.c (cmd_area_set_text_redo): Use expr_parse_string
      	in the newly corrected fashion.
      	* src/expr-name.c (expr_name_create): Idem, require a ParseError
      	struct to be passed instead of a char** aswell.
      	* src/parse-util.c (parse_text_value_or_expr): Idem.
      	* src/sheet-object-widget.c (cb_checkbox_config_clicked): Idem.
      	* src/test-parser.c (main): Idem.
      	* src/xml-io.c (xml_cell_set_array_expr): Idem.
      
      	* src/sheet.c (sheet_clone_names): Use expr_name_create which now
      	uses ParseError instead of char **.
      	* src/xml-io.c (xml_read_names): Idem.
      
      2001-04-23  Almer S. Tigelaar  <almer@gnome.org>
      
      	* dialog-define-names.c (cb_name_guru_add):
      	Correct use of expr_parse_string.
      78d888e3
  25. 18 Apr, 2001 3 commits
    • Jon K Hellan's avatar
      Remove commented out stuff. (cb_name_guru_value_focus): Remove to · 227922d6
      Jon K Hellan authored
      2001-04-18  Jon K Hellan  <hellan@acm.org>
      
      	* dialog-define-names.c (name_guru_init): Remove commented out stuff.
      	(cb_name_guru_value_focus): Remove to eliminate warning.
      227922d6
    • Morten Welinder's avatar
      Leak fix. · d3d9cc90
      Morten Welinder authored
      d3d9cc90
    • Jon K Hellan's avatar
      Change return type to GnumericExprEntry. (workbook_set_entry): Change type · eb52c908
      Jon K Hellan authored
      2001-04-18  Jon K Hellan  <hellan@acm.org>
      
      	* src/workbook-edit.[ch] (workbook_get_entry,
      	workbook_get_entry_logical): Change return type to
      	GnumericExprEntry.
      	(workbook_set_entry): Change type of entry argument to
      	GnumericExprEntry.
      
      	* src/gnumeric-sheet.c (move_cursor): Move to scg::scg_move_cursor
      	(cursor_horizontal_move): Move to scg::scg_cursor_horizontal_move
      	(cursor_horizontal_extend): Move to
      	scg::scg_cursor_horizontal_extend
      	(cursor_vertical_move): Move to scg::scg_cursor_vertical_move
      	(cursor_vertical_extend): Move to scg::scg_cursor_vertical_extend
      	(selection_remove_selection_string,
      	selection_insert_selection_string): Remove. GnumericExprEntry
      	widget now handles this.
      	(start_cell_selection_at): Rename to start_range_selection_at.
      	(start_cell_selection): Rename to start_range_selection.
      	(gnumeric_sheet_start_cell_selection): Rename to
      	gnumeric_sheet_start_range_selection.
      	(gnumeric_sheet_stop_cell_selection): Rename to
      	gnumeric_sheet_stop_range_selection. Remove clear_string parameter
      	and selection string manipulation.
      	(rangesel_horizontal_move): Make non-static, rename to
      	gnumeric_sheet_rangesel_horizontal_move, remove selection string
      	manipulation.
      	(rangesel_vertical_move): Make non-static, rename to
      	gnumeric_sheet_rangesel_vertical_move, remove selection string
      	manipulation.
      	(rangesel_horizontal_extend): Make non-static, rename to
      	gnumeric_sheet_rangesel_horizontal_extend, remove selection string
      	manipulation.
      	(rangesel_vertical_extend): Make non-static, rename to
      	gnumeric_sheet_rangesel_vertical_extend, remove selection string
      	manipulation.
      	(gnumeric_sheet_key_mode_sheet): Use movefn's from scg instead of
      	from GnumericSheet.
      
      	* src/gnumeric-sheet.h (gnumeric_sheet_start_cell_selection):
      	Rename to gnumeric_sheet_start_range_selection.
      	(gnumeric_sheet_stop_cell_selection): Rename to
      	gnumeric_sheet_stop_range_selection. Remove clear_string
      	parameter.
      	(gnumeric_sheet_rangesel_horizontal_move,
      	gnumeric_sheet_rangesel_vertical_move,
      	gnumeric_sheet_rangesel_horizontal_extend,
      	gnumeric_sheet_rangesel_vertical_extend): Declare.
      
      	* src/gnumeric-util.[ch] (gnumeric_entry_at_subexpr_boundary_p):
      	Rename to gnumeric_expr_entry_at_subexpr_boundary_p and move to
      	gnumeric_expr_entry widget.
      
      	* src/item-grid.c (item_grid_button_1, item_grid_event): Use scg
      	methods instead of methods from GnumericSheet.
      
      	* src/sheet.[ch] (sheet_stop_cell_selection): Rename to
      	sheet_stop_range_selection.
      
      	* src/sheet-control-gui.c (scg_colrow_select): Use scg methods
      	instead of methods from GnumericSheet.
      	(scg_stop_editing): Add call to scg_stop_cell_selection.
      	(scg_range_selection_changed): New function. Notify ExprEntry that
      	the expression range has changed.
      	(scg_move_cursor): Moved here from GnumericSheet.
      	(scg_rangesel_cursor_extend): Add call to
      	scg_range_selection_changed.
      	(scg_rangesel_cursor_bounds, scg_rangesel_horizontal_move,
      	scg_rangesel_vertical_move, scg_rangesel_horizontal_extend,
      	scg_rangesel_vertical_extend): New functions. Call GnumericSheet
      	counterpart and notify ExprEntry.
      	(scg_cursor_horizontal_move, scg_cursor_horizontal_extend,
      	scg_cursor_vertical_move, scg_cursor_vertical_extend): Moved here
      	from GnumericSheet.
      	(scg_get_sel_cursor_pos): New function. Return selection cursor
      	position.
      
      	* src/sheet-control-gui.h (scg_range_selection_changed,
      	scg_move_cursor, scg_rangesel_cursor_bounds,
      	scg_rangesel_horizontal_move, scg_rangesel_vertical_move,
      	scg_rangesel_horizontal_extend, scg_rangesel_vertical_extend,
      	scg_cursor_horizontal_move, scg_cursor_vertical_move,
      	scg_cursor_horizontal_extend, scg_cursor_vertical_extend,
      	scg_get_sel_cursor_pos): Declare.
      
      	* src/sheet-control-gui.[ch] (scg_stop_cell_selection): Rename to
      	scg_stop_range_selection. Notify ExprEntry that range selection
      	has stopped.
      
      	* src/sheet-object-widget.c (cb_checkbox_config_focus): Call
      	gnumeric_expr_entry_select_absolute.
      	(sheet_widget_checkbox_user_config): Use GnumericExprEntry. Attach
      	it to the scg.
      
      	* src/workbook-control-gui.c (cb_notebook_switch_page): Use new
      	function name sheet_stop_range_selection.
      
      	* src/workbook-control-gui-priv.h (struct
      	_WorkbookControlGUI::struct edit_line): entry and temp_entry are
      	now GnumericExprEntries.
      	(struct _WorkbookControlGUI): Remove select_abs_col,
      	select_abs_row, select_full_col, select_full_row and
      	select_single_cell.
      
      	* src/workbook-control-gui.c (wbcg_finish_editing,
      	wb_edit_key_pressed, cb_autofunction, workbook_setup_edit_area,
      	auto_complete_matches): Entry must now be cast to GtkEntry.
      	(workbook_control_gui_init): select_abs_col, select_abs_row,
      	select_full_col, select_full_row and select_single_cell no longer
      	exist.
      
      	* src/workbook-edit.c (workbook_finish_editing, entry_changed,
      	workbook_start_editing_at_cursor): entry must now be cast to
      	GtkEntry.
      	(workbook_start_editing_at_cursor): Attach scg to
      	ExprEntry. wbcg->select_abs_col and select_abs_row no longer
      	exist.
      	(workbook_edit_select_absolute): Move to ExprEntry widget.
      	(workbook_edit_toggle_absolute): New function. Probably remove it
      	again.
      	(workbook_edit_init): Remove redundant 'g_assert != NULL'. Use
      	GnumericExprEntry widget.
      
      2001-04-18 Jon K Hellan  <hellan@acm.org>
      
      	* src/dialogs/dialog-define-names.c (struct NameGuruState):
      	Change type of expr_text to GnumericExprEntry.
      	(name_guru_set_expr, name_guru_update_sensitivity,
      	name_guru_set_expr, cb_name_guru_add): expr_text must now be
      	cast to GTK_ENTRY.  (cb_name_guru_value_focus): Use
      	gnumeric_expr_entry_set_absolute. w argument is now expected
      	to be a GnumericExprEntry.  (cb_name_guru_set_focus): New
      	function. Make anted selection go away when a widget other
      	than expr_text receives focus.  (name_guru_init): Create a
      	GnumericExprEntry and insert in the dialog. Attach it to the
      	current sheet. Connect cb_name_guru_set_focus to dialog's
      	set-focus signal, and remove the focus-in handler from
      	name_value.
      
      	* src/dialogs/dialog-function-wizard.c (struct ArgumentState):
      	Change type of entry to GnumericExprEntry.
      	(formula_guru_set_expr): Change type of new_entry to
      	GnumericExprEntry. Cast to GTK_ENTRY where necessary.
      	(formula_guru_set_expr, cb_formula_guru_rolled_entry_changed,
      	cb_formula_guru_entry_changed, formula_guru_init):
      	ArgumentState->entry must now be cast to GTK_ENTRY.
      	(formula_guru_set_rolled_state): Change type of new_entry to
      	GnumericExprEntry. Cast to GTK_ENTRY where necessary.
      	(formula_guru_arg_new): Create a GnumericExprEntry instead of
      	a GtkEntry and insert in the dialog. Attach it to the current
      	sheet.  (formula_guru_init): Create a GnumericExprEntry for
      	rolled_entry and insert in the dialog. Attach it to the
      	current sheet.  (dialog_formula_guru): Value returned by
      	workbook_get_entry must now be cast to GTK_ENTRY.
      
      	* src/dialogs/formula-guru.glade: Remove 'rolled_entry'
      	GtkEntry. A GnumericExprEntry is now added at runtime instead.
      
      	* src/dialogs/names.glade: Remove 'expr_text' GtkEntry. A
      	GnumericExprEntry is now added at runtime instead.
      eb52c908
  26. 12 Apr, 2001 1 commit
  27. 14 Feb, 2001 2 commits
  28. 27 Dec, 2000 1 commit
  29. 17 Dec, 2000 1 commit
    • Jody Goldberg's avatar
      support merged cells. (sheet_find_boundary_vertical) : ditto. · 17579c92
      Jody Goldberg authored
      
      2000-12-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_find_boundary_horizontal) : support merged cells.
      	(sheet_find_boundary_vertical) : ditto.
      	(sheet_set_edit_pos) : Add edit_pos vs edit_pos_real to improve merged
      	  cell support.
      	(sheet_region_get_merged_cell) : new function.
      
      	* src/gnumeric-sheet.c (move_cursor_horizontal) : Use edit_pos_real to
      	  improve handling for merged cells.
      	(move_cursor_vertical) : Ditto.
      	(start_cell_selection) : Ditto.
      
      2000-12-16  Jody Goldberg <jgoldberg@home.com>
      
      	s/Sheet::cursor::edit_pos/Sheet::edit_pos/
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_new) : No need to pass in the
      	  col/row items.  They are available from the sheet control.
      
      	* src/sheet-control-gui.c (sheet_view_construct) : signature change to
      	  gnumeric_sheet_new.
      17579c92
  30. 09 Dec, 2000 1 commit
    • Chema Celorio's avatar
      add NameGuruScope enums (name_guru_warn): warn when deleting a name that · d069b117
      Chema Celorio authored
      2000-12-09  Chema Celorio  <chema@celorio.com>
      
      	* dialog-define-names.c: add NameGuruScope enums
      	(name_guru_warn): warn when deleting a name that is beein used
      	(name_guru_scope_change): handle scope changes
      	(name_guru_set_expr): implement.
      	(name_guru_clear_selection): implement
      	(name_guru_in_list): implement
      	(name_guru_update_sensitivity): implement.
      	(cb_name_guru_select_name): clean
      	(name_guru_scope_get): implement
      	(cb_name_guru_add): fix
      	(name_guru_init): conect sensitivy after (see coment on code)
      
      2000-12-09  Chema Celorio  <chema@celorio.com>
      
      	* src/xml-io.c (xml_write_names): Always wrinte a <Names> node,
      	even if it is empty. (See coment on code for details)
      
      	* src/sheet.c (sheet_new): make sheet->names NULL.
      	(sheet_clone_names): free the list with g_list_free not g_free
      	(sheet_clone_names): add a warning about not duplicating
      	names yet.
      
      	* src/expr-name.h (expr_name_wb2sheet): add prototypes for
      	wb2sheet & sheet2wb
      
      	* src/expr-name.c (expr_name_unlink): new funct. Code form
      	expr_name_remove
      	(expr_name_remove): call expr_name_unlink
      	(expr_name_invalidate_refs_name): add a warning about this function
      	not beeing implemented
      	(expr_name_invalidate_refs_sheet): ditto
      	(expr_name_invalidate_refs_wb): ditto
      	(expr_name_sheet2wb): new funct. changed the scope of a NamedExpression
      	from sheet to workbook.
      	(expr_name_wb2sheet): not implemented yet. Workbook to sheet scope change
      d069b117
  31. 15 Nov, 2000 1 commit
    • Morten Welinder's avatar
      Remove trailing white-space from files that have it. · 5570aef3
      Morten Welinder authored
      (The following command was done in src/ and plugins/.  Note, that the
      grep has a space and a tab.)
      
      for i in `find . -name '*.[ch]' -print`; do if grep '[         ]$' $i >/dev/null; then echo $i; perl -pi -e 's/[ \t]+$//' $i; fi; done
      5570aef3
  32. 31 Oct, 2000 1 commit
    • Jody Goldberg's avatar
      Set LC_MONETARY and LC_NUMERIC. Ditto. (xml_workbook_read) : Ditto. · ffac72f5
      Jody Goldberg authored
      
      2000-10-31  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-view.c (wb_view_auto_expr) : Set LC_MONETARY and
      	  LC_NUMERIC.
      	* src/xml-io.c (xml_workbook_write) : Ditto.
      	(xml_workbook_read) : Ditto.
      
      2000-10-31  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/*.[ch] : WorkbookControlGUI is now required for gui
      	  operations.  A WorkbookView is required to know which sheet is the
      	  current.
      
      	* src/xml-io.c : We now load/save WorkbookViews.
      
      	* src/xml-io-autoft.c : Adjust to signature changes.
      
      	* src/workbook.c : Split the View into WorkbookView.
      	  Abstract the Controler interface, and move the GUI specific
      	  implementation of the Controler into WorkbookControlGUI.
      
      	* src/workbook-view.c : Complete rewrite with correct semantics.
      
      	* src/workbook-private.h : Move all the GUI specific stuff into
      	  WorkbookControlGUI were it belongs.
      
      	* src/workbook-private.c (workbook_private_class_init) : Fix typo.
      
      	* src/workbook-edit.c : These are now WorkbookControlGUI specific.
      	  We should rename the functions eventually.
      	* src/workbook-format-toolbar.c : Ditto.
      	* src/workbook-object-toolbar.c : Ditto.
      
      	* src/workbook-cmd-format.c : Adjust to signature changes.
      	  and use WorkbookControlGUI were necessary.
      
      	* src/style.c (style_font_new_from) : Delete dead code.
      
      	* src/solver-lp.c : Adjust to signature changes.
      	* src/sort.c : Ditto.
      	* src/stf.c : Ditto. Make dialog conditional on gui-ness.
      
      	* src/sheet.c (sheet_new_sheet_view) : IS_SHEET checks for NULL.
      	(sheet_detach_sheet_view) : renamed from sheet_destroy_sheet_view
      	  and only take a SheetView as argument.
      	(sheet_new) : Do not create a view by default.
      	(sheet_update_zoom_controls) : foreach control.
      	(sheet_update_editpos) : ditto.
      	(sheet_update) : handle multiple views and controls.
      
      	* src/sheet-view.c : Commands take WorkbookControls rather than
      	  CommandContexts.
      
      	* src/sheet-object-widget.c : Most things take WorkbookControlGUI
      	  rather than Workbooks.
      
      	* src/sheet-object-container.c (sheet_object_container_new_view) :
      	  Use the uic from the WorkbookControlGUI.
      
      	* src/sheet-control.c : New file. Unused so far.
      	  cp sheet-view.c sheet-control.c
      	  s/SheetView/SheetControl/
      
      	* src/print.c : Make the GUI dependency explicit.
      	  At some point the setup dialog should be split out of here.
      
      	* src/main.c (gnumeric_main) : Explicitly create a WorkbookControlGUI
      	  only adding sheets if nothing was loaded.  Improve handing of exit
      	  request while loading.
      
      	* src/item-grid.c (item_grid_draw) : Filter the edit cell from here
      	  because we know which control to use.
      	(context_menu_hander) : Switch to WorkbookControlGUI.
      	(item_grid_popup_menu) : Ditto.
      
      	* src/item-edit.c : Everything takes a WorkbookControlGUI inplace of a
      	  Workbook now.
      
      	* src/item-cursor.c (item_cursor_target_region_ok) : dialog_run takes
      	  a WorkbookControlGUI.
      	(item_cursor_do_action) : All the commands take WorkbookControls.
      
      	* src/item-bar.c (item_bar_event) : item_grid_popup_menu takes a
      	  SheetView now.
      
      	* src/history.c : Take WorkbookControlGUI.
      	  Update all controls for each workbook.
      
      	* src/gui-clipboard.c : Use 'unsigned char'
      
      	* src/gnumeric.xml : More work to split commands from layout.
      
      	* src/gnumeric-util.c (gnumeric_no_modify_array_notice) : Delete.
      	(gnumeric_notice) : Take a WorkbookControlGUI.
      	(gnumeric_wb_dialog_run) : Ditto.
      	(gnumeric_dialog_run) : Ditto.
      	(gnumeric_dialog_show) : Ditto.
      	(gnumeric_set_transient) : Ditto.
      	(gnumeric_glade_xml_new) : Ditto.
      	(gnumeric_non_modal_dialog) : Ditto.
      	(gnumeric_inject_widget_into_bonoboui) : Ditto.
      
      	* src/gnumeric-sheet.c : SheetView now has a WorkbookControlGUI member
      	  to keep track of which control it is associated with. Use it.
      
      	* src/file.c : Adjust to lots of signature changes.
      	  We now load/save WorkbookView rather than Workbook.
      	  Add a placeholder struct IOContext so that we can consider doing
      	  smarter import/export and dealing with warnings and missing things
      	  smoothly.
      
      	* src/eval.c (workbook_recalc_all) : After a recalc update all views.
      
      	* src/commands.c (undo_redo_menu_labels) : foreach control.
      	(command_undo) : ditto.
      	(command_redo) : ditto.
      	(command_push_undo) : change signature.  The workbookcontrol
      	  now acts as the command context.
      
      	* src/cmd-edit.c : Adjust to signature changes.
      
      	* src/clipboard.c : split the gui specific X handlers out into a new
      	  file.
      	* src/gui-clipboard.c :  here.
      
      	* src/cell-draw.c (cell_draw) : Do not test the sheet for whether or
      	  not to we are editing.  That is at the control level.  Test it in
      	  the rendering loop.
      
      	* src/bonobo-io.c : FIXME. adjusted to signature changes.  Totatly
      	  broken for now.  This needs a View rather than a Model and should be
      	  associated with something.
      
      	* src/application.c (application_workbook_list_add) : New function.
      	(application_workbook_list_remove) : New function.
      	(application_workbook_list) : New function.
      	(application_clipboard_copy) : foreach control.
      	(application_clipboard_cut) : foreach control.
      	(application_clipboard_clear) : foreach control.
      	(application_workbook_foreach) : renamed from workbook_foreach.
      	(application_set_selected_sheet) : FIXME. Disabled for now.
      
      	* src/about.c (cb_closed) : Associated the flag with the control
      	  directly.
      	(dialog_about) : dialogs are associated with gui-controls.
      
      	* src/analysis-tools.c : change all dialog signatures to handle MVC
      	  split of workbook.
      
      2000-10-30  Jody Goldberg <jgoldberg@home.com>
      
      	* src/Makefile.am : Add new command-context,  io-context,
      	  workbook-view, workbook-control, workbook-control-gui files.
      	  Remove old command-context-gui, command-context-corba, and disable
      	  corba-* for now.
      
      2000-10-29  Jody Goldberg <jgoldberg@home.com>
      
      	* idl/gnumeric-graphs.idl : Remove studdly caps.  I wish people would
      	  make up their minds.
      
      	* idl/Gnumeric.idl : Remove Workbook::show.
      
      2000-10-29  Jody Goldberg <jgoldberg@home.com>
      
      	* BUGS : Update.
      	* NEWS : Update.
      	* TODO : Update.
      ffac72f5
  33. 14 Oct, 2000 1 commit
    • Jody Goldberg's avatar
      Relax the restrictions. · ffe0347e
      Jody Goldberg authored
      
      2000-10-13  Jody Goldberg <jgoldberg@home.com>
      
      	* src/position.c (parse_pos_init) : Relax the restrictions.
      
      	* src/workbook.c : Improve wording of Names->Define.
      
      	* src/gnumeric.xml : fix typo with Insert->Names->Define
      ffe0347e
  34. 25 Sep, 2000 1 commit
  35. 22 Sep, 2000 1 commit
    • Jody Goldberg's avatar
      redraw the selection. redraw the selection. · fafbc8cf
      Jody Goldberg authored
      
      2000-09-21  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_hide_cursor) : redraw the selection.
      	* src/sheet.c (sheet_show_cursor) : redraw the selection.
      
      	* src/sheet-object.c : Improve framework for editing/creating objects.
      	  We are more consistent about hiding the selection, and when to make
      	  things visible again.
      
      	* src/sheet-object-widget.c : Begin framework for configuring the
      	  sheet widgets.
      
      	* src/selection.c (sheet_selection_redraw) : new function.
      
      	* src/item-grid.c (item_grid_button_1) : Don't cancel object editing
      	  if there is a guru up.  We could be configuring things.
      
      	* src/selection.c (sheet_is_cell_selected) : Do no show selections
      	  while objects are being edited.
      
      	* src/gnumeric-util.c (gnumeric_non_modal_dialog) : Change the
      	  signature.
      
      	* src/sheet-object.c (sheet_object_destroy) : Improve safety.
      fafbc8cf
  36. 31 Aug, 2000 1 commit
    • Jody Goldberg's avatar
      New base class for Cells. Convert everything to access the elements that · 8b5866fb
      Jody Goldberg authored
      
      2000-08-30  Jody Goldberg <jgoldberg@home.com>
      
      	* dependent.[ch] : New base class for Cells.
      	  Convert everything to access the elements that are now
      	  in the cell's base.
      	s/Cell::sheet/Cell::Dependent::sheet/
      	s/Cell::cell_flags/Cell::Dependent::flags/
      
      	* Makefile.am : Because of XL we need to build plugins before src.
      	  That will need changing.
      
      	* src/func.c (function_marshal_arg) : Use expr_array_intersection.
      
      	* src/expr.c (eval_expr_real) : Do implicit conversions from strings
      	  to numbers if possible.
      	  Access the first element of an array.  NOTE : This is WRONG
      	  We need to implement array expression behavior some day.
      	(expr_array_intersection) : New routine.
      8b5866fb