1. 20 Sep, 2000 6 commits
  2. 19 Sep, 2000 7 commits
    • Morten Welinder's avatar
      Don't free new_fmt until we are done with it. · 1e40d865
      Morten Welinder authored
      2000-09-19  Morten Welinder  <terra@diku.dk>
      
      	* dialog-stf-format-page.c (format_page_format_changed): Don't
       	free new_fmt until we are done with it.
      1e40d865
    • Morten Welinder's avatar
      isdigit takes unsigned chars, not chars. · 8e1c25c3
      Morten Welinder authored
      2000-09-19  Morten Welinder  <terra@diku.dk>
      
      	* src/workbook.c (workbook_sheet_name_strip_number): isdigit takes
       	unsigned chars, not chars.
      
      	* src/functions/fn-lookup.c (find_index_linear): Quiet warnings.
      
      
      2000-09-19  Morten Welinder <terra@diku.dk>
      
      	* applix-read.c (applix_read_colormap): isdigit takes unsigned
       	chars, not chars.
      	(applix_parse_style): Ditto.
      	(applix_read_impl): Ditto.
      8e1c25c3
    • Morten Welinder's avatar
      Gripe. · c1c9fb44
      Morten Welinder authored
      c1c9fb44
    • Jody Goldberg's avatar
      typo · 8d32ba78
      Jody Goldberg authored
      8d32ba78
    • Michael Meeks's avatar
      add GNOME_DATADIR · db53dfa6
      Michael Meeks authored
      2000-09-18  Michael Meeks  <michael@helixcode.com>
      
      	* src/Makefile.am (INCLUDES): add GNOME_DATADIR
      
      	* src/workbook.c (workbook_new): use it.
      db53dfa6
    • Jody Goldberg's avatar
      Woohoo! The last of the release critical bugs are done. · b121e5da
      Jody Goldberg authored
      2000-09-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_row_size_fit_pixels) : PUTRID KLUDGE.
      	  Avoid the ugly row size changes when fitting the size.
      
      	* src/format.c (style_format_new_XL) : Implement translation.
      	(style_format_as_XL) : Ditto.
      
      	* src/number-match.c (format_match_init) : No need to compare to
      	  translated General.
      
      	* src/sheet.c (sheet_flag_status_update_cell) : Adjust signature.
      b121e5da
    • Jody Goldberg's avatar
      Bug 24122 · 62fd10ba
      Jody Goldberg authored
      2000-09-18  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet.c (sheet_flag_status_update_cell) : Adjust signature.
      
      2000-09-18  Jody Goldberg <jgoldberg@home.com>
      
      	* dialog-solver.c (dialog_solver) : No need to create a cell manually
      	  and fill with empty.  sheet_cell_fetch will handle that.
      
      	* dialog-goal-seek.c (dialog_goal_seek) : No need to create cell
      	  locally.
      	(gnumeric_goal_seek) : Update size, span, and status region for the
      	  cell that was being tweaked.  While solving we did not update it.
      62fd10ba
  3. 18 Sep, 2000 1 commit
    • Morten Welinder's avatar
      Leak and crash fixes. · bae5583d
      Morten Welinder authored
      
      2000-09-17  Morten Welinder  <terra@diku.dk>
      
      	* src/main.c (gnumeric_main): Init colours earlier.
      
      
      2000-09-17  Morten Welinder  <terra@diku.dk>
      
      	* dialog-autoformat.c (dialog_autoformat): Free "info" only when
       	done with it.  Free tooltips using unref, not plain g_free.
      bae5583d
  4. 17 Sep, 2000 4 commits
    • Jody Goldberg's avatar
      Add GAL checks · 5c11f296
      Jody Goldberg authored
      5c11f296
    • Jody Goldberg's avatar
      We need to recalc the size after rendering the value. However, it is · df403993
      Jody Goldberg authored
      
      2000-09-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (cb_cell_rerender) : We need to recalc the size
      	  after rendering the value.  However, it is wasteful to redraw each
      	  cell individually.
      	(cb_sheet_pref_display_formulas) : redraw entire sheet.  It is
      	  simpler.
      df403993
    • Jody Goldberg's avatar
      Use the newly minted Gnome Application Library (GAL) · 031ceea8
      Jody Goldberg authored
      2000-09-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook-format-toolbar.c : Use the new Gnome App Libs (GAL)
      	  routines.
      	* src/workbook-view.c : Ditto.
      	* src/workbook.c : Ditto.
      
      	* src/main.c (gnumeric_main) : call e_color_init and e_color_shutdown.
      
      	* src/gnumeric-util.c (gnumeric_create_tooltip) :
      	  Rename from color -> e_color.
      	* src/style.c (style_color_new) : Ditto.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_realize) :
      	  Rename from cursor -> e_cursor.
      	* src/item-cursor.c (item_cursor_set_cursor) : Ditto.
      	* src/cell-comment.c (cell_comment_clicked) : Ditto.
      	* src/item-grid.c (item_grid_event) : Ditto.
      	* src/sheet-object.c : Ditto.
      
      	* src/color.c : Split the utilities into the gal library.
      
      	* src/Makefile.am : Remove cursors.[ch]
      
      	* configure.in : Handle the new Gnome App Lib (GAL)
      031ceea8
    • Jody Goldberg's avatar
      GraphSeries is responsible for registering. · 8259d107
      Jody Goldberg authored
      2000-09-17  Jody Goldberg <jgoldberg@home.com>
      
      	* src/dialogs/dialog-graph-guru.c (cb_create_series_from_range) :
      	  GraphSeries is responsible for registering.
      
      	* src/history.c : Attempt to convert to the new bonobo ui handler.
      
      	* src/graph-series.c (graph_series_eval) : Support string and date
      	  series.
      	(series_get_name) : New function.
      	(impl_vector_scalar_value) : Use it here.
      	(impl_vector_date_value) : here
      	(impl_vector_string_value) : and here.
      	(cb_check_range_for_pure_string) : new function.
      	(graph_series_new) : Start guess whether a series is scalar or string.
      	(graph_series_servant) : Delete.
      	(graph_series_set_subscriber) : Take responsibility for registering
      	  with the remote Graph::Manager.
      
      	* src/gnumeric.xml : Remove bogus '/menu/File/open' placeholder
      	  Name the '/menu/File/FileHistory' placeholder.
      
      	* src/sheet-object-container.c (sheet_object_container_update_bounds)
      	  Fix off by 1 error here.
      	(make_container_item) : And here.
      
      	* src/sheet-object.c (sheet_object_add_view) : Renamed from
      	  sheet_view_object_realize.
      	(sheet_object_remove_view) : Renamed from sheet_view_object_unrealize.
      	(control_point_handle_event) : Enable edit popup from control points.
      8259d107
  5. 16 Sep, 2000 3 commits
    • Almer S. Tigelaar's avatar
      Remove ability to focus widgets on the Template Details tab. Remove the · 2f343484
      Almer S. Tigelaar authored
      2000-09-16  Almer S. Tigelaar  <almer1@dds.nl>
      
      	* src/dialogs/autoformat.glade:
      	Remove ability to focus widgets on the Template Details tab.
      	Remove the 'Apply Dimensions' checkbox.
      	Add some accelerators.
      	Add tooltip to category combo.
      
      	* src/dialogs/dialog-autoformat.c:
      	(cb_category_entry_changed): Replaced by cb_category_popwin_hide
      	(cb_category_popwin_hide): Invoked when the popup window of
      	the category window becomes hidden.
      	(dialog_autoformat): Remove handling for dimensions checkbox and
      	change signal binding for category combo.
      2f343484
    • Michael Meeks's avatar
      use datadir for get_ui_fname. · 8a6b93ff
      Michael Meeks authored
      2000-09-16  Michael Meeks  <michael@helixcode.com>
      
      	* src/workbook.c (workbook_new): use datadir for get_ui_fname.
      8a6b93ff
    • Almer S. Tigelaar's avatar
      New autoformat dialog. · 42aa39da
      Almer S. Tigelaar authored
      2000-09-16  Almer S. Tigelaar  <almer1@dds.nl>
      
      	* src/dialogs/autoformat.glade:
      	New autoformat dialog.
      
      	* src/dialogs/dialog-autoformat.c:
      	(fill_category_list): Replace with load_categories.
      	(load_categories): Same role as fill_category_list, but
      	loads them into a GtkList instead.
      	(free_categories): New, frees a GtkList holding categories.
      	(templates_load): Hide the scrollbar when it's not needed, remove
      	obsolete label code.
      	(previews_load): Set only the template name as tooltip.
      	(cb_more_clicked): Removed entirely, the more button is no longer.
      	(cb_new_clicked): Replaced by cb_new_activated.
      	(cb_new_activated): Same as cb_new_clicked but now
      	for a GtkMenuItem.
      	(cb_edit_clicked): Replaced by cb_edit_activated.
      	(cb_edit_activated): Same as cb_edit_clicked but now
      	for a GtkMenuItem.
      	(cb_remove_clicked): Replaced by cb_remove_current_activated.
      	(cb_remove_current_activated): Same as cb_remove_clicked but now
      	for a GtkMenuItem.
      	(cb_categories_select_row): Replace with cb_category_entry_changed.
      	(cb_category_entry_changed): New, same role as cb_categories_select_row,
      	but now for the 'category' GtkEntry instead of the previous GtkCList.
      	(cb_apply_button_toggled): Replaced by cb_apply_item_toggled.
      	(cb_apply_item_toggled): Same as cb_apply_item_toggled, but now for
      	GtkCheckMenuItem.
      	(cb_gridlines_button_toggled): Replaced by cb_gridlines_item_toggled.
      	(cb_gridlines_item_toggled): Same as cb_gridlines_item_toggled, but now
      	for GtkCheckMenuItem.
      	(setup_apply_item): New, load a glade control and bind it's event to
      	cb_apply_item_toggled in one step.
      	(dialog_autoformat): Adjusted to handle the new controls.
      42aa39da
  6. 15 Sep, 2000 7 commits
  7. 14 Sep, 2000 3 commits
    • Jody Goldberg's avatar
      Revert premature commit of new glade file. · 676efd61
      Jody Goldberg authored
      676efd61
    • Jody Goldberg's avatar
      Use sheet_selection_full_rows and workbook_cmd_format_row_height. · 01af4e73
      Jody Goldberg authored
      
      2000-09-14  Jody Goldberg <jgoldberg@home.com>
      
      	* src/sheet-view.c (sheet_view_row_size_changed) : Use
      	  sheet_selection_full_rows and workbook_cmd_format_row_height.
      	(sheet_view_col_size_changed) : Use
      	  sheet_selection_full_cols and workbook_cmd_format_column_width.
      
      	* src/item-grid.c (context_row_height) : Use sheet_dialog_set_row_height.
      	(context_col_width) : Use sheet_dialog_set_column_width.
      
      	* src/workbook-cmd-format.c (sheet_dialog_set_column_width) : Split
      	  the gui into here.
      	(workbook_cmd_format_column_width) : And the action into here.  Use
      	  the appropriate commands to get undo support.
      	(workbook_cmd_format_column_auto_fit) : Use workbook_cmd_format_column_width.
      	(sheet_dialog_set_row_height) : Split the gui into here.
      	(workbook_cmd_format_row_height) : And the action into here.  Use
      	  the appropriate commands to get undo support.
      	(workbook_cmd_format_row_auto_fit) : Use workbook_cmd_format_row_height.
      
      	* src/selection.c (sheet_row_selection_type) : moved from sheet.c
      	(sheet_col_selection_type) : moved from sheet.c
      	(sheet_selection_full_cols) : new routine.
      	(sheet_selection_full_rows) : new routine.
      
      	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Don't jump
      	  directly to the edit line with F2.  Start editing in sheet first.
      
      	* src/selection.c (selection_foreach_range) : Add the option of
      	  iterating the list backwards.
      
      	* src/workbook-cmd-format.c (cb_colrow_collect) : New function.
      
      	* src/workbook-cmd-format.c (workbook_cmd_format_column_width) : Fix.
      	(workbook_cmd_format_row_height) : Fix.
      
      	* src/sheet-object-graphic.c (sheet_object_graphic_update_bounds) :
      	  new function.
      	(sheet_object_filled_new_view) : Set the bounds when a new view is
      	  constructed.  DO NOT rely on the realized list, new objects are not
      	  added until AFTER construction.
      	* src/sheet-object.c (sheet_object_update_bounds) : delete.
      
      2000-09-13  Jody Goldberg <jgoldberg@home.com>
      
      	* src/expr.c (cellref_relocate) : Return more information so that we
      	  can differentiate relocating rows, cols, or both.
      	(cellrange_relocate) : Use the new information to extend the
      	  heuristic for when to relocate a range.  In the past we assumed that
      	  unless both ends of the range were moving we should not do the
      	  relocation.  It seems that there are other cases which will also
      	  relocate.  When inserting/deleting rows/cols or cutting a region
      	  that includes an entire side of the source region we should
      	  relocate.
      	  Sadly this patch is incomplete.  It relocates too much now.
      	  If you cut B2 and paste it into B3 the source region A1:B2 will
      	  resize to A1:B3 even though it should not.  At least ins/del row/col
      	  will now work.
      
      2000-09-12  Jody Goldberg <jgoldberg@home.com>
      
      	* src/workbook.c (create_bonobo_object) : Fixed.
      
      	* src/sheet-object-bonobo.c (sheet_object_bonobo_new_from_oid) :
      	  Delete duplicate function.
      
      2000-09-11  Jody Goldberg <jgoldberg@home.com>
      
      	* src/commands.c (cmd_ins_del_row_col_{undo,redo}) : Insert/delete
      	  rows/cols clears the cut buffer.  Copies are preserved.
      
      	* src/sheet-object.c (cb_obj_create_button_release) :  remove the
      	  bonobo specific file handling.  That is to be done earlier
      	  or in a different place.  This routine is strictly for placement,
      	  not content.
      	(sheet_mode_clear) : Move the deactivation here for now.  Hopefully
      	  move it to a virtual.
      
      	* src/about.c (dialog_about) : suppress warning.
      01af4e73
    • Jody Goldberg's avatar
      Move these to guppi · 119693ab
      Jody Goldberg authored
      119693ab
  8. 13 Sep, 2000 2 commits
  9. 12 Sep, 2000 4 commits
    • Morten Welinder's avatar
      It's not pining, it's passed on. This leak is no more. · e1167fe4
      Morten Welinder authored
      It has ceased to be. It's expired and gone to meet its
      maker. This is a late leak. It's a stiff. Bereft of life, it
      rests in peace. If you hadn't nailed it to the perch, it
      would be pushing up the daisies. It's rung down the
      curtain and joined the choir invisible. This is an
      ex-leak.
      
      (ahem)
      e1167fe4
    • Jody Goldberg's avatar
      typo · 3b4cee2c
      Jody Goldberg authored
      3b4cee2c
    • Morten Welinder's avatar
      help texts for bit operators. · 3381505e
      Morten Welinder authored
      2000-09-12  Morten Welinder  <terra@diku.dk>
      
      	* numtheory.c: help texts for bit operators.
      3381505e
    • Morten Welinder's avatar
      Constify. Plug leak. · 2e4c2694
      Morten Welinder authored
      2000-09-11  Morten Welinder  <terra@diku.dk>
      
      	* color-group.c (color_group_new_named): Constify.  Plug leak.
      
      	* color-palette.c (color_palette_new_with_vals): Constify.
      	(color_palette_new): Constify.
      2e4c2694
  10. 11 Sep, 2000 3 commits
    • Miguel de Icaza's avatar
      Optionally select the entire text. (el_button_press_event): Double click · 8d0bbe6b
      Miguel de Icaza authored
      2000-09-10  Miguel de Icaza  <miguel@helixcode.com>
      
      	* widget-editable-label.c (el_start_editing): Optionally select
      	the entire text.
      	(el_button_press_event): Double click should start editing with
      	all the text selected.
      8d0bbe6b
    • Jon K Hellan's avatar
      Add print_debugging variable / debug_print startup option. · a8e8311c
      Jon K Hellan authored
      2000-09-11  Jon K Hellan  <hellan@acm.org>
      
      	* src/main.c: Add print_debugging variable / debug_print startup
      	option.
      	(gnumeric_main): Make stdout line buffered - we only use it for
      	debug info.
      
      	* src/print-cell.[ch] (print_make_rectangle_path): New function: make
      	a rectangular gnome-print path.
      	* src/print-cell.c (print_cell): Use it.
      
      	* src/print.c (print_empty_pages variable): Remove. This variable
      	is never set. With the new repeated row/column handling, the logic
      	will have to be rewritten anyway if needed.
      	(print_page_repeated_rows): Remove unused parameters start_row and
      	end_row.
      	(print_page_repeated_cols): s/row/col/. Fix bug - was repeat_left,
      	corrected to repeat_top.
      	(print_page_object): Remove unused parameters page_width /
      	page_height and end_col / end_row.
      	(print_hf_element): Rename from print_hf
      	(print_hf_line): New function. Logic shared by print_header and
      	print_footer. Clip to header region. if print_debugging != 0, draw
      	a box around header region.
      	(print_headers): Use print_hf_line. Place at correct y position -
      	ascenders flush with inside of top margin.
      	(print_footers): Descenders flush with inside of bottom
      	margin. Otherwise like headers.
      	(print_page): Include logic for repeated rows and columns: They
      	are only repeated after the start of the repeating range has been
      	seen in the regular page flow. Fix grid size bug when centering
      	horizontally or vertically. Use print_make_rectangle_path.  Remove
      	print_empty_pages logic.
      	(compute_group): New function. Old compute groups changed to only
      	compute one page. Rationale: Available space on page for normal
      	cell flow changes once repeated rows/columns kick in, so there is
      	no gain in precomputing a list.
      	(render_sheet_objects): New function. Factored out of
      	print_sheet_range.
      	(print_range_down_then_right): New function. Used to be the row
      	major loop of print_sheet_range. Include logic for repeated rows
      	and columns (see print_page).
      	(print_range_right_then_down): s/row major/column major/
      	(print_sheet_range): Restructure into a small function that calls
      	render_sheet_objects, print_range_down_then_right,
      	print_range_right_then_down.
      	(compute_sheet_pages): Remove print_empty_pages logic. The
      	variable is never set. With the new repeated row/column handling,
      	the logic will have to be rewritten anyway if needed.
      	(compute_sheet_pages, print_sheet): Remove "key" parameter because
      	we are now called from g_list_foreach instead of
      	g_hash_table_foreach.
      
      	(compute_pages): Use list returned by workbook_sheets instead of
      	wb->sheets so sheets are processed in order.
      	(workbook_print_all): Print sheets in display order. To do so, use
      	list returned by workbook_sheets instead of wb->sheets.
      	(sheet_print): Use changed print_sheet signature.
      
      	* src/workbook.h (struct _Workbook): Rename "sheets" to
      	sheet_hash_private.
      
      	* src/workbook.c (workbook_do_destroy, workbook_do_destroy,
      	workbook_set_dirty, workbook_is_dirty, workbook_is_pristine,
      	workbook_init, workbook_rename_sheet, workbook_sheet_count,
      	workbook_attach_sheet, workbook_detach_sheet,
      	workbook_sheet_lookup): s/wb->sheets/wb->sheet_hash_private/
      	(cb_assemble_selection, workbook_selection_to_string): Not in
      	use. Remove.
      
      	* src/workbook-view.c (workbook_view_pref_visibility):
      	s/wb->sheets/wb->sheet_hash_private/
      a8e8311c
    • Jody Goldberg's avatar
      We need to ungrab from the combo when the custom colour dialog is brought · 44cc9dad
      Jody Goldberg authored
      
      2000-09-11  Jody Goldberg <jgoldberg@home.com>
      
      	* widget-color-combo.c (color_table_setup) : We need to ungrab from
      	  the combo when the custom colour dialog is brought up.
      	(cb_cust_color_clicked) : restore.
      
      	* color-palette.c (color_palette_get_color_picker) : New function.
      44cc9dad