GitLab

- Fix a problem with zooming caused by the new item-bar enhancements.
- Remove gnumeric-sheet.h from a number of places that it had no reason to be.
- Move all of the row/col pos/offset cache into GnumericSheet.  WARNING
  I do not populate all of it yet.

2000-01-26  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-view.c (sheet_view_set_zoom_factor) : Keep the cursor in
	  the same place and recompute the alignments for everything.

	* src/item-cursor.c (item_cursor_set_bounds) : New function.

	* src/gnumeric-sheet.h : Add more orthogonal structure for caching
	  common row/col bounds and their canvas offsets.

	* src/gnumeric-sheet.c (gnumeric_sheet_create) : Init the new members.
	(gnumeric_sheet_filenames_dropped) : Keep the canvas private.
	(gnumeric_sheet_make_cell_visible) : Add 'force_scroll' argument.

	* src/clipboard.c (clipboard_release) : It is possible to have no
	  styles associated with a region.

	* src/item-grid.c : Remove overlapping cache of bounding rows/cols and
	  offsets.  Use the superset in GnumericSheet.
	 (item_grid_find_{row, col}) : Support sliding backwards.

2000-01-26  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/solver-lp.c: Implemented the `>=' and `=' constraints.
  	Solver should be quite usable now for LP problems assumed to be
 	non-negative.

	* src/dialogs/dialog-solver.c: Related changes.

	* src/dialogs/advanced-filter.glade,
 	src/dialogs/dialog-advanced-filter.c: New files added.  Not done
 	yet.

2000-01-25  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/workbook.[ch]: Made workbook_is_dirty() public.

	* src/dialogs/dialog-autosave.c (dialog_autosave_callback): Added
 	checking whether the workbook is changed or not before saving it.

2000-01-24  Jody Goldberg <jgoldberg@home.com>

	* src/cell-draw.c (cell_draw) : Take the style as an argument, no need
	  to recompute something that is already available.

	* src/xml-io.c (xml_sheet_read) : Move the {freeze,thaw}_redraws here.
	(xml_read_cell) : Remove the sillyness about removing newlines and
	  trailing spaces.  Remove the {freeze,thaw}_redraws.

	* src/cell.c (cell_set_text_simple) : Store the rendered value.
	(cell_set_text) : Store the entered value.

2000-01-24 Jon K Hellan  <hellan@acm.org>

	* src/dialogs/autocorrect.glade: Really commit the changes I
	entered into the ChangeLog yesterday.

	* ChangeLog: I jumbled the order and attributions of some entries
	yesterday. Fix.

2000-01-24  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/dialogs/analysis-tools.glade, src/dialogs/Makefile.am: New
 	file added.

	* src/dialogs/dialog-analysis-tools.c (dialog_data_analysis): Made
 	the main dialog of the analysis tools to use the new Glade file.

2000-01-24  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/dialogs/solver-options.glade, src/dialogs/Makefile.am: New
 	file for Solver options.

	* src/dialogs/dialog-solver.c: Updated for the new Glade file.
  	Removed some unimplemented options.  Made the Solver options
 	unsensitive.

	* src/sheet.c (sheet_new): Added setting some default parameter
 	values for the Solver tool.

2000-01-23  NotZed  <notzed@zedzone.helixcode.com>

        * src/xml-io.c (xml_set_print_hf): Dont encode the html entity &,
        since we dont have to.
        (xml_read_print_info): Store the footer into the footer, not the
        header(!).

        * src/print.c (print_job_info_get): Init the page number to be 1
        (global page number).
        (print_sheet_range): Do not reset the page number to 1 for each
        sheet.
        (compute_pages): New function, calculates the total number of
        pages to be printed.
        (compute_sheet_pages): New function, calculates the number of
        pages to be printed by a single sheet.
        (print_sheet_range): No longer set the # pages.
        (sheet_print_selection): Calculate the # pages for selection
        printing.
        (workbook_print_all): Calculate the # pages for all or sheet range
        printing.
        (sheet_print): Caclulate the # pages for sheet printing.
        The changes above are a bit messy.
        (sheet_print): Killed some warnings.

2000-01-11  Michael Zucchi  <zucchi@zedzone.mmc.com.au>

        * src/print.c: Removed preview from PrintJobInfo.
        (print_sheet): When printing a sheet range, only print pages in
        the range.
        (print_job_info_get): Initialise end_page to the # pages in the
        sheet.
        (sheet_print): Use the gnomeprintmaster object for
        printing/preview, and gnomeprintdialog for getting printer
        information.

2000-01-23  Miguel de Icaza   <miguel@gnu.org>

	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet): Handle
	GDK_ISO_Left_Tab and GDK_KP_Tab as well, per Chris' suggestion.

2000-01-23  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/autosave-prompt.glade: Give "Yes"
	button initial keyboard focus.

	* src/dialogs/autosave.glade: Set initial focus to
	first check button. Make OK the default.

	* src/dialogs/dialog-autocorrect.c (dialog_autocorrect): Make
	<Ret> in entry fields invoke default.
	(dialog_autocorrect, exceptions_callback):

	* src/dialogs/autocorrect-exceptions.glade: Set initial focus to
	text entry field. Make OK the default. Do not show column headers
	in clist. Remove unnecessary level of scrollwindow.

	* src/dialogs/autocorrect.glade: Make OK the default. Set initial
	focus to first check button. Define accelerators. Set widgets for
	"replace text when typed" insensitive until feature is
	implemented. Do not show column headers in clist.

	* src/dialogs/dialog-autosave.c (dialog_autosave): Make
	<Ret> in "minutes" fields invoke default.

2000-01-23  Michael Meeks  <michael@edenproject.org>

	* src/ranges.c (range_translate): fix glaring bugs + make
	semantics saner.
	(range_transpose): implement.

	* src/clipboard.c (do_clipboard_paste_cell_region): s/cell.cell/cell.
	(x_selection_to_cell_region): Null styles.
	(clipboard_prepend_cell): kill mstyle inefficiency.
	(clipboard_release): destroy styles.
	(sheet_paste_selection): new style bits.

	* src/render-ascii.c (cell_region_render_ascii): kill cell.cell

	* src/cell.h (CellCopy): Kill MStyle member.

	* src/ranges.c (range_init): implement helper.

	* src/sheet-style.c (style_region_destroy): add precondition.
	(sheet_get_styles_in_range, sheet_style_list_destroy): implement.

2000-01-22  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-view.c (sheet_view_redraw_headers) : New function that
	  will redraw a subset of an itembar.
	(sheet_view_redraw_columns) : Delete.
	(sheet_view_redraw_rows) : Delete.

	* src/sheet.c (sheet_redraw_headers) : Call sheet_view_redraw_headers.
	(sheet_redraw_columns) : Delete.
	(sheet_redraw_rows) : Delete.

	* src/gnumeric-sheet.h (GnumericSheet) : Remove unused member item_bar_col.

	* src/colrow.c (col_row_set_visiblity) : Use sheet_redraw_headers
	  in place of sheet_redraw_{cols,row}.
	* src/selection.c (sheet_selection_append_range) : Ditto.
	(sheet_select_all) : Ditto.
	(sheet_selection_reset_only) : Ditto.  Clear the selection internally.

	* src/sheet.c (sheet_{col,row}_get_distance) : Handle from > to.

	* src/item-cursor.c (item_cursor_get_pixel_coords) : Use the
	  precalculated offsets.
	* src/item-edit.c (item_edit_get_pixel_coords) : Ditto.

	* src/gnumeric-sheet.c (gnumeric_sheet_bar_set_top_row) : Update the
	  item_grid's notion of the top.  Calculate the new distance using the
	  previous top as the start point.
	(gnumeric_sheet_bar_set_left_col) : Rename from top_col.  Ditto.

2000-01-21  Jody Goldberg <jgoldberg@home.com>

	* src/item-bar.c (item_bar_draw) : Remove minor drawing glitch when
	  drawing at the edge of the sheet.
	(item_bar_class_init) : Remove the unsed 'First' argument.

	* src/item-grid.c (item_grid_draw) : Draw gridlines even at the
	  outer edges.

Put a wrapper in place around dialog creation.  This will eventually handle the
setting of the parent and closing the parent application while a dialog is up.

2000-01-21  Jody Goldberg <jgoldberg@home.com>

	* src/dialogs/dialog-printer-setup.c (do_hf_config) : Take a Workbook.

	* src/gnumeric-util.c (gnumeric_dialog_run) : New function.
	  It is a wrapper for now.  After the release of .48 we will
	  move the parent setting here.  And handle the case where a
	  user closes the app window while a dialog is displayed.

	* src/file.c (workbook_import) : Use gnumeric_dialog_run.

	* src/dialogs/dialog-{dialog-zoom.c (dialog_zoom_impl)
		    summary.c (dialog_summary_update)
		    solver.c (dialog_solver)
		    solver.c (constr_add_click)
		    solver.c (dialog_solver_options)
		    simple-input.c (dialog_get_number, dialog_get_sheet_name)
		    printer.c (gnumeric_printer_dialog_run)
		    paste-special.c (dialog_paste_special)
		    insert-cells.c (dialog_insert_cells_impl)
		    goto-cell.c (dialog_goto_cell)
		    goal-seek.c (dialog_found_solution, dialog_goal_seek)
		    function-wizard.c (dialog_function_wizard)
		    delete-cells.c (dialog_delete_cells_impl)
		    cell-sort.c (dialog_cell_sort)
		    cell-format.c (fmt_dialog_impl)
		    cell-comment.c (dialog_cell_comment)
		    autosave.c (dialog_autosave_callback, dialog_autosave)
		    autocorrect.c (exceptions_callback)
		    (dialog_autocorrect)} : Ditto.

	* src/dialogs/dialog-analysis-tools.c
	(dialog_{correlation_tool, covariance_tool, sampling_tool,
	 descriptive_stat_tool, ztest_tool, ttest_paired_tool, ttest_eq_tool,
	 ttest_neq_tool, ftest_tool, random_tool, regression_tool,
	 average_tool, ranking_tool, anova_single_factor_tool,
	 anova_two_factor_without_r_tool, data_analysis}) : Ditto.

	* src/workbook.c (workbook_can_close) : Ditto.
	* src/item-cursor.c (item_cursor_target_region_ok) : Ditto.

	* src/sheet.c (sheet_move_range) : Avoid leaking when we paste.
	  This information will be used when undo for pasteing a cut
	  is ready.

	* README : update requirements.

	* plugins/Makefile.am : Do not compile the python plugin by
	  default.  This will avoid complaints regarding problems with
	  no dynamic python library until we have a solution.

	* src/functions/fn-stat.c : (gnumeric_kurt, gnumeric_kurtp) : return DIV/0
	  on error.

Thu Jan 20 16:52:14 2000  Morten Welinder  <welinder@rentec.com>

	* src/functions/fn-stat.c (gnumeric_stdev): Correct error code.

	* src/functions/fn-math.c (gnumeric_log): Correct error code and
 	protect from crash.

2000-01-20  Morten Welinder  <terra@diku.dk>

	* src/functions/fn-math.c (gnumeric_mod): Correct error code; fix
 	for b < 0.

2000-01-20  Morten Welinder  <terra@diku.dk>

	* src/functions/fn-math.c (gnumeric_power): Correct error code.

	* src/functions/fn-stat.c (gnumeric_avedev): Correct error code.
	(gnumeric_varp): Ditto.
	(gnumeric_var): Ditto.
	(gnumeric_median): Ditto.
	(gnumeric_min): Empty list yields zero, not error.
	(gnumeric_max): Ditto.

- Col/Row hide undo
- Keep selection extension cell visible
- Improve selection overlap range fragmentation, and debugging.

2000-01-20  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-cmd-format.c (workbook_cmd_format_{col,row}_{hide,unhide}) :
	  Use the undo framework.

	* src/sheet.c (sheet_fill_selection_with) : Take a context.

	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Add
	  Alt-Pg{Up,Down}.  sheet_fill_selection_with now takes a context.

	* src/commands.c (cmd_hide_selection_rows_cols) : Implement undo for
	  row/col hiding.
	(cmd_hide_row_col_{undo,redo,destroy}) : Ditto.

	* src/item-grid.c (context_{col,row}_{hide,unhide}) : Use undo support.

	* src/selection.c (selection_get_ranges) : Improve heuristics.
	(sheet_selection_extend_{horizontal,vertical}) : Ensure that the cell
	  being moved stays visible.

2000-01-20  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/dialog-autosave.c (dialog_autosave): Re-enable
	autosave timer on cancel.

2000-01-19  Jon K Hellan  <hellan@acm.org>

	* src/workbook.c (workbook_do_destroy): Remove autosave timer.

	* src/dialogs/dialog-zoom.c (dialog_zoom_impl): Set initial focus
	to selected radio button.

	* src/dialogs/font-sel.glade.h, src/dialogs/font-sel.glade: Fix
	typo in preview text

	* src/dialogs/dialog-printer-setup.c (do_setup_main_dialog):
	Set Initial focus for print setup dialog.

	* src/workbook.c (workbook_can_close): Yes/No dialog: Give cancel
	button initial keyboard focus.

Bug fix.
gtk_timeout functions need to return a flag.

2000-01-19  JP Rosevear  <jpr@arcavia.com>

	* src/dialogs/dialog-cell-sort.c (dialog_cell_sort): Modularize a
	bit more for the sort dialog.  Use GLADE_FILE macro.
	(dialog_cell_sort_ok): New function connected to the sort
	dialog ok button.  Builds the clause data and then calls cmd_sort.
	(dialog_cell_sort_adv): Use GLADE_FILE macro.
	(clip_range_to_finite): New function, reduces an infinite range to
	an appropriate finite range.

	* src/commands.c (cmd_sort): New function for new command
	organization.
	(cmd_sort_redo): ditto
	(cmd_sort_undo): ditto
	(cmd_sort_destroy): ditto

	* src/sort.c (sort_compare_values): The former compare_values
	function from dialog_cell_sort.c.
	(sort_compare_values2): Does comparisons on original order
	for undo.
	(sort_qsort_func): The former qsort_func function from
	dialog_cell_sort.c.
	(sort_qsort_func2): Quicksort function for undo.
	(sort_range): Performs the sort.  Much the same as the
	sort_cell_range function that was in dialog_cell_sort.c.
	Sorts the data of a CmdSort object, creating it if necessary.
	Takes the quicksort function to call as an argument.

	* src/sort.h : New header file

	* src/ranges.h: Prototype range_name.

	* src/ranges.c (range_name): New function that returns a
	const char * to "A1:B5" type range name.

2000-01-19  Jody Goldberg <jgoldberg@home.com>

	* src/print-cell.c (print_cell_grid) : Don't print grid lines for
	  hidden cols/rows.

	* src/print.c (compute_groups) : Hidden cols/rows exist.  They just
	  don't take up any space.

	* src/parser.y : array_cols remove null production.  We can have
	  empty array_rows OR we can have empty array_cols.  Not both.

Support hidden rows cols in print preview.

2000-01-18  Jody Goldberg <jgoldberg@home.com>

	* src/expr.c (eval_expr_real) : Add OPER_UNARY_PLUS.
	(do_expr_decode_tree) : Ditto.
	(expr_dump_tree) : Ditto.

	* src/auto-format.c (do_af_suggest) : Add OPER_UNARY_PLUS.

	* src/parser.y (exp -> + exp): treat as OPER_UNARY_PLUS.

	* src/print-cell.c (print_cell_range) : Ignore hidden rows/cols.

2000-01-18  Morten Welinder  <terra@diku.dk>

	* src/expr.c (eval_expr_empty): New function.

	* src/func.c (function_iterate_argument_values): New new
 	eval_expr_empty and ignore empty values.

	* src/collect.c (callback_function_collect): Handle NULL value.

2000-01-18  Morten Welinder  <terra@diku.dk>

	* src/parser.y (exp -> + exp): treat as 0+exp.  Remove duplicate
 	production.

2000-01-18  Morten Welinder  <terra@diku.dk>

	* plugins/Makefile.am (SUBDIRS): Delete the superseded stat
 	plugin.

	* plugins/stat/*: remove

	* configure.in (AC_OUTPUT): Ditto.

2000-01-18  Morten Welinder  <terra@diku.dk>

	* src/functions/fn-logical.c (logical_functions_init): Add result
 	type for IF.

	* src/auto-format.h (AutoFormatTypes): Add AF_FIRST_ARG_FORMAT2.

	* src/auto-format.c (do_af_suggest): Implement
 	AF_FIRST_ARG_FORMAT2.

- Row/Col hiding.

2000-01-18  Jody Goldberg <jgoldberg@home.com>

	* src/xml-io.c (xml_write_colrow_info) : Save whether or not a row/col
	  is hidden.
	(xml_read_colrow_info) : Restore the hidden-ness.

	* src/gnumeric-sheet.c (gnumeric_sheet_compute_visible_ranges) :
	  Col/Row pixel width < 0 indicates the row is hidden.
	(gnumeric_sheet_make_cell_visible) : Ditto.
	(colrow_set_units) : Ditto.
	(sheet_{row,col}_info_set_{height,width}) : Ditto.
	(sheet_{row,col}_set_internal_{height,width}) : Ditto.
	(sheet_{row,col}_get_distance) : Ditto.
	(sheet_{row,col}_get_unit_distance) : Ditto.
	(sheet_{row,col}_is_hidden) : Utility routines.
	(sheet_find_boundary_{vertical,horizontal}) : Skip hidden rows/cols.
	(sheet_row_col_visible) : Mark a contiguous set of rows/cols as
	  visible or hidden.

	* src/sheet.c (sheet_compute_col_row_new_size) : Ditto.

	* src/item-bar.c (item_bar_draw) : Ditto.
	(is_pointer_on_division) : Ditto.
	(get_col_from_pos) : Ditto.

	* src/item-grid.c (item_grid_find_{col,row}) : Ditto.
	(item_grid_draw) : Skip cells in hidden rows cols.
	(item_grid_paint_empty_cell) : Ditto, just in case.
	(item_grid_draw_cell) : Ditto.
	(context_{col,row}_{hide,unhide}) : New functions.
	(item_grid_context_menu) : Add new menu items.

	* src/selection.c (selection_row_col_visible) : New function.
	cb_row_col_visibility : Utility function.

	* src/workbook-cmd-format.c
	(workbook_cmd_format_{column,row}_{hide,unhide}) : New functions.
	(workbook_cmd_format_column_std_width) : Stub.
	(workbook_cmd_format_row_std_height) : Stub.

	* src/workbook.c : Add hide/unhide to the row/col format menus.

2000-01-18  Jody Goldberg <jgoldberg@home.com>

	* configure.in : Add test for gnome-xml >= 1.8.5. This is
	  required to support the problems with versions 1.8.[234].
	* gnumeric.spec.in : Ditto.