Commit cf3f1e00 authored by Jody Goldberg's avatar Jody Goldberg Committed by Jody Goldberg
Browse files

Fix typo, did this ever work ?


2000-04-07  Jody Goldberg <jgoldberg@home.com>

	* src/embeddable-grid.h (GridViewClass) : Fix typo, did this ever work ?

	* src/workbook.c (workbook_move_sheet) : Mark the book as dirty when a
	  sheet moved.
	(insert_sheet_cmd) : Mark book as dirty when sheet is added.
	(workbook_attach_sheet) : Add a precondition to avoid failing in the
	  bonobo case.
parent 6b3ee7b5
......@@ -44,3 +44,5 @@ Widget polishing
- gtk-combo-text
: a value entered directly in the edit field does not handle selection in
the list correctly
: The mouse over effect is incorrect when the popup is closed and reopened.
2000-04-07 Jody Goldberg <jgoldberg@home.com>
* src/embeddable-grid.h (GridViewClass) : Fix typo, did this ever work ?
* src/workbook.c (workbook_move_sheet) : Mark the book as dirty when a
sheet moved.
(insert_sheet_cmd) : Mark book as dirty when sheet is added.
(workbook_attach_sheet) : Add a precondition to avoid failing in the
bonobo case.
2000-04-07 Morten Welinder <terra@diku.dk>
* src/collect.h (CollectFlags): Get rid of COLLECT_IGNORE_POSITIVE
......
2000-04-07 Jody Goldberg <jgoldberg@home.com>
* src/embeddable-grid.h (GridViewClass) : Fix typo, did this ever work ?
* src/workbook.c (workbook_move_sheet) : Mark the book as dirty when a
sheet moved.
(insert_sheet_cmd) : Mark book as dirty when sheet is added.
(workbook_attach_sheet) : Add a precondition to avoid failing in the
bonobo case.
2000-04-07 Morten Welinder <terra@diku.dk>
* src/collect.h (CollectFlags): Get rid of COLLECT_IGNORE_POSITIVE
......
2000-04-07 Jody Goldberg <jgoldberg@home.com>
* src/embeddable-grid.h (GridViewClass) : Fix typo, did this ever work ?
* src/workbook.c (workbook_move_sheet) : Mark the book as dirty when a
sheet moved.
(insert_sheet_cmd) : Mark book as dirty when sheet is added.
(workbook_attach_sheet) : Add a precondition to avoid failing in the
bonobo case.
2000-04-07 Morten Welinder <terra@diku.dk>
* src/collect.h (CollectFlags): Get rid of COLLECT_IGNORE_POSITIVE
......
2000-04-07 Jody Goldberg <jgoldberg@home.com>
* src/embeddable-grid.h (GridViewClass) : Fix typo, did this ever work ?
* src/workbook.c (workbook_move_sheet) : Mark the book as dirty when a
sheet moved.
(insert_sheet_cmd) : Mark book as dirty when sheet is added.
(workbook_attach_sheet) : Add a precondition to avoid failing in the
bonobo case.
2000-04-07 Morten Welinder <terra@diku.dk>
* src/collect.h (CollectFlags): Get rid of COLLECT_IGNORE_POSITIVE
......
2000-04-07 Jody Goldberg <jgoldberg@home.com>
* src/embeddable-grid.h (GridViewClass) : Fix typo, did this ever work ?
* src/workbook.c (workbook_move_sheet) : Mark the book as dirty when a
sheet moved.
(insert_sheet_cmd) : Mark book as dirty when sheet is added.
(workbook_attach_sheet) : Add a precondition to avoid failing in the
bonobo case.
2000-04-07 Morten Welinder <terra@diku.dk>
* src/collect.h (CollectFlags): Get rid of COLLECT_IGNORE_POSITIVE
......
2000-04-07 Jody Goldberg <jgoldberg@home.com>
* src/embeddable-grid.h (GridViewClass) : Fix typo, did this ever work ?
* src/workbook.c (workbook_move_sheet) : Mark the book as dirty when a
sheet moved.
(insert_sheet_cmd) : Mark book as dirty when sheet is added.
(workbook_attach_sheet) : Add a precondition to avoid failing in the
bonobo case.
2000-04-07 Morten Welinder <terra@diku.dk>
* src/collect.h (CollectFlags): Get rid of COLLECT_IGNORE_POSITIVE
......
2000-04-07 Jody Goldberg <jgoldberg@home.com>
* src/embeddable-grid.h (GridViewClass) : Fix typo, did this ever work ?
* src/workbook.c (workbook_move_sheet) : Mark the book as dirty when a
sheet moved.
(insert_sheet_cmd) : Mark book as dirty when sheet is added.
(workbook_attach_sheet) : Add a precondition to avoid failing in the
bonobo case.
2000-04-07 Morten Welinder <terra@diku.dk>
* src/collect.h (CollectFlags): Get rid of COLLECT_IGNORE_POSITIVE
......
......@@ -173,7 +173,6 @@ gtk_combo_box_popup_hide_unconditional (GtkComboBox *combo_box)
gtk_signal_handler_unblock_by_func (GTK_OBJECT (arrow),
GTK_SIGNAL_FUNC (gtk_combo_toggle_pressed),
combo_box);
}
/**
......
......@@ -69,7 +69,7 @@ struct _GridView {
};
typedef struct {
BonoboView parent_class;
BonoboViewClass parent_class;
} GridViewClass;
GtkType grid_view_get_type (void);
......
......@@ -173,7 +173,6 @@ gtk_combo_box_popup_hide_unconditional (GtkComboBox *combo_box)
gtk_signal_handler_unblock_by_func (GTK_OBJECT (arrow),
GTK_SIGNAL_FUNC (gtk_combo_toggle_pressed),
combo_box);
}
/**
......
......@@ -173,7 +173,6 @@ gtk_combo_box_popup_hide_unconditional (GtkComboBox *combo_box)
gtk_signal_handler_unblock_by_func (GTK_OBJECT (arrow),
GTK_SIGNAL_FUNC (gtk_combo_toggle_pressed),
combo_box);
}
/**
......
......@@ -81,7 +81,6 @@ gtk_combo_text_select_item (GtkComboText *ct, int elem)
* this.
*
* TODO : Add autoscroll
* TODO : Cancel the popup when 'Escape' is pressed.
*/
static gboolean
cb_enter (GtkWidget *w, GdkEventCrossing *event,
......
......@@ -788,6 +788,7 @@ insert_sheet_cmd (GtkWidget *unused, Workbook *wb)
g_free (name);
workbook_attach_sheet (wb, sheet);
sheet_set_dirty (sheet, TRUE);
}
static void
......@@ -2899,6 +2900,9 @@ workbook_attach_sheet (Workbook *wb, Sheet *sheet)
gtk_widget_show_all (t);
gtk_object_set_data (GTK_OBJECT (t), "sheet", sheet);
/* FIXME : The bonobo case does not seem to have a notebook ? */
g_return_if_fail (wb->notebook != NULL);
sheet_label = editable_label_new (sheet->name);
/*
* NB. this is so we can use editable_label_set_text since
......@@ -3399,6 +3403,7 @@ workbook_move_sheet (Sheet *sheet, int direction)
gtk_notebook_get_nth_page (nb, source);
gtk_notebook_reorder_child (nb, w, dest);
sheet_set_dirty (sheet, TRUE);
}
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment