Commit c15cd1d4 authored by Jody Goldberg's avatar Jody Goldberg Committed by Jody Goldberg

Arrrggh. textdomain seems to use a static buffer. We need to strdup the


2000-05-29  Jody Goldberg <jgoldberg@home.com>

	* src/xml-io.c (xml_workbook_write) : Arrrggh.  textdomain seems to
	  use a static buffer.  We need to strdup the result.  A more thorough
	  reading of the docs suggests that changing the textdomain is
	  completely wrong.  It is not doing what I had originally thought at
	  all.  Any idea what the correct solution would be ?  I'll patch this
	  for now because 12461 is serious, and this does solve the problem,
	  even if the solution is crap.
parent d679caf8
2000-05-29 Jody Goldberg <jgoldberg@home.com>
* src/xml-io.c (xml_workbook_write) : Arrrggh. textdomain seems to
use a static buffer. We need to strdup the result. A more thorough
reading of the docs suggests that changing the textdomain is
completely wrong. It is not doing what I had originally thought at
all. Any idea what the correct solution would be ? I'll patch this
for now because 12461 is serious, and this does solve the problem,
even if the solution is crap.
2000-05-29 ERDI Gergo <cactus@cactus.rulez.org>
* src/commands.c: Including dialogs/dialog-autocorrect.h (warning fix)
......
2000-05-29 Jody Goldberg <jgoldberg@home.com>
* src/xml-io.c (xml_workbook_write) : Arrrggh. textdomain seems to
use a static buffer. We need to strdup the result. A more thorough
reading of the docs suggests that changing the textdomain is
completely wrong. It is not doing what I had originally thought at
all. Any idea what the correct solution would be ? I'll patch this
for now because 12461 is serious, and this does solve the problem,
even if the solution is crap.
2000-05-29 ERDI Gergo <cactus@cactus.rulez.org>
* src/commands.c: Including dialogs/dialog-autocorrect.h (warning fix)
......
2000-05-29 Jody Goldberg <jgoldberg@home.com>
* src/xml-io.c (xml_workbook_write) : Arrrggh. textdomain seems to
use a static buffer. We need to strdup the result. A more thorough
reading of the docs suggests that changing the textdomain is
completely wrong. It is not doing what I had originally thought at
all. Any idea what the correct solution would be ? I'll patch this
for now because 12461 is serious, and this does solve the problem,
even if the solution is crap.
2000-05-29 ERDI Gergo <cactus@cactus.rulez.org>
* src/commands.c: Including dialogs/dialog-autocorrect.h (warning fix)
......
2000-05-29 Jody Goldberg <jgoldberg@home.com>
* src/xml-io.c (xml_workbook_write) : Arrrggh. textdomain seems to
use a static buffer. We need to strdup the result. A more thorough
reading of the docs suggests that changing the textdomain is
completely wrong. It is not doing what I had originally thought at
all. Any idea what the correct solution would be ? I'll patch this
for now because 12461 is serious, and this does solve the problem,
even if the solution is crap.
2000-05-29 ERDI Gergo <cactus@cactus.rulez.org>
* src/commands.c: Including dialogs/dialog-autocorrect.h (warning fix)
......
2000-05-29 Jody Goldberg <jgoldberg@home.com>
* src/xml-io.c (xml_workbook_write) : Arrrggh. textdomain seems to
use a static buffer. We need to strdup the result. A more thorough
reading of the docs suggests that changing the textdomain is
completely wrong. It is not doing what I had originally thought at
all. Any idea what the correct solution would be ? I'll patch this
for now because 12461 is serious, and this does solve the problem,
even if the solution is crap.
2000-05-29 ERDI Gergo <cactus@cactus.rulez.org>
* src/commands.c: Including dialogs/dialog-autocorrect.h (warning fix)
......
2000-05-29 Jody Goldberg <jgoldberg@home.com>
* src/xml-io.c (xml_workbook_write) : Arrrggh. textdomain seems to
use a static buffer. We need to strdup the result. A more thorough
reading of the docs suggests that changing the textdomain is
completely wrong. It is not doing what I had originally thought at
all. Any idea what the correct solution would be ? I'll patch this
for now because 12461 is serious, and this does solve the problem,
even if the solution is crap.
2000-05-29 ERDI Gergo <cactus@cactus.rulez.org>
* src/commands.c: Including dialogs/dialog-autocorrect.h (warning fix)
......
2000-05-29 Jody Goldberg <jgoldberg@home.com>
* src/xml-io.c (xml_workbook_write) : Arrrggh. textdomain seems to
use a static buffer. We need to strdup the result. A more thorough
reading of the docs suggests that changing the textdomain is
completely wrong. It is not doing what I had originally thought at
all. Any idea what the correct solution would be ? I'll patch this
for now because 12461 is serious, and this does solve the problem,
even if the solution is crap.
2000-05-29 ERDI Gergo <cactus@cactus.rulez.org>
* src/commands.c: Including dialogs/dialog-autocorrect.h (warning fix)
......
......@@ -2826,7 +2826,7 @@ xml_workbook_write (parse_xml_context_t *ctxt, Workbook *wb)
old_num_locale = g_strdup (setlocale (LC_NUMERIC, NULL));
setlocale (LC_NUMERIC, "C");
old_msg_locale = textdomain (NULL);
old_msg_locale = g_strdup (textdomain (NULL));
textdomain ("C");
args = workbook_get_attributev (wb, &n_args);
......@@ -2879,6 +2879,7 @@ xml_workbook_write (parse_xml_context_t *ctxt, Workbook *wb)
xmlAddChild (cur, child);
textdomain (old_msg_locale);
g_free (old_msg_locale);
setlocale (LC_NUMERIC, old_num_locale);
g_free (old_num_locale);
......@@ -2930,7 +2931,7 @@ xml_workbook_read (Workbook *wb, parse_xml_context_t *ctxt, xmlNodePtr tree)
old_num_locale = g_strdup (setlocale (LC_NUMERIC, NULL));
setlocale (LC_NUMERIC, "C");
old_msg_locale = textdomain (NULL);
old_msg_locale = g_strdup (textdomain (NULL));
textdomain ("C");
child = xml_search_child (tree, "Summary");
......@@ -2999,6 +3000,7 @@ xml_workbook_read (Workbook *wb, parse_xml_context_t *ctxt, xmlNodePtr tree)
}
textdomain (old_msg_locale);
g_free (old_msg_locale);
setlocale (LC_NUMERIC, old_num_locale);
g_free (old_num_locale);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment