Commit acbe5a8b authored by Jody Goldberg's avatar Jody Goldberg Committed by Jody Goldberg
Browse files

Call sheet_update so that selection changes via mouse movement will update

2000-05-08  Jody Goldberg <jgoldberg@home.com>

	* src/selection.c (sheet_selection_extend_to) : Call sheet_update
	  so that selection changes via mouse movement will update the status
	  areas.
	(sheet_selection_set) : Call sheet_flag_selection_change.

	* src/sheet.c (sheet_flag_selection_change) : New function to
	  flag that sheet_update should recalc the autoexpressions.
parent 44d15c1f
......@@ -4,8 +4,6 @@ and longer term bugs.
Release Critical
----------------
- gnumeric_ftest : Needs auditing. All calls to eval_pos_init_cellref
are questionable.
Long term breakage
------------------
......@@ -14,6 +12,7 @@ Long term breakage
- Increase/Decrease precision toolbar buttons should look at the displayed
precision for the edit cell and assign the changed value to the entire
selection. Not individually adjusting each non-blank cell's precision.
This would mirror the application of bold/italic/underline
- Auto resize needs to handle empty cells.
- Clearing a cell that stopped a span does not regenerate the span.
......@@ -21,16 +20,18 @@ Long term breakage
- The implication of mixed mode references ($B$2:C3)
is large. All accesses to a RangeRef need to be normalized.
- gnumeric_ftest : Needs auditing. All calls to eval_pos_init_cellref
are questionable.
- Copy with destination larger than source does not duplicate the styles.
- border style double_line does handle all of the different intersection cases.
- 'General' numbers need to be formated based on the width of the cell.
- when guess the format of a possible value we should try the format associated
with the cell FIRST rather than later. eg enter '10-1' (without quotes) in a
cell with an assigned format of Text. This should be treated as text. Instead
It parses as a Date (Oct 1) and gets converted.
- when guessing the format of a possible value we should try the format
associated with the cell FIRST rather than later. eg enter '10-1' (without
quotes) in a cell with an assigned format of Text. This should be treated as
text. Instead It parses as a Date (Oct 1) and gets converted.
- The File->Print Preview icon is too big. Use the stock version when the next
release of gnome-libs is made. (tigert is adding to gnome-libs)
......@@ -41,13 +42,24 @@ Long term breakage
- All forms of autoscroll should use the timer mechanism from item-grid.
- The auto scroll timer from item-grid needs to move to sheet-view.
Dialogs
-------
- Finish function wizard
- Use color combos in format dialog.
Function Breakage
-----------------
- Index : does not support 0,0 or reference syntax.
Printing
--------
- When sizing the page no space is left for the headers and footers.
Widget polishing
----------------
- gtk-combo-text
: a value entered directly in the edit field does not handle selection in
the list correctly
: the list does not auto scroll.
- Add row (rows ?) for custom colours in the color combo dialog.
2000-05-08 Jody Goldberg <jgoldberg@home.com>
* src/selection.c (sheet_selection_extend_to) : Call sheet_update
so that selection changes via mouse movement will update the status
areas.
(sheet_selection_set) : Call sheet_flag_selection_change.
* src/sheet.c (sheet_flag_selection_change) : New function to
flag that sheet_update should recalc the autoexpressions.
2000-05-07 Jody Goldberg <jgoldberg@home.com>
* README : Update to require new gnome-print.
* gnumeric.spec.in : Ditto.
2000-05-08 Jon K Hellan <hellan@acm.org>
This change was committed a week ago, but I forgot the changelog:
......
2000-05-08 Jody Goldberg <jgoldberg@home.com>
* src/selection.c (sheet_selection_extend_to) : Call sheet_update
so that selection changes via mouse movement will update the status
areas.
(sheet_selection_set) : Call sheet_flag_selection_change.
* src/sheet.c (sheet_flag_selection_change) : New function to
flag that sheet_update should recalc the autoexpressions.
2000-05-07 Jody Goldberg <jgoldberg@home.com>
* README : Update to require new gnome-print.
* gnumeric.spec.in : Ditto.
2000-05-08 Jon K Hellan <hellan@acm.org>
This change was committed a week ago, but I forgot the changelog:
......
2000-05-08 Jody Goldberg <jgoldberg@home.com>
* src/selection.c (sheet_selection_extend_to) : Call sheet_update
so that selection changes via mouse movement will update the status
areas.
(sheet_selection_set) : Call sheet_flag_selection_change.
* src/sheet.c (sheet_flag_selection_change) : New function to
flag that sheet_update should recalc the autoexpressions.
2000-05-07 Jody Goldberg <jgoldberg@home.com>
* README : Update to require new gnome-print.
* gnumeric.spec.in : Ditto.
2000-05-08 Jon K Hellan <hellan@acm.org>
This change was committed a week ago, but I forgot the changelog:
......
2000-05-08 Jody Goldberg <jgoldberg@home.com>
* src/selection.c (sheet_selection_extend_to) : Call sheet_update
so that selection changes via mouse movement will update the status
areas.
(sheet_selection_set) : Call sheet_flag_selection_change.
* src/sheet.c (sheet_flag_selection_change) : New function to
flag that sheet_update should recalc the autoexpressions.
2000-05-07 Jody Goldberg <jgoldberg@home.com>
* README : Update to require new gnome-print.
* gnumeric.spec.in : Ditto.
2000-05-08 Jon K Hellan <hellan@acm.org>
This change was committed a week ago, but I forgot the changelog:
......
2000-05-08 Jody Goldberg <jgoldberg@home.com>
* src/selection.c (sheet_selection_extend_to) : Call sheet_update
so that selection changes via mouse movement will update the status
areas.
(sheet_selection_set) : Call sheet_flag_selection_change.
* src/sheet.c (sheet_flag_selection_change) : New function to
flag that sheet_update should recalc the autoexpressions.
2000-05-07 Jody Goldberg <jgoldberg@home.com>
* README : Update to require new gnome-print.
* gnumeric.spec.in : Ditto.
2000-05-08 Jon K Hellan <hellan@acm.org>
This change was committed a week ago, but I forgot the changelog:
......
2000-05-08 Jody Goldberg <jgoldberg@home.com>
* src/selection.c (sheet_selection_extend_to) : Call sheet_update
so that selection changes via mouse movement will update the status
areas.
(sheet_selection_set) : Call sheet_flag_selection_change.
* src/sheet.c (sheet_flag_selection_change) : New function to
flag that sheet_update should recalc the autoexpressions.
2000-05-07 Jody Goldberg <jgoldberg@home.com>
* README : Update to require new gnome-print.
* gnumeric.spec.in : Ditto.
2000-05-08 Jon K Hellan <hellan@acm.org>
This change was committed a week ago, but I forgot the changelog:
......
2000-05-08 Jody Goldberg <jgoldberg@home.com>
* src/selection.c (sheet_selection_extend_to) : Call sheet_update
so that selection changes via mouse movement will update the status
areas.
(sheet_selection_set) : Call sheet_flag_selection_change.
* src/sheet.c (sheet_flag_selection_change) : New function to
flag that sheet_update should recalc the autoexpressions.
2000-05-07 Jody Goldberg <jgoldberg@home.com>
* README : Update to require new gnome-print.
* gnumeric.spec.in : Ditto.
2000-05-08 Jon K Hellan <hellan@acm.org>
This change was committed a week ago, but I forgot the changelog:
......
2000-05-07 Jody Goldberg <jgoldberg@home.com>
* Makefile.am (gnumeric_plugin_LTLIBRARIES) : Disable for now.
2000-04-27 Jody Goldberg <jgoldberg@home.com>
* Makefile.am : typo.
2000-04-26 Jody Goldberg <jgoldberg@home.com>
* perl.c (init_plugin) : Use gnumeric_sys_data_dir.
......@@ -168,6 +168,7 @@ sheet_selection_add (Sheet *sheet, int col, int row)
* @row: row that gets covered
*
* This extends the selection to cover col, row
* and updates the status areas.
*/
void
sheet_selection_extend_to (Sheet *sheet, int col, int row)
......@@ -188,6 +189,14 @@ sheet_selection_extend_to (Sheet *sheet, int col, int row)
workbook_set_region_status (sheet->workbook,
sheet_get_selection_name (sheet));
/*
* FIXME : Does this belong here ?
* This is a convenient place to put is so that move movements
* that change the selection also update the status region,
* but this is somewhat lower level that I want to do this.
*/
sheet_update (sheet);
}
/*
......@@ -407,6 +416,8 @@ sheet_selection_set (Sheet *sheet,
sheet_redraw_headers (sheet, FALSE, TRUE, &tmp);
}
}
sheet_flag_selection_change (sheet);
}
/**
......
......@@ -621,7 +621,7 @@ sheet_reposition_comments (Sheet const * const sheet,
*/
void
sheet_flag_status_update_cell (Sheet const *sheet,
int const col, int const row)
int col, int row)
{
/* if a part of the selected region changed value update
* the auto expressions
......@@ -651,7 +651,7 @@ sheet_flag_status_update_cell (Sheet const *sheet,
*/
void
sheet_flag_status_update_range (Sheet const *sheet,
Range const * const range)
Range const *range)
{
/* Force an update */
if (range == NULL) {
......@@ -673,6 +673,20 @@ sheet_flag_status_update_range (Sheet const *sheet,
sheet->priv->edit_pos_changed = TRUE;
}
/**
* sheet_flag_selection_change :
* flag the sheet as requiring an update to the status display
*
* @sheet :
*
* Will cause auto expressions to be updated
*/
void
sheet_flag_selection_change (Sheet const *sheet)
{
sheet->priv->selection_content_changed = TRUE;
}
/*
* sheet_update : Should be called after a logical command has finished processing
* to request redraws for any pending events
......
......@@ -291,8 +291,9 @@ void sheet_redraw_headers (Sheet const *sheet,
gboolean const col, gboolean const row,
Range const * r /* optional == NULL */);
void sheet_flag_status_update_cell (Sheet const *sheet, int const col, int const row);
void sheet_flag_status_update_range(Sheet const *sheet, Range const * const range);
void sheet_flag_status_update_cell (Sheet const *sheet, int col, int row);
void sheet_flag_status_update_range(Sheet const *sheet, Range const *range);
void sheet_flag_selection_change (Sheet const *sheet);
void sheet_update (Sheet const *sheet);
void sheet_compute_visible_ranges (Sheet const *sheet);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment