Disable jump to edit pos to avoid unintended jumping when a sheet is

2000-06-15  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-view.c (sheet_view_size_allocate) : Disable jump to edit
	  pos to avoid unintended jumping when a sheet is added.

ChangeLog

+2000-06-15  Jody Goldberg <jgoldberg@home.com>
+
+	* src/sheet-view.c (sheet_view_size_allocate) : Disable jump to edit
+	  pos to avoid unintended jumping when a sheet is added.
+
+	* src/func.c (function_def_count_args) : Correctly handle vararg
+	  functions that takes nodes.
+
 2000-06-15  JP Rosevear  <jpr@arcavia.com>
 
 	* src/expr.c (eval_expr_real): Use new value_compare API

ChangeLog-2000-10-10

+2000-06-15  Jody Goldberg <jgoldberg@home.com>
+
+	* src/sheet-view.c (sheet_view_size_allocate) : Disable jump to edit
+	  pos to avoid unintended jumping when a sheet is added.
+
+	* src/func.c (function_def_count_args) : Correctly handle vararg
+	  functions that takes nodes.
+
 2000-06-15  JP Rosevear  <jpr@arcavia.com>
 
 	* src/expr.c (eval_expr_real): Use new value_compare API

OChangeLog-2000-10-10

+2000-06-15  Jody Goldberg <jgoldberg@home.com>
+
+	* src/sheet-view.c (sheet_view_size_allocate) : Disable jump to edit
+	  pos to avoid unintended jumping when a sheet is added.
+
+	* src/func.c (function_def_count_args) : Correctly handle vararg
+	  functions that takes nodes.
+
 2000-06-15  JP Rosevear  <jpr@arcavia.com>
 
 	* src/expr.c (eval_expr_real): Use new value_compare API

OChangeLog-2001-06-26

+2000-06-15  Jody Goldberg <jgoldberg@home.com>
+
+	* src/sheet-view.c (sheet_view_size_allocate) : Disable jump to edit
+	  pos to avoid unintended jumping when a sheet is added.
+
+	* src/func.c (function_def_count_args) : Correctly handle vararg
+	  functions that takes nodes.
+
 2000-06-15  JP Rosevear  <jpr@arcavia.com>
 
 	* src/expr.c (eval_expr_real): Use new value_compare API

OChangeLog-2002-01-22

+2000-06-15  Jody Goldberg <jgoldberg@home.com>
+
+	* src/sheet-view.c (sheet_view_size_allocate) : Disable jump to edit
+	  pos to avoid unintended jumping when a sheet is added.
+
+	* src/func.c (function_def_count_args) : Correctly handle vararg
+	  functions that takes nodes.
+
 2000-06-15  JP Rosevear  <jpr@arcavia.com>
 
 	* src/expr.c (eval_expr_real): Use new value_compare API

OChangeLog-2003-12-23

+2000-06-15  Jody Goldberg <jgoldberg@home.com>
+
+	* src/sheet-view.c (sheet_view_size_allocate) : Disable jump to edit
+	  pos to avoid unintended jumping when a sheet is added.
+
+	* src/func.c (function_def_count_args) : Correctly handle vararg
+	  functions that takes nodes.
+
 2000-06-15  JP Rosevear  <jpr@arcavia.com>
 
 	* src/expr.c (eval_expr_real): Use new value_compare API

OChangeLog-2005-11-14

+2000-06-15  Jody Goldberg <jgoldberg@home.com>
+
+	* src/sheet-view.c (sheet_view_size_allocate) : Disable jump to edit
+	  pos to avoid unintended jumping when a sheet is added.
+
+	* src/func.c (function_def_count_args) : Correctly handle vararg
+	  functions that takes nodes.
+
 2000-06-15  JP Rosevear  <jpr@arcavia.com>
 
 	* src/expr.c (eval_expr_real): Use new value_compare API

src/sheet-control-gui.c

@@ -293,6 +293,7 @@ sheet_view_scrollbar_config (SheetView const *sheet_view)
 	gtk_adjustment_changed (ha);
 }
 
+#if 0
 /*
  * sheet_view_make_edit_pos_visible
  * @sheet_view  Sheet view
@@ -314,11 +315,21 @@ sheet_view_make_edit_pos_visible (SheetView const *sheet_view)
 		 TRUE);
 
 }
+#endif
 
 static void
 sheet_view_size_allocate (GtkWidget *widget, GtkAllocation *alloc, SheetView *sheet_view)
 {
+#if 0
+	/* FIXME
+	 * When a new sheet is added this is called and if the edit cell was not visible
+	 * we change the scroll position even though to the user the size did not change
+	 * and there is no reason for the scrolling to jump.
+	 *
+	 * Can we somehow do this only if the edit pos was visible initially ?
+	 */
 	sheet_view_make_edit_pos_visible (sheet_view);
+#endif
 	sheet_view_scrollbar_config (sheet_view);
 }
 

src/sheet-view.c

@@ -293,6 +293,7 @@ sheet_view_scrollbar_config (SheetView const *sheet_view)
 	gtk_adjustment_changed (ha);
 }
 
+#if 0
 /*
  * sheet_view_make_edit_pos_visible
  * @sheet_view  Sheet view
@@ -314,11 +315,21 @@ sheet_view_make_edit_pos_visible (SheetView const *sheet_view)
 		 TRUE);
 
 }
+#endif
 
 static void
 sheet_view_size_allocate (GtkWidget *widget, GtkAllocation *alloc, SheetView *sheet_view)
 {
+#if 0
+	/* FIXME
+	 * When a new sheet is added this is called and if the edit cell was not visible
+	 * we change the scroll position even though to the user the size did not change
+	 * and there is no reason for the scrolling to jump.
+	 *
+	 * Can we somehow do this only if the edit pos was visible initially ?
+	 */
 	sheet_view_make_edit_pos_visible (sheet_view);
+#endif
 	sheet_view_scrollbar_config (sheet_view);
 }