Commit 9e615b65 authored by Jody Goldberg's avatar Jody Goldberg Committed by Jody Goldberg

Rework the style engine. Mostly functional. see BUGS for remaining details.

NOTE : I have not tested persistance.

2001-01-11  Jody Goldberg <jgoldberg@home.com>

	* src/mstyle.c (mstyle_ref_multiple) : new function.
	(mstyle_copy_merge) : new function.
	(mstyle_new_default) : Do not cache the result.  That is done at the
	  sheet level.
	(mstyle_do_merge) : delete.
	(mstyle_get_format) : constness.

	* src/format-template.c (cb_format_sheet_border) : delete.
	(format_template_apply_to_sheet_regions) : borders are no longer special.

	* src/expr.c (expr_tree_array_formula_corner) : do not store the
	  corner anymore.
	(expr_tree_new_array) : ditto.
	(do_expr_tree_unref) : ditto.

	* src/cell.c (cell_relocate) : Arrays are simplified.  No need to keep
	  a pointer to the corner.  It made the system too brittle.
	(cell_set_mstyle) : delete.

	* src/Makefile.am : remove test.[ch]

	* src/gnumeric-sheet.c (gnumeric_sheet_find_{col,row}) : There is no
	  1 pixel border.

2001-01-09  Jody Goldberg <jgoldberg@home.com>

	* src/mstyle.h : Change order of borders to match BorderLocation

2001-01-08  Jody Goldberg <jgoldberg@home.com>

	* src/ranges.c (range_has_header) : avoid leaking styles.

	* src/cell.c (cell_get_mstyle) : Use sheet_style_get, and do not bump
	  the ref count.
	(cell_render_value) : Adjust.
	(cell_get_format : Adjust.
	(cell_set_text) : Adjust.

	* src/functions/fn-information.c (gnumeric_cell) : sheet_style_get
	  does not make a reference. Use it.
	* src/workbook-format-toolbar.c (modify_cell_format) :  Ditto.
	(change_selection_font) : Ditto.
	* src/sheet-autofill.c (fill_item_new) : ditto.
	* src/print-cell.c (print_cell_range) : ditto.
	* src/cellspan.c (cell_calc_span) : ditto.
	* src/sheet.c (sheet_cell_set_text) : ditto.
	* src/rendered-value.c (rendered_value_calc_size) : ditto.
	* src/workbook-view.c (wb_view_format_feedback) : ditto.

2001-01-07  Jody Goldberg <jgoldberg@home.com>

	* src/dialogs/dialog-cell-format.c (dialog_cell_format) :
	  init initial style to NULL.
	(fmt_dialog_selection_type) : call sheet_style_get_uniform here.

	* src/commands.c (cmd_format_redo) : Now that apply_border is not
	  doing a redraw we need to if there is no style applied.

	* src/selection.c (sheet_selection_extend_to) : Add support akin to
	  gnumeric_sheet_rangesel_cursor_extend to extend to full col/row.

	* src/sheet-control-gui.c (scg_colrow_select) : extend to full col/row
	  if necessary.

	* src/item-bar.c (item_bar_event) : Set the selection, not extend it.
parent 9a08951e
......@@ -137,7 +137,8 @@ Each translation team has its own mailing list, courtesy of Linux
International. You may reach your translation team at the address
`LL@li.org', replacing LL by the two-letter ISO 639 code for your
language. Language codes are *not* the same as the country codes given
in ISO 3166. The following translation teams exist, as of August 1997:
in ISO 3166. The following translation teams exist, as of December
1997:
Chinese `zh', Czech `cs', Danish `da', Dutch `nl', English `en',
Esperanto `eo', Finnish `fi', French `fr', German `de', Hungarian
......@@ -172,42 +173,42 @@ Available Packages
==================
Languages are not equally supported in all packages. The following
matrix shows the current state of internationalization, as of August
matrix shows the current state of internationalization, as of December
1997. The matrix shows, in regard of each package, for which languages
PO files have been submitted to translation coordination.
Ready PO files cs da de en es fi fr it ja ko nl no pl pt sl sv
.-------------------------------------------------.
bash | [] [] [] | 3
bison | [] [] [] | 3
clisp | [] [] [] [] | 4
cpio | [] [] [] [] [] | 5
diffutils | [] [] [] [] [] | 5
enscript | [] [] [] [] [] [] | 6
fileutils | [] [] [] [] [] [] [] [] [] [] | 10
findutils | [] [] [] [] [] [] [] [] | 8
flex | [] [] [] [] | 4
gcal | [] [] [] [] [] | 5
gettext | [] [] [] [] [] [] [] [] [] [] | 11
grep | [] [] [] [] [] [] [] [] [] | 9
hello | [] [] [] [] [] [] [] [] [] [] | 10
id-utils | [] [] [] | 3
indent | [] [] [] [] | 4
libc | [] [] [] [] [] [] [] | 7
m4 | [] [] [] [] [] | 5
make | [] [] [] [] [] [] | 6
music | [] [] | 2
ptx | [] [] [] [] [] [] [] [] | 8
recode | [] [] [] [] [] [] [] [] [] | 9
sh-utils | [] [] [] [] [] [] [] | 7
sharutils | [] [] [] [] [] | 5
tar | [] [] [] [] [] [] [] [] [] [] | 10
texinfo | [] | 1
textutils | [] [] [] [] [] [] [] [] [] | 9
wdiff | [] [] [] [] [] [] [] [] | 8
`-------------------------------------------------'
16 languages cs da de en es fi fr it ja ko nl no pl pt sl sv
27 packages 3 2 24 1 17 1 26 2 1 11 20 9 19 7 7 17 167
Ready PO files cs da de en es fi fr it ja ko nl no pl pt ru sl sv
.----------------------------------------------------.
bash | [] [] [] | 3
bison | [] [] [] | 3
clisp | [] [] [] [] | 4
cpio | [] [] [] [] [] [] | 6
diffutils | [] [] [] [] [] | 5
enscript | [] [] [] [] [] [] | 6
fileutils | [] [] [] [] [] [] [] [] [] [] | 10
findutils | [] [] [] [] [] [] [] [] [] | 9
flex | [] [] [] [] | 4
gcal | [] [] [] [] [] | 5
gettext | [] [] [] [] [] [] [] [] [] [] [] | 12
grep | [] [] [] [] [] [] [] [] [] [] | 10
hello | [] [] [] [] [] [] [] [] [] [] [] | 11
id-utils | [] [] [] | 3
indent | [] [] [] [] [] | 5
libc | [] [] [] [] [] [] [] | 7
m4 | [] [] [] [] [] [] | 6
make | [] [] [] [] [] [] | 6
music | [] [] | 2
ptx | [] [] [] [] [] [] [] [] | 8
recode | [] [] [] [] [] [] [] [] [] | 9
sh-utils | [] [] [] [] [] [] [] [] | 8
sharutils | [] [] [] [] [] [] | 6
tar | [] [] [] [] [] [] [] [] [] [] [] | 11
texinfo | [] [] [] | 3
textutils | [] [] [] [] [] [] [] [] [] | 9
wdiff | [] [] [] [] [] [] [] [] | 8
`----------------------------------------------------'
17 languages cs da de en es fi fr it ja ko nl no pl pt ru sl sv
27 packages 6 4 25 1 18 1 26 2 1 12 20 9 19 7 4 7 17 179
Some counters in the preceding matrix are higher than the number of
visible blocks let us expect. This is because a few extra PO files are
......@@ -220,6 +221,6 @@ distributed as such by its maintainer. There might be an observable
lag between the mere existence a PO file and its wide availability in a
distribution.
If August 1997 seems to be old, you may fetch a more recent copy of
this `ABOUT-NLS' file on most GNU archive sites.
If December 1997 seems to be old, you may fetch a more recent copy
of this `ABOUT-NLS' file on most GNU archive sites.
......@@ -5,14 +5,22 @@ and longer term bugs.
Release Critical
----------------
- Styles
- get_extent
- uniform
- test persistance
- more tuning
- Merged Cells
- copy/paste (cut works)
- fix undo ins/del row/col to restore lost merged regions
- fill range should not put entries in
- autofill should not fill in the invisible areas.
- the selection cursor is confused by making selection via the item-bars
- Fix Borders
- border style double_line does not handle all of the different
intersection cases.
- We are back to drawing just top and left
- > 1. Rename Sheet1 to Sheet1a.
> 2. Duplicate Sheet1a.
......@@ -93,8 +101,6 @@ STF - pasting a single line should not invoke the importer
- The implication of mixed mode references ($B$2:C3)
is large. All accesses to a RangeRef need to be normalized. (1/2 done)
- border style double_line does not handle all of the different intersection cases.
- Underline should scale with font size. (Say, max (1, font->descent/4?)
gnome-print has a function we could use for printing which returns the
underline thickness.
......
2001-01-11 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.c (mstyle_ref_multiple) : new function.
(mstyle_copy_merge) : new function.
(mstyle_new_default) : Do not cache the result. That is done at the
sheet level.
(mstyle_do_merge) : delete.
(mstyle_get_format) : constness.
* src/format-template.c (cb_format_sheet_border) : delete.
(format_template_apply_to_sheet_regions) : borders are no longer special.
* src/expr.c (expr_tree_array_formula_corner) : do not store the
corner anymore.
(expr_tree_new_array) : ditto.
(do_expr_tree_unref) : ditto.
* src/cell.c (cell_relocate) : Arrays are simplified. No need to keep
a pointer to the corner. It made the system too brittle.
(cell_set_mstyle) : delete.
* src/Makefile.am : remove test.[ch]
* src/gnumeric-sheet.c (gnumeric_sheet_find_{col,row}) : There is no
1 pixel border.
2001-01-09 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.h : Change order of borders to match BorderLocation
2001-01-08 Jody Goldberg <jgoldberg@home.com>
* src/ranges.c (range_has_header) : avoid leaking styles.
* src/cell.c (cell_get_mstyle) : Use sheet_style_get, and do not bump
the ref count.
(cell_render_value) : Adjust.
(cell_get_format : Adjust.
(cell_set_text) : Adjust.
* src/functions/fn-information.c (gnumeric_cell) : sheet_style_get
does not make a reference. Use it.
* src/workbook-format-toolbar.c (modify_cell_format) : Ditto.
(change_selection_font) : Ditto.
* src/sheet-autofill.c (fill_item_new) : ditto.
* src/print-cell.c (print_cell_range) : ditto.
* src/cellspan.c (cell_calc_span) : ditto.
* src/sheet.c (sheet_cell_set_text) : ditto.
* src/rendered-value.c (rendered_value_calc_size) : ditto.
* src/workbook-view.c (wb_view_format_feedback) : ditto.
2001-01-07 Jody Goldberg <jgoldberg@home.com>
* src/dialogs/dialog-cell-format.c (dialog_cell_format) :
init initial style to NULL.
(fmt_dialog_selection_type) : call sheet_style_get_uniform here.
* src/commands.c (cmd_format_redo) : Now that apply_border is not
doing a redraw we need to if there is no style applied.
* src/selection.c (sheet_selection_extend_to) : Add support akin to
gnumeric_sheet_rangesel_cursor_extend to extend to full col/row.
* src/sheet-control-gui.c (scg_colrow_select) : extend to full col/row
if necessary.
* src/item-bar.c (item_bar_event) : Set the selection, not extend it.
2001-01-11 Morten Welinder <terra@diku.dk>
* src/search.h: New file.
......@@ -98,8 +166,8 @@
when building from cvs. Please make sure that the macrofile
installed by xml-i18n-tools is installed so it's in aclocal's
path. or do:
export ACLOCAL_FLAGS='-I /usr/local/share/aclocal'
export ACLOCAL_FLAGS='-I <prefix>/share/aclocal'
2001-01-04 Jon K Hellan <hellan@acm.org>
......
Hacking on Gnumeric
Working in Gnumeric
-------------------
When writing Gnumeric, I have tried to write the code with various
goals in mind:
When writing Gnumeric our priorities are
- Gnumeric code has to be maintainable.
- Gnumeric code needs to be documented.
- Gnumeric code has to be good.
- Gnumeric has to be extensible.
- Gnumeric code has to make sense.
1) Correct.
2) Maintainable & Documented
3) Modular and well designed
and a distant
4) Fast
When you submit code to me for inclusion in Gnumeric, or when you
modify the sources directly on the CVS repository, please keep those
things in mind. Specifically, this means:
modify the sources directly on the CVS repository, please keep those things in
mind. While performance is important please note that we do not want to hand
tune code to shave milliseconds at this point. Well designed algorithms and
data strucutures are fertile areas for development, obfuscated code it make a
loop 3% faster is not. Specifically, this means:
- Clarity of design and function are paramount
- Make sure your code does not generate warnings at all.
- Please follow the coding style used Gnumeric.
......@@ -48,7 +50,7 @@ modular chunks (as detailed by Linus).
- Make sure your code does not have a single warning (with the
default strong warnings that Gnumeric compiles with) before
your code is submited.
your code is submited. (Although we do not advocate -Werror)
- Every entry point to a public routine should use the
g_return_if_fail and g_return_val_if_fail macros to verify
......@@ -67,11 +69,10 @@ modular chunks (as detailed by Linus).
- Do not submit code that is just a temporary workaround for a
full fledged feature. i.e. don't submit a quick hack at
"search text" which is not designed to be expanded upon. I
do not want to maintain limited features.
It is better submit an implementation that has been designed
to be expanded and enhanced, even if it is not completely finished.
"search text" which is not designed to be expanded upon. We
do not want to maintain limited features. It is better submit an
implementation that has been designed to be expanded and enhanced,
even if it is not completely finished.
- It is more important to be correct than to be fast.
......@@ -94,21 +95,6 @@ modular chunks (as detailed by Linus).
* multi-line comments
*/
- Do not overuse const; there is a great danger that const
will be overused and whilst this makes the code more robust
against idiot hackers, idiot hackers should not be committing.
Furthermore const TypeName is strongly preferred to the synonym
TypeName const.
ie. TypeName const * const non_array; should be:
const TypeName *non_array; good.
- Your code should compile without warnings.
- When documenting a function in the comments, please follow
the comment style of the existing code.
- Gnumeric is intended to be run in various countries with
different currency conventions, number formatting
conventions and different languages. Use the locale
......@@ -128,8 +114,8 @@ CORBA service provision).
break existing code. By all means, code clean ups are always
welcome.
Extra functions
---------------
Extra Spreadsheet functions
---------------------------
When you write new functions, keep the following in mind:
......@@ -230,9 +216,3 @@ aren't GnomeDialogs at all, and you have to do more work manually.
set to "No". You should also not call gtk_widget_show / show_all on
the dialog before calling gnumeric_dialog_run / gnome_dialog_run,
because the dialog_run functions reposition the dialog.
Miguel de Icaza.
October, 1998
......@@ -5,6 +5,7 @@ Jody:
* Fix inverted objects
* Fix stupid memory corruption problem in the applix importer.
* Improve range selection for expressions.
* Rework style engine.
Jon Kåre:
* Improve file save dialog.
......
2001-01-11 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.c (mstyle_ref_multiple) : new function.
(mstyle_copy_merge) : new function.
(mstyle_new_default) : Do not cache the result. That is done at the
sheet level.
(mstyle_do_merge) : delete.
(mstyle_get_format) : constness.
* src/format-template.c (cb_format_sheet_border) : delete.
(format_template_apply_to_sheet_regions) : borders are no longer special.
* src/expr.c (expr_tree_array_formula_corner) : do not store the
corner anymore.
(expr_tree_new_array) : ditto.
(do_expr_tree_unref) : ditto.
* src/cell.c (cell_relocate) : Arrays are simplified. No need to keep
a pointer to the corner. It made the system too brittle.
(cell_set_mstyle) : delete.
* src/Makefile.am : remove test.[ch]
* src/gnumeric-sheet.c (gnumeric_sheet_find_{col,row}) : There is no
1 pixel border.
2001-01-09 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.h : Change order of borders to match BorderLocation
2001-01-08 Jody Goldberg <jgoldberg@home.com>
* src/ranges.c (range_has_header) : avoid leaking styles.
* src/cell.c (cell_get_mstyle) : Use sheet_style_get, and do not bump
the ref count.
(cell_render_value) : Adjust.
(cell_get_format : Adjust.
(cell_set_text) : Adjust.
* src/functions/fn-information.c (gnumeric_cell) : sheet_style_get
does not make a reference. Use it.
* src/workbook-format-toolbar.c (modify_cell_format) : Ditto.
(change_selection_font) : Ditto.
* src/sheet-autofill.c (fill_item_new) : ditto.
* src/print-cell.c (print_cell_range) : ditto.
* src/cellspan.c (cell_calc_span) : ditto.
* src/sheet.c (sheet_cell_set_text) : ditto.
* src/rendered-value.c (rendered_value_calc_size) : ditto.
* src/workbook-view.c (wb_view_format_feedback) : ditto.
2001-01-07 Jody Goldberg <jgoldberg@home.com>
* src/dialogs/dialog-cell-format.c (dialog_cell_format) :
init initial style to NULL.
(fmt_dialog_selection_type) : call sheet_style_get_uniform here.
* src/commands.c (cmd_format_redo) : Now that apply_border is not
doing a redraw we need to if there is no style applied.
* src/selection.c (sheet_selection_extend_to) : Add support akin to
gnumeric_sheet_rangesel_cursor_extend to extend to full col/row.
* src/sheet-control-gui.c (scg_colrow_select) : extend to full col/row
if necessary.
* src/item-bar.c (item_bar_event) : Set the selection, not extend it.
2001-01-11 Morten Welinder <terra@diku.dk>
* src/search.h: New file.
......@@ -98,8 +166,8 @@
when building from cvs. Please make sure that the macrofile
installed by xml-i18n-tools is installed so it's in aclocal's
path. or do:
export ACLOCAL_FLAGS='-I /usr/local/share/aclocal'
export ACLOCAL_FLAGS='-I <prefix>/share/aclocal'
2001-01-04 Jon K Hellan <hellan@acm.org>
......
2001-01-11 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.c (mstyle_ref_multiple) : new function.
(mstyle_copy_merge) : new function.
(mstyle_new_default) : Do not cache the result. That is done at the
sheet level.
(mstyle_do_merge) : delete.
(mstyle_get_format) : constness.
* src/format-template.c (cb_format_sheet_border) : delete.
(format_template_apply_to_sheet_regions) : borders are no longer special.
* src/expr.c (expr_tree_array_formula_corner) : do not store the
corner anymore.
(expr_tree_new_array) : ditto.
(do_expr_tree_unref) : ditto.
* src/cell.c (cell_relocate) : Arrays are simplified. No need to keep
a pointer to the corner. It made the system too brittle.
(cell_set_mstyle) : delete.
* src/Makefile.am : remove test.[ch]
* src/gnumeric-sheet.c (gnumeric_sheet_find_{col,row}) : There is no
1 pixel border.
2001-01-09 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.h : Change order of borders to match BorderLocation
2001-01-08 Jody Goldberg <jgoldberg@home.com>
* src/ranges.c (range_has_header) : avoid leaking styles.
* src/cell.c (cell_get_mstyle) : Use sheet_style_get, and do not bump
the ref count.
(cell_render_value) : Adjust.
(cell_get_format : Adjust.
(cell_set_text) : Adjust.
* src/functions/fn-information.c (gnumeric_cell) : sheet_style_get
does not make a reference. Use it.
* src/workbook-format-toolbar.c (modify_cell_format) : Ditto.
(change_selection_font) : Ditto.
* src/sheet-autofill.c (fill_item_new) : ditto.
* src/print-cell.c (print_cell_range) : ditto.
* src/cellspan.c (cell_calc_span) : ditto.
* src/sheet.c (sheet_cell_set_text) : ditto.
* src/rendered-value.c (rendered_value_calc_size) : ditto.
* src/workbook-view.c (wb_view_format_feedback) : ditto.
2001-01-07 Jody Goldberg <jgoldberg@home.com>
* src/dialogs/dialog-cell-format.c (dialog_cell_format) :
init initial style to NULL.
(fmt_dialog_selection_type) : call sheet_style_get_uniform here.
* src/commands.c (cmd_format_redo) : Now that apply_border is not
doing a redraw we need to if there is no style applied.
* src/selection.c (sheet_selection_extend_to) : Add support akin to
gnumeric_sheet_rangesel_cursor_extend to extend to full col/row.
* src/sheet-control-gui.c (scg_colrow_select) : extend to full col/row
if necessary.
* src/item-bar.c (item_bar_event) : Set the selection, not extend it.
2001-01-11 Morten Welinder <terra@diku.dk>
* src/search.h: New file.
......@@ -98,8 +166,8 @@
when building from cvs. Please make sure that the macrofile
installed by xml-i18n-tools is installed so it's in aclocal's
path. or do:
export ACLOCAL_FLAGS='-I /usr/local/share/aclocal'
export ACLOCAL_FLAGS='-I <prefix>/share/aclocal'
2001-01-04 Jon K Hellan <hellan@acm.org>
......
2001-01-11 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.c (mstyle_ref_multiple) : new function.
(mstyle_copy_merge) : new function.
(mstyle_new_default) : Do not cache the result. That is done at the
sheet level.
(mstyle_do_merge) : delete.
(mstyle_get_format) : constness.
* src/format-template.c (cb_format_sheet_border) : delete.
(format_template_apply_to_sheet_regions) : borders are no longer special.
* src/expr.c (expr_tree_array_formula_corner) : do not store the
corner anymore.
(expr_tree_new_array) : ditto.
(do_expr_tree_unref) : ditto.
* src/cell.c (cell_relocate) : Arrays are simplified. No need to keep
a pointer to the corner. It made the system too brittle.
(cell_set_mstyle) : delete.
* src/Makefile.am : remove test.[ch]
* src/gnumeric-sheet.c (gnumeric_sheet_find_{col,row}) : There is no
1 pixel border.
2001-01-09 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.h : Change order of borders to match BorderLocation
2001-01-08 Jody Goldberg <jgoldberg@home.com>
* src/ranges.c (range_has_header) : avoid leaking styles.
* src/cell.c (cell_get_mstyle) : Use sheet_style_get, and do not bump
the ref count.
(cell_render_value) : Adjust.
(cell_get_format : Adjust.
(cell_set_text) : Adjust.
* src/functions/fn-information.c (gnumeric_cell) : sheet_style_get
does not make a reference. Use it.
* src/workbook-format-toolbar.c (modify_cell_format) : Ditto.
(change_selection_font) : Ditto.
* src/sheet-autofill.c (fill_item_new) : ditto.
* src/print-cell.c (print_cell_range) : ditto.
* src/cellspan.c (cell_calc_span) : ditto.
* src/sheet.c (sheet_cell_set_text) : ditto.
* src/rendered-value.c (rendered_value_calc_size) : ditto.
* src/workbook-view.c (wb_view_format_feedback) : ditto.
2001-01-07 Jody Goldberg <jgoldberg@home.com>
* src/dialogs/dialog-cell-format.c (dialog_cell_format) :
init initial style to NULL.
(fmt_dialog_selection_type) : call sheet_style_get_uniform here.
* src/commands.c (cmd_format_redo) : Now that apply_border is not
doing a redraw we need to if there is no style applied.
* src/selection.c (sheet_selection_extend_to) : Add support akin to
gnumeric_sheet_rangesel_cursor_extend to extend to full col/row.
* src/sheet-control-gui.c (scg_colrow_select) : extend to full col/row
if necessary.
* src/item-bar.c (item_bar_event) : Set the selection, not extend it.
2001-01-11 Morten Welinder <terra@diku.dk>
* src/search.h: New file.
......@@ -98,8 +166,8 @@
when building from cvs. Please make sure that the macrofile
installed by xml-i18n-tools is installed so it's in aclocal's
path. or do:
export ACLOCAL_FLAGS='-I /usr/local/share/aclocal'
export ACLOCAL_FLAGS='-I <prefix>/share/aclocal'
2001-01-04 Jon K Hellan <hellan@acm.org>
......
2001-01-11 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.c (mstyle_ref_multiple) : new function.
(mstyle_copy_merge) : new function.
(mstyle_new_default) : Do not cache the result. That is done at the
sheet level.
(mstyle_do_merge) : delete.
(mstyle_get_format) : constness.
* src/format-template.c (cb_format_sheet_border) : delete.
(format_template_apply_to_sheet_regions) : borders are no longer special.
* src/expr.c (expr_tree_array_formula_corner) : do not store the
corner anymore.
(expr_tree_new_array) : ditto.
(do_expr_tree_unref) : ditto.
* src/cell.c (cell_relocate) : Arrays are simplified. No need to keep
a pointer to the corner. It made the system too brittle.
(cell_set_mstyle) : delete.
* src/Makefile.am : remove test.[ch]
* src/gnumeric-sheet.c (gnumeric_sheet_find_{col,row}) : There is no
1 pixel border.
2001-01-09 Jody Goldberg <jgoldberg@home.com>
* src/mstyle.h : Change order of borders to match BorderLocation
2001-01-08 Jody Goldberg <jgoldberg@home.com>
* src/ranges.c (range_has_header) : avoid leaking styles.
* src/cell.c (cell_get_mstyle) : Use sheet_style_get, and do not bump
the ref count.
(cell_render_value) : Adjust.
(cell_get_format : Adjust.
(cell_set_text) : Adjust.
* src/functions/fn-information.c (gnumeric_cell) : sheet_style_get
does not make a reference. Use it.
* src/workbook-format-toolbar.c (modify_cell_format) : Ditto.
(change_selection_font) : Ditto.
* src/sheet-autofill.c (fill_item_new) : ditto.
* src/print-cell.c (print_cell_range) : ditto.
* src/cellspan.c (cell_calc_span) : ditto.
* src/sheet.c (sheet_cell_set_text) : ditto.
* src/rendered-value.c (rendered_value_calc_size) : ditto.
* src/workbook-view.c (wb_view_format_feedback) : ditto.
2001-01-07 Jody Goldberg <jgoldberg@home.com>
* src/dialogs/dialog-cell-format.c (dialog_cell_format) :
init initial style to NULL.
(fmt_dialog_selection_type) : call sheet_style_get_uniform here.
* src/commands.c (cmd_format_redo) : Now that apply_border is not
doing a redraw we need to if there is no style applied.
* src/selection.c (sheet_selection_extend_to) : Add support akin to
gnumeric_sheet_rangesel_cursor_extend to extend to full col/row.
* src/sheet-control-gui.c (scg_colrow_select) : extend to full col/row
if necessary.
* src/item-bar.c (item_bar_event) : Set the selection, not extend it.
2001-01-11 Morten Welinder <terra@diku.dk>
* src/search.h: New file.
......@@ -98,8 +166,8 @@
when building from cvs. Please make sure that the macrofile
installed by xml-i18n-tools is installed so it's in aclocal's
path. or do:
export ACLOCAL_FLAGS='-I /usr/local/share/aclocal'
export ACLOCAL_FLAGS='-I <prefix>/share/aclocal'
2001-01-04 Jon K Hellan <hellan@acm.org>
......
2001-01-11 Jody Goldberg <jgoldberg@home.com>
* applix-read.c (applix_parse_style) : remove the border shifting
cruft. This will be taken care of in the primary system.
2000-12-29 Jody Goldberg <jgoldberg@home.com>
* applix-read.c (applix_read) : fix cut-n-pate-o
......
......@@ -306,7 +306,7 @@ applix_parse_style (ApplixReadState *state, char **buffer)
char *sep = start;
/* Allocate the new style */
style = mstyle_new ();
style = mstyle_new_default ();
if (sep[1] == '\'')
sep += 2;
......@@ -935,32 +935,7 @@ applix_read_cells (ApplixReadState *state)
cell = sheet_cell_fetch (sheet, col, row);
/* Apply the formating */
#if 0
sheet_style_attach_single (sheet, col, row, style);
#else
cell_set_mstyle (cell, style);
#endif
if (mstyle_is_element_set (style, MSTYLE_BORDER_BOTTOM)) {
Range r;
MStyle *tmp = mstyle_new ();
StyleBorder *border =
mstyle_get_border (style, MSTYLE_BORDER_BOTTOM);
mstyle_set_border (tmp, MSTYLE_BORDER_TOP,
style_border_ref (border));
range_init (&r, col, row+1, col, row+1);