Commit 99ec14fe authored by Jody Goldberg's avatar Jody Goldberg Committed by Jody Goldberg

Fix span bugs.

2000-03-22  Jody Goldberg <jgoldberg@home.com>

	* src/sheet.c (sheet_reposition_comments) : Merged from
	  sheet_reposition_comments_from_row and
	  sheet_reposition_comments_from_col.

	(sheet_update) : New function.  Use the new update flags from
	  SheetPrivate that are set in the col/row resize functions
	  to do delayed resizing and updates.  This allows the resizing to be
	  batched for an entire logical operation.
	(sheet_{col,row}_set_size_pixels) : Set the update flags.

	* src/workbook-cmd-format.c (workbook_cmd_format_{row,column}_auto_fit) : No need to
	  worry about redraws.  Use sheet_update.
	(workbook_cmd_format_{row_height,column_width}) : Ditto.

	* src/sheet-view.c (sheet_view_redraw_cell_region) : No need to
	  recalculate the spans,  Use the pre-calculated versions.
	(sheet_view_col_size_changed) : Use sheet_update.
	(sheet_view_row_size_changed) : Ditto.

	* src/sheet-style.c (re_dimension_cells_cb) : Use cell_calc_dimensions.
	(sheet_cells_update) : No need to redraw per cell and guess the bound.
	  It is simpler and more correct to calc dimension per cell, and
	  redraw the region BEFORE and AFTER to handle spans.

	* src/cell.[ch] (cell_style_changed) : Delete.

	* src/cell-draw.c (cell_draw) : continue syncing with print code.
	  Be even more careful in the possible presence of style bugs.
	* src/item-grid.c (item_grid_draw) : Ditto.
	* src/print-cell.c (print_cell) : Ditto.

	* src/analysis-tools.c (correlation_tool) : Use sheet_update.
	(covariance_tool) : Ditto.
	(ttest_paired_tool) : Ditto.
	(ttest_eq_var_tool) : Ditto.
	(ttest_neq_var_tool) : Ditto.
	(ftest_tool) : Ditto.

2000-03-21  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-private.h : Add status flags to accumulate state changes
	  for later redraw.

	* src/commands.c (cmd_format_redo) : Use sheet_update
	  in case the row/col sizes changed due to font size changes.
	(cmd_format_undo) : Ditto.

	* src/widgets/gtk-combo-box.c (cb_state_change) : Only pseudo-prelight
	  the display when over the arrow, not vice versa.
	(gtk_combo_box_init) : Ditto.
	(gtk_combo_box_set_display) : Ditto.

	* src/sheet.c (sheet_row_get_distance_pts) : Enable reversed indicies.
	(sheet_col_get_distance_pts) : Ditto.

	* src/plugin.c (plugin_load) : Add more version checking to ensure
	  that very old plugins that do not check their versions can not be
	  loaded.

2000-03-20  Jody Goldberg <jgoldberg@home.com>

	* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : When
	  forcing a scroll do a hard reset of the visible ranges.
	(gnumeric_sheet_compute_visible_ranges) : Ditto.
	(gnumeric_sheet_set_top_row) : Remove extraneous scroll.
	(gnumeric_sheet_set_left_col) : Remove extraneous scroll.
parent 7bb1eb3f
......@@ -8,9 +8,6 @@ Release Critical
- gnumeric depends on unreleased gnome-print
- text in print-preview is vertically offset (lewing has a patch for gnome-print)
- print-preview is not cleared between pages.
- Changing the size of rows/cols that are not visible messes up the alignment
of first visible row/col.
- Changing the size of rows/cols does not reset the item cursor
Long term breakage
------------------
......@@ -20,3 +17,5 @@ Long term breakage
with the cell FIRST rather than later. eg enter '10-1' (without quotes) in a
cell with an assigned format of Text. This should be treated as text. Instead
It parses as a Date (Oct 1) and gets converted.
- File->Print Preview does not have an icon.
2000-03-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_reposition_comments) : Merged from
sheet_reposition_comments_from_row and
sheet_reposition_comments_from_col.
(sheet_update) : New function. Use the new update flags from
SheetPrivate that are set in the col/row resize functions
to do delayed resizing and updates. This allows the resizing to be
batched for an entire logical operation.
(sheet_{col,row}_set_size_pixels) : Set the update flags.
* src/workbook-cmd-format.c (workbook_cmd_format_{row,column}_auto_fit) : No need to
worry about redraws. Use sheet_update.
(workbook_cmd_format_{row_height,column_width}) : Ditto.
* src/sheet-view.c (sheet_view_redraw_cell_region) : No need to
recalculate the spans, Use the pre-calculated versions.
(sheet_view_col_size_changed) : Use sheet_update.
(sheet_view_row_size_changed) : Ditto.
* src/sheet-style.c (re_dimension_cells_cb) : Use cell_calc_dimensions.
(sheet_cells_update) : No need to redraw per cell and guess the bound.
It is simpler and more correct to calc dimension per cell, and
redraw the region BEFORE and AFTER to handle spans.
* src/cell.[ch] (cell_style_changed) : Delete.
* src/cell-draw.c (cell_draw) : continue syncing with print code.
Be even more careful in the possible presence of style bugs.
* src/item-grid.c (item_grid_draw) : Ditto.
* src/print-cell.c (print_cell) : Ditto.
* src/analysis-tools.c (correlation_tool) : Use sheet_update.
(covariance_tool) : Ditto.
(ttest_paired_tool) : Ditto.
(ttest_eq_var_tool) : Ditto.
(ttest_neq_var_tool) : Ditto.
(ftest_tool) : Ditto.
2000-03-21 Jody Goldberg <jgoldberg@home.com>
* src/sheet-private.h : Add status flags to accumulate state changes
for later redraw.
* src/commands.c (cmd_format_redo) : Use sheet_update
in case the row/col sizes changed due to font size changes.
(cmd_format_undo) : Ditto.
* src/widgets/gtk-combo-box.c (cb_state_change) : Only pseudo-prelight
the display when over the arrow, not vice versa.
(gtk_combo_box_init) : Ditto.
(gtk_combo_box_set_display) : Ditto.
* src/sheet.c (sheet_row_get_distance_pts) : Enable reversed indicies.
(sheet_col_get_distance_pts) : Ditto.
* src/plugin.c (plugin_load) : Add more version checking to ensure
that very old plugins that do not check their versions can not be
loaded.
2000-03-20 Jody Goldberg <jgoldberg@home.com>
* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : When
forcing a scroll do a hard reset of the visible ranges.
(gnumeric_sheet_compute_visible_ranges) : Ditto.
(gnumeric_sheet_set_top_row) : Remove extraneous scroll.
(gnumeric_sheet_set_left_col) : Remove extraneous scroll.
2000-03-21 Miguel de Icaza <miguel@helixcode.com>
* src/utils.c (parse_cell_name_or_range): Allow for parsing to be
......
2000-03-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_reposition_comments) : Merged from
sheet_reposition_comments_from_row and
sheet_reposition_comments_from_col.
(sheet_update) : New function. Use the new update flags from
SheetPrivate that are set in the col/row resize functions
to do delayed resizing and updates. This allows the resizing to be
batched for an entire logical operation.
(sheet_{col,row}_set_size_pixels) : Set the update flags.
* src/workbook-cmd-format.c (workbook_cmd_format_{row,column}_auto_fit) : No need to
worry about redraws. Use sheet_update.
(workbook_cmd_format_{row_height,column_width}) : Ditto.
* src/sheet-view.c (sheet_view_redraw_cell_region) : No need to
recalculate the spans, Use the pre-calculated versions.
(sheet_view_col_size_changed) : Use sheet_update.
(sheet_view_row_size_changed) : Ditto.
* src/sheet-style.c (re_dimension_cells_cb) : Use cell_calc_dimensions.
(sheet_cells_update) : No need to redraw per cell and guess the bound.
It is simpler and more correct to calc dimension per cell, and
redraw the region BEFORE and AFTER to handle spans.
* src/cell.[ch] (cell_style_changed) : Delete.
* src/cell-draw.c (cell_draw) : continue syncing with print code.
Be even more careful in the possible presence of style bugs.
* src/item-grid.c (item_grid_draw) : Ditto.
* src/print-cell.c (print_cell) : Ditto.
* src/analysis-tools.c (correlation_tool) : Use sheet_update.
(covariance_tool) : Ditto.
(ttest_paired_tool) : Ditto.
(ttest_eq_var_tool) : Ditto.
(ttest_neq_var_tool) : Ditto.
(ftest_tool) : Ditto.
2000-03-21 Jody Goldberg <jgoldberg@home.com>
* src/sheet-private.h : Add status flags to accumulate state changes
for later redraw.
* src/commands.c (cmd_format_redo) : Use sheet_update
in case the row/col sizes changed due to font size changes.
(cmd_format_undo) : Ditto.
* src/widgets/gtk-combo-box.c (cb_state_change) : Only pseudo-prelight
the display when over the arrow, not vice versa.
(gtk_combo_box_init) : Ditto.
(gtk_combo_box_set_display) : Ditto.
* src/sheet.c (sheet_row_get_distance_pts) : Enable reversed indicies.
(sheet_col_get_distance_pts) : Ditto.
* src/plugin.c (plugin_load) : Add more version checking to ensure
that very old plugins that do not check their versions can not be
loaded.
2000-03-20 Jody Goldberg <jgoldberg@home.com>
* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : When
forcing a scroll do a hard reset of the visible ranges.
(gnumeric_sheet_compute_visible_ranges) : Ditto.
(gnumeric_sheet_set_top_row) : Remove extraneous scroll.
(gnumeric_sheet_set_left_col) : Remove extraneous scroll.
2000-03-21 Miguel de Icaza <miguel@helixcode.com>
* src/utils.c (parse_cell_name_or_range): Allow for parsing to be
......
2000-03-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_reposition_comments) : Merged from
sheet_reposition_comments_from_row and
sheet_reposition_comments_from_col.
(sheet_update) : New function. Use the new update flags from
SheetPrivate that are set in the col/row resize functions
to do delayed resizing and updates. This allows the resizing to be
batched for an entire logical operation.
(sheet_{col,row}_set_size_pixels) : Set the update flags.
* src/workbook-cmd-format.c (workbook_cmd_format_{row,column}_auto_fit) : No need to
worry about redraws. Use sheet_update.
(workbook_cmd_format_{row_height,column_width}) : Ditto.
* src/sheet-view.c (sheet_view_redraw_cell_region) : No need to
recalculate the spans, Use the pre-calculated versions.
(sheet_view_col_size_changed) : Use sheet_update.
(sheet_view_row_size_changed) : Ditto.
* src/sheet-style.c (re_dimension_cells_cb) : Use cell_calc_dimensions.
(sheet_cells_update) : No need to redraw per cell and guess the bound.
It is simpler and more correct to calc dimension per cell, and
redraw the region BEFORE and AFTER to handle spans.
* src/cell.[ch] (cell_style_changed) : Delete.
* src/cell-draw.c (cell_draw) : continue syncing with print code.
Be even more careful in the possible presence of style bugs.
* src/item-grid.c (item_grid_draw) : Ditto.
* src/print-cell.c (print_cell) : Ditto.
* src/analysis-tools.c (correlation_tool) : Use sheet_update.
(covariance_tool) : Ditto.
(ttest_paired_tool) : Ditto.
(ttest_eq_var_tool) : Ditto.
(ttest_neq_var_tool) : Ditto.
(ftest_tool) : Ditto.
2000-03-21 Jody Goldberg <jgoldberg@home.com>
* src/sheet-private.h : Add status flags to accumulate state changes
for later redraw.
* src/commands.c (cmd_format_redo) : Use sheet_update
in case the row/col sizes changed due to font size changes.
(cmd_format_undo) : Ditto.
* src/widgets/gtk-combo-box.c (cb_state_change) : Only pseudo-prelight
the display when over the arrow, not vice versa.
(gtk_combo_box_init) : Ditto.
(gtk_combo_box_set_display) : Ditto.
* src/sheet.c (sheet_row_get_distance_pts) : Enable reversed indicies.
(sheet_col_get_distance_pts) : Ditto.
* src/plugin.c (plugin_load) : Add more version checking to ensure
that very old plugins that do not check their versions can not be
loaded.
2000-03-20 Jody Goldberg <jgoldberg@home.com>
* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : When
forcing a scroll do a hard reset of the visible ranges.
(gnumeric_sheet_compute_visible_ranges) : Ditto.
(gnumeric_sheet_set_top_row) : Remove extraneous scroll.
(gnumeric_sheet_set_left_col) : Remove extraneous scroll.
2000-03-21 Miguel de Icaza <miguel@helixcode.com>
* src/utils.c (parse_cell_name_or_range): Allow for parsing to be
......
2000-03-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_reposition_comments) : Merged from
sheet_reposition_comments_from_row and
sheet_reposition_comments_from_col.
(sheet_update) : New function. Use the new update flags from
SheetPrivate that are set in the col/row resize functions
to do delayed resizing and updates. This allows the resizing to be
batched for an entire logical operation.
(sheet_{col,row}_set_size_pixels) : Set the update flags.
* src/workbook-cmd-format.c (workbook_cmd_format_{row,column}_auto_fit) : No need to
worry about redraws. Use sheet_update.
(workbook_cmd_format_{row_height,column_width}) : Ditto.
* src/sheet-view.c (sheet_view_redraw_cell_region) : No need to
recalculate the spans, Use the pre-calculated versions.
(sheet_view_col_size_changed) : Use sheet_update.
(sheet_view_row_size_changed) : Ditto.
* src/sheet-style.c (re_dimension_cells_cb) : Use cell_calc_dimensions.
(sheet_cells_update) : No need to redraw per cell and guess the bound.
It is simpler and more correct to calc dimension per cell, and
redraw the region BEFORE and AFTER to handle spans.
* src/cell.[ch] (cell_style_changed) : Delete.
* src/cell-draw.c (cell_draw) : continue syncing with print code.
Be even more careful in the possible presence of style bugs.
* src/item-grid.c (item_grid_draw) : Ditto.
* src/print-cell.c (print_cell) : Ditto.
* src/analysis-tools.c (correlation_tool) : Use sheet_update.
(covariance_tool) : Ditto.
(ttest_paired_tool) : Ditto.
(ttest_eq_var_tool) : Ditto.
(ttest_neq_var_tool) : Ditto.
(ftest_tool) : Ditto.
2000-03-21 Jody Goldberg <jgoldberg@home.com>
* src/sheet-private.h : Add status flags to accumulate state changes
for later redraw.
* src/commands.c (cmd_format_redo) : Use sheet_update
in case the row/col sizes changed due to font size changes.
(cmd_format_undo) : Ditto.
* src/widgets/gtk-combo-box.c (cb_state_change) : Only pseudo-prelight
the display when over the arrow, not vice versa.
(gtk_combo_box_init) : Ditto.
(gtk_combo_box_set_display) : Ditto.
* src/sheet.c (sheet_row_get_distance_pts) : Enable reversed indicies.
(sheet_col_get_distance_pts) : Ditto.
* src/plugin.c (plugin_load) : Add more version checking to ensure
that very old plugins that do not check their versions can not be
loaded.
2000-03-20 Jody Goldberg <jgoldberg@home.com>
* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : When
forcing a scroll do a hard reset of the visible ranges.
(gnumeric_sheet_compute_visible_ranges) : Ditto.
(gnumeric_sheet_set_top_row) : Remove extraneous scroll.
(gnumeric_sheet_set_left_col) : Remove extraneous scroll.
2000-03-21 Miguel de Icaza <miguel@helixcode.com>
* src/utils.c (parse_cell_name_or_range): Allow for parsing to be
......
2000-03-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_reposition_comments) : Merged from
sheet_reposition_comments_from_row and
sheet_reposition_comments_from_col.
(sheet_update) : New function. Use the new update flags from
SheetPrivate that are set in the col/row resize functions
to do delayed resizing and updates. This allows the resizing to be
batched for an entire logical operation.
(sheet_{col,row}_set_size_pixels) : Set the update flags.
* src/workbook-cmd-format.c (workbook_cmd_format_{row,column}_auto_fit) : No need to
worry about redraws. Use sheet_update.
(workbook_cmd_format_{row_height,column_width}) : Ditto.
* src/sheet-view.c (sheet_view_redraw_cell_region) : No need to
recalculate the spans, Use the pre-calculated versions.
(sheet_view_col_size_changed) : Use sheet_update.
(sheet_view_row_size_changed) : Ditto.
* src/sheet-style.c (re_dimension_cells_cb) : Use cell_calc_dimensions.
(sheet_cells_update) : No need to redraw per cell and guess the bound.
It is simpler and more correct to calc dimension per cell, and
redraw the region BEFORE and AFTER to handle spans.
* src/cell.[ch] (cell_style_changed) : Delete.
* src/cell-draw.c (cell_draw) : continue syncing with print code.
Be even more careful in the possible presence of style bugs.
* src/item-grid.c (item_grid_draw) : Ditto.
* src/print-cell.c (print_cell) : Ditto.
* src/analysis-tools.c (correlation_tool) : Use sheet_update.
(covariance_tool) : Ditto.
(ttest_paired_tool) : Ditto.
(ttest_eq_var_tool) : Ditto.
(ttest_neq_var_tool) : Ditto.
(ftest_tool) : Ditto.
2000-03-21 Jody Goldberg <jgoldberg@home.com>
* src/sheet-private.h : Add status flags to accumulate state changes
for later redraw.
* src/commands.c (cmd_format_redo) : Use sheet_update
in case the row/col sizes changed due to font size changes.
(cmd_format_undo) : Ditto.
* src/widgets/gtk-combo-box.c (cb_state_change) : Only pseudo-prelight
the display when over the arrow, not vice versa.
(gtk_combo_box_init) : Ditto.
(gtk_combo_box_set_display) : Ditto.
* src/sheet.c (sheet_row_get_distance_pts) : Enable reversed indicies.
(sheet_col_get_distance_pts) : Ditto.
* src/plugin.c (plugin_load) : Add more version checking to ensure
that very old plugins that do not check their versions can not be
loaded.
2000-03-20 Jody Goldberg <jgoldberg@home.com>
* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : When
forcing a scroll do a hard reset of the visible ranges.
(gnumeric_sheet_compute_visible_ranges) : Ditto.
(gnumeric_sheet_set_top_row) : Remove extraneous scroll.
(gnumeric_sheet_set_left_col) : Remove extraneous scroll.
2000-03-21 Miguel de Icaza <miguel@helixcode.com>
* src/utils.c (parse_cell_name_or_range): Allow for parsing to be
......
2000-03-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_reposition_comments) : Merged from
sheet_reposition_comments_from_row and
sheet_reposition_comments_from_col.
(sheet_update) : New function. Use the new update flags from
SheetPrivate that are set in the col/row resize functions
to do delayed resizing and updates. This allows the resizing to be
batched for an entire logical operation.
(sheet_{col,row}_set_size_pixels) : Set the update flags.
* src/workbook-cmd-format.c (workbook_cmd_format_{row,column}_auto_fit) : No need to
worry about redraws. Use sheet_update.
(workbook_cmd_format_{row_height,column_width}) : Ditto.
* src/sheet-view.c (sheet_view_redraw_cell_region) : No need to
recalculate the spans, Use the pre-calculated versions.
(sheet_view_col_size_changed) : Use sheet_update.
(sheet_view_row_size_changed) : Ditto.
* src/sheet-style.c (re_dimension_cells_cb) : Use cell_calc_dimensions.
(sheet_cells_update) : No need to redraw per cell and guess the bound.
It is simpler and more correct to calc dimension per cell, and
redraw the region BEFORE and AFTER to handle spans.
* src/cell.[ch] (cell_style_changed) : Delete.
* src/cell-draw.c (cell_draw) : continue syncing with print code.
Be even more careful in the possible presence of style bugs.
* src/item-grid.c (item_grid_draw) : Ditto.
* src/print-cell.c (print_cell) : Ditto.
* src/analysis-tools.c (correlation_tool) : Use sheet_update.
(covariance_tool) : Ditto.
(ttest_paired_tool) : Ditto.
(ttest_eq_var_tool) : Ditto.
(ttest_neq_var_tool) : Ditto.
(ftest_tool) : Ditto.
2000-03-21 Jody Goldberg <jgoldberg@home.com>
* src/sheet-private.h : Add status flags to accumulate state changes
for later redraw.
* src/commands.c (cmd_format_redo) : Use sheet_update
in case the row/col sizes changed due to font size changes.
(cmd_format_undo) : Ditto.
* src/widgets/gtk-combo-box.c (cb_state_change) : Only pseudo-prelight
the display when over the arrow, not vice versa.
(gtk_combo_box_init) : Ditto.
(gtk_combo_box_set_display) : Ditto.
* src/sheet.c (sheet_row_get_distance_pts) : Enable reversed indicies.
(sheet_col_get_distance_pts) : Ditto.
* src/plugin.c (plugin_load) : Add more version checking to ensure
that very old plugins that do not check their versions can not be
loaded.
2000-03-20 Jody Goldberg <jgoldberg@home.com>
* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : When
forcing a scroll do a hard reset of the visible ranges.
(gnumeric_sheet_compute_visible_ranges) : Ditto.
(gnumeric_sheet_set_top_row) : Remove extraneous scroll.
(gnumeric_sheet_set_left_col) : Remove extraneous scroll.
2000-03-21 Miguel de Icaza <miguel@helixcode.com>
* src/utils.c (parse_cell_name_or_range): Allow for parsing to be
......
2000-03-22 Jody Goldberg <jgoldberg@home.com>
* src/sheet.c (sheet_reposition_comments) : Merged from
sheet_reposition_comments_from_row and
sheet_reposition_comments_from_col.
(sheet_update) : New function. Use the new update flags from
SheetPrivate that are set in the col/row resize functions
to do delayed resizing and updates. This allows the resizing to be
batched for an entire logical operation.
(sheet_{col,row}_set_size_pixels) : Set the update flags.
* src/workbook-cmd-format.c (workbook_cmd_format_{row,column}_auto_fit) : No need to
worry about redraws. Use sheet_update.
(workbook_cmd_format_{row_height,column_width}) : Ditto.
* src/sheet-view.c (sheet_view_redraw_cell_region) : No need to
recalculate the spans, Use the pre-calculated versions.
(sheet_view_col_size_changed) : Use sheet_update.
(sheet_view_row_size_changed) : Ditto.
* src/sheet-style.c (re_dimension_cells_cb) : Use cell_calc_dimensions.
(sheet_cells_update) : No need to redraw per cell and guess the bound.
It is simpler and more correct to calc dimension per cell, and
redraw the region BEFORE and AFTER to handle spans.
* src/cell.[ch] (cell_style_changed) : Delete.
* src/cell-draw.c (cell_draw) : continue syncing with print code.
Be even more careful in the possible presence of style bugs.
* src/item-grid.c (item_grid_draw) : Ditto.
* src/print-cell.c (print_cell) : Ditto.
* src/analysis-tools.c (correlation_tool) : Use sheet_update.
(covariance_tool) : Ditto.
(ttest_paired_tool) : Ditto.
(ttest_eq_var_tool) : Ditto.
(ttest_neq_var_tool) : Ditto.
(ftest_tool) : Ditto.
2000-03-21 Jody Goldberg <jgoldberg@home.com>
* src/sheet-private.h : Add status flags to accumulate state changes
for later redraw.
* src/commands.c (cmd_format_redo) : Use sheet_update
in case the row/col sizes changed due to font size changes.
(cmd_format_undo) : Ditto.
* src/widgets/gtk-combo-box.c (cb_state_change) : Only pseudo-prelight
the display when over the arrow, not vice versa.
(gtk_combo_box_init) : Ditto.
(gtk_combo_box_set_display) : Ditto.
* src/sheet.c (sheet_row_get_distance_pts) : Enable reversed indicies.
(sheet_col_get_distance_pts) : Ditto.
* src/plugin.c (plugin_load) : Add more version checking to ensure
that very old plugins that do not check their versions can not be
loaded.
2000-03-20 Jody Goldberg <jgoldberg@home.com>
* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : When
forcing a scroll do a hard reset of the visible ranges.
(gnumeric_sheet_compute_visible_ranges) : Ditto.
(gnumeric_sheet_set_top_row) : Remove extraneous scroll.
(gnumeric_sheet_set_left_col) : Remove extraneous scroll.
2000-03-21 Miguel de Icaza <miguel@helixcode.com>
* src/utils.c (parse_cell_name_or_range): Allow for parsing to be
......
2000-03-21 Jody Goldberg <jgoldberg@home.com>
* ms-excel-util.c (init_xl_font_widths) : Add Geneva.
* ms-excel-read.c (biff_xf_data_new) : Have the horizontal alignment
type center_across_selection default to 'center' instead.
(ms_excel_read_workbook) : Be more explicit about NOT supporting 1904
dates as yet.
2000-03-14 Jody Goldberg <jgoldberg@home.com>
* ms-excel-read.c (biff_xf_data_new) : Remove warning about parent
......
......@@ -1459,11 +1459,24 @@ biff_xf_data_new (ExcelWorkbook *wb, BiffQuery *q, eBiff_version ver)
xf->halign = HALIGN_JUSTIFY;
break;
case 6:
xf->halign = HALIGN_JUSTIFY;
/*
/* FIXME :
* ACK! this seems to create a somewhat dynamic span.
* All adjacent blank cells with this type of alignment
* are merged into a single span. cursor still behaves
* normally and the span is adjusted if contents are changed.
* Use center for now.
* xf->halign = HALIGN_CENTRE_ACROSS_SELECTION;
*/
xf->halign = HALIGN_CENTER;
{
static gboolean need_warning = TRUE;
if (need_warning) {
g_warning ("EXCEL : 'Center across selection' is unsupported. Using Center");
need_warning = FALSE;
}
}
break;
default:
xf->halign = HALIGN_JUSTIFY;
printf ("Unknown halign %d\n", subdata);
......@@ -3894,7 +3907,8 @@ ms_excel_read_workbook (CommandContext *context, Workbook *workbook,
case BIFF_1904 : /* 0, NOT 1 */
if (MS_OLE_GET_GUINT16(q->data) == 1)
printf ("Uses 1904 Date System\n");
printf ("EXCEL : Warning workbook uses unsupported 1904 Date System\n"
"dates will be incorrect\n");
break;
case BIFF_WINDOW1 : /* 0 NOT 1 */
......
......@@ -207,6 +207,7 @@ init_xl_font_widths ()
{ 103, 110, "Courier New" },
{ 103, 110, "Fixedsys" },
{ 80, 86, "Garamond" },
{ 115, 122, "Geneva" },
{ 95, 102, "Haettenscheiler" },
{ 103, 110, "HE_TERMINAL" },
{ 95, 102, "Helvetica" },
......
......@@ -413,6 +413,7 @@ ms_obj_read_biff8_obj (BiffQuery *q, ExcelWorkbook * wb, Sheet * sheet, MSObj *
switch (record_type) {
case GR_END:
g_return_val_if_fail (len == 0, TRUE);
ms_obj_dump (data, len, "ObjEnd");
hit_end = TRUE;
break;
......@@ -548,6 +549,10 @@ ms_obj_read_biff8_obj (BiffQuery *q, ExcelWorkbook * wb, Sheet * sheet, MSObj *
}
/* The ftEnd record should have been the last */
if (data_len_left != 0) {
printf("OBJ : unexpected extra data (%d) at the end of the object;\n", data_len_left);
return TRUE;
}
g_return_val_if_fail (data_len_left == 0, TRUE);
if (next_biff_record_is_imdata) {
......
......@@ -771,7 +771,7 @@ pln_parse_sheet (CommandContext *context, FileSource_t *src)
cwidth = PLN_WORD(src->cur + ccol * 6 + 8);
if ((cwidth != 0) && (ccol <= lastcol))
{
sheet_col_set_size_pixels
sheet_col_set_size_pts
(src->sheet, ccol,
(cwidth & 255) * FONT_WIDTH,
FALSE);
......
......@@ -265,8 +265,8 @@ autofit_column (data_analysis_output_t *dao, int col)
if (ideal_size == 0)
return;
sheet_col_set_size_pixels (dao->sheet, actual_col, ideal_size+5,
TRUE);
sheet_col_set_size_pixels (dao->sheet, actual_col, ideal_size, TRUE);
sheet_recompute_spans_for_col (dao->sheet, col);
}
static void
......@@ -446,8 +446,7 @@ correlation_tool (Workbook *wb, Sheet *sheet,
autofit_column (dao, col);
sheet_set_dirty (dao->sheet, TRUE);
sheet_compute_visible_ranges (dao->sheet);
sheet_redraw_all (dao->sheet);
sheet_update (sheet);
return 0;
}
......@@ -603,8 +602,7 @@ covariance_tool (Workbook *wb, Sheet *sheet,
autofit_column (dao, col);
sheet_set_dirty (dao->sheet, TRUE);
sheet_compute_visible_ranges (dao->sheet);
sheet_redraw_all (dao->sheet);
sheet_update (sheet);
return 0;
}
......@@ -1335,8 +1333,7 @@ ttest_paired_tool (Workbook *wb, Sheet *sheet, Range *input_range1,
autofit_column (dao, 2);
sheet_set_dirty (dao->sheet, TRUE);
sheet_compute_visible_ranges (dao->sheet);
sheet_redraw_all (dao->sheet);
sheet_update (sheet);
return 0;
}
......@@ -1472,8 +1469,7 @@ ttest_eq_var_tool (Workbook *wb, Sheet *sheet, Range *input_range1,
autofit_column (dao, 2);
sheet_set_dirty (dao->sheet, TRUE);
sheet_compute_visible_ranges (dao->sheet);
sheet_redraw_all (dao->sheet);
sheet_update (sheet);
return 0;