Commit 7f35fd7d authored by Miguel de Icaza's avatar Miguel de Icaza Committed by Arturo Espinosa

Fixed the annoying flashing of the cursor/selection problem by reverting

2000-01-03  Miguel de Icaza  <miguel@gnu.org>

	* src/gnumeric-sheet.c (move_cursor): Fixed the annoying flashing
	of the cursor/selection problem by reverting to the old code setup.

	I also eliminated some animation of the cursor while doing this.
parent ceb01e23
......@@ -154,13 +154,27 @@ static void
move_cursor (GnumericSheet *gsheet, int col, int row, gboolean clear_selection)
{
Sheet *sheet = gsheet->sheet_view->sheet;
/*
* Please note that the order here is important, as
* the sheet_make_cell_visible call might scroll the
* canvas, you should do all of your screen changes
* in an atomic fashion.
*
* The code at some point did do the selection change
* after the sheet moved, causing flicker -mig
*
* If you dont know what this means, just mail me.
*/
if (clear_selection)
sheet_selection_reset_only (sheet);
sheet_cursor_set (sheet, col, row, col, row, col, row);
sheet_make_cell_visible (sheet, col, row);
if (clear_selection) {
sheet_selection_reset_only (sheet);
if (clear_selection)
sheet_selection_append (sheet, col, row);
}
}
void
......
......@@ -154,13 +154,27 @@ static void
move_cursor (GnumericSheet *gsheet, int col, int row, gboolean clear_selection)
{
Sheet *sheet = gsheet->sheet_view->sheet;
/*
* Please note that the order here is important, as
* the sheet_make_cell_visible call might scroll the
* canvas, you should do all of your screen changes
* in an atomic fashion.
*
* The code at some point did do the selection change
* after the sheet moved, causing flicker -mig
*
* If you dont know what this means, just mail me.
*/
if (clear_selection)
sheet_selection_reset_only (sheet);
sheet_cursor_set (sheet, col, row, col, row, col, row);
sheet_make_cell_visible (sheet, col, row);
if (clear_selection) {
sheet_selection_reset_only (sheet);
if (clear_selection)
sheet_selection_append (sheet, col, row);
}
}
void
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment