OChangeLog-2001-06-26 123 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
2000-05-14  Jody Goldberg <jgoldberg@home.com>

	* src/commands.h : Reformat.

	* src/commands.c (cmd_ins_del_row_col_{undo,redo}) : unant the
	  selection when the topology changes.

	* src/workbook.c (workbook_expr_relocate) : Fix typo.

	* src/sheet-view.c (sheet_view_{col,row}_selection_changed) : Call
	  sheet_update after a change.

13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31
2000-05-11  Michael Meeks  <michael@helixcode.com>

	* src/embeddable-grid.c (grid_view_activate): grab widget focus.

	* src/workbook-format-toolbar.c (workbook_feedback_set): make it
	cope with no format toolbar.

	* src/workbook.c (workbook_init): g_new0 for safety and to blank
	edit_line.

	* src/embeddable-grid.c (grid_view_new): set a sensible default
	size so we actually see something. (grid_view_activate): Fix with
	state boolean. (set_header_visibility): implement.
	(embeddable_grid_set_header_visibility): update.
	(grid_view_destroy): kill. (grid_view_new): kill evil private list
	of views.

	* gnumeric.oafinfo: another fix, evil bug from oaf conversion script.

32 33 34 35 36
2000-05-11  Jon K Hellan  <hellan@acm.org>

	* src/workbook.c (workbook_rename_sheet): Don't make "Duplicate
	sheet name" message if sheet name did not change.

Michael Meeks's avatar
Michael Meeks committed
37 38 39 40 41 42 43 44
2000-05-11  Michael Meeks  <michael@helixcode.com>

	* src/Makefile.am (gnumeric_libs): kill libole2 libs kludge.

2000-05-10  Michael Meeks  <michael@helixcode.com>

	* configure.in: Add check for libole2 and add to gnome-config.

Karl Eichwalder's avatar
Typo.  
Karl Eichwalder committed
45 46 47 48
2000-05-10  Karl Eichwalder  <ke@suse.de>

	* Makefile.am: Typo.

49 50 51 52 53 54 55 56 57
2000-05-10  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-format-toolbar.c (workbook_format_toolbar) : Add
	  accelerators for Bold, Underline, and Italic.
	(workbook_create_format_toolbar) : Pass accel_group.

	* src/workbook.c (workbook_create_standard_toobar) : Pass the
	  acceleration group to the toolbar.

58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93
2000-05-10  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/dialog-analysis-tools.c (dialog_data_analysis):
	Use gnumeric_clist_moveto to ensure that selected tool is visible.
	
	* src/dialogs/dialog-function-select.c (category_list_fill):
	s/current sheet/selected category/
	(function_list_fill): s/category/function/

	* src/dialogs/dialog-zoom.c (dialog_zoom_impl):
	s/selected function/current sheet/

	* src/dialogs/dialog-cell-format.c (fmt_dialog_init_format_page):
	Use gnumeric_clist_make_selection_visible to ensure that list rows
	are visible.

	* src/dialogs/dialog-sheet-order.c (dialog_sheet_order_impl): 
	s/list rows/current sheet/
	
	* src/gnumeric-util.c (clist_moveto): New helper function scroll
	list so that row becomes visible.
	(cb_clist_moveto): New callback function:
	Disconnect callback and use clist_moveto to make row visible.

	* src/gnumeric-util.[ch] (gnumeric_clist_moveto): New public
	function: Make given row visible in list - immediately if mapped,
	otherwise by attaching a signal handler.
	(gnumeric_clist_make_selection_visible): New public function: Make
	first selected row visible in list.
	
2000-05-10  Jon K Hellan  <hellan@acm.org>

	* src/func.c (tokenized_help_find): This segfaulted if no help was
	available. The test for no help failed because of
	signedness. Fixed it.

Michael Meeks's avatar
Michael Meeks committed
94 95
2000-05-10  Michael Meeks  <michael@helixcode.com>

96 97 98 99 100 101 102 103
	* gnumeric.oafinfo: fix borked magic sodding UUID's which suck.

	* src/corba-workbook-factory.c (_WorkbookFactory_init): update
	for oaf, but only the IID.

	* src/embeddable-grid.c (EmbeddableGridFactory_init): update
	for oaf. (embeddable_grid_factory): add failure warning.

Michael Meeks's avatar
Michael Meeks committed
104 105
	* Makefile.am: Install oafinfo.

Jacob Berkman's avatar
Jacob Berkman committed
106 107 108 109 110 111 112 113 114
2000-05-10  Jacob Berkman  <jacob@helixcode.com>

	* configure.in (use_wm_icons): check for using window icons

	* src/main.c (gnumeric_main): use an icon if available in
	gnome-libs

	* src/Makefile.am (INCLUDES): add a -D for the icon dir

115 116 117 118
2000-05-10  Karl Eichwalder  <ke@suse.de>

	* src/dialogs/cell-format.glade: Typo.

Jody Goldberg's avatar
Jody Goldberg committed
119 120 121 122
2000-05-09  Jody Goldberg <jgoldberg@home.com>

	* Release 0.53

Morten Welinder's avatar
Typo.  
Morten Welinder committed
123 124 125 126
2000-05-09  Morten Welinder  <terra@diku.dk>

	* src/auto-format.c (do_af_suggest): Test right pointer for NULL.

127 128
2000-05-09  Jody Goldberg <jgoldberg@home.com>

129 130
	* configure.in : Tweak to produce a semi reasonable gnumericConf.sh
	  remove gnumeric-config.
131 132
	* Makefile.am : ditto.
	* gnumericConf.sh : ditto.
133

134 135
	* src/sort.c (sort_range) : Use sheet_cell_remove_simple.

Jody Goldberg's avatar
Jody Goldberg committed
136 137
	* src/cell.c (cell_set_expr_internal) : Restore static.

138 139
	* src/commands.c (cmd_set_date_time_{undo,redo}) : Mark the changed cell for
	  status update.
Jody Goldberg's avatar
Jody Goldberg committed
140
	(cmd_sort_destroy) : Leaks.
141 142 143 144 145

	* src/Makefile.am (INCLUDES) : Remove extra '/' at end.

	* src/workbook.c (insert_current_time_cmd) : fix cut-n-paste-o.

Valek Frob's avatar
Valek Frob committed
146 147 148 149 150
2000-05-09  Valek Filippov  <frob@df.ru>

	* src/functions/fn-financial.c: changed "NUM!" to "#NUM!".
	* src/functions/fn-logical.c: changed "'#VALUE!'" to "#VALUE!".

151 152 153 154 155
2000-05-09  Jody Goldberg <jgoldberg@home.com>

	* src/xml-io.c (xml_probe) : Check versioning in descending order.
	(gnumeric_xml_read_workbook) : Add check for v3.

Valek Frob's avatar
Valek Frob committed
156 157 158 159 160
2000-05-09  Valek Filippov  <frob@df.ru>

	* src/dialogs/cell-format.glade.h: inserted /* xgettext:no-c-format */
	  before "%" strings.

Jody Goldberg's avatar
Jody Goldberg committed
161 162
2000-05-08  Jody Goldberg <jgoldberg@home.com>

163 164 165 166
	* src/cell.c (cell_set_value) : When guessing what the entered text
	  was for a supplied string value prepend a \' to ensure that the
	  value stays a string, and so that blank cells work better.

Jody Goldberg's avatar
Jody Goldberg committed
167 168 169 170 171 172 173
	* src/sheet.c (sheet_cell_calc_span) : redraw the bounding range when
	  interupting spans.
	(sheet_clear_region) : Respan ranges that were interupted by the
	  cleared region.
	(sheet_cell_remove_simple) : rename from sheet_cell_remove_internal and
	  export.

174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190
2000-05-08  Jon K Hellan  <hellan@acm.org>

	* src/file.c (cb_select): New callback: Make double click on list
	in import filter chooser works like "OK".
	(workbook_import): Back when we first started using glade, we used
	a hack to avoid flicker when popping up the filter chooser. We now
	know how to do it right, and remove the hack.
	(workbook_import): Connect callback to handle double click.
	(workbook_import): Fix bug: return value from import would clobber
	return value from dialog_run. We now close dialog after retrieving
	selection, but before importing.  We really should keep the dialog
	up until user either succeeds with import or explicitly
	cancels. But we let that wait. This behaviour should be
	implemented in a lot of places in a coordinated way.
	(workbook_import): Do not destroy workbook after WM close - it is
	already destroyed.

191 192 193 194 195
2000-05-08  Morten Welinder  <terra@diku.dk>

	* configure.in (gnome-print): Survive version "0.19cvs".
	* *: include <config.h>

196 197
2000-05-08  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
198 199 200 201 202
	* configure.in : Disable the perl plugin
	  Disable the plan perfect plugin
	  Disable the gdb plugin.
	These are not ready for prime time.

203 204 205 206 207 208 209 210 211 212 213 214 215
	* src/selection.c (sheet_selection_extend_to) : Call sheet_update
	  so that selection changes via mouse movement will update the status
	  areas.
	(sheet_selection_set) : Call sheet_flag_selection_change.

	* src/sheet.c (sheet_flag_selection_change) : New function to
	  flag that sheet_update should recalc the autoexpressions.

2000-05-07  Jody Goldberg <jgoldberg@home.com>

	* README : Update to require new gnome-print.
	* gnumeric.spec.in : Ditto.

216 217 218 219 220 221 222 223 224 225
2000-05-08  Jon K Hellan  <hellan@acm.org>

	This change was committed a week ago, but I forgot the changelog:
	
	* src/dialogs/dialog-goto-cell.c (cb_row_selected): Make double
	click on list work like "OK".

	* src/dialogs/dialog-goto-cell.c (dialog_goto_cell): Remove
	buttons which do not do anything yet.
 
226 227 228 229 230 231 232 233
2000-05-07  Jon K Hellan  <hellan@acm.org>

	* src/workbook.c (yield_focus): New callback: Give up focus when
	widget is destroyed. This gets rid of a warning when import is
	canceled.
	(workbook_attach_sheet): Connect callback.
	(workbook_set_focus): Do nothing if focus target argument is NULL.

234 235 236 237 238
2000-05-07  Jody Goldberg <jgoldberg@home.com>

	* src/xml-io.c (xml_workbook_write) : Bump the xml version to v3.
	(xml_probe) : Handle v[123].

239 240 241 242 243 244 245 246 247 248
2000-05-07  Jon K Hellan  <hellan@acm.org>

        * src/dialogs/Makefile.am: dialog-printer.[ch] have been
        superseded by gnome-print dialogs. Remove.

	* src/print.c (sheet_print): Make print button default. Add
	accelerators. 

	* configure.in: Depend on gnome-print >= 0.19

249 250
2000-05-07  Jody Goldberg <jgoldberg@home.com>

251 252 253
	* src/sheet-style.c (sheet_style_attach) : disable cache trash avoidance code.
	  None of the sample xls were loading.

Jody Goldberg's avatar
Jody Goldberg committed
254 255 256 257
	* src/workbook.c (workbook_do_destroy) : Empty the formula list before
	  the cell contents so that we can avoid searching the lists for each
	  cell.  This is a big time savings on exit.

258 259 260 261 262 263
	* src/sheet.c (sheet_cell_calc_span) : Size the content if
	  it has not yet been sized.

	* src/commands.c (cmd_area_set_text_redo) : Do not queue the
	  resize, rerender, and respan until after the recalc.

Jody Goldberg's avatar
Jody Goldberg committed
264 265
2000-05-06  Jody Goldberg <jgoldberg@home.com>

266 267
	* src/main.c (gnumeric_main) : Re-disable the style tests.

Jody Goldberg's avatar
Jody Goldberg committed
268 269 270 271
	* src/cell.c (cell_set_expr_unsafe) : Split from cell_set_expr.

	* src/eval.c (invalidate_refs) : Use cell_set_expr_unsafe.

272 273 274 275 276 277 278 279 280 281
2000-05-06  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/stf-parse.c (stf_parse_is_valid_data) : Add
	the form feed character (\f) as valid text character.
	(stf_parse_convert_to_unix) : In addition to CRLF and CR,
	remove form feeds (\f) from data.

	* src/stf.c (stf_read_workbook) : Add a workbook_recalc just
	to be sure.
	
282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303
2000-05-06  Michael Meeks  <michael@helixcode.com>

	* src/eval.c (handle_cell_range_deps): Add 3D dependency support.
	(cb_single_hash_to_list, cb_range_hash_to_list): Re-arrange handling of
	where the list is collated. (do_deps_destroy): update.
	(cell_drop_dependencies): remove cretinism here.
	(drop_cell_range_dep, handle_cell_single_dep): return on NULL deps structure.

	* src/sheet-style.c (sheet_style_attach): enable cache trash avoidance code.

	* src/sheet.c (sheet_cell_remove_internal): short circuit for NULL
	deps.

	* src/expr.c (expr_rewrite): update to handle workbook case.

	* src/eval.c (workbook_deps_destroy): update for speed.
	(sheet_deps_destroy): split body into (do_deps_destroy): here.

	* src/workbook.c (workbook_delete_sheet): destroy the sheet's
	dependencies here as well; very silly. (workbook_do_destroy): destroy
	deps of all sheets up front.

304 305
2000-05-06  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
306 307 308
	* src/sheet.c (sheet_set_zoom_factor) : Depending on the order of
	  initialization we may also need to render some unrendered values.

309 310 311
	* src/parse-util.c (parse_text_value_or_expr) : Be sure the clear the
	  expr if we are returning a value.

312 313
2000-05-05  Jody Goldberg <jgoldberg@home.com>

314 315 316
	* src/sheet.c (sheet_set_zoom_factor) : Need to recalc cell
	  sizes when zooming changes.

317 318 319 320 321 322 323 324 325
	* src/functions/fn-math.c (gnumeric_countif) :
	    Make code match comment.  We can safely ignore blanks.
	(gnumeric_sumif) : Code was correct.  Add a larger comment explaining
	  rationale.
	(gnumeric_sumx2my2) : Code was wrong.  We can not skip blank cells
	  if there are multiple ranges that need to be kept in sync.
	(gnumeric_sumx2py2) : Ditto.
	(gnumeric_sumxmy2) : Ditto.

326 327 328 329 330
2000-05-05  Tuomas Kuosmanen  <tigert@tigert.gimp.org>

	* src/pixmaps/function_selector.xpm: Made the ()'s a bit higher
	to make the f(x) more clear.

Michael Meeks's avatar
Michael Meeks committed
331 332
2000-05-05  Michael Meeks  <michael@helixcode.com>

333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356
	* src/eval.c (cell_drop_dependencies): silence checks for sheet->deps.

	* src/workbook.c (workbook_expr_relocate): update for expr_rewrite.

	* src/sheet-autofill.c (autofill_cell): update for expr_rewrite.

	* src/sheet.c (sheet_destroy): use sheet_deps_destroy and hoist above
	destroy_contents.

	* src/cell.c (cell_relocate): update for expr_rewrite.

	* src/eval.c (dependancy_data_destroy): rename to (sheet_deps_destroy),
	(invalidate_refs): re-write. (dependency_single_destroy, dependency_range_destroy): 
	implement for non-intersheet deps. (workbook_deps_destroy): implement.

	* src/expr.c (expr_relocate): renamed to (expr_rewrite): update,
	add sheet re-writing. Fix serious bug with OPER_CONSTANT drop through
	to OPER_ARRAY. (cellrange_relocate): split out. (cellref_relocate): 
	update for structure pos.

	* src/expr.h: create ExprRewriteInfo.

	* src/gnumeric.h: add ExprRewriteInfo.

Michael Meeks's avatar
Michael Meeks committed
357 358 359
	* src/sheet-object-container.c (sheet_object_container_realize): fix
	no brainer bug stopping menu's merging.

360 361 362 363 364 365 366 367 368 369 370
2000-05-04  Michael Meeks  <michael@helixcode.com>

	* src/sheet-style.c (sheet_style_delete_colrow): don't shrink.
	sheet sized ranges. (sheet_style_compute): add precondition for
	Norberts.

	* src/workbook.c (workbook_new_with_sheets): kill ' ' in
	sheet names.

	* corba-test/test-gnumeric-corba.c (do_test): ditto.

371 372 373 374 375 376 377 378 379 380 381 382
2000-05-04  Jody Goldberg <jgoldberg@home.com>

	* src/workbook.c : Fix typo that was calling undo for redo toolbar.
	({redo,undo}_cmd) : Use workbook_finish_editing directly.
	(cb_auto{function,sum}) : If we are already editing do not start.
	  When the wizard is in place bring it up.
	(workbook_start_editing_at_cursor) : Make the '=' insensitive while
	  editing.
	(workbook_finish_editing) : Make the '=' sensitive.
	(sheet_action_delete_sheet) : Fix typo and rename parm
	  'current_sheet' -> 'sheet' to avoid confision with
	  workbook->current_sheet.
383 384 385 386 387 388 389
	(workbook_close_if_user_permits) : Documented, and use gboolean.
	(workbook_delete_event) : No need to invert the return value.
	(workbook_new) : connect to the 'delete_event' using
	  gtk_signal_connect_after so that we can influence the result.
	(workbook_delete_sheet) : NULL the undo, redo lists after they are
	  cleared.
	(workbook_do_destroy) : Ditto.
390

391 392 393 394 395 396 397
2000-05-04  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/rendered-value.c :
	(rendered_value_calc_size) : Check if
	cell->rendered_value is NULL. To avoid
	segfaulting.

398 399 400 401 402
2000-05-04  Almer. S. Tigelaar.  <almer1@dds.nl>

	* doc/stf-export.txt :
	Added stf-exporter documentation

403 404 405 406 407 408 409 410 411 412 413 414 415 416
2000-05-04  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/gnumeric-util.[ch] :
	(gnumeric_combo_enters) : New, makes dialogs
	close when enter is pressed inside a gtkcombo.

	* src/dialogs/dialog-stf.c :
	(stf_dialog_editables_enter) : Modified to use
	the above function for combo boxes.

	* src/dialogs/dialog-stf-export.c :
	(stf_export_dialog_editables_enter) : Modified to
	use the above function for combo boxes.

Jody Goldberg's avatar
Jody Goldberg committed
417 418
2000-05-03  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
419 420 421 422 423 424 425 426 427 428 429
	* src/command-context.c (gnumeric_error_invalid) : new function.
	* src/command-context-gui.c (ccg_error_invalid) : Handle.
	* src/command-context-corba.c (ccc_error_invalid) : Handle.

	* src/commands.c (cmd_rename_sheet_{undo,redo}) : Pass a context to
	  workbook_rename_sheet.

	* src/workbook.c (workbook_rename_sheet) : Sheet names can not be
	  empty.  Take a CommandContext and report the error.  Invert the
	  return value.

430 431 432
	* src/format.c (pre_parse_format) : Fix old typo that was causing
	  bug 10001 by breaking AM/PM.

Jody Goldberg's avatar
Jody Goldberg committed
433 434 435 436 437
	* src/cell.c (cell_set_array_formula) : Add some invariants to catch
	  inverted arrays.  The function should use the supplier's
	  reference.  It should not re-reference the supplied expression.
	  Document this.

Morten Welinder's avatar
Morten Welinder committed
438 439 440 441
2000-05-03  Morten Welinder  <terra@diku.dk>

	* autogen.sh (libtool): Add version check.

442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502
2000-05-03  Jody Goldberg <jgoldberg@home.com>

	* EvalPosition -> EvalPos
	  ParsePosition -> ParsePos
	  new struct RangeRef used in ValueRange

	  eval_pos_init* -> position.[ch]
	  parse_pos_init*
	  cell_ref_{get,make}*

	* src/workbook.c : Reorder the toolbar a bit.
	(workbook_foreach_cell_in_range) : New function.
	(cb_autofunction) : New routine.
	(workbook_set_auto_expr) : DO NOT put real code into pre/post
	  conditions.  It will be removed when debugging is eventually
	  disabled.

	* src/position.c (range_ref_normalize) : New function.

	* src/ranges.c (range_normalize) : New function.

	* src/expr.c (expr_implicit_intersection) : Use range_ref_normalize.

	* src/eval.c (cell_eval_content) : No need to release the value.
	  cell_assign_value already does that.
	(dependency_range_ctor) : Use range_normalize.

	* src/auto-format.c (do_af_suggest) : Use workbook_foreach_cell_in_range.

	* src/cell.c (cell_set_expr_and_value) : link the new expression but
	  do not queue it for recalc.
	(cell_assign_value) : Release the old value.
	(cell_copy) : Init the value to empty.

	* src/func.c (function_iterate_do_value) : Use
	  workbook_foreach_cell_in_range.

	* src/dialogs/dialog-function-wizard.c (create_description) : Use
	  a label rather than a text entry widget.  It looks better.

	* src/functions/fn-string.c (gnumeric_expression) : range is already
	  absolute.

	* src/functions/fn-stat.c (gnumeric_linest) : Handle inverted ranges.
	(gnumeric_logest) : Ditto.

	* src/functions/fn-information.c (gnumeric_countblank) : Use
	workbook_foreach_cell_in_range.
	(gnumeric_{row,column}) : Handle inversions.

	* src/functions/fn-lookup.c (gnumeric_offset) : No need to make
	  absolute.  The marshaller already did that.

2000-05-02  Jody Goldberg <jgoldberg@home.com>

	* src/eval.c (dependency_range_ctor) : normalize the range.

	* src/xml-io.c (xml_write_cell_and_position) : Suppress warning.

	* src/pixmaps.h : Add function wizard and equal sign.

503 504 505 506 507 508 509 510 511 512 513 514
2000-05-03  Michael Meeks  <michael@helixcode.com>

	* doc/Dependencies.txt: update to reflect changes.

	* src/eval.c: comment and const mending.	
	(handle_cell_range_deps): prune no inter-sheet singletons code,
	it is a sluggish anachronism. (handle_cell_single_dep): setup
	the correct sheet to enter data into.

	* src/eval.h: expunge redundant commenting, re-order,
	const kill.

515 516 517 518
2000-05-03  Almer. S. Tigelaar.  <almer1@dds.nl>

	* *.c: s/strcasecmp/g_strcasecmp/

519 520 521 522 523 524
2000-05-02  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/file.c (workbook_import) : We called gtk_widget_destroy
	_after_ gnome_dialog_close. This causes a weird "invalid cast"
	message each time something was successfully imported.

Michael Meeks's avatar
Michael Meeks committed
525 526 527 528
2000-05-01  Michael Meeks  <michael@helixcode.com>

	* src/corba-args.c (gnumeric_arg_parse): fixup popt for oaf.

Jody Goldberg's avatar
Jody Goldberg committed
529 530 531 532 533 534 535 536 537 538 539 540 541
2000-05-01  Jody Goldberg <jgoldberg@home.com>

	* src/expr.c (expr_tree_shared) : New function.

	* src/xml-io.c (gnumeric_xml_write_selection_clipboard) : Init and
	  destroy the expression hash.
	(gnumeric_xml_read_selection_clipboard) : Ditto.
	(gnumeric_xml_read_workbook) : Ditto.
	(gnumeric_xml_write_workbook) : Ditto.
	(xml_write_cell_and_position) : When saving cells that have expression
	  assign and store an ID for shared expressions.
	(xml_read_cell) : Use the ID to restore shared expressions.

542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566
2000-05-01  Jody Goldberg <jgoldberg@home.com>

	* ExprName -> NamedExpression
	  ArrayRef -> ExprArray

	change ExprTree to be a union of similar types and split
	the elements into discrete types.
	    ExprConstant
	    ExprFunction
	    ExprUnary
	    ExprBinary
	    ExprName
	    ExprVar
	    ExprArray

	    expr->oper -> expr->any.oper

2000-04-29  Jody Goldberg <jgoldberg@home.com>

	* src/value.c (value_new_empty) : Don't allocate any memory.
	(value_release) : Don't free any either.

	* src/sheet-style.c (border_check) : Init outer_style to remove a
	  warning.

567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588
2000-05-01  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/dialog-analysis-tools.c (selection_made): Popup tool
	and dismiss chooser on double click.

	* src/dialogs/col-width.glade: Add title
	* src/dialogs/import.glade: Ditto
	* src/dialogs/row-height.glade: Ditto
	* src/dialogs/sheet-rename.glade: Ditto
	* src/dialogs/summary.glade: Ditto
	
	* src/dialogs/analysis-tools.glade (All dialogs): Add padding
	between input and output frames.
	(TTest1 dialog, TTest2 dialog, TTest3 dialog, Anova2 dialog,
	MovingAverage dialog): Remove spaces from label string.
	(Anova1 dialog, Correlation dialog, Covariance dialog,
	RankAndPercentile dialog): Use table in input frame. Get rid of
	frame around "Grouped by". Use alignment and fill instead of
	spaces to place label strings. Minor output options tweaks.
	(MovingAverage dialog): Place all user widgets inside the same
	vbox to make padding uniform.

Michael Meeks's avatar
Michael Meeks committed
589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624
2000-05-01  Michael Meeks  <michael@helixcode.com>

	* configure.in: Handle oafinfo.in

	* src/sheet-object.c (sheet_set_mode_type_full): oafize.

	* src/sheet-object-container.c (sheet_object_container_new_from_goadid): 
	ditto.

	* src/sheet.c (sheet_insert_object): always launch via.
	bonobo_object_activate regardless of monikers.

	* idl/Gnumeric.idl: add a comment telling people to look elsewhere if
	they want to write bonobo components.

	* src/workbook.c (insert_object_cmd): update for oaf.

	* src/main.c (gnumeric_main): Check for NULL ctx, on corba failure.

	* src/corba-args.c (gnumeric_arg_parse): NULL ctx.

	* src/corba-workbook-factory.c (_WorkbookFactory_init): update to
	use od_server_register.
	(WorkbookFactory_create_object): use Bonobo_stringlist not GNOME_stringlist,
	when was this last compiled ...

	* src/corba-args.c (gnumeric_arg_parse): update for OAF.

	* acconfig.h: USING_OAF

	* configure.in: ditto.

2000-05-01  Michael Meeks  <michael@helixcode.com>

	* HACKING: make it more explicit.

625 626
2000-05-01  Morten Welinder  <terra@diku.dk>

Morten Welinder's avatar
Morten Welinder committed
627 628 629
	* src/main.c (has_gnumeric_been_compiled_with_guile_support): Fix
 	prototype.

630 631 632 633 634 635 636
	* src/gutils.c (gnumeric_usr_plugin_dir, gnumeric_sys_plugin_dir,
 	gnumeric_sys_glade_dir): fix prototype.  (C isn't C++.)

	* src/complete.c (complete_destroy): Static.

	* src/regression.c: Inlcude <string.h> for memset.

Almer. S. Tigelaar's avatar
Almer. S. Tigelaar committed
637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656
2000-05-01  Almer. S. Tigelaar.  <almer1@dds.nl>

	* configure.in:
	Export GNUMERIC_VERSION
	
	* acconfig.h:
	Undefine GNUMERIC_VERSION

	* */Makefile.am:
	Removed -DGNUMERIC_VERSION, now located in config.h

	* src/functions/Makefile.am, src/dialogs/Makefile.am : 	
	VERSION changed to gnumeric_version.

	* plugins/excel/libole2/Makefile.am, plugins/guile/Makefile.am :
	ditto
	
	* plugins/perl/Makefile.am :
	ditto

657 658 659 660 661 662 663 664 665
2000-04-30  Miguel de Icaza  <miguel@helixcode.com>

	* src/workbook.c (workbook_new_with_sheets): Put a space there, to
	avoid having "Sheet 1" and then "Sheet1" in the same workbook.

2000-04-29  Miguel de Icaza  <miguel@helixcode.com>

	* src/application.c (application_init): Oops.

666 667 668 669 670 671 672 673
2000-04-29  Jody Goldberg <jgoldberg@home.com>
	
	* * : Convert 'Value' into a union of real types and allocate each
	  seperately.

	* src/dialogs/dialog-printer-setup.c (do_print_preview_cb) :
	  Suppress warning.

674 675 676 677 678 679
2000-04-29  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/dialogs/dialog-stf-preview.c :
	(stf_preview_merge_with-hash) : Remove warning
	message, because empty lines also render to NULL

Michael Meeks's avatar
Michael Meeks committed
680 681 682 683 684
2000-04-29  Michael Meeks  <michael@helixcode.com>

	* src/sheet-style.c (sheet_mstyle_compute_from_list): kill inline.
	(border_check): make outer style calcs mostly conditional on do_outer.

685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714
2000-04-29  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/stf-export.[ch] : New, 
	low-level stf-export code.

	* src/dialogs/dialog-stf-export.glade : New, 
	stf export dialog.

	* src/dialogs/dialog-stf-export.glade.h : New, 
	stf export dialog strings.

	* src/dialogs/dialog-stf-export.[ch] : New, 
	top-level controlling code for the stf export dialog.

	* src/dialogs/dialog-stf-export-private.h : New, 
	private declarations for the stf exporter.

	* src/dialogs/dialog-stf-export-format-page.c : New, 
	controlling code for the format page of the stf export dialog

	* src/dialogs/dialog-stf-export-sheet-page.c : New, 
	controlling code for the sheet page of the stf export dialog
	
	* src/Makefile.am : Updated to include new files

	* src/stf.c : Now also provides export for csv files
	using the new stf export dialog

	* src/dialogs/Makefile.am : Updated to include new files
	
715 716 717 718 719 720 721 722 723 724 725 726 727 728
2000-04-29  Jody Goldberg <jgoldberg@home.com>

	* src/parser.y : Make the sheet_sep, and range_sep conditional
	  so that I can use the parser for applix too.

	* src/workbook.c (workbook_unref) : encapsulate workbook_unref.

	* src/application.c (application_init) : Do not save the value if it
	  is not there.  Fix typo.

	* src/mstyle.c (mstyle_unref) : If the default style is released
	  clear the cached pointer.  This can happen if the first workbook
	  loaded fails.

Miguel de Icaza's avatar
Miguel de Icaza committed
729 730
2000-04-28  Miguel de Icaza  <miguel@helixcode.com>

Miguel de Icaza's avatar
Miguel de Icaza committed
731 732
	* src/complete.c (complete_idle): Removed debugging messages

Miguel de Icaza's avatar
Miguel de Icaza committed
733 734 735 736 737 738 739
	* src/item-edit.c (entry_changed): Update here.

	* src/application.c (application_init): Load auto-complete state
	here.
	(application_use_auto_complete_set): accesor function.
	(application_use_auto_complete_get): ditto.

740 741 742 743 744
2000-04-28  Jody Goldberg <jgoldberg@home.com>

	* src/complete.c (complete_start) : Do not install an idle handler if
	  one has already been installed for this object.

745 746 747 748 749 750
2000-04-27  Miguel de Icaza  <miguel@helixcode.com>

	* src/dialogs/dialog-printer-setup.c (do_print_preview_cb): Close
	the dialog if the user selects preview.  Not optimal but better
	than the two possible choices.

751 752 753 754 755 756
2000-04-27  Jody Goldberg <jgoldberg@home.com>

	* *Makefile.am : Use new extended configure variables.

	* configure.in: Add a few variables

757 758 759 760 761 762 763 764
2000-04-27  JP Rosevear  <jpr@arcavia.com>

	* Makefile.am: Delete old gnumeric-config generation. 

	* gnumeric-config.in: Use new variables exported from autoconf.

	* configure.in: gnumeric-config magic

Jody Goldberg's avatar
Jody Goldberg committed
765 766 767 768 769 770
2000-04-27  Jody Goldberg <jgoldberg@home.com>

	* src/workbook.c (workbook_sheet_get_free_name) : No need to translate "%s%d".

	* src/gutils.c (PLUGIN_SUFFIX) : typo.

Karl Eichwalder's avatar
Karl Eichwalder committed
771 772 773 774
2000-04-27  Karl EICHWALDER  <ke@suse.de>

	* NEWS (Translations): Add `da', `es', `no', and `uk'.

775 776 777 778 779 780 781 782 783 784
2000-04-27  Morten Welinder  <terra@diku.dk>

	* src/plugin.c (plugin_load_plugins_in_dir): Don't access memory
 	that isn't ours to access.  Constify.
	(plugin_data_last_modified): Constify.
	(plugin_data_get_title): Constify.
	(plugin_data_get_descr): Constify.
	(plugin_data_get_size): Constify.
	(plugin_data_get_user_data): Constify.

Karl Eichwalder's avatar
Typo.  
Karl Eichwalder committed
785 786 787 788
2000-04-27  Karl EICHWALDER  <ke@suse.de>

	* doc/translating.sgml: Typo.

789 790
2000-04-27  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
791 792 793
	* src/functions/fn-lookup.c (gnumeric_offset) : Bug 9372.
	  Both corners get offset.

794 795 796 797 798 799
	* src/workbook-format-toolbar.c (modify_cell_region) : Do redraws
	  respans, and redimensions here.

	* src/cell.c (cell_set_format) : Do not attempt to render or redraw
	  the value.

800 801 802 803 804 805
2000-04-27  Jon K Hellan  <hellan@acm.org>

	* src/rendered-value.c (cell_rendered_height): 
	(cell_rendered_height): Check for null pointers. Zoomed sheets
	with dangling references would segfault. 

806 807 808 809 810 811
2000-04-27  Jody Goldberg <jgoldberg@home.com>

	* src/sheet.c (sheet_update) : Do not update the status or
	  autoexpression when in edit mode.  This solves a sneaky problem
	  selecting a range for an expression on a newly created sheet.

812 813
2000-04-26  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
814 815 816 817 818 819 820 821 822 823
	* src/gnumeric-sheet.c (start_cell_selection_at) : Only hide the
	  primary cursor when selecting cells on a different sheet.

	* src/expr.c (eval_expr_real) : Pass EVAL_PERMIT_NON_SCALAR to
	  eval_expr_real when evaluating an array.

	* src/cell.c (cell_set_array_formula) : typo.

	* src/sheet.c (sheet_find_boundary_{horizontal,vertical}) : Another thinko.

824 825 826 827 828
	* src/dialogs/cell-format.glade : Improve layout of font attributes
	  slightly.

	* src/gnumeric-util.c (gnumeric_glade_xml_new) : thinko.

829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863
2000-04-26  Jody Goldberg <jgoldberg@home.com>

	* src/command-context.c (gnumeric_error_sys_err) : New function.
	* src/command-context-gui.c (ccg_error_sys_err) : Support it.

	* src/gnumeric-util.c (gnumeric_glade_xml_new) : Use gnumeric_error_sys_err.

	* src/gutils.c (gnumeric_sys_{data,lib,glade,plugin)_dir) : New functions.
	(gnumeric_usr_dir, gnumeric_usr_plugin_dir) : New functions.

	* src/plugin.c (load_all_plugins) : Use
	  gnumeric_usr_plugin_dir, and  gnumeric_sys_plugin_dir.

	* src/item-edit.c (point_is_inside_range) : Handle non-singleton
	  expr start characters.

2000-04-25  Jody Goldberg <jgoldberg@home.com>

	* *.c : glade_new_xml -> gnumeric_glade_new_xml
	  Localize GNUMERIC_GLADEDIR so that plugins can use it too.

	* src/gnumeric-util.c (gnumeric_glade_xml_new) : New function.

	* */Makefile.am : Set 'DATADIR' rather than GLADEDIR.  And version
	  the glade file the same way the plugins are set.  This should
	  probably expand to include architecture akin to gcc.

	* src/widgets/widget-editable-label.c (el_button_press_event) :
	  Clicking in another window accepts the changes.  Once we have
	  reliquished our grab push the button event back on the queue
	  so that it can be forwarded on to the appropriate recipient (9007).

	* src/parse-util.c (parse_text_value_or_expr) : Watch for 1 character
	  strings which could start an expression.

864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881
2000-04-25  Miguel de Icaza  <miguel@helixcode.com>

	* src/item-edit.c (entry_changed): Call complete_start here;  Pass
	the text to scan_for_range now.
	(item_edit_set_arg): Create the complete_sheet object here.
	(item_edit_destroy): kill it here.

	* src/complete.c: New file.  Implements the abstract
	auto-completion class;

	* src/complete-sheet.c: New file.  Implements the sheet-based
	completion code.

	* src/item-edit.c (item_edit_draw_text): Take a GtkStyle instead
	of a GdkGC.

	* src/item-grid.c (create_popup_menu): Remove unrequired code. 

Morten Welinder's avatar
Morten Welinder committed
882 883 884 885 886 887 888 889 890
2000-04-25  Morten Welinder  <terra@diku.dk>

	* src/value.c (value_duplicate): Plug leak.

	* plugins/Makefile.am (SUBDIRS): Add numtheory.

	* plugins/numtheory/*: new files, mostly from Marko R. Riedel
 	(mriedel@neuearbeit.de).

891 892 893 894
2000-04-26  Tuomas Kuosmanen  <tigert@tigert.gimp.org>

	* src/pixmaps/auto-sum.xpm: Better fitting Sigma icon for Jody.

895 896 897 898 899 900 901 902
2000-04-25  Jody Goldberg <jgoldberg@home.com>

	* src/pattern.c (gnumeric_sheet_patterns) : Add the rest of the
	  patterns for applix.

	* src/dialogs/cell-format.glade : Add all of the new patterns.
	* src/dialogs/dialog-cell-format.c : Ditto.

903 904 905
2000-04-24  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-private.h : Rename ea_status -> selection_descriptor
906
	  Moved ea_entry here and called it edit_line.
907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967
	* src/workbook.c (workbook_get_entry) : new routine.

	* src/dialogs/function-select.glade : Made this a dialog, not a popup.

	* src/summary.c (summary_item_free) : format police.
	* src/value-sheet.c (value_area_foreach) : Ditto.

	* src/sheet.c (sheet_new) : Init the update flags to FALSE, rather
	  than TRUE now that the system seems to be getting their initial
	  state correct when importing, paging and the like.
	(sheet_load_cell_val) : Use workbook_get_entry.
	(sheet_find_boundary_horizontal) : format police.
	(sheet_find_boundary_vertical) : Ditto.
	(sheet_range_splits_array) : Ditto.
	(sheet_delete_{cols,rows}) : Ditto.
	(sheet_restore_row_col_sizes) : Ditto.
	(sheet_col_get_distance_{pixels,pts}) : Ditto.
	(sheet_row_get_distance_pixels) : Ditto.
	(sheet_row_get_distance_pts) : Ditto, Init accumulator.

	* src/selection.c (sheet_selection_set) : format police.
	(selection_check_for_array) : Ditto.
	(sheet_selection_walk_step) : Ditto.
	* src/sheet-view.c (horizontal_scroll_event) : Ditto.
	(vertical_scroll_event) : Ditto.
	* src/dialogs/dialog-cell-format.c : Ditto.
	* src/dialogs/dialog-printer.c : Ditto.
	* src/dialogs/dialog-workbook-attr.c : Ditto.
	* src/functions/fn-eng.c : Ditto.
	* src/functions/fn-lookup.c : Ditto.
	* src/functions/fn-string.c : Ditto.

	* src/pattern.c (gnumeric_sheet_patterns) : Add a few patterns for
	  applix.  More are needed, and these are not available in the format
	  dialog yet.

	* src/number-match.c (compute_value) : Use g_strtod.
	(format_match) : Ditto.

	* src/item-edit.c : Use workbook_get_entry.

	* src/item-bar.c (item_bar_event) : format police.

	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Do not set
	  the focus directly.  Leave that to workbook_start_editing.
	(gnumeric_sheet_new) : Use workbook_get_entry.

	* src/format.c (render_number) : format police.

	* src/complex.c (complex_from_string) : Use g_strtod.
	* src/functions/fn-database.c : Ditto.

	* src/colrow.c (cb_row_col_visibility) : format police.

	* src/main.c (gnumeric_main) : Move the workbook_style_test to the
	  empty case.

	* src/mstyle.c (mstyle_set_pattern) : Add some safety.

	* src/number-match.c (format_match) : Handle empties.

968 969 970 971 972 973
2000-04-22  Michael Meeks  <michael@helixcode.com>

	* src/test.c (zero_stats, dump_stats): implement.
	(thrash_scroll): implement. (thrash_insert): implement.
	(workbook_style_test): use them.

Tuomas Kuosmanen's avatar
Tuomas Kuosmanen committed
974 975 976 977
2000-04-22  Tuomas Kuosmanen  <tigert@gimp.org>

	* src/pixmaps/auto-sum.xpm: New icon for Jody.

978 979 980 981 982 983 984 985 986 987 988 989 990 991 992
2000-04-22  Michael Meeks  <michael@helixcode.com>

	* src/sheet-style.c (sheet_style_attach): comment out optimization
	for now.

	* src/workbook.h (workbook_mark_clean): remove redundant prototype.

	* src/corba-workbook.c (Workbook_save_to): use workbook_set_dirty
	instead.

2000-04-21  Michael Meeks  <michael@helixcode.com>

	* src/sheet-style.c (sheet_style_cache_flush): update, kill inline
	update all cache_flushes to be more explicit.

993 994 995 996 997 998 999 1000 1001 1002 1003 1004
2000-04-22  Almer. S. Tigelaar.  <almer1@dds.nl>

	Fixed Bug #9007 
	Note : Does not fix the mouse click problem, just the focus
	problem
	
	* src/workbook.c 
	(workbook_attach_sheet) : Attaches a signal handler for 
	the "editing_stopped" signal of the editable label.
	(sheet_label_editing_stopped_signal) : The signal handler
	of the "editing_stopped" signal.
	
1005 1006 1007 1008 1009 1010
2000-04-21  Chema Celorio  <chema@celorio.com>

	* src/sheet.c (sheet_redraw_cell_region): small typo
	that was causing a MCSSRB.
	( multiple cell span string redraw bug)

1011 1012
2000-04-21  Jody Goldberg <jgoldberg@home.com>

1013 1014 1015
	* src/workbook.c (autosum_cmd) : Add a quick and simple auto-sum
	  routine.

1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030
	* src/functions/fn-math.c (gnumeric_lcm) : Use value_new_int.
	(gnumeric_minverse) : Use value_new_array_non_init.
	(gnumeric_mmult) : Ditto.
	* src/functions/fn-stat.c (gnumeric_frequency) : Ditto.

	* src/value.c : Make Value::type a constant in preparation for
	  changing the structure of the union to save space.

	* src/workbook.c (do_focus_sheet) : Use sheet_update.
	(workbook_calc_spans) : New routine.
	(workbook_mark_clean) : Delete, use workbook_set_dirty instead.

	* src/file.c (workbook_import) : Set the dialog parent.
	(workbook_read) : Use workbook_calc_spans.

1031 1032 1033
	* src/sheet.c (sheet_row_get_distance_{pixels,pts}) : Optimize this
	  to directly access the segmented arrays so that we can skip empty
	  blocks.
1034
	(sheet_find_boundary_{horizontal,vertical}) : Rename
1035 1036
	  some variables for clarity and add some trivial optimizations to
	  recognize when we are jumping to/from the far edge.
1037 1038
	(sheet_cell_calc_span) : Differentiate between a forced rerender and
	  one that fills in the blanks.
1039

Jody Goldberg's avatar
Jody Goldberg committed
1040 1041
2000-04-20  Jody Goldberg <jgoldberg@home.com>

1042 1043 1044 1045
	* src/dialogs/dialog-cell-format.c (draw_format_preview) : Don't
	  display preview text if there is none.
	(dialog_cell_format) : Don't init the preview text if the cell is empty.

Jody Goldberg's avatar
Jody Goldberg committed
1046 1047
	* src/plugin.c (plugin_load) : Fix leak.

1048 1049 1050
	* src/formats.c (currency_symbols) : Add Yen.  Attempt to add
	  a version of the Euro.  It uses an iso_8859_15 encoding
	  which is not commonly available.
1051 1052 1053 1054

	* src/corba-sheet.c (Sheet_cell_set_value): 
	cell_set_value -> sheet_cell_set_value

1055 1056 1057 1058 1059 1060 1061
2000-04-20  Matt Wilson  <msw@redhat.com>

	* src/corba-sheet.c (Sheet_cell_set_value): 
	sheet_cell_set_value -> cell_set_value

	* src/corba-sheet.c: include cell-comment.h, rendered-value.h

1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233
2000-04-20  Jody Goldberg <jgoldberg@home.com>

	* src/dialogs/dialog-cell-format.c : Use the edit_pos as the example
	  not the top left corner.

	* src/functions/fn-stat.c (gnumeric_ftest) : Use eval_pos_cellref
	  to help localize the strangeness.
	(gnumeric_ttest) : Ditto.

	* src/xml-io.c (xml_write_cell_and_position) : If this is an array
	  expression and we are the top left then add attributes to indicate
	  size of array.  Ignore the rest of the array.
	(xml_not_used_old_array_spec) : New routinr to handle the old array format.
	(xml_cell_set_array_expr) : store an array.
	(xml_read_cell) : Handle the old and the new array formats.

	* src/workbook.c (workbook_close_if_user_permits) : Accept input
	  first.
	(wb_edit_key_pressed) : Handle array formulas here.
	(workbook_detach_sheet) : Do not recalc all if we are exiting.
	(workbook_start_editing_at_cursor) : When we start editing an
	  array formula display just the formula not all the extra {}()[][] crap.

	* src/sheet.c (SheetPrivate) : Add a recompute_spans flag.
	(sheet_calc_spans) : New routine.
	(sheet_cell_calc_span) : New routine.
	(sheet_range_calc_spans) : Renamed and extended from
	  sheet_cells_update.
	(sheet_update) : Use sheet_calc_spans when necessary.
	  Update the location region when the edit_pos changes.
	(cb_recalc_spans_in_col) : Renamed from cb_collect_cells_in_col.
	  Recalcs spans directly, no need to collect first.
	(cb_set_cell_content) : New routine to set expr, or expr_and_value.
	(sheet_range_set_text) : Use cb_set_cell_content, and remember
	  chosen format with the cell rather than overriding the assigned
	  format.
	(sheet_cell_set_text) : Renamed from sheet_set_text.  Be more specific
	  about how spans, rendering and the rest are handled.
	(sheet_cell_set_expr) : New routine.
	(sheet_cell_set_value) : Ditto.
	(sheet_load_cell_val) : When displaying an array formula add {%s}()[][].
	(sheet_redraw_cell_region) : Honour spans when redrawing.
	(sheet_redraw_partial_row) : New routine.
	(sheet_redraw_cell) : Ditto.
	(sheet_is_cell_array) : Use cell_is_array.
	(sheet_range_splits_array) : Renamed from sheet_check_for_partial_array.
	(sheet_cell_add_to_hash) :  Do not touch spans at this point.
	(sheet_cell_insert) : Rename from sheet_cell_add made recalc span
	  optional.
	(sheet_cell_new) : New routine that does not touch spans.
	(sheet_cell_remove) : Made redraw optional.
	(cb_clear_cell_comments) : Remove the cell if there is no comment.
	(sheet_clear_region) : Remove the cell if there are no comments or
	  contents.  Flag an update of the status region.

	* src/sheet-view.c (cb_colrow_resize) : New function.
	(sheet_view_col_size_changed) : Resize all rows, irrespective of
	(sheet_view_row_size_changed) : existing cells.
	(sheet_view_redraw_cell_region) : This no longer honours spans.

	* src/sheet-style.c (sheet_style_attach) : Removed call to redraw.
	sheet_cells_update : rename to sheet_range_calc_spans and move to
	  sheet.c.

	* src/sheet-autofill.c (autofill_cell) : Use sheet_cell_set_value
	  rather than set_text.

	* src/selection.c (sheet_selection_changed_hook) : Delete.
	(sheet_selection_extend_to) : Update the status region to display the
	  new size.
	(sheet_selection_cut) : Use sheet_range_splits_array.
	(selection_check_for_array) : New routine.

	* src/parser.y : Remove icky array formula parsing that conflicted
	  with array entries.

	* src/number-match.c (format_match) : Return a Value * rather than a
	  double.

	* src/mstyle.c (mstyle_set_font_size) : Do not allow font sizes < 1.

	* src/main.c (gnumeric_main) : Do NOT create an empty workbook
	  then delete it if things are successfully loaded.  This causes
	  a global recalc.  Instead add a flag to disable exit when the
	  number of workbooks go to zero.  Then only enable the flag AFTER
	  we have attempted to load the initial workbooks.

	* src/item-grid.c (item_grid_event) : Update the status_region when
	  button-1 is release.  It should display the edit_pos.

	* src/gutils.c : Move cell_name, col_name, col_from_name,
	  parse_cell_name, parse_cell_name_or_range and parse_cell_name_list,
	  to parse-util.c.

	* src/gnumeric.h  : Add RenderedValue.

	* src/gnumeric-util.c (gnumeric_char_start_expr_p) : Move
	  to parse-util.c

	* src/file.c (workbook_read) : Remove freese thaw usage.
	  Move call to update AFTER mark clean.

	* src/expr.c (eval_pos_init) : Take a cellpos.
	(parse_pos_evalpos) : New routine.
	(eval_pos_cellref) : There is some questionable code scattered in the
	  functions.  This routing localizes the odd bits for correction.

	* src/eval.c (cell_eval_content) : Use sheet_redraw_cell,
	  and rendered_value_calc_size.
	(cell_get_dependencies) : Improve constness.

	* src/corba-sheet.c : Remove the freeze thaw operations.
	(Sheet_cell_set_formula) : Deleted.
	(Sheet_range_set_formula) : Delete.

	* src/commands.c : Adjust so that registration of command auto
	  calls redo.  Add misc checks for splitting arrays.

	* src/clipboard.h : Move the CellCopy types here from cell.h

	* src/clipboard.c (paste_cell) : Use cell_has_expr.
	  Don't insert the new cell till after its contents are assigned.

	* src/cellspan.c (cell_register_span) : Improve constness.
	(cell_unregister_span) : Ditto.
	(row_cell_get_displayed_at) : Delete.
	(cell_calc_span) : Moved here from cell.c

	* src/dialogs/dialog-stf.glade : Adjust the header background colour
	  to match the purdy new icon.  Add the icon.

	* src/cell-draw.c : Use the rendered_value routines.
	  Improve constness.

	* src/analysis-tools.c (set_cell) : Use sheet_cell_fetch.

	*.*
	    cell_set_* -> sheet_cell_set_
	    cell_set_*_simple -> cell_set_
	    Cell::{row,col} -> Cell::{row,col}_info
	    cell_get_text -> cell_get_entered_text
	    cell_get_content -> cell_get_entered_text
	    cell_name -> cell_coord_name 
	    cell_get_formatted_val -> cell_get_rendered_text
	    cell_get_content -> cell_get_entered_text

	* src/cell.c :
	(cell_dirty) : Renamed from cell_modified.  Use
	  sheet_set_dirty.
	(cell_formula_changed) : Make the queuing of the recalc optional.
	(cell_cleanout) : Handle union of expression and entered_text,
	  and remove the rendered value.
	(cell_copy) : Ditto.
	(cell_destroy) : handle cell_modified -> cell_dirty.
	(cell_set_text) : Use parse_text_value_or_expr and store the prefered
	  format.
	(cell_set_text_and_value) : New routine.
	(cell_assign_value) : New routine.
	(cell_set_value) : Support formats.
	(cell_set_expr_and_value) : New routine.
	(cell_set_expr_internal) : Split from cell_set_expr.
	(cell_set_expr) : Divide to allow for not queuing a recalc.
	(cell_set_array_formula) : Use cell_set_expr_internal.
	(cell_is_array) : New utility.
	(cell_is_partial_array) : New utility.
	(cell_has_expr) : New utility.
	(cell_render_value) : Use rendered_value_*.
	Move all comment routines into cell-comment.[ch].

	* idl/Gnumeric.idl : Remove cell_set_formula, and range_set_formula.
	  These were identical to set_text.  Made Workbook embeddable.

1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251
2000-04-18  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/dialogs/dialog-stf-format-page.c
	(stf_dialog_format_page_init) : Created an stf options struct 
	which was never freed or used

	* src/dialogs/dialog-stf-preview.c
	(stf_preview_merge_with_hash) : Somehow there was a *gigantic* leak
	in this routine. I simply rewrote it from scratsch because I didn't
	see the error. This seemed to help, because the leak is gone. :-)

	* src/dialogs/dialog-stf-preview.[ch]
	Added some 'how it works' comments on top. Should make it clear
	who is responsible of freeing memory and when.
	(stf_preview_share_hash) : Removed.
	I removed the hash sharing, it is obsolete and just wasted space as
	hashes are no longer shared between druid pages anyway.

1252 1253 1254 1255 1256
2000-04-18  Cody Russell  <car0969@gamma2.uta.edu>
	* src/workbook-format-toolbar.c, src/workbook.c: Make the toolbars
	honor the user's control-center settings regarding GnomeDock
	handles.

1257 1258 1259 1260 1261
2000-04-17  Karl EICHWALDER  <ke@suse.de>

	* src/dialogs/dialog-analysis-tools.c (dialog_correlation_tool):
	Correct C&P errors (ACK by Jukka-Pekka Iivonen).

Karl Eichwalder's avatar
Karl Eichwalder committed
1262 1263
2000-04-17  Karl EICHWALDER  <ke@suse.de>

Karl Eichwalder's avatar
Karl Eichwalder committed
1264 1265
	* NEWS (Translations): New top.

Karl Eichwalder's avatar
Karl Eichwalder committed
1266 1267 1268
	* gnumeric.desktop.in (Comment): Shorten comment.
	Reported by Jon K Hellan.

1269 1270
2000-04-16  Morten Welinder  <terra@diku.dk>

Morten Welinder's avatar
Morten Welinder committed
1271 1272 1273 1274
	* src/eval.c (cell_add_explicit_dependency): Quiet a bit.

	* src/functions/fn-lookup.c (gnumeric_match): Fix.

1275 1276 1277
	* src/functions/fn-financial.c (finance_functions_init): Define a
 	ton of stubs.  (We appear to have everything now.)

1278 1279 1280 1281
2000-04-16  Valek Filippov  <frob@df.ru>

	* src/functions/fn-math.c: Typos fixed ("@" and "\n").

Morten Welinder's avatar
Morten Welinder committed
1282
2000-04-15  Morten Welinder  <terra@diku.dk>
1283

Morten Welinder's avatar
Morten Welinder committed
1284 1285
	* src/functions/fn-stat.c (gnumeric_quartile): Fix for empty case.

Morten Welinder's avatar
Morten Welinder committed
1286
	* src/xml-io.c (xml_free_arg_list): Plug leak.
1287

Karl Eichwalder's avatar
Karl Eichwalder committed
1288 1289 1290 1291
2000-04-15  Karl EICHWALDER  <ke@suse.de>

	* src/dialogs/dialog-cell-sort.c (order_box_new): Mark as translatable.

Morten Welinder's avatar
Morten Welinder committed
1292 1293
2000-04-15  Morten Welinder  <terra@diku.dk>

1294
	* src/Makefile.am (GNUMERIC_BASE_SOURCES): Delete print-preview.[ch]
Morten Welinder's avatar
Morten Welinder committed
1295 1296 1297

	* src/print.c: Kill many #includes.

Karl Eichwalder's avatar
Karl Eichwalder committed
1298 1299 1300 1301 1302
2000-04-15  Karl EICHWALDER  <ke@suse.de>

	* src/dialogs/dialog-zoom.glade, src/dialogs/dialog-zoom.glade.h
	(N_): Make labels conforming.

Karl Eichwalder's avatar
Karl Eichwalder committed
1303 1304 1305 1306
2000-04-15  Karl EICHWALDER  <ke@suse.de>

	* configure.in (ALL_LINGUAS): Sort alphabetically.

Jon K Hellan's avatar
Jon K Hellan committed
1307 1308 1309 1310
2000-04-15  Jon K Hellan  <hellan@acm.org>

	* configure.in: Require gnome-print >= 0.18

1311 1312 1313 1314 1315
2000-04-15  Miguel de Icaza  <miguel@gnu.org>

	* src/print.c (print_headers): Use black for printing the
	headers and footers. 

1316 1317 1318 1319 1320
2000-04-14  Karl EICHWALDER  <ke@suse.de>

	* gnumeric.desktop.in: Exchange Name/Comment.  Adjust the values
	for de.

1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334
2000-04-14  Miguel de Icaza  <miguel@gnu.org>

	* src/selection.c (selection_is_simple): Use an
	internationalizable version of the message here.

2000-04-10  Miguel de Icaza  <miguel@gnu.org>

	* Lots of files: replaces utils.h for gutils.h

	* renamed utils.h to gutils.h to avoid the compilation problem on
	some Unices (yes, fixing the Makefile would have done it, but
	utils.h was still a lame name;  Of course gutils.h is not any
	better, but it is now don). 

1335 1336 1337 1338
2000-04-14  Michael Meeks  <michael@helixcode.com>

	* src/*: s/ENABLE_BONOBO_PRINT/ENABLE_BONOBO/

Karl Eichwalder's avatar
Karl Eichwalder committed
1339 1340 1341 1342
2000-04-14  Karl EICHWALDER  <ke@suse.de>

	* src/file.c (wants_to_overwrite): Add missing dot.

1343 1344 1345 1346
2000-04-14  Jody Goldberg <jgoldberg@home.com>

	* src/print.c : make ENABLE_BONOBO_PRINT conditional on ENABLE_BONOBO.

1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359
2000-04-14  Michael Meeks  <michael@helixcode.com>

	* src/print.c (print_job_info_get): setup sheet object list.
	(print_job_info_destroy): check it. (print_sheet_range): build a list of
	pre-printed sheet objects. (print_page_object): updated.

	* src/sheet-object-bonobo.c (sheet_object_bonobo_print): simplify muchly
	to new API.

2000-04-11  Michael Meeks  <michael@helixcode.com>

	* configure.in: Bump required gb version.

Karl Eichwalder's avatar
Karl Eichwalder committed
1360 1361 1362 1363
2000-04-13  Karl EICHWALDER  <ke@suse.de>

	* src/about.c (dialog_about): Add missing dot :)

Miguel de Icaza's avatar
Miguel de Icaza committed
1364 1365 1366 1367 1368
2000-04-12  Miguel de Icaza  <miguel@helixcode.com>

	* configure.in: New version of Gnumeric coming out.  New version
	of gnumeric coming out.

1369 1370 1371
2000-04-12  Jon K Hellan  <hellan@acm.org>

	* src/history.c (history_menu_item_create): Really add
Jon K Hellan's avatar
Jon K Hellan committed
1372
	accelerators to history menu item
1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390

	* src/dialogs/dialog-analysis-tools.c (dialog_random_tool): Bug:
	Dialog would quit when combo list was popped via keyboard. Fix:
	Remove gnome_dialog_editable_enters from distribution combo.

2000-04-11  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/dialog-zoom.c (focus_to_custom): New callback: Set
	focus to custom spinbutton when custom radiobutton is checked.
	(dialog_zoom_impl): Connect the callback.

	* src/dialogs/dialog-analysis-tools.c (focus_on_entry): New
	callback: Set focus to output range entry when output range
	radiobutton is checked.
	(set_output_option_signals): Connect the callback.
	(distribution_parbox_config): Only add accelerator if we've got
	one.

1391 1392 1393
2000-04-11  Morten Welinder  <terra@diku.dk>

	* src/print.c (sheet_print): Supply new landscape argument to
1394
 	preview.
1395

1396 1397 1398 1399 1400 1401 1402 1403
2000-04-11  Jody Goldberg <jgoldberg@home.com>

	* src/solver-lp.c (make_solver_arrays) : Make more robust in the face
	  of missing variables or constraints.

	* src/eval.c (cell_eval_content) : Handle the case of a cell without a
	  formula more gracefully.

1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419
2000-04-10  Jody Goldberg <jgoldberg@home.com>

	* src/file.c (workbook_read) : Force clean after post load recalc.

	* src/sheet-view.c (sheet_view_col_selection_changed) : keep the
	  moving col visible.
	(sheet_view_row_selection_changed) : Keep the moving row visible.

	* src/item-grid.c (item_grid_find_col) : Tune iteration bounds to
	  improve speed and allow for scrolling back to the first col/row.

	* src/item-cursor.c (item_cursor_autofill_event) : Pass the coords of
	  the cell we want to keep visible rather than the top left corner.
	(item_cursor_set_bounds_visibly) : Rename the parameters to reflect
	  their real purpose.

Morten Welinder's avatar
Morten Welinder committed
1420 1421 1422 1423 1424 1425 1426 1427
2000-04-09  Morten Welinder  <terra@diku.dk>

	* configure.in (gnome-print): Need 0.17.

	* src/print.c (print_page): Put page numbers into (post script)
 	file.
	(print_page): Move setup_rotation into page loop.

Michael Meeks's avatar
Michael Meeks committed
1428 1429 1430 1431 1432 1433
2000-04-11  Michael Meeks  <michael@helixcode.com>

	* src/parser.y: correct include.

	* src/cell.c (cell_set_rendered_text): move up to before its first use.

1434
2000-04-09 Dom Lachowicz <dominicl@seas.upenn.edu>
Morten Welinder's avatar
Morten Welinder committed
1435

1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454
 	* src/sheet.h: Rename member "private" -> "priv" in case anyone in the
 	future writes a plugin / module written in C++
 
 	* src/sheet.c (sheet_new, sheet_flag_status_update_cell,
 	sheet_flag_status_update_page, sheet_update, sheet_destroy,
 	sheet_set_edit_pos, sheet_insert_cols, sheet_delete_cols,
 	sheet_insert_rows, sheet_delete_rows, sheet_restore_row_col_sizes,
 	sheet_col_set_size_pts, sheet_col_set_size_pixels,
 	sheet_row_set_size_pts, sheet_row_set_size_pixels): Same
 
 	* src/corba-sheet.c (sheet_corba_setup, sheet_corba_shutdown): Same
 
 	* src/corba-workbook.c (corba_sheet): Same
 
 	* src/embeddable-grid.c (Grid_get_sheet): Same
 
 	* src/sheet-vector.c (sheet_vector_attach, sheet_vector_detach,
 	sheet_vectors_cell_changed, sheet_vectors_shutdown): Same

1455 1456 1457 1458
2000-04-07  Miguel de Icaza  <miguel@gnu.org>

	* src/cellspan.c (span_remove): Pretify code.

1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471
2000-04-10  Jody Goldberg <jgoldberg@home.com>

	* src/file.c (workbook_read) : Do NOT recalc on load for now even
	  though there are are queued cells that desire it.  This will
	  prematurely mark the sheet as dirty.  This will need to be
	  revisited.

	* src/cell.c (cell_set_rendered_text) : Make static.

	* src/cell.c (cell_calc_dimensions) : Be careful to recalculate spans
	  that centered on other cells when calculating the span for a new
	  cell.

1472 1473 1474 1475 1476 1477 1478 1479
2000-04-09  Michael Meeks  <michael@helixcode.com>

	* src/sheet-object-bonobo.c (sheet_object_bonobo_class_init): add print
	hooks.

	* src/sheet-object-graphic.c (sheet_object_graphic_print): implement.
	(sheet_object_graphic_class_init): setup print method

1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516
2000-04-09  Jody Goldberg <jgoldberg@home.com>

	* src/dialogs/dialog-cell-format.c : Do not change the target style if
	  editing has not yet been enabled.

	* src/workbook.c (workbook_set_saveinfo) : If the save function is
	  NULL default to xml.

	* src/format.c (format_value) : Add some error checking.

	* src/cell.c (calc_text_dimensions) : Make static

	* src/main.c : Add main.h

2000-04-03  Dom Lachowicz <dominicl@seas.upenn.edu>
 
 	* src/workbook.c (sheet_action_reorder_sheet): Right click on a
 	sheet tab, and if there's more than one sheet, you'll get an
 	option to bring up the re-order sheets dialog
 
 	* src/dialogs/dialog-plugin-manager.c (refresh_right_frame) :  Do not
	  override default fonts and colours.
 
	* src/dialogs/sheet-order.glade,
	* src/dialogs/sheet-order.glade.h,
	* src/dialogs/dialog-sheet-order.c (row_cb, delete_clicked_cb,
	  up_clicked_cb, down_clicked_cb, close_clicked_cb, 
	  dialog_sheet_order_impl) : Improve look by moving buttons to the
	  right edge rather than using stock buttons on the bottom and side.
	
2000-04-07  Jody Goldberg <jgoldberg@home.com>

	* src/workbook.c (workbook_finish_editing) : resensitize the toolbars
	  after editing.
	(workbook_start_editing_at_cursor) : Desensitize the toolbars when we
	  start to edit.

Morten Welinder's avatar
Morten Welinder committed
1517 1518 1519 1520
2000-04-09  Morten Welinder  <terra@diku.dk>

	* src/sheet-style.c (sheet_unique_cb): Plug leak.

Morten Welinder's avatar
Morten Welinder committed
1521 1522 1523
	* src/sheet-view.c (sheet_view_comment_relocate): Leak plug (for
 	Jody).

1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538
2000-04-09  Michael Meeks  <michael@helixcode.com>

	* src/print.c (print_page_object): implement.
	(print_page): add hook.

	* src/sheet-object.c (sheet_object_print): implement.
	(sheet_object_class_init): setup default print behavior.

	* src/sheet-object.h: Add virtual method 'print'

	* src/dialogs/dialog-cell-format.c (fmt_dialog_init_format_page):
	free list after creation. (fmt_dialog_impl, cb_notebook_destroy):
	pass the signal id without using the FormatState that is free'd by
	the time we destroy the notebook.

1539 1540 1541 1542 1543 1544 1545
2000-04-09  Jon K Hellan  <hellan@acm.org>

	* src/workbook.[ch] (workbook_class_init): Put "cell_changed"
	signal back in.

	* src/sheet.c (sheet_load_cell_val): Ditto.

1546 1547 1548 1549 1550 1551
2000-04-06  Michael Meeks  <michael@helixcode.com>

	* src/sheet-style.c (sheet_style_relocate): use range_translate to
	shrink code size + set a blank style under the moved styles to get
	correct behavior: this routine needs optimizing sometime.

1552 1553 1554 1555 1556 1557 1558 1559
2000-04-09  Morten Welinder  <terra@diku.dk>

	* src/sheet.h (ParsePositions): Add sheet.

	* src/expr.c (parse_pos_init): New arg sheet.  All callers changed.

	* src/parser.y (gnumeric_expr_parser): Use pp->sheet.

1560 1561 1562 1563
2000-04-08  Jon K Hellan  <hellan@acm.org>

	(sheet_name_quote): Quote embedded quotes.

Morten Welinder's avatar
Leak.  
Morten Welinder committed
1564 1565 1566 1567
2000-04-08  Morten Welinder  <terra@diku.dk>

	* src/xml-io.c (xml_read_solver): Plug leak.

1568 1569
	* src/functions/fn-financial.c (gnumeric_xnpv): Plug leak.

1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580
2000-04-08  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/dialogs/dialog-stf-csv-page.c
	(csv_page_global_change) : Result of gtk_editable_get_chars was not
	freed. (2x)

	* src/stf-parse.c
	(stf_parse_region) : Only the last item of the GSList's would be
	freed
	(stf_parse_sheet) : ditto
	
Jon K Hellan's avatar
Jon K Hellan committed
1581 1582 1583 1584
2000-04-08  Jon K Hellan  <hellan@acm.org>

	* src/sheet.c (cellref_name): Remove unused variable.

1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664
2000-04-08  Jon K Hellan  <hellan@acm.org>

        * src/sheet.h (struct _Sheet): Replace member name with
	name_quoted and name_unquoted. In name_quoted, names with spaces
	or quote characters are protected with quotes.

	* src/analysis-tools.c (prepare_output): Use
	workbook_sheet_get_free_name to ensure that we don't create more
	than one sheet with the same name.

	* src/eval.c (dump_cell_list, sheet_dump_dependencies): Dump
	sheet->name_unquoted instead of sheet->name.

	* src/expr-name.c (name_sheet_title): Make value from
	sheet->name_quoted instead of sheet->name. FIXME: Is this correct?

	* src/gnumeric-sheet.c (selection_insert_selection_string): Make
	selection string from sheet->name_quoted instead of quoting
	sheet->name here.

	* src/print-info.c (render_tab): Render sheet->name_unquoted
	instead of sheet->name.

	* src/print-preview.c (create_toplevel): Use sheet->name_unquoted
	instead of sheet->name in window title.

	* src/selection.c (sheet_selection_to_string, range_to_string):
	Make reference string from sheet->name_quoted instead of quoting
	sheet->name here.

	* src/sheet.[ch] (sheet_quote_name): Rename to
	sheet_name_quote. Take name_unquoted parameter, not a sheet.

	* src/sheet.c (sheet_rename, sheet_new): Set both
	sheet->name_quoted and sheet->name_unquoted.
	(sheet_destroy): Free both sheet->name_quoted and
	name_unquoted.
	(cellref_name): Make reference from sheet->name_quoted instead of
	quoting sheet->name here.

	* src/test.c (thrash_sheet): Use sheet->name_unquoted instead of
	sheet->name in debug output.

	* src/value-sheet.c (value_dump): Dump sheet->name_quoted instead
	of quoting sheet->name here.
	(encode_cellref): Use sheet->name_quoted instead of quoting
	sheet->name here.

	* src/workbook.[ch] (workbook_sheet_get_free_name): Make it more
	generally useful: Add "base" and "always_suffix" parameters. The
	caller should now select the base to make the name from
	(e.g. "Sheet"), and specify whether or not a suffix should be
	added when the name "base" is not in use.

	* src/workbook.c (insert_sheet_cmd): Use new signature of
	workbook_sheet_get_free_name.
	(workbook_rename_sheet): Insert unquoted name in hash table.
	(sheet_label_text_changed_signal): Remove test for quote
	characters in sheet name.
	(sheet_action_delete_sheet): Prompt with name_unquoted instead of
	name.
	(sheet_action_rename_sheet, workbook_attach_sheet): Use
	name_unquoted instead on name.
	(workbook_detach_sheet): Use sheet->name_unquoted as hash key
	instead of sheet->name.

	* src/workbook-cmd-format.c
	(workbook_cmd_format_sheet_change_name): Use name_unquoted instead
	on name.

	* src/xml-io.c (xml_sheet_write): Output sheet->name_unquoted
	instead of sheet->name.

	* src/dialogs/dialog-sheet-order.c (dialog_sheet_order_impl): Make
	list header passive.
	(add_to_sheet_clist, delete_cb): Substitute sheet->name_unquoted
	for sheet->name.

	* src/dialogs/dialog-zoom.c (dialog_zoom_impl): Ditto.

1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723
2000-04-08  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/dialog-analysis-tools.c (struct
	random_tool_callback_t): Use gladified random dialog: changed most
	members.
	(struct DistributionStrs): New struct to hold name to show in list
	and parameter labels for a random distribution.
	(distribution_strs): Change to a DistributionStrs struct.
	(output_range_selected): New callback function. This is part of a
	change which selects the corresponding toggle button when the
	output range field is entered. This works for all gladified
	dialogs in this file.
	(set_output_option_signals): Set up output_range_selected callback
	on output range field. The widget is retrieved by name, so widget
	names in analysis-tools.glade had to be changed.
	(dialog_correlation_tool, dialog_covariance_tool,
	dialog_ttest_paired_tool, dialog_ttest_eq_tool,
	dialog_ttest_neq_tool, dialog_ftest_tool, dialog_average_tool,
	dialog_ranking_tool, dialog_anova_single_factor_tool,
	dialog_anova_two_factor_without_r_tool): New widget name for
	output range field.
	(dialog_correlation_tool, dialog_covariance_tool,
	dialog_ttest_paired_tool, dialog_ttest_eq_tool,
	dialog_ttest_neq_tool, dialog_ftest_tool, dialog_average_tool,
	dialog_ranking_tool, dialog_anova_single_factor_tool,
	dialog_anova_two_factor_without_r_tool): Make <Enter> in entry
	fields activate default button.
	(distribution_strs_find, distribution_parbox_config,
	combo_get_distribution, dialog_random_realized): These new
	functions are helpers for gladified random generation dialog.
	(distribution_strs_find): Find strings record, given distribution
	enum.
	(distribution_parbox_config): Configure parameter widgets given
	random distribution.
	(combo_get_distribution): Find from combo the distribution the
	user selected.
	(distribution_callback): Configure parameter widgets for the
	distribution which was selected.
	(dialog_random_realized): Make initial geometry of distribution
	table permanent.
	(dialog_random_tool): Libgladify. This is a complete
	rewrite. Other changes: Make the "distribution" variable function
	static instead of file static. Rebuild the dialog each time it is
	displayed. This is like the other libglade dialogs in this file.
	Make <Enter> in entry fields activate default button. Get random
	distribution name and parameter label strings from
	distribution_strs struct. Use a "realized" callback to make
	initial geometry permanent. Unref accel group for distribution
	parameter widgets when dialog is destroyed.

	* src/dialogs/analysis-tools.glade (All dialogs): Remove ':' from
	frame labels. Add accelerators. Rename output range entry widgets
	to xxx_output_range_entry. Minor output options tweaks.
	(FTest dialog, TTest1 dialog, TTest2 dialog, TTest3 dialog): Use
	alignment and fill instead of spaces to place label strings.
	(Anova2 dialog, MovingAverage dialog): Use table in input frame so
	that entry fields are aligned.
	(Random dialog:) New dialog.

Morten Welinder's avatar
Leaks.  
Morten Welinder committed
1724 1725 1726 1727 1728 1729 1730 1731
2000-04-07  Morten Welinder  <terra@diku.dk>

	* src/selection.c (sheet_selection_reset_only): Free the right list.
	(sheet_is_range_selected): Avoid double assignment.
	(sheet_is_cell_selected): Ditto.

	* src/history.c (history_menu_remove_items): Plug leak.

Jody Goldberg's avatar
Jody Goldberg committed
1732 1733 1734 1735 1736 1737 1738 1739 1740 1741
2000-04-07  Jody Goldberg <jgoldberg@home.com>

	* src/embeddable-grid.h (GridViewClass) : Fix typo, did this ever work ?

	* src/workbook.c (workbook_move_sheet) : Mark the book as dirty when a
	  sheet moved.
	(insert_sheet_cmd) : Mark book as dirty when sheet is added.
	(workbook_attach_sheet) : Add a precondition to avoid failing in the
	  bonobo case.

1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760
2000-04-07  Morten Welinder  <terra@diku.dk>

	* src/collect.h (CollectFlags): Get rid of COLLECT_IGNORE_POSITIVE
 	and COLLECT_IGNORE_NEGATIVE.

	* src/collect.c (callback_function_collect): Don't have the above
 	flags.

	* src/functions/fn-financial.c (irr_npv_df): New function.
	(gnumeric_irr): Use irr_npv_df for better results.
	(gnumeric_ipmt, gnumeric_ppmt): Fix order of arguments!  (It works
 	so much better that way.)
	(gnumeric_mirr): Fix formula.

	* src/goal-seek.c (update_data): Spelling fix.

	* src/functions/fn-financial.c (gnumeric_rate, gnumeirc_irr,
 	gnumeric_xirr): Use the supplied guess.

1761 1762
2000-04-06  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
1763 1764 1765 1766 1767 1768
	* src/xml-io.c (gnumeric_xml_read_workbook) : No need to recalc, the
	  loader handles it.

	* src/file.c (workbook_read) : Do a recalc and sheet_update after loading.
	  Wrap entire process in deep_{freeze,thaw}.

Jody Goldberg's avatar
Jody Goldberg committed
1769 1770
	* src/expr.c (eval_expr) : Fix thinko.

1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791
	* src/functions/fn-string.c : Add func 'expression' to return text of
	  formula.

	* src/parser.y : It is illegal to write A1:Sheet2!A3.

	* src/value.c (value_new_cellrange) : Take the eval pos so that we can
	  correctly invert mixed mode references when necessary.

	* src/expr.c (cell_ref_make_abs) : New routine.
	(expr_relocate) : Handle changes in value_new_cellrange.
	* src/func.c (function_marshal_arg) : Ditto.
	* src/ranges.c (range_parse) : Ditto.

	* src/corba-sheet.c (Sheet_cell_set_value) : No need to check these
	  references.  They seem to be hard coded to be relative.

	* src/functions/fn-lookup.c (gnumeric_offset) : Begin to handle
	  relative references.

	* src/sheet.c (cellref_get) : Simplify the logic a smidge.

1792 1793 1794
	* src/workbook.c (workbook_finish_editing) : Restore the edit area
	  manually for now.  We may need to make the update flags finer grain.

1795 1796 1797 1798 1799 1800
2000-04-05  Jody Goldberg <jgoldberg@home.com>

	* src/stf-parse.c (stf_parse_options_new) : Init oldsplitpositions.
	* src/dialogs/dialog-stf-format-page.c (stf_dialog_format_page_init) :
	  Init format_run_parseoptions.

Morten Welinder's avatar
Leak.  
Morten Welinder committed
1801 1802 1803 1804 1805
2000-04-05  Morten Welinder  <terra@diku.dk>

	* src/workbook.c (workbook_do_destroy): Unref, not destroy, the
 	wb->priv->gui_context member.  (Plugs leak.)

1806 1807 1808 1809 1810 1811 1812
2000-04-05  Jody Goldberg <jgoldberg@home.com>

	* (*.[ch]) : merge eval_expr, eval_expr_nonempty, eval_expr_empty.

	* src/xml-io.c (xml_write_attributes) : remove unused variable.
	(xml_read_attribute) : Fix warning.

1813 1814 1815 1816 1817 1818 1819
	* src/clipboard.c (x_selection_received) : Cache the Sheet* before
	  freeing the closure.

	* src/workbook-format-toolbar.c (workbook_feedback_set) : Disable
	  callbacks when setting the font status.  This avoids applying a
	  spurious format.

Miguel de Icaza's avatar
Miguel de Icaza committed
1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836
2000-04-05  Miguel de Icaza  <miguel@gnu.org>

	Fix #8326
	
	* src/print-info.c (print_info_new): Test was reversed here, so we
	were actually flipping the orientation for printing.

	* src/print.c (print_sheet_range): Now the routine returns the
	number of pages printed, and can be directed not to generate
	actual output.  
	(print_sheet_range): Do column/row fitting for the other printing
	order as well.
	(compute_sheet_pages): Support both empty-page printing, and non
	empty-page printing.
	(print_page): Can now print and detect if there is anything to
	print. 

1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857
2000-04-05  Jody Goldberg <jgoldberg@home.com>

	* src/commands.c (cmd_paste_cut_undo) : Use sheet_update and force a
	  status update.
	(cmd_paste_cut_redo) : Ditto. Change the selection here.

	* src/sheet.c (sheet_flag_status_update_range) : Handle NULL ranges.

	* src/selection.c (sheet_selection_add_range) : Use
	  sheet_flag_status_update_range rather than an immediate call
	  to selection_changed_hook (that is deprecated).
	(sheet_selection_move) : Delete.
	(sheet_selection_paste) : Use sheet_update.

	* src/clipboard.c (clipboard_paste_region) : Remove unnecessary and
	  incorrect code to do status updates.  The selection mechanism
	  handles it already.
	(x_selection_received) : Use sheet_update.

	* src/about.c (dialog_about) : Add Almer.

1858 1859 1860 1861 1862 1863 1864 1865 1866 1867
2000-04-05  Michael Meeks  <michael@helixcode.com>

	* src/sheet-style.c (sheet_style_compute): kill leak.
	(sheet_destroy_styles): destroy hash.

2000-03-25  Michael Meeks  <michael@helixcode.com>

	* src/sheet-object-bonobo.c (sheet_object_bonobo_load): Add
	warnings and fixup.

Morten Welinder's avatar
Sort.  
Morten Welinder committed
1868 1869 1870 1871 1872
2000-04-05  Morten Welinder  <terra@diku.dk>

	* src/about.c (dialog_about): Re-establish sorting (except Sir
 	Miguel).

1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913
2000-04-05  Jody Goldberg <jgoldberg@home.com>

	* src/functions/fn-logical.c (gnumeric_if) : Use eval_expr_nonempty
	  and permit non-scalars.
	* src/functions/fn-lookup.c (gnumeric_choose) : Ditto.
	* src/functions/fn-math.c (gnumeric_sumproduct) : Ditto.

	* src/functions/fn-information.c (get_value_class) : Use
	  eval_expr_empty, and permit non-scalars.

	* src/func.c (function_iterate_argument_values) : Permit non-scalar
	  values.
	(function_marshal_arg) : Be more specific about what types of argument
	  must be scalar.

2000-04-04  Jody Goldberg <jgoldberg@home.com>

	* src/functions/fn-math.c (gnumeric_sumproduct) : eval_expr_nonempty
	  and permit non-scalars.
	* src/functions/fn-lookup.c (gnumeric_choose) : Ditto.

	* src/expr-name.c (eval_expr_name) : Accept 'as_scalar' as an
	  argument use eval_expr_empty.

	* src/expr.c (eval_expr_real) : Push the common cases for implicit
	  intersection further down for a big speed improvement.
	(eval_expr_nonempty) : New routine.
	(eval_expr_empty) : Accept as_scalar.

2000-04-04  Jody Goldberg <jgoldberg@home.com>

	* src/item-grid.c (item_grid_button_1) : sheet_update after button
	  press that changes selection.

2000-04-04  Jody Goldberg <jgoldberg@home.com>

	* src/print.c (print_hf) : Add precautions in an attempt to address
	  http://bugs.gnome.org/db/82/8200.html
	  I can not replicate it, but it can't hurt to be more careful just in
	  case.

Miguel de Icaza's avatar
Miguel de Icaza committed
1914 1915 1916 1917
2000-04-04  Miguel de Icaza  <miguel@gnu.org>

	* src/item-cursor.c (item_cursor_autofill_event): Flush the canvas updates

Jody Goldberg's avatar
Jody Goldberg committed
1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977
2000-04-04  Jody Goldberg <jgoldberg@home.com>

	* src/workbook.c (workbook_class_init) : Remove CELL_CHANGED.
	(workbook_finish_editing) : At LAST! cmd_set_text is responsible for
	  setting the text directly :-)

	* src/workbook-format-toolbar.c (change_font_size_in_selection_cmd) :
	  cmd_format takes care of the height adjustments.
	* src/dialogs/dialog-cell-format.c (cb_fmt_dialog_dialog_apply) : Ditto.

	* src/sheet.c (Sheet): Add flags edit_pos_changed, selection_content_changed.
	(sheet_new) : init them.
	(sheet_flag_status_update_cell) : New function that sets the flags.
	(sheet_flag_status_update_range) : Ditto.
	(sheet_update) : Fix typo. Add support for new flags.
	(sheet_update_auto_expr) : Const correctness.
	(sheet_update_controls) : Ditto.
	(sheet_load_cell_val) : Ditto. Delete unused signal.
	(sheet_set_text) : Use sheet_flag_status_update_range.
	(sheet_set_edit_pos) : New routine.
	(sheet_cursor_move) : Delete.
	(sheet_fill_selection_with) : Remove.

	* src/selection.c (sheet_selection_changed_hook) : const correctness.
	(sheet_selection_change) : merge into sheet_selection_set.
	(sheet_selection_extend_to) : Use sheet_selection_set.
	(sheet_selection_set) : Merge with sheet_selection_change and use the
	  sheet_cursor accessors rather than changing things directly.
	(sheet_selection_walk_step) : Use sheet_selection_set, and sheet_set_edit_pos.

	(sheet_is_all_selected) : const correctness.
	(sheet_is_cell_selected) : New routine.
	(sheet_is_range_selected) : New routine.

	* src/item-grid.c (item_grid_draw_background) : Adjust to rename of
	* sheet_selection_is_cell_selected -> sheet_is_cell_selected.

	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Cleanup the
	  logic for creating fills and arrays so that it can have undo
	  support.
	  - Change the heuristic for selecting what type of characters can start
	    an edit session.  Rather than using fixed Latin1 centric codes,
	    guess that the 'length' field of the event is >0 if the character is
	    printable.  Be more careful NOT to forward characters to the entry
	    if we are not editing.
	  - Use sheet_update.

	* src/commands.c (command_pop_list_top) : Delete.
	(cmd_format_redo) : Apply the height adjustment here.
	(cmd_set_area_*) : Implement.
	(*) : Use sheet_update.

	* src/colrow.c (rows_height_update) : Moved here and generalized from
	  sheet_selection_height_update.

	* src/clipboard.c (sheet_paste_selection) : No need to call
	  sheet_cursor_set.  sheet_selection_add_range already does that.
	(clipboard_paste_region) : Flag updates to the status display if
	  something changes.

1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026
2000-04-04  Jon K Hellan  <hellan@acm.org>

	* src/sheet-view.c (sheet_view_set_zoom_factor): Call
	gnumeric_sheet_make_visible only if sheet widget is realized.
	(sheet_view_make_edit_pos_visible): New function: Make the cell at
	the edit position visible.
	(sheet_view_size_allocate): Add call to
	sheet_view_make_edit_pos_visible.

	* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible): Add
	comment.

	* src/xml-io.c (xml_sheet_read): Read zoom into a local variable
	before calling sheet_set_zoom_factor. Otherwise,
	sheet_set_zoom_factor would assume that it had already initialized
	this factor.

	* src/workbook.c (change_zoom_in_current_sheet_cb): No longer call
	change_displayed_zoom_cb, sheet_set_zoom_factor will call it
	indirectly. 

	* src/workbook.[ch] (workbook_class_init,
	workbook_focus_current_sheet, workbook_create_standard_toobar):
	Rename "sheet_changed" signal to "sheet_entered".  Remove
	"cell_changed" signal.
	(workbook_focus_current_sheet): Rename "sheet_changed" signal to
	"sheet_entered".
	(workbook_zoom_feedback_set): New function: Update zoom combo in
	toolbar when zoom changes.

	* src/sheet.c (sheet_update_zoom_controls): New function: Update
	zoom controls when zoom changes.
	(sheet_set_zoom_factor): Use it.
	(sheet_load_cell_val): Do not emit "cell_changed".

	* src/dialogs/dialog-cell-format.c (cb_fmt_dialog_dialog_apply):
	Call sheet_update_controls to update toolbar controls.

	* src/history.c (file_history_cmd): Remove pristine workbook when
	a new one is read in. For consistency with File/Open, File/Import
	and Bonobo File/History.

	* src/dialogs/dialog-workbook-attr.c
	(cb_attr_dialog_dialog_apply): Include workbook-view.h to get
	prototype for workbook_view_pref_visibility.

	* src/border.h (style_border_print): Remove bogus const in  prototype.
	Reported by Aron Griffis.

Jody Goldberg's avatar
Jody Goldberg committed
2027 2028 2029 2030 2031 2032 2033 2034 2035
2000-04-02  Jody Goldberg <jgoldberg@home.com>

	* src/item-edit.c (entry_changed) : Call scan_for_range here.
	(item_edit_set_arg) : And here.
	(recalc_spans) : But NOT here.  Calling request_update while updating
	  any other canvas item is bad.

	* src/item-cursor.c (item_cursor_set_bounds) : remove ugly hack.

2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055
2000-04-02  Jody Goldberg <jgoldberg@home.com>

	* doc/stf-parser.txt : Add description of double quote handling.
        * src/stf-parse.c (stf_parse_options_new) : Init
	  indicator_2x_is_single and duplicates.
	(stf_parse_options_csv_set_indicator_2x_is_single) : New function.
	(stf_parse_csv_cell) : Add logic to optionaly treat double quotes as a
	  single escaped quote.
	* src/dialogs/dialog-stf-csv-page.c : Add the double quote checkbox.
	* src/dialogs/dialog-stf.glade : Ditto.

2000-04-02  Jody Goldberg <jgoldberg@home.com>

	* src/gnumeric-sheet.[ch] (gnumeric_sheet_get_cell_bounds) : Delete.

	* src/item-edit.c (item_edit_init) : Init the feedback_cursor to NULL.

	* src/item-cursor.c (item_cursor_set_bounds) : HACK to force the
	  canvas to honour update requests.

Jody Goldberg's avatar
Jody Goldberg committed
2056 2057 2058 2059 2060 2061 2062 2063 2064