ChangeLog-2000-10-10 187 KB
Newer Older
1 2 3 4 5 6 7
2000-07-05  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/stf-parse.c:
	(stf_parse_options_fixed_autodiscover): When a column has right
	and left aligned text split and has 2 or more spaces in the
	middle split the column in two. (Suggested by Morten)

8 9
2000-07-04  Jody Goldberg <jgoldberg@home.com>

10 11 12
	* src/workbook-edit.c (workbook_edit_detach_guru) : Nat having a
	  guru in place is not an error.

13 14 15 16 17
	* src/clipboard.c (x_selection_received) : No need to sheet_update or
	  recalc.  cmd_paste_copy handles that.

	* src/gnumeric-util.c (gnumeric_non_modal_dialog) : New function.

18 19 20 21 22
2000-07-04  Morten Welinder  <terra@diku.dk>

	* src/clipboard.c (x_selection_received): Update current sheet,
 	not a NULL sheet.

23 24
2000-07-04  Almer. S. Tigelaar.  <almer1@dds.nl>

25
	* autogen.sh:
26 27 28
	Downgrade libtool requirment from 1.3.4 to 1.3.3.
	because compiling Gnumeric works fine with 1.3.3.

29 30 31 32 33 34 35
2000-07-04  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/functions/fn-financial.c: Implemented basis 0 for COUPDAYBS.

	* src/functions/fn-financial.c (coupdays): Implemented frequency 1
 	for basis 1 (frequences 2 and 4 are still not done).

36 37
2000-07-04  Almer. S. Tigelaar.  <almer1@dds.nl>

38
	* src/dialogs/dialog-stf.c, src/dialogs/dialog-stf-fixed-page.c:
39 40
	Fix column mangling in fixed width import.

41 42 43 44 45 46
	* src/dialogs/dialog-stf-format-page.c:
	(format_page_format_changed): Use new sublist_select member
	to avoid 'jumping' of the GtkClist when selecting from
	the sublist.
	(format_page_sublist_select_row): idem.
	(stf_dialog_format_page_init): Initialize sublist_select.
47

48 49
	* src/stf-parse.c, src/stf-parse.h:
	(stf_parse_options_fixed_autodiscover): New!
50 51
	Column autodiscovery for fixed width.

52
	* src/dialogs/dialog-stf.glade:
53 54
	Add clear and autodiscovery buttons
	
55 56 57 58
	* src/dialogs/dialog-stf-fixed-page.c: 
	(fixed_page_autodiscover): Autodiscovery routine.
	(fixed_page_clear_clicked): Clear click handler
	(fixed_page_auto_clicked): Autodiscovery click handler
59
	
60 61 62 63 64 65 66
2000-07-04  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* samples/excel/infofuns.xls: Changed the third test case of
 	ERROR.TYPE.  It seems that XL produces #VALUE! error for
 	STDEV("foo") but #DIV/0! error for STDEV(A1) when A1 contains
 	string `foo'.  Cool.

67 68 69 70 71 72 73 74 75 76 77 78 79 80 81
2000-07-03  Morten Welinder  <terra@diku.dk>

	* src/stf-parse.c (stf_parse_get_rowcount): Don't add one to the
 	number of lines if the last line is empty.

	* src/sheet.c (sheet_cell_set_text): Plug leak.

	* src/workbook-format-toolbar.c
 	(do_sheet_selection_apply_number_format): Avoid double translation
 	of format.

	* src/mstyle.c (mstyle_set_format_text): Renamed from
 	mstyle_set_format.
	(mstyle_set_format): New function taking a StyleFormat *.

Jody Goldberg's avatar
Jody Goldberg committed
82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101
2000-07-03  Jody Goldberg <jgoldberg@home.com>

	* src/workbook.c : Begin the Name menu.

	* src/workbook-edit.c (workbook_edit_set_sensitive) : New function.
	(workbook_finish_editing) : Use here.
	(workbook_start_editing_at_cursor) : And here.
	(workbook_edit_attach_guru) : And here.
	(workbook_edit_detach_guru) : And here.
	(workbook_edit_entry_redirect_p) : New function.

	* src/item-grid.c (item_grid_button_1) : If we have a guru up, but are
	  not selecting a region ignore clicks.
	(item_grid_event) : Ditto.

	* src/gnumeric-sheet.c (gnumeric_sheet_can_select_expr_range) : It is
	  possible to have a guru up without selecting regions.

	* src/expr-name.c (expr_name_list) : Doh!

102 103 104 105 106
2000-07-03  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/analysis-tools.c: Implemented `Histogram' tool (mostly).

	* src/dialogs/tools.h: Related changes.
107

108 109 110 111
	* src/dialogs/analysis-tools.glade, 
	src/dialogs/dialog-analysis-tools.c: Added dialogs for `Histogram'
	and `Fourier Analysis' tools.  The later is not implemented yet.
	
Jukka-Pekka Iivonen's avatar
Jukka-Pekka Iivonen committed
112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128
2000-07-03  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/functions/fn-financial.c: Implemented COUPNUM().

	* src/analysis-tools.c: Started the implementation of the third
	anova tool (two-factor with replication).
	
	* src/dialogs/analysis-tools.glade: Added dialog for the new
	tool.  Fixed the `Correlation' dialog.
	
	* src/dialogs/dialog-analysis-tools.c: Added 
	dialog_anova_two_factor_without_r_tool().

	* src/dialogs/tools.h: Related changes.

	* TODO: Added `Data analysis tools' section.

129 130
2000-07-02  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
131 132 133
	* src/expr.c (expr_rewrite) : Names can contain relative references,
	  we need to check them too.

134 135 136 137 138 139 140
	* src/parser.y (exp) : Add production for sheet specific names.
	  eg Sheet2!name

2000-07-01  Jody Goldberg <jgoldberg@home.com>

	* src/functions/fn-string.c (parse_search_strin) : Use g_strdup.

141 142 143 144 145 146
2000-07-01  Morten Welinder  <terra@diku.dk>

	* src/file.c (can_try_save_to): Constify.  Handle empty name.
	(do_save_as): Ditto.
	(wants_to_overwrite): Ditto.

Morten Welinder's avatar
Morten Welinder committed
147 148
2000-06-30  Morten Welinder  <terra@diku.dk>

Morten Welinder's avatar
Morten Welinder committed
149 150
	* src/file.c (dialog_query_load_file): Guard against empty entry.

Morten Welinder's avatar
Morten Welinder committed
151 152
	* src/parse-util.c (parse_cell_name_list): Plug leak.

153 154 155 156
	* src/solver-lp.c (write_constraint_str): Return an allocated
 	string instead of taking an unsized buffer.  Constify.  All
 	callers changed.

Morten Welinder's avatar
Morten Welinder committed
157 158 159 160
	* plugins/Makefile.am (SUBDIRS): Delete text, ff-csv, and sample
 	plugins.  Separate the remaining ones into file formats and
 	functions.

JP Rosevear's avatar
JP Rosevear committed
161 162
2000-06-30  JP Rosevear  <jpr@arcavia.com>

Morten Welinder's avatar
Morten Welinder committed
163 164
	* src/embeddable-grid.c (EmbeddableGridFactory_init): Use
 	consistent names.
JP Rosevear's avatar
JP Rosevear committed
165 166 167 168 169

	* gnumeric.gnorba: Make server names consistent 

	* gnumeric.oafinfo: Make server names consistent

170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195
2000-06-30  Jody Goldberg <jgoldberg@home.com>

	* src/gnumeric-sheet.c (gnumeric_sheet_can_select_expr_range) : It is
	  possible to have a guru up without editing.
	(gnumeric_sheet_key_press) : rename from gnumeric_sheet_key.
	(gnumeric_sheet_size_allocate) : rename from gnumeric_size_allocate.
	(gnumeric_sheet_focus_in) : Enable the input context.
	(gnumeric_sheet_focus_out) : Disable the input context.
	(gnumeric_sheet_realize) : Create the input context.
	(gnumeric_sheet_unrealize) : Destroy the input context.
	(gnumeric_sheet_class_init) : Register the new methods.
	(gnumeric_sheet_init) : Init the input context.

	* src/clipboard.c (x_selection_handler) : Adjust to changes in
	  application_clipboard_clear.
	(x_selection_clear) : Ditto.
	* src/cmd-edit.c (cmd_paste) : Ditto.
	* src/sheet.c (sheet_destroy) : Ditto.

	* src/application.c (application_clipboard_clear) : Make dropping the
	  selection optional.  This removes the kludges necessary to handle
	  changing the clipboard when we already have the selection.

	* src/functions/fn-logical.c (gnumeric_true, gnumeric_false) :
	  fix signatures.

Jukka-Pekka Iivonen's avatar
Jukka-Pekka Iivonen committed
196 197 198 199
2000-06-30  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/functions/fn-logical.c: Added FALSE().

200 201
2000-06-29  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
202 203 204 205
	* src/application.c (application_set_selected_sheet) : short circuit
	  clearing the selection if we are in the same workbook, not just the
	  same sheet.

206 207 208 209
	* src/sheet.c (sheet_name_quote) : cast to unsigned char for safety
	  when using isdigit.
	* src/workbook.c (wb_edit_key_pressed) : Ditto.

Arturo Tena's avatar
Arturo Tena committed
210 211 212 213
2000-06-28  Arturo Tena <arturo@directmail.org>
 
	* configure.in: Improve libole2 detection.
 
214 215 216 217 218 219 220 221
2000-06-29  Jody Goldberg <jgoldberg@home.com>

	* src/parser.y : Add 'string_opt_quote' and use it in a few
	  productions that do not care about the quote state of the token.

	* src/sheet.c (sheet_name_quote) : Sheet names that begin with digits
	  need to be quoted. (#15720)

Jody Goldberg's avatar
Jody Goldberg committed
222 223
2000-06-28  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
224 225
	* src/expr.c (expr_tree_new_funcall) : Ref the function here.

Jody Goldberg's avatar
Jody Goldberg committed
226 227
	* src/func.c (fn_def_new) : Init the new elements.

Jody Goldberg's avatar
Jody Goldberg committed
228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318
2000-06-28  Jody Goldberg <jgoldberg@home.com>

	* src/functions/fn-sheet.c (GNUMERIC_VERSION) : new function.

	* src/workbook.c (workbook_do_destroy) : No need to release the
	  clipboard here.  The Sheet does it for us.

	* src/workbook-format-toolbar.c : Add Fill to the default money
	  format.

	* src/symbol.c : The only symbols are functions.  The global table
	  should not be world visible.

	* src/sheet.c (sheet_flag_status_update_cell) : Take a CellPos.
	(sheet_get_extent_cb) : Use Cell::pos rather than adding an
	  indirection.
	(cb_set_cell_content) : Use StyleFormat.
	(sheet_cell_set_value) : Call sheet_flag_status_update_cell.
	(sheet_cell_set_value) : Ditto.
	(sheet_destroy) : Prepare to clear out named expressions.
	(colrow_move) : Handle changes in cell_relocate signature.
	(sheet_move_range) : Ditto.

	* src/sheet-autofill.c : Use StyleFormats.

	* src/position.c (parse_pos_init) : Global position are permitted.

	* src/parser.y : Large change.  Do not automaticlly look for function
	  names or named expressions in the lexer.  The lexer returns STRING
	  and QUOTED_STRING.  The parser then does the appropriate lookups to
	  potentially convert to something else.  This allows us to have sheet
	  names that are the same as functions.

	* src/parse-util.c (cellref_name) : Add flag to optionally disable the
	  addition of the sheet name.  This is useful when printing
	  Sheet2!A1:A3 rather than Sheet2!A1:Sheet2!A3.

	* src/number-match.c (format_create_regexp) : Handle fill formats.

	* src/mstyle.c (mstyle_get_border) : Fix constness.

	* src/mathfunc.c (combin, fact) : Moved these here from
	  functions/fn-math.c

	* src/main.c (gnumeric_main) : No more constants_init, or
	  global_symbol_init.

	* src/func.c () : Reorg.  Remove some dead code.  Begin adding
	  workbook local function support, Begin adding volatile, and
	  semi-volatile functions.  Move the use of SymbolTable internal
	  in preparation for eliminating it.

	* src/format.c (format_number) : Improve support for pound, yen, and euro.
	  Remember to produce a number when we hit spacing.

	* src/expr.c : Have ExprFunc refer directly to the FunctionDefinition
	  We still use a SymbolTable internally, but that will be merged out
	  later.

	* src/expr-name.c : Major reorg.  Not complete.

	* src/corba-sheet.c (fill_corba_value) : Adjust to changes in
	  cellref_name signature.

	* src/commands.c (cmd_set_date_time_undo) : No need to manually call
	  update_cell_flag.  cell_remove, and cell_set_text do that for us.
	(cmd_set_date_time_redo) : Ditto.
	  Use StyleFormat.

	* src/clipboard.c (paste_cell) : Take the ExprRewriteInfo as an
	  argument.
	(clipboard_paste_region) : Init the ExprRewriteInfo.  We need to do
	  this here rather than in cell_relocate because we may be moving a
	  region, not just a single cell, and references within the region
	  should not be changed.

	* src/cell.c (cell_relocate) : Take the relocation info as an
	  argument.  Non NULL indicates a request to check bounds.  We can not
	  do this at the cell level. becuase we may be moving a block rather
	  than just a single cell, and references into the block should NOT be
	  rewritten.
	(cell_set_text_and_value) : Take a StyleFormat.
	(cell_assign_value) : Ditto.
	(cell_set_value) : Ditto.
	(cell_set_expr_internal) : Ditto.
	(cell_set_expr_unsafe) : Ditto.
	(cell_set_expr) : Ditto.

	* src/auto-format.c (do_af_suggest) : Expression now refers directly
	  to functionDef.

Miguel de Icaza's avatar
Miguel de Icaza committed
319 320 321 322 323
2000-06-22  Miguel de Icaza  <miguel@helixcode.com>

	* src/sheet-object-item.c (sheet_object_item_new): Add OAF support
	here. 

324 325 326 327 328 329 330
2000-06-27  JP Rosevear  <jpr@arcavia.com>

	* src/functions/fn-lookup.c (find_index_bisection): Undo
	transposition of find_bound_walk parameters.

	* samples/excel/lookfuns2.xls: Add type mismatch tests.

331 332 333 334 335 336 337 338 339 340
2000-06-27  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/functions/fn-stat.c (help_finv): Fixed copy-paste bug in
 	documentation.

	* src/functions/fn-logical.c: Added TRUE() function since it is
 	also a function in Excel.

	* TODO: Updated the status of the build-in functions.
	
Jody Goldberg's avatar
Jody Goldberg committed
341 342 343 344 345
2000-06-26  Jody Goldberg <jgoldberg@home.com>

	* src/value.c (value_get_as_checked_bool) : Use g_return_val_if_fail
	  rather than assert.  A log entry is better than a crash.

346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369
2000-06-26  JP Rosevear  <jpr@arcavia.com>

	* src/value.c (value_get_as_checked_bool): New function that
	doesn't require an error variable - use only if confident that
	the value does actually exist.

	* src/value.h: Add new prototype.

	* src/functions/fn-lookup.c: Clean up cruft
	(find_type_valid): See if the value is a string or is gnumeric.
	(find_compare_type_valid): See if the types are comparable.
	(find_bound_walk): Walk an integer range first in one direction
	and then in the other direction.
	(find_index_linear): Do a linear search on a range or array.
	(find_index_bisection): Do a bisection search on a range or array
	that also follows excel rules for for handling type mismatches 
	during the search and finding the first and last item matching
	the search.
	(gnumeric_vlookup): Use new functions and implement undocumented
	excel behaviour.
	(gnumeric_hlookup): ditto
	(gnumeric_lookup): ditto
	(gnumeric_match): ditto

370 371 372 373 374
2000-06-26  Morten Welinder  <terra@diku.dk>

	* src/format.c (lookup_color): Don't double translate.  Compare
 	the right number of characters.

Michael Meeks's avatar
Michael Meeks committed
375 376 377 378 379
2000-06-26  Michael Meeks  <michael@helixcode.com>

	* src/sheet-object-bonobo.c (get_file_name): return non-filenames
	as NULL.

380 381 382 383 384
2000-06-26  Jukka-Pekka Iivonen  <iivonen@iki.fi>

	* src/functions/fn-financial.c: Implemented COUPDAYS for basis 0,
 	2, 3, and 4 (basis 1 is still not implented).

385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412
2000-06-23  Morten Welinder  <terra@diku.dk>

	* src/dialogs/dialog-analysis-tools.c (set_output_option_signals):
 	Constify.
	(set_group_option_signals): Constify.
	(new_frame): Constify.
	(error_in_entry): Constify.
	(new_dialog): Constify.

	* src/analysis-tools.c: major cleanup.  Eliminate fixed-size
 	buffers that might overflow; constify; plug leaks; improve
 	precision; produce numbers without going through strings.
	(set_cell_float, set_cell_int, set_cell_na, set_cell_printf): New
 	functions.

	* src/xml-io.c (xml_write_range): Constify.
	(xml_get_gnome_canvas_points): Mark code as bogus.
	(xml_set_gnome_canvas_points): Constify.  Improve space checks.
	(xml_set_value_int): Improve buffer sizing.
	(xml_set_value_string): Constify.
	(xml_set_color_value): Improve buffer sizing.

	* src/ranges.c (parse_range): Constify, simplify, optimise, and
 	secure.
	(range_parse): Fix strict case.

	* src/parse-util.c (parse_cell_name_or_range): Remove bogus cast.

413 414 415 416 417 418
2000-06-23  Jon K Hellan  <hellan@acm.org>

	(sheet_object_container_new_bonobo): As suggested by Michael:
	use the accessor function bonobo_client_site_get_embeddable to
	get the bound embeddable.

419 420 421 422
2000-06-23  Karl Eichwalder  <ke@suse.de>

	* src/style.c (font_init): Add missing dot.

423 424 425 426 427 428
2000-06-22  Jody Goldberg <jgoldberg@home.com>

	* src/item-edit.c (item_edit_draw_text) : Restore code that was
	  deleted to handle a cursor on another line, or at the start of the
	  line.

429 430 431 432 433 434 435
2000-06-22  Jon K Hellan  <hellan@acm.org>

	* src/sheet-object-container.c
	(sheet_object_container_new_bonobo): Change
	BonoboClientSite->bound_object to bound_embeddable. This was
	just changed in Bonobo CVS.

Michael Meeks's avatar
fix.  
Michael Meeks committed
436 437 438 439
2000-06-21  Michael Meeks  <michael@helixcode.com>

	* src/embeddable-grid.c (embeddable_grid_init_anon): fix.

440 441 442 443 444
2000-06-20  Morten Welinder  <terra@diku.dk>

	* src/commands.c (cmd_ins_del_row_col_undo): Leak and assertion
 	fix from Jody's tree.

445 446
2000-06-20  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
447 448
	* src/commands.c (cmd_paste_cut_redo) : Plug leak.

449 450 451
	* src/number-match.c (format_match) : strings with only spaces are NOT
	  numbers.

Jody Goldberg's avatar
Jody Goldberg committed
452 453 454 455
2000-06-18  Jody Goldberg <jgoldberg@home.com>

        * Release 0.56

456 457
2000-06-19  Jody Goldberg <jgoldberg@home.com>

458 459 460 461 462 463 464 465 466
	* src/eval.c (invalidate_refs) : const.
	(do_deps_destroy) : const.

	* src/cell.c (cell_set_expr_internal) : Be careful about unrefing.

	* src/item-edit.c (entry_event) : Rather than catching 'event' and
	  checking for the type of event we want.  Catch the events directly.
	  That way the events can take place BEFORE we look for our position.

467 468 469 470 471
	* src/workbook-edit.c (entry_changed) : The characters starting
	  expressions are not alphabetic.  Don't bother testing them too.
	(workbook_start_editing_at_cursor) : Do not start autocompletetion
	  if the content is not completable.

472 473 474 475 476
2000-06-19  Morten Welinder  <terra@diku.dk>

	* src/sheet.c (sheet_get_extent_cb): Typo fix per Jody.  Hopefully
 	cures all the save-as-XL95 problems.

Jody Goldberg's avatar
Jody Goldberg committed
477 478 479 480
2000-06-18  Jody Goldberg <jgoldberg@home.com>

        * Release 0.55

481 482
2000-06-18  Jody Goldberg <jgoldberg@home.com>

483 484 485
	* src/parser.y (build_array) : This is almost certainly broken in
	  locales that use ',' as a decimal point.

486 487 488
	* src/xml-io.c (xml_probe) : xmlCreateFileParserCtxt will return NULL
	  if the file was not readable.

489
2000-06-17  Jody Goldberg <jgoldberg@home.com>
Valek Frob's avatar
Valek Frob committed
490

491 492 493 494 495
	* src/sheet.c (sheet_cell_set_text) : Does this change the selection
	  or content of edit pos.
	(sheet_cell_remove) : Ditto.
	(sheet_destroy) : Remove irrelevant assignment.  sheet_deps_destroy
	  does it for us.
Valek Frob's avatar
Valek Frob committed
496

497 498
2000-06-15  Jody Goldberg <jgoldberg@home.com>

499 500 501 502 503 504 505 506 507 508 509 510 511 512
	* src/value-sheet.c (value_is_error) : No need for 'offset' parm.

	* src/number-match.c (format_match) : Parse TRUE/FALSE as this level.

	* src/value-sheet.c (constants_init) : TRUE/FALSE are not symbols.
	  They are values.  A symbol only has value in an expression.
	  A value operates at a lower level.  eg
	A1 : '=TRUE' will work as a value or a symbol
	A1 : 'TRUE' will only work as a value

2000-06-15  Jody Goldberg <jgoldberg@home.com>

	* src/format.c (lookup_color) : Handle translated colours.

513 514 515 516 517
	* src/number-match.c (format_create_regexp) : Build the regexp
	  ourselves.  The poor translators had no idea what the hell that was
	  supposed to do.  The regexp is still way way to general.
	(compute_value) : Use the locale.

518 519 520 521 522 523 524
	* src/expr.c (expr_tree_as_string) : Renamed from expr_decode_tree.
	(expr_tree_get_func_def) : new function.
	(expr_tree_first_func) : New function.

	* src/expr-name.c (expr_name_value) : Rename expr_decode_tree ->
	  expr_tree_as_string.

525 526 527
	* src/style.c (font_init) : Improve error message to include the most
	  probable location of the fontmap file.

528 529 530 531 532 533
	* src/sheet-view.c (sheet_view_size_allocate) : Disable jump to edit
	  pos to avoid unintended jumping when a sheet is added.

	* src/func.c (function_def_count_args) : Correctly handle vararg
	  functions that takes nodes.

JP Rosevear's avatar
JP Rosevear committed
534 535 536 537 538 539 540 541 542 543 544 545 546 547 548
2000-06-15  JP Rosevear  <jpr@arcavia.com>

	* src/expr.c (eval_expr_real): Use new value_compare API

2000-06-14  JP Rosevear  <jpr@arcavia.com>

	* src/value.h: Update value_compare prototype.

	* src/value.c (value_compare): Make it take a new case
	sensitive flag for string comparisons.

	* src/sort.c (sort_compare_cells): Use value_compare to do the
	comparisons.  Handle the special cases of blanks (always at
	bottom, whether asc or desc) and errors (after booleans).

549 550
2000-06-14  Morten Welinder  <terra@diku.dk>

551 552 553
	* src/history.c (history_item_label): Change "_" to "-", fixing
 	around 14183.

554 555
	* src/print.c (sheet_print): Complain when printing fails.

556 557 558 559 560 561
2000-06-14  JP Rosevear  <jpr@arcavia.com>

	* samples/excel/sort.xls: Add sort sample.  Now we see that Excel
	sorts Errors after Booleans (for ascending order) and then by the
	name of the error.  Blanks are always at the bottom (asc and desc).

562 563
2000-06-14  Jody Goldberg <jgoldberg@home.com>

564
	* src/workbook-format-toolbar.c (money_format) : Correct.
565
	  (do_sheet_selection_apply_number_format) : Decrease hackishness and
566
	  improve docs for the formats.  
567

568 569 570 571 572 573 574 575 576 577 578 579 580
2000-06-13  Jody Goldberg <jgoldberg@home.com>

	* src/functions/fn-math.c (callback_function_sumproduct) : Handle
	  empty.
	(gnumeric_sumproduct) : Handle blank cells correctly, correct error
	  handling slightly.

	* src/func.c (iterate_cellrange_callback) : Handle empty cells.
	(function_iterate_do_value) : Add a new argument to control the
	  handling of empty cells.
	(function_iterate_argument_values) : Hard code the ignore_blanks
	  argument to TRUE the same as the previous behavior.

581 582 583 584 585 586 587 588
2000-06-13  Morten Welinder  <terra@diku.dk>

	* src/stf-parse.c (trim_spaces_inplace): New function.
	(stf_parse_fixed_cell): Don't trim spaces here.
	(stf_parse_fixed_line): Trim here.
	(stf_parse_csv_cell): Don't trim spaces here.
	(stf_parse_csv_line): Trim here.

Jody Goldberg's avatar
Jody Goldberg committed
589 590
2000-06-13  Jody Goldberg <jgoldberg@home.com>

591 592 593 594
	* src/functions/fn-math.c (callback_function_sumif) : No need to
	  malloc memory for an int.  Fix the logic to handle empty cells
	  properly.

Jody Goldberg's avatar
Jody Goldberg committed
595 596
	* src/stf-parse.c (stf_parse_options_set_trim_spaces) : patch typo.

597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682
2000-06-13  Jody Goldberg <jgoldberg@home.com>

	* src/workbook.c : Enable the formula guru, make WorkbookPrivate hold
	  the BonoboObject in the ENABLED_BONOBO case.

	* src/workbook-edit.c (workbook_finish_editing) : Disconnect any gurus
	  that may be up.
	(entry_changed) : Do not autocomplete expressions.  Gurus play havoc
	  with this.
	(workbook_edit_auto_complete_init) : Delete unused.
	(workbook_get_entry_logical) : New function.
	(workbook_set_entry) : New function.
	(workbook_edit_attach_guru) : New function.
	(workbook_edit_detach_guru) : New function.
	(workbook_editing_expr) : When a guru is up we are always editing an
	  expression. TODO, tune this.
	(workbook_edit_load_value) : Moved from Sheet, and renamed from
	  sheet_load_cell_val.
	(workbook_edit_init) : Handle gurus.

	* src/sheet.c (sheet_destroy_cell_select_cursor) : Make clearing optional.

	* src/sheet-vector.c (sheet_vector_new) : The vectors are
	  BonoboObjects, destroy them correctly.
	(sheet_vectors_shutdown) : Ditto.

	* src/sheet-object.c (sheet_set_mode_type_full) : Silence warning.
	(sheet_object_insert) : Renamed from sheet_insert_object and moved
	  from sheet.c

	* src/pixmaps.h : Enable the Formula guru.

	* src/parser.y (arg_list) : Improve handling of empty arguments.

	* src/gnumeric-sheet.c (selection_remove_selection_string) : Use
	  workbook_get_entry_logical.
	(selection_insert_selection_string) : Ditto.
	(start_cell_selection_at) : Ditto.
	(gnumeric_sheet_key_mode_sheet) : Ditto.

	* src/workbook-private.[ch] : Make this into a Bonobo Object for now.

	* src/embeddable-grid.c (embeddable_grid_init_anon) : Use
	  workbook_new_with_sheets.
	(embeddable_grid_new) : WorkbookPrivate is temporarily the bonobo
	  object.

	* src/history.c (history_menu_item_create) : Ditto.
	(history_menu_locate_separator) : Ditto.
	(history_menu_insert_separator) : Ditto.
	(history_menu_remove_items) : Ditto.

	* src/sheet-object-bonobo.c (sheet_object_bonobo_construct) : Ditto.
	* src/sheet-object-container.c (sheet_object_container_realize) : Ditto.

	* src/workbook-view.c (workbook_view_set_paste_special_state) : Ditto.
	(change_menu_label) : Ditto.

	* src/file.c (workbook_try_read) : Workbook is now always just a
	  GtkObject.
	(workbook_import) : Ditto.

	* src/formats.c (cell_format_date) : Add some new formats.

	* src/format.c (find_decimal_char) : Restore constness.
	(format_remove_decimal) : Fix the const correctly.

	* src/commands.c (cmd_ins_del_row_col_redo) : Fix to use the new
	  semantics.

2000-06-12  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-autofill.c (fill_item_destroy) : Free the format.
	(fill_item_new) : Handle filling by month and year.
	(autofill_compute_delta) : Ditto.
	(autofill_cell) : Ditto.

	* src/formats.c (cell_format_is_number) : currently handle the single
	  character currencies.
	(cell_format_date) : year only formats.

2000-06-10  Jody Goldberg <jgoldberg@home.com>

	* src/gnumeric-sheet.c (gnumeric_sheet_make_cell_visible) : Minor
	  optimization.

Morten Welinder's avatar
Morten Welinder committed
683 684 685 686
2000-06-13  Morten Welinder  <terra@diku.dk>

	* src/functions/fn-math.c (gnumeric_round): Round properly.

687 688 689 690 691 692 693 694 695 696 697 698
2000-06-12  JP Rosevear  <jpr@arcavia.com>

	* src/workbook.c (sort_cmd): Adjust if the range to be sorted
	has a header.

	* NEWS: Update. 

	* src/ranges.h: New prototype.

	* src/ranges.c (range_has_header): New function to determine if
	a region has a header row.

699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727
2000-06-09  Jody Goldberg <jgoldberg@home.com>

	* src/item-cursor.c (item_cursor_update) : Change sheet -> sheet-view.
	(item_cursor_set_bounds) : Add a short circuit test and return TRUE
	  if things changed.
	(item_cursor_selection_event) : Take a SheetView.
	(item_cursor_target_region_ok) : sheet -> sheet-view
	(item_cursor_do_action) : Ditto.
	(item_cursor_set_arg) : Ditto.
	(item_cursor_class_init) : Ditto.
	(item_cursor_set_bounds_visibly) : Make the cell visible before
	  changing the bounds.
	(cb_move_cursor) : New function.
	(cb_autofill_scroll) : New function.
	(item_cursor_handle_motion) : New function.
	(item_cursor_drag_event) : Enable timer based scrolling.
	(item_cursor_autofill_event) : Ditto.

	* src/gnumeric-sheet.c (start_cell_selection_at) : item-cursor takes a
	  sheet-view rather than a sheet.
	(gnumeric_sheet_new) : Ditto. Only update if the bounds changed.

	* src/item-edit.c : Take a SheetView rather than a Sheet.

	* src/sheet-view.c (sheet_view_start_sliding) : Return a flag
	  indicating whether or not the timer has been triggered.

	* src/border.c (LineDotPattern) : Fixed const.

728 729
2000-06-08  Jody Goldberg <jgoldberg@home.com>

730 731 732 733
	* src/gnumeric-sheet.c (gnumeric_sheet_compute_visible_ranges) :
	  ok now I understand what those calls to
	  gnome_canvas_get_scroll_offsets where supposed to do.

Jody Goldberg's avatar
Jody Goldberg committed
734
	* src/colrow.c (col_row_restore_sizes) : Arrgghh.  Stupid typo.
Jody Goldberg's avatar
Jody Goldberg committed
735
	(col_row_restore_sizes_group) : Patch leak.
Jody Goldberg's avatar
Jody Goldberg committed
736

737 738 739
	* src/workbook-edit.c (entry_changed) : Only autocomplete text that
	  begins with an alphabetic

740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790
2000-06-08  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-view.c (sheet_view_{col,row}_selection_changed) :
	  Do not make the edge visible, the scroll time will take care of
	  that.
	(sheet_view_{col,row}_size_changed) : Use the new undo wrappers.
	(cb_colrow_resize) : Use the new undo wrappers.
	(sheet_view_init) : Init the scroll timers.
	(sheet_view_stop_sliding) : Based on the version from item_grid.
	(sheet_view_start_sliding) : Ditto.
	(sheet_view_sliding_callback) : Ditto.  Added callback support.
	  tuned scroll parameters.

	* src/number.h : Clear out unused cruft.

	* src/item-grid.c : Move support for scroll timers into sheet-view.

	* src/item-bar.c (get_element_from_pixel) : Renamed from
	  get_col_from_pos.
	(cb_extend_selection) : New function.
	(item_bar_event) : Use the sliding scroll mechanism in sheet_view.

	* src/item-cursor.c (item_cursor_selection_event) : Adapt to changes in
	  item_grid_find_{col,row}.
	(item_cursor_drag_event) : Ditto.

	* src/sheet.c (sheet_foreach_colrow) : renamed and moved to.
	* src/colrow.c (col_row_foreach) here.
	
	* src/gnumeric-sheet.c (gnumeric_sheet_find_{col,row}) : Moved here
	  and renamed from.
	* src/item-grid.c (item_grid_find_{col,row}) : here.

	* src/value.c (value_equal) : deleted.
	(value_compare) : Moved and renamed from
	* src/expr.c (compare) : here.
	(expr_dump_tree) : Delete replicated function.

	* src/colrow.c (col_row_size_list_destroy) :
	(col_row_index_list_destroy) : New function.
	(col_row_get_index_list) : New function.
	(col_row_set_sizes) : New function.
	(col_row_restore_sizes_group) : New function.

	(col_row_save_sizes) : Moved from sheet.c
	col_row_restore_sizes : Ditto.
	cb_set_row_height : Ditto.
	rows_height_update : Ditto.

	src/commands.c (cmd_resize_row_col*) : Implement.

791 792 793 794
2000-06-08  Morten Welinder  <terra@diku.dk>

	* src/commands.c (cmd_sort_undo): Take advantage of
 	sort_data_length and sort_permute_invert.
Morten Welinder's avatar
Morten Welinder committed
795
	(cmd_sort_destroy): leak fix.
796 797 798 799

	* src/sort.c (sort_data_length): Make public.
	(sort_permute_invert): New function.

800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821
2000-06-08  Jon K Hellan  <hellan@acm.org>

	* src/workbook.c (change_displayed_zoom_cb): Set zoom using
	gtk_combo_text_set_text.
	(change_zoom_in_current_sheet_cb): Check that current sheet is non
	NULL.
	(workbook_zoom_feedback_set): Block callbacks while changing
	displayed zoom.

	* src/workbook-format-toolbar.c (workbook_create_format_toolbar):
	Drop the empty font name - that was needed in the option menu, but
	not now we're using a combo box.  Ignore nameless fonts in
	gnumeric_font_family_list. (We were displaying *two* blank lines
	at the top - now we've got rid of both.)
	(workbook_feedback_set): Set font size and font name using
	gtk_combo_text_set_text, which also selects the item in the combo
	list if present.  Get rid of hack to select font name in list -
	this is now done in the widget.
	(workbook_feedback_set):

	* src/sheet.c (sheet_set_zoom_factor): Check that sheet isn't NULL.

Morten Welinder's avatar
Morten Welinder committed
822 823
2000-06-07  Morten Welinder  <terra@diku.dk>

Morten Welinder's avatar
Morten Welinder committed
824
	* src/sort.c (sort_contents): Use the C-library's qsort.
Morten Welinder's avatar
Morten Welinder committed
825 826
	Fix permutation.  Speed up things.

827 828 829 830 831
2000-06-07  Jody Goldberg <jgoldberg@home.com>

	* src/format.c (format_number) : Escaped characters trigger a render
	  too.  This code really needs to be rationalized.

832 833 834 835 836
2000-06-07  Darin Adler  <darin@eazel.com>

	* src/history.c: (history_menu_item_create):
	Update name of call so it will compile with the latest Bonobo.

Miguel de Icaza's avatar
Miguel de Icaza committed
837 838
2000-06-06  Miguel de Icaza  <miguel@helixcode.com>

Miguel de Icaza's avatar
Miguel de Icaza committed
839 840
	* src/commands.c (cmd_set_text): Update code.

Miguel de Icaza's avatar
Miguel de Icaza committed
841 842 843
	* src/workbook-edit.c (workbook_auto_complete_destroy): Simplify
	test here. 

844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859
2000-06-06  Jody Goldberg <jgoldberg@home.com>

	* src/workbook.c (workbook_delete_sheet) : Update the undo/redo
	  toolbar and menus.

	* src/sort.c (sort_permute) : Avoid Leak.
	* src/commands.c (cmd_sort_destroy) : Avoid leak.
	(cmd_autofill) : Do not autofill if the target is the same as the
	  source.

	* src/main.c (gnumeric_main) : Fix typo that was breaking minicons.

	* src/item-bar.c (item_bar_end_resize) : Always emit signal.
	(item_bar_event) : On double click emit a signal with newsize == -1 to
	 indicate a need to autosize.

860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887
2000-06-06  JP Rosevear  <jpr@arcavia.com>

	* src/sort.c (sort_position): Call sort_permute with the given
	permutation index
	(sort_contents): Call sort_qsort to get a permutation index and
	then use sort_permute to actually move the rows
	(sort_permute): Use copy and paste to move rows/cols around
	(sort_permute_next): Find next row/col the hasn't been set based
	on the permutation array
	(sort_permute_is_set): Find if a a bit in a bit array is set
	(sort_permute_set): Set a bit in a bit array
	(sort_permute_find): Find a given number in a permutation array
	(sort_qsort): Produce a permutation index for sorting rows or cols 
	(sort_swap): Swap two entries in the permutation index
	(sort_compare_sets): Compare two sets of cells
	(sort_compare_cells): Compare two cells
	(sort_data_destroy): Destroy SortData struct

	* src/commands.c (cmd_sort): Store the new sort data structure
	(cmd_sort_redo): Call sort_contents only if a permutation index
	does not already exist, otherwise use the index with sort_postion
	(cmd_sort_undo): Create an inverse of the permutation index
	if it doesn't already exit to call sort_positon with

	* src/commands.h: New cmd_sort prototype.

	* src/workbook.c (sort_cmd): Reflecting sorting API changes

Jody Goldberg's avatar
Jody Goldberg committed
888 889 890 891 892 893 894 895 896
2000-06-05  Jody Goldberg <jgoldberg@home.com>

	* src/cell.c (cell_relocate) : when relocating the expression
	  be careful to use the offsets when calculating the validity.

	* src/workbook-edit.c (workbook_auto_complete_destroy) : Only remove
	  signal if it has been activated.  Only delete the completer if it
	  exists.

Miguel de Icaza's avatar
Miguel de Icaza committed
897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983
2000-06-05  Miguel de Icaza  <miguel@helixcode.com>

	* src/gnumeric-util.c (gtk_radio_button_select): Add
	precondition.  Chema found this, but we should add the proper
	check at an upper layer.

2000-06-04  Miguel de Icaza  <miguel@helixcode.com>

	* src/gnumeric-util.c (gnumeric_entry_at_subexpr_boundary_p):
	Change prototype to use GtkEntry instead of GtkWidget.

	* src/workbook-edit.c (workbook_finish_editing): Changed direct access to
	workbook->private_entry to workbook_get_entry. 
	(entry_changed): ditto.
	(workbook_start_editing_at_cursor): ditto.
	(workbook_editing_expr): ditto.
	(workbook_edit_get_display_text): ditto.

	* src/workbook.c (autosum_cmd): Changed direct access to
	workbook->private_entry to workbook_get_entry. 
	(do_focus_sheet): ditto.
	(wb_edit_key_pressed): ditto.
	(workbook_setup_edit_area): ditto.

	* src/workbook.c (cb_autofunction): ditto.

	* src/workbook-private.h: Make edit_line a structure to keep track
	of the entry and its signal changed.  Also take a chance to change
	this to the self descriptive GtkEntry instead of GtkWidget.

	* src/commands.c (cmd_set_text): Added const here.

	* src/workbook.c (workbook_do_destroy): Add destroy notification
	for the editing facilities

	* src/item-edit.c (item_edit_set_arg): removed auto complete code
	from here. 

2000-06-03  Miguel de Icaza  <miguel@helixcode.com>

	* src/workbook-edit.c, src/workbook-edit.h: New files.  Moved
	workbook_start_editing_at_cursor, workbook_finish_editing,
	workbook_get_entry, workbook_editing_expr here.  Killed
	workbook_set_entry prototype.

	* src/workbook.c (workbook_start_editing_at_cursor): Moved
	autocomplete here. 

	* src/workbook.h: Removed warning.  #include <config.h> is a
	mandatory header file in every C file.  A correct approach is to
	use something like Nautilus' perl script that verifies the
	presence of config.h as the first include.

	* src/workbook.c (close_cmd): Removed ulgy (void)
	(quit_cmd): More.
	(sheet_action_rename_sheet): more.
	(workbook_finish_editing): Fixed more ugly.

	* src/gutils.c (gnumeric_sys_glade_dir): Fixed ugly indentation.
	(gnumeric_usr_plugin_dir): More ugly stuff fixed.
	(gnumeric_usr_dir): Removed ugly const.

2000-05-02  Miguel de Icaza  <miguel@helixcode.com>

	* src/item-edit.h: New ::entry member, auto_max_size, auto_complete_text

	* src/item-edit.c (item_edit_draw_text): Take an ItemEdit as a
	first argument, and reduce the cluttered arguments we were
	passing.
	(item_edit_draw): Cursor_pos is now only the position, it is not
	overloaded with show/hide cursor as well.
	(item_edit_draw_text): Update acoordingly.
	(item_edit_draw_cursor): This new routine paints the cursor only.
	(item_edit_set_arg): Add a new signal handler for "activated" on
	the entry
	(cb_item_edit_cursor_blink): Removed FIXME.
	(item_edit_set_arg): Init item_edit->entry.  I am pretty sure this
	existed in the past.

2000-05-01  Miguel de Icaza  <miguel@helixcode.com>

	* src/item-edit.c (item_edit_draw): Pass auto-completing flag.
	(item_edit_draw_text): Invert auto-complete region.
	(item_edit_set_arg): Init auto_completing here.
	(item_edit_complete_notify): Set the entry from the
	auto-completing data here.

984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005
2000-06-05  Jody Goldberg <jgoldberg@home.com>

	* src/sheet.c (sheet_cell_expr_{link,unlink}) : renamed from
	  sheet_cell_formula_{link,unlink}.

	* src/cell.c (cell_relocate) : Doh! use the offset flags now that they
	  are being passed.

	* src/clipboard.c (paste_cell) : Renamed from paste_cell_flags.

	* src/expr.c (compare) : value_is_empty_cell -> VALUE_IS_EMPTY.

	* src/value.c (VALUE_IS_EMPTY) : rename from value_is_empty_cell.

	* src/sheet-private.h : Add resize_scrollbar.

	* src/sheet.c (sheet_{col,row}_add) : Use resize_scrollbar flag rather
	  than manually updating the scrolling bar.
	(sheet_update) : Handle resize_scrollbar.
	(sheet_cell_expr_link) : renamed from sheet_cell_formula_link.
	(sheet_cell_expr_unlink) : renamed from sheet_cell_formula_unlink.

Jody Goldberg's avatar
Jody Goldberg committed
1006 1007 1008 1009 1010 1011
2000-06-04  Jody Goldberg <jgoldberg@home.com>

	* src/value.c (value_is_empty_cell) : str == "" is not empty

	* src/expr.c (compare) : comparisons between "" and empty are special.

1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035
2000-06-04  Jody Goldberg <jgoldberg@home.com>

	* src/sheet.c (sheet_cell_add_to_hash) : Set the CELL_IN_SHEET_LIST
	  flag.
	(sheet_cell_remove_from_hash) : Clear the CELL_IN_SHEET_LIST flag.
	(cb_remove_allcells) : Ditto.
	(sheet_cell_formula_link) : Set the CELL_IN_EXPR_LIST flag.
	(sheet_cell_formula_unlink) : Clear the CELL_IN_EXPR_LIST flag.
	(sheet_formulas_unlink) : Ditto.

	* src/clipboard.c (paste_cell_flags) : Take some additional arguments
	  so that pasted cells can potentially have their references made
	  invariant, this is for sorting.
	(clipboard_paste_region) : Pass the additional offsets when
	  PASTE_EXPR_RELOCATE is specified.
	(append_cell_closure_t) : Delete this type.  Move the origin cell info
	  into CellRegion.

	* src/cell.c (cell_copy) : Clear the sheet and associated flags for
	  the copied cell.  This avoids accidentally realizing comments that
	  become undeletable.
	(cell_relocate) : Remove the unlink flag now that we have the
	  additional cell_flags.

Michael Meeks's avatar
Michael Meeks committed
1036 1037 1038 1039
2000-06-02  Michael Meeks  <michael@helixcode.com>

	* Makefile.am (SUBDIRS): remove libole2. duh.

1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062
2000-06-02  Jody Goldberg <jgoldberg@home.com>

	* src/selection.c (sheet_selection_reset) : Delete unused routine.
	(sheet_selection_to_list) : Ditto.

	* src/item-cursor.c (item_cursor_autofill_event) : Use new undoable
	  version of autofill.

	* src/corba-sheet.c (Sheet_selection_reset) : Delete.

	* src/commands.c (cmd_area_set_text_undo) : We want to restore
	  formulas, not values.
	(cmd_clear_selection) : Paste by value should be exclusive of paste by
	  formula.
	(cmd_autofill_*) : New functions.

	* idl/Gnumeric.idl : Remove useless function selection_reset.

	* src/number-match.c (format_match) : Handle numbers larger than
	  LONG_{MAX,MIN} by falling through to double.

	* src/sheet.c (sheet_recompute_spans_for_col) : Use closure.

1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098
2000-06-01  Jody Goldberg <jgoldberg@home.com>

	* src/xml-io.c (xml_sheet_write) : Adjust to changes in
	  sheet_foreach_colrow.

	* src/sheet.c (sheet_foreach_colrow) : Adjust signature.
	(colrow_compute_pixels_from_pts) : Adjust to changes in sheet_foreach_colrow.
	(sheet_set_zoom_factor) : Ditto.
	(cb_recalc_spans_in_col) : Ditto.
	(sheet_recompute_spans_for_col) : Ditto.
	(cb_colrow_compute_pixels_from_pts) : New function wrapper.
	(sheet_find_boundary_{horizontal,vertical}) : Fix case of being on the
	  last non-blank element of a col/row and jumping to the far edge.
	(sheet_move_range) : Redraw prior to moving incase the src region
	  contains a span.

	(sheet_redraw_cell_region) : Be more intelligent about skipping over
	  large empty regions.
	(sheet_cell_foreach_range) : Ditto.

	(cb_check_array_{horizontal,vertical}) : new functions.
	(sheet_range_splits_array) : Rewrite to be use sheet_foreach_colrow.

	* src/selection.c (sheet_selection_cut) : Adjust to changes in
	  sheet_range_splits_array.

	* src/commands.c (cmd_paste_cut_undo) : Select the src range when
	  undoing a cut.  This seems like a nice effect.

	* src/colrow.c (cb_set_row_height) : Adjust to the changes in
	  sheet_foreach_colrow.

	* src/auto-format.c (auto_format_suggest) : Make static.

	* src/gnumeric-util.c (gnumeric_wb_dialog_run) : Silence warning.

1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114
2000-06-02  Jon K Hellan  <hellan@acm.org>

	* src/gnumeric-util.c (gnumeric_wb_dialog_run): Do not set parent
	if parent is already the right one. This avoids unwanted moving of
	already displayed dialogs.

	* src/about.c: Make sure it is only popped up once
	(cb_closed): New callback to remove dialog from workbook window's
	object data.
	(dialog_about): Check if dialog exists as object data on workbook
	window. If so, raise dialog window instead of creating a new one.
	Otherwise store dialog as object data, and connect signal handler
	for "close".  Replace calls to gnome_dialog_set_parent,
	gnome_dialog_set_close and gtk_widget_show with a call to
	gnumeric_dialog_show which does it all.

Michael Meeks's avatar
Michael Meeks committed
1115 1116 1117 1118 1119 1120
2000-05-30  Michael Meeks  <michael@helixcode.com>

	* src/Makefile.am (gnumeric_libs): kill libole2 hack.

	* configure.in: kill CONFIG_SUBDIRS for libole2.

1121 1122 1123 1124 1125 1126 1127 1128
2000-05-31  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/dialogs/dialog-stf.c :
	(stf_dialog_druid_page_cancel) : Remove misplaced gtk_main_quit.

	* src/dialogs/dialog-stf-export.c :
	(stf_export_dialog_druid_page_cancel) : Idem.

1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140
2000-06-01  Kenneth Christiansen <kenneth@gnu.org>

        * po/desk.pl, po/update.pl: Two new scripts for helping 
        translation/i18n maintainance of Gnumeric

        * po/README.tools: Added readme file, which explains the
        use of the newly checked in po tools.

	* NEWS: Added notice about this

        Please go read.

1141 1142
2000-05-31  Jody Goldberg <jgoldberg@home.com>

1143 1144
	* configure.in : Improve naming for libxml messages.

1145 1146 1147
	* src/functions/fn-information.c (gnumeric_countblank) : Fix typo
	  reported by <matasmi@iki.fi> Bug 12428.

1148 1149 1150 1151 1152 1153
	* src/sheet.c (sheet_move_range) : invalidate destination before
	  adjsuting src to point to dst.
	(cmd_paste_cut_*) : keep a list of displaced content, not just the
	  lost bits of the destination range, but also the portions of the src
	  that are out of range.

Jody Goldberg's avatar
Jody Goldberg committed
1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174
2000-05-31  Jody Goldberg <jgoldberg@home.com>

	* src/commands.c (cmd_ins_del_row_col_destroy) : Fix leak.
	(cmd_paste_cut_*) : We do need to worry about invalidations.  Any
	  references to the portions of the destination region that do not
	  overlap the src region get invalidated.

	* src/ranges.c (range_translate) : Adjust the semantics so that the
	  result warns of a range that was translated completly out of bounds.

	* src/sheet.c (sheet_move_range) : Invalidate the references to the
	  portions of the destination range that do NOT overlap with the src.
	(sheet_shift_{cols,rows}) : Rename and move to..
	* src/cmd-edit.c (cmd_shift_{cols,rows}) : here.  Use cmd_paste_cut
	  instead of sheet_move_range directly.

	* src/dialogs/dialog-{insert,delete}.c : Switch to cmd_shift_{cols,rows}.

	* src/history.c (history_menu_insert_separator) : Add a more detailed
	  explaination when the history lookup fails.

1175 1176 1177 1178 1179
2000-05-30  Morten Welinder  <terra@diku.dk>

	* src/format.c (find_decimal_char): Remove over-constification.
	(format_remove_decimal): Terminate the copy properly.

1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204
2000-05-30  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/dialog-printer-setup.c (enum MarginOrientation): Add
	MARGIN_NONE for use with set_horizontal/vertical_bounds.
	(spin_button_set_bound): New function. Allow the value in spin
	button to increase by at most space_to_grow.
	(get_printable_width): New function. Return page width minus
	margins in specified unit.
	(get_printable_height): New function. Return page height minus
	margins, header and footer in specified unit.
	(set_horizontal_bounds): New function. Set the upper bounds for
	left and right margins.
	(set_vertical_bounds): New function. Set the upper bounds for
	top/bottom margins, headers and footers.
	(draw_margin): Add default branch to silence warning - MARGIN_NONE
	now exists.
	(canvas_update): Update bounds for margins when paper size has
	changed.
	(spin_button_adapt_to_unit): New function. Select suitable
	increments and number of digits for the unit.
	(do_convert): Call function above.
	(unit_changed): Update bounds for margins when a margin has
	changed.
	(unit_editor_configure): Call spin_button_adapt_to_unit.

1205 1206 1207 1208
2000-05-29  Jody Goldberg <jgoldberg@home.com>

	* src/commands.c (cmd_ins_del_row_col_undo) : Bounds are inclusive.

Jody Goldberg's avatar
Jody Goldberg committed
1209 1210 1211 1212
2000-05-29  Jody Goldberg <jgoldberg@home.com>

	* src/item-grid.c (create_popup_menu) : translate the menu labels.

1213 1214 1215 1216 1217 1218 1219
2000-05-27  Michael Meeks  <michael@helixcode.com>

	* src/sheet-object-bonobo.c (sheet_object_bonobo_load),
	(sheet_object_bonobo_load_from_file): update for new PersistStream API.

	* configure.in (gnumeric_executable): check for bonobo 0.14

1220 1221 1222 1223 1224
2000-05-29  Jody Goldberg <jgoldberg@home.com>

	* src/expr.c (cellrange_relocate) : Only relocate a range if both
	  elements need relocation.

1225 1226 1227 1228 1229 1230 1231 1232 1233 1234
2000-05-29  Jody Goldberg <jgoldberg@home.com>

	* src/xml-io.c (xml_workbook_write) : Arrrggh.  textdomain seems to
	  use a static buffer.  We need to strdup the result.  A more thorough
	  reading of the docs suggests that changing the textdomain is
	  completely wrong.  It is not doing what I had originally thought at
	  all.  Any idea what the correct solution would be ?  I'll patch this
	  for now because 12461 is serious, and this does solve the problem,
	  even if the solution is crap.

1235 1236
2000-05-29  ERDI Gergo  <cactus@cactus.rulez.org>

1237 1238
	* src/commands.c: Including dialogs/dialog-autocorrect.h (warning fix)

1239 1240 1241
	* src/workbook.c (workbook_create_standard_toobar): Turn off the
	button reliefs on the toolbar

1242 1243 1244 1245 1246 1247 1248 1249 1250 1251
2000-05-28  ERDI Gergo  <cactus@cactus.rulez.org>

	* src/workbook.c: Create and insert GtkComboStacks into the
	toolbar for Undo/Redols

	* src/commands.c: Use the new undo/redo stack methods

	* src/workbook-view.[ch]: Several new methods to modify the user interface
	to the undo/redo stack

1252 1253 1254 1255 1256 1257
2000-05-28  Jody Goldberg <jgoldberg@home.com>

	* src/commands.c (cmd_paste_copy_undo) : The first time through we
	  transpose.  After that we are jsut replace the old content.  no
	  transpose needed.

1258 1259 1260 1261
2000-05-28  Jody Goldberg <jgoldberg@home.com>

	* src/commands.c (cmd_paste_copy_undo) : handle paste errors.
	(cmd_paste_copy_destroy) : do not release unless we are permitted to.
1262 1263
	(cmd_paste_copy) : When pasting a transpose we are more lenient about
	  resizing things.  I am not sure I agree with this behavior.
1264 1265 1266 1267 1268 1269 1270 1271

	* src/clipboard.c (clipboard_paste_region) : Return a boolean
	  indicating success or failure.

2000-05-27  Jody Goldberg <jgoldberg@home.com>

	* src/clipboard.c (clipboard_paste_region) : Off by one error.

1272 1273
2000-05-27  Jody Goldberg <jgoldberg@home.com>

1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285
	* src/sheet.c (sheet_update) : When recalulating all spans, we may
	  need to render some cells too.
	(sheet_move_range) : Do not call sheet_update here.
	(sheet_shift_rows) : Call it here.
	(sheet_shift_cols) : and here.

	* src/commands.c (cmd_paste_cut_undo) : Do a recalc.
	(cmd_paste_cut_redo) : No need to force a status range update, move
	  already did that.

	* src/cmd-edit.c (cmd_paste) : typo.

1286 1287 1288 1289 1290
	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Chift/Ctrl
	  space are not active while editing.

	* src/workbook.c (function_druid) : Disable until this works better.

1291 1292 1293 1294 1295 1296
	* src/commands.c (cmd_paste_copy_undo) : Mark the sheet as dirt, and
	  do a recalc.

	* src/clipboard.c (clipboard_paste_region) : flag the need to
	  potentially update the status range.

1297 1298 1299 1300
2000-05-27  Jody Goldberg <jgoldberg@home.com>

	* src/clipboard.c (x_selection_received) : Do not try to paste if the
	  conversion was canceled.
1301
	(clipboard_paste_region) : Respan/rerender as necessary after pasting.
1302

1303 1304 1305 1306 1307 1308 1309 1310 1311
2000-05-27  Jody Goldberg <jgoldberg@home.com>

	* src/commands.c (cmd_paste_copy) : Move the handling of singletons
	  and the setting of the selection here.
	* src/clipboard.c (clipboard_paste_region) : From here.

	* src/cmd-edit.c (cmd_paste_to_selection) : Remove incorrect
	  precondition.

Valek Frob's avatar
Valek Frob committed
1312 1313 1314 1315 1316
2000-05-27  Valek Filippov  <frob@df.ru>

	* src/functions/fn-math.c, fn-stat.c, fn-lookup.c: typos in
	description fixed.

1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371
2000-05-27  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/dialogs/stf-parse.c: 
	(stf_parse_options_set_trim_spaces): New function.
	(stf_parse_csv_cell): Modified so it can trim spaces in 
	several ways
	(stf_parse_fixed_cell): Ditto.
	(stf_parse_get_longest_row_width) : Fixed small bug which
	caused incorrect width to be returned.

	* src/dialogs/dialog-stf.glade:
	Added trim spaces option and did some general polishing.
	
	* src/dialogs/dialog-stf.h:
	Added new member to DruidPageData_t which indicates weather
	the user wants to trim spaces and in which way.
	
	* src/dialogs/dialog-stf-main-page.c:
	(stf_dialog_main_page_init): Modified so it loads the trim optionmenu.
	(main_page_trim_menu_deactivate): New.

	* src/dialogs/dialog-stf-csv-page.c:
	(stf_dialog_csv_page_prepare): Now sets the trim member of the parse
	options struct.

	* src/dialogs/dialog-stf-fixed-page.c:
	(stf_dialog_fixed_page_prepare): Now sets the trim member of the 
	parse options struct.
	(stf_dialog_fixed_page_prepare): Did not honor the from/to line 
	settings.
	(fixed_page_remove_clicked): Added gnumeric_clist_moveto to make 
	selection visible.
	(fixed_page_add_clicked): Ditto.

	* src/dialogs/dialog-stf-format-page.c:
	(format_page_canvas_button_press_event): Modified to use
	gnumeric_clist_moveto
	(format_page_collist_select_row): Ditto.
	(format_page_format_changed): Ditto.
	(stf_dialog_format_page_prepare): Ditto.
	
	* src/gnumeric-util.c, src/gnumeric-util.h:
	(gnumeric_option_menu_get_selected_index): New function, Returns
	the selected index of a GtkOptionMenu. (Originally from
	dialog-stf-export-format-page.c)	

	* src/dialogs/dialog-stf-export-format-page.c:
	(stf_export_dialog_option_menu_index): Removed.
	(sheet_page_separator_menu_deactivate): Modified to use the new
	gnumeric_option_menu_get_selected_index.
	(stf_export_dialog_format_page_result): Ditto.

	* doc/stf-parser.txt:
	Update documentation.
	
Jody Goldberg's avatar
Jody Goldberg committed
1372 1373 1374 1375
2000-05-26  Jody Goldberg <jgoldberg@home.com>

	* src/clipboard.c (clipboard_paste_region) : Fix typo, and thinko.

1376 1377
2000-05-26  Jody Goldberg <jgoldberg@home.com>

1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418
	* src/selection.c (selection_is_simple) : Use a command context.
	(sheet_selection_paste) : Delete.

	* src/plugin.c : rename error_plugin_problem -> error_plugin.

	* src/item-grid.c (context_paste_cmd) : Use cmd_paste_to_selection.
	(context_paste_special_cmd) : Ditto.

	* src/gnumeric-sheet.c : remove cached 'controlling_entry' in
	  preparation for the function druid.

	* src/corba-sheet.c : Delete Sheet_selection_paste.
	  this will need to be replaced with a new signature.

	* src/item-cursor.c (item_cursor_do_action) : Use new cmd_paste.

	* src/commands.c (cmd_area_set_text_{undo,redo}) : Use new
	  clipboard_paste_region.
	(cmd_ins_del_row_col_{undo,redo}) : Ditto.
	(cmd_clear_{undo,redo}) : Ditto.
	(cmd_set_date_time_{undo,redo}) : Ditto.
	(cmd_paste_cut_*) : new functions.

	* src/command-context*.c : Add progress, remove splits_array.

	* src/cmd-edit.c (cmd_paste) : New function.
	(cmd_paste_to_selection) : New function.

	* src/clipboard.c : Reorganize/rewrite.
	(clipboard_paste_region) : paste content.
	(clipboard_paste) : paste content from clipboard or X selection.
	(paste_target_init) : New function.
	(sheet_paste_selection) : merge into clipboard_paste_region.

	* src/application.c (application_clipboard_copy) : rename
	  clipboard_copy_cell_range -> clipboard_copy_range.

	* idl/Gnumeric.idl : Merge InvalidValue, SplitsArray -> InvalidCmd.

	* src/workbook.c (workbook_setup_status_area) : Include a progress bar.

1419 1420
	* src/sheet.c (sheet_update) : SPANCALC_NO_DRAW exists now.

1421 1422 1423 1424 1425
2000-05-26  Michael Meeks  <michael@helixcode.com>

	* src/sheet.c (sheet_update): corrent SPANCALC_NO_DRAW to
	SPANCALC_RESIZE since the former does not exist.

1426 1427 1428 1429 1430
2000-05-26  ERDI Gergo  <cactus@cactus.rulez.org>

	* src/dialogs/dialog-printer-setup.c (unit_editor_configure):
	Hilight the currently edited margin

1431 1432
2000-05-25  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
1433 1434 1435 1436 1437
	* src/sheet.c (sheet_update) : Only redraw forech cell if we will not
	  be redrawing everything later.
	(sheet_{insert,del}_{cols,row}) : Mark the need to recompute spans on
	  next update.

1438 1439 1440 1441
	* src/print.c (print_{headers, footers}) : Headers and footers are
	  offset from the edge of the page by their own margins.  MS appears
	  to assume the order is edge -> header -> top.

1442 1443 1444 1445 1446 1447
2000-05-26  ERDI Gergo  <cactus@cactus.rulez.org>

	* src/dialogs/dialog-printer-setup.c (draw_margin): Draw
	header/footer space correctly (computed in accordance to the
	top/bottom margins)

1448 1449 1450 1451 1452
2000-05-25  ERDI Gergo  <cactus@cactus.rulez.org>

	* src/dialogs/dialog-printer-setup.c: The small page icon reflects
	the actual margin values

1453 1454 1455 1456
2000-05-25  Valek Filippov  <frob@df.ru>

	* src/dialog/print.glade.h: insert /* xgettext: no-c-format */

1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516
2000-05-25  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/dialog-printer-setup.c: Add an option menu for
	selecting units to the margin page.  Read entire dialog from guile
	file rather than just reading contents and reparenting into a new
	GnomeDialog.
	(dialog_print_info_t): Add conversion_listeners list.
	(convert_to_{pt|mm|cm|in): These are no longer called directly as
	callbacks, so the unused widget parameter has been removed.
	(listeners_convert): New callback function invoked when a new unit
	has been selected. Receives a conversion function as callback data
	and invokes it on all the registered conversion listeners.
	(add_unit): Add dpi parameter. Remove data parameter. Connect
	listeners_convert.
	(unit_editor_new): Rename to unit_editor_configure. Connect target
	to existing spinbutton in glade dialog. Add dialog_print_info and
	spin button name parameter. Replace PrintUnit parameter with
	points and units. Use unit parameter instead of hardcoded
	centimeters. Register unit editor as a conversion listener. Make
	<Ret> in spin buttons invoke "OK". Remove deactivated code to
	display a unit selector for each margin.
	(tattach): Remove.
	(do_setup_margin): Use the top margin unit for display and ignore
	desired display for the others. Configure unit selector option
	menu. Call unit_editor_configure for each margin - previously
	unit_editor_new was called via tattach. Pack preview canvas in
	container instead of explicitly in table. Thus, the code no longer
	contains table coordinates, and the glade file can safely be
	changed.
	(do_setup_page): Make <Ret> in spin buttons and combo invoke "OK".
	(do_setup_main_dialog): Remove dialog reparenting hack -
	GnomeDialogs are now fully supported in Glade. Remove explicit
	focusing - now done in Glade file.
	(dialog_print_info_destroy): Free conversion listeners.
	(do_setup_page_info): Make <Ret> in entry fields and combo invoke
	"OK".

	* src/dialogs/print.glade(.h?): Turn into a complete GnomeDialog.
	Set consistent internal border in notebook pages. Rename rightmost
	page from "page" (used for two pages) to "sheet".
	(page page): Give meaningful name to first page number combo. Make
	it insensitive.
	(margin page): Add an option menu for units. Include spin buttons
	in glade file. Tweak layout.
	(sheet page): Give meaningful names to print area entry and
	comments combo. Make them insensitive.
	
	* src/dialogs/cell-format.glade: Add focus target to
	format_symbol_label to make Number/Currency/S_ymbol accelerator
	work.

	* src/dialogs/autocorrect-exceptions.glade: Add internal border to
	notebook pages.

	* src/dialogs/workbook-attr.glade: Add internal border to notebook
	pages and frames.

	* src/dialogs/dialog-workbook-attr.c (attr_dialog_impl): Set
	dialog title.

1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557
2000-05-24  Morten Welinder  <terra@diku.dk>

	* src/main.c (gnumeric_main): Style now needs to be initialised
 	before formats.

	* src/number-match.c (format_match): Take a StyleFormat ** instead
 	of a char ** for the suggested format.  All callers changed.
	(format_parse_t): rename member format to format_str and
 	introduce new member format, a StyleFormat *.
	(format_match_define): Get a style at this point.

	* src/datetime.c (datetime_value_to_serial_raw): Don't supply a
 	format return variable to format_match since we aren't interested
 	in the result.

	* src/parse-util.c (parse_text_value_or_expr): Return a
 	StyleFormat * instead of a char *.  All callers changed.

	* src/expr.c (expr_parse_string): Take a StyleFormat ** instead of
 	a char ** for the suggested format.  All callers changed.

	* src/parser.y (make_string_return): Turn parser_desired_format
 	into a StyleFormat **.
	(gnumeric_expr_parser): Take a StyleFormat ** instead of a char **
 	for the suggested format.  All callers changed.

	* src/auto-format.c (auto_style_format_suggest): New function.


	* src/sheet-style.c (sheet_style_optimize): Include adjacent
 	ranges in the list of styles to consider.  Handle intervening
 	styles better.  Don't stop searching for matching pairs just
 	because we merge -- only when the merge kills the slave.

	* src/ranges.c (range_dump): Don't print "\n".  All callers
 	changed as needed.

	* src/sheet-style.c (sheet_style_optimize, sheet_styles_dump):
 	Send all debugging output to stderr.  (As opposed to half stderr
 	and half stdout.)

1558 1559
2000-05-24  Jody Goldberg <jgoldberg@home.com>

1560 1561 1562
	* src/file.c (workbook_import) : set the import dialog's parent widget
	  to be the PARENT workbook, not the new unrealized workbook.

1563 1564 1565 1566 1567
	* src/cell.c (cell_set_expr_internal) : Actually assign the format
	  after we ref it.
	(cell_get_format) : Cells with format 'General' may appear to have
	  a format via autoformat or via the text that was entered.

Jody Goldberg's avatar
Jody Goldberg committed
1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582
2000-05-21  Jody Goldberg <jgoldberg@home.com>

	* src/cmd-edit.[ch] : New files.

	* src/workbook.c (cb_edit_select_*) : Use the cmd-edit utilities.
	Make a 'select' sub menu of edit.

	* src/sheet.c : Use the newly added CellPos in each Cell rather than
	  mallocing a seperate struct.

	* src/selection.c (sheet_select_all) : Move.

	* src/gnumeric-sheet.c (gnumeric_sheet_key_mode_sheet) : Make the
	  selection commands accelerators.

1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596
2000-05-21  Jon K Hellan  <hellan@acm.org>

	* src/gnumeric-util.[ch] (gnumeric_toolbar_insert_with_eventbox):
	(gnumeric_toolbar_append_with_eventbox): New functions. Pack
	widget in eventbox and add eventbox to toolbar. This lets a
	windowless widget (e.g. combo box) have tooltips.

	* src/workbook-format-toolbar.c (workbook_create_format_toolbar):
	Enable tooltips for combo boxes. We do this by using
	gnumeric_toolbar_{insert|append}_with_eventbox instead of 
	gtk_toolbar_{insert|append}_widget.

	* src/workbook.c (workbook_create_standard_toobar): Ditto

1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609
2000-05-21  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/dialog-zoom.glade: Remove label from invisible
	column title.

	* src/dialogs/plugin-manager.glade(.h?): Add accelerators to
	notebook tabs.
	
	* src/dialogs/autocorrect-exceptions.glade(.h?): Add accelerators to
	buttons on notebook pages.

	* src/dialogs/workbook-attr.glade(.h?): Ditto.

Jody Goldberg's avatar
Jody Goldberg committed
1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659
2000-05-17  Jody Goldberg <jgoldberg@home.com>

	* src/clipboard.c (clipboard_copy_cell_range) : Adjust signature to
	  take a range.
	(sheet_paste_selection) : Export in preparation for adding undo.

	* src/commands.c (cmd_paste_copy) : Some initial work.  Not used or
	  complete.

	* src/parse-util.c (parse_text_value_or_expr) : Start passing in the
	  current format so that we can eventually attempt to match it before
	  trying all the others.

	* src/sheet.c (sheet_formulas_unlink) : New function.
	(sheet_destroy_contents) : Optimize.

	* src/dialogs/dialog-plugin-manager.c : Make a bit prettier.
	* src/dialogs/plugin-manager.glade : Ditto.

2000-05-16  Jody Goldberg <jgoldberg@home.com>

	* plugins/*/*.c : Rationalize the naming scheme.

2000-05-15  Jody Goldberg <jgoldberg@home.com>

	* src/eval.[ch] : Rename
	  cell_queue_recalc      -> eval_queue_cell
	  cell_queue_recalc_list -> eval_queue_list
	  cell_unqueue_recalc    -> eval_unqueue_cell
	(eval_unqueue_sheet) : New function.

	* src/sheet.c (sheet_cell_remove_simple) : Add precautionary removal
	  of cells from recalc list.  We should not need this in most
	  instances, but the check is inexpensive so I'll play it safe.
	(sheet_destroy_contents) : Batch cleanups rather than doing it cell by
	  cell.

	* src/cell.c (cell_make_value) : Fill in the implementation.

	* src/clipboard.c (paste_cell_flags) : Remove some dead code.
	  Merged in paste_cell and fixed handling of paste by value.

2000-05-14  Jody Goldberg <jgoldberg@home.com>

	* src/clipboard.c (paste_cell) : No need to call cell_content_changed
	  we can queue the recalc for the entire region later.  It is
	  sufficent to make the cell as changed with sheet_cell_changed.
	(paste_cell) : It is premature to redraw, we have no yet calculated
	  spans.  Redraw and respan at the range level, not the cell.

1660 1661
2000-05-20  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
1662 1663 1664 1665 1666 1667 1668
        * Release 0.54

2000-05-20  Jody Goldberg <jgoldberg@home.com>

	* src/print-cell.c (print_cell_range) : Don't draw background if we
	  are just sizing things.

1669 1670
	* configure.in : Bump reqs.  libglade >= .13, gnome-print .20

1671 1672 1673
	* src/workbook-format-toolbar.c (change_selection_font) : Add strikethrough.
	({bold,italic,underline}_cmd) : Handle accelerators too.

1674 1675 1676
	* src/cellspan.c (cell_calc_span) : Do not overlap spans when using
	  center across selection.

1677 1678 1679
	* src/application.c (application_set_selected_sheet) : We still need
	  to partially clear the clipboard when short circuiting.

1680 1681 1682 1683 1684 1685
	* src/item-grid.c (item_grid_draw) : Do not draw the contents of
	  hidden spanning rows/cols.
	* src/print-cell.c (print_cell_range) : Ditto.

	* src/colrow.c (cb_row_col_visibility) : Be careful not to compare
	  TRUE for equality.
1686

1687
	* src/cell.c (cell_copy) : Ref the format if one exists.
Jody Goldberg's avatar
Jody Goldberg committed
1688 1689 1690 1691 1692 1693 1694 1695 1696
	(cell_set_format) : Apply the format to a NEW style, not the current
	   style which may be say .... the DEFAULT!!!

	* src/sheet.c (sheet_update) : Update cursor positions when visibility
	  changes.
	(sheet_clear_region) : When clearing formats we need to update the
	  spans and sizes of the contents.
	(sheet_update_cursor_pos) : New function.
	(sheet_row_col_visible) : changing the status of a row/col changes visibility.
1697 1698 1699 1700 1701 1702
	(sheet_update_cursor_pos) : warning suppression.
	(sheet_row_col_visible) : Be careful not to compare TRUE for equality.
	(sheet_clear_region) : respan both sides of a singleton row/col.
	  Check for cells to either side even if there is no span,  if we are
	  directly adjacent to a cell it would have no span even if it wanted
	  one.
Jody Goldberg's avatar
Jody Goldberg committed
1703 1704 1705 1706

	* src/sheet-view.c (sheet_view_update_cursor_pos) : New function split
	  out from sheet_view_set_zoom_factor.
	(sheet_view_set_zoom_factor) : Use sheet_view_update_cursor_pos.
1707

1708 1709 1710
	* src/colrow.c (cb_set_row_height) : Only set the height if it
	  changed.

Jody Goldberg's avatar
Jody Goldberg committed
1711 1712 1713
	* src/application.c (application_set_selected_sheet) : No need to
	  clear the X selection if we already own it.

1714 1715 1716 1717 1718 1719 1720 1721 1722
	* src/commands.c (cmd_format_undo) : It is necessary to respan, resize
	  things when some format elements change.

	* src/sheet-style.c (sheet_range_apply_style) : Changing the word
	  wrapping changes the size, changing the underline or strikethrough
	  does not.
	(required_updates_for_style) : Split out from sheet_range_apply_style.
	(sheet_style_attach_list) : Track the types of updates required.

1723 1724
2000-05-18  Jody Goldberg <jgoldberg@home.com>

1725 1726 1727 1728 1729
	* src/xml-io.c (xml_workbook_read) : Set the textdomain as well as the
	  LC_NUMERIC so that things like TRUE/FALSE do not get translated
	  while persisting.
	(xml_workbook_write) : Ditto.

Jody Goldberg's avatar
Jody Goldberg committed
1730 1731 1732 1733 1734 1735
	* src/sheet-style.c (sheet_style_optimize) : We can not merge (in any
	  dimension) if there is an intervening style that partially overlaps.

	* src/ranges.c (range_adjacent) : Tweak to increase readability,
	  and delete dead code.

1736 1737 1738 1739 1740
	* src/sheet-object.c (sheet_button_press) : Minor patch so that
	  objects begin with a non zero size.  This needs to be reworked into
	  a more general technique so that a 0 sized object is not possible in
	  instances when that should be disabled.

1741 1742 1743 1744
	* src/print-cell.c (print_cell) : Correct double negative that was
	  breaking printing for cells with multiple lines that were bottom
	  or center aligned.

1745 1746
	* src/normal-args.c : Adjust includes to remove warning.

Michael Meeks's avatar
Michael Meeks committed
1747 1748 1749 1750
2000-05-18  Michael Meeks  <michael@helixcode.com>

	* configure.in: Bump required GB version.

1751 1752 1753 1754 1755
2000-05-16  Michael Meeks  <michael@helixcode.com>

	* configure.in: Kill libole2 path check, add CONFIG_SUBDIRS
	(EXTRA_GNOME_*): remove libole2.

1756 1757
2000-05-17  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768
	* src/summary.c (summary_item_as_text) : Be careful to strdup all strings.
	(g_str_case_equal) : Delete duplicate.
	(g_str_case_hash) : Delete duplicate.
	(summary_info_new) : Use gnumeric_strcase_hash & gnumeric_strcase_equal.

	* src/workbook-cmd-format.c (workbook_cmd_format_{column,row}_auto_fit) :
	  Only mark the sheet as dirty if something was changed.

	* src/stf.c (stf_read_workbook) :  Bring up to date.

	* src/xml-io.c (xml_write_attributes) : Do not use freed memory.
Jody Goldberg's avatar
Jody Goldberg committed
1769
	(xml_workbook_write) : Free the args.
Jody Goldberg's avatar
Jody Goldberg committed
1770 1771 1772 1773

	* src/item-bar.c (item_bar_event) : Autosizing an empty row/col
	  returns 0.

Jody Goldberg's avatar
update  
Jody Goldberg committed
1774 1775 1776
	* configure.in : Update required version of bonobo to 0.13.
	* README : Ditto.

1777 1778 1779 1780 1781 1782 1783 1784 1785 1786
	* src/cell-draw.c (cell_draw) : Cache the vertical alignment, and
	  ensure that verticaly justified lines do not overlap.
	* src/print-cell.c (print_cell) : Ditto.

	* src/sheet-object.c (sheet_set_mode_type_full) : Add a prototype to
	  avoid warnings.

	* src/sheet-object.c (create_object) : Ugly workaround for bug 9984.
	  Ensure that objects do not start with size 0,0.

Jody Goldberg's avatar
Jody Goldberg committed
1787 1788 1789 1790 1791 1792 1793 1794
	* src/workbook.c (workbook_expr_relocate) : Add missing
	  initialization.

	* src/file.c (file_finish_load) : New function to finish loading after
	  a read or import.
	(workbook_read) : Use here.
	(workbook_import) : And here.

1795 1796
	* src/sheet.c (sheet_get_extent) : Disable the use of
	  sheet_style_get_extent until it is more intelligent.
Jody Goldberg's avatar
Jody Goldberg committed
1797 1798
	(sheet_{insert,delete}_{cols,rows}) : Flag that the range content has
	  changed so that the status areas will be updated.
Jody Goldberg's avatar
Jody Goldberg committed
1799
	(sheet_{col,row}_size_fit_pixels) : Return 0 if there are no cells.
1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813

	* configure.in : Produce a Using OAF message in the non-bonobo case
	  too.  Limit xml to version 1.x for now.

	* src/cell.c (cell_set_text_and_value) : Set the entered_text BEFORE
	  the value so that cells with format = text render correctly.

2000-05-16  Jody Goldberg <jgoldberg@home.com>

	* src/sheet-autofill.c (autofill_cell) : Init the RewriteInfo::type.

	* src/clipboard.c (paste_cell) : Cells need acurate locations before
	  relocation.  This is not pretty, but it is functional.

Karl Eichwalder's avatar
Karl Eichwalder committed
1814 1815 1816 1817
2000-05-16  Karl Eichwalder  <ke@suse.de>

	* NEWS (Translations): Add gl.

1818 1819 1820 1821 1822
2000-05-16  Karl Eichwalder  <ke@suse.de>

	* gnumeric.spec.in: Use %{version}, %{name} and %{sysconfdir} more
	consistently. Avoid long lines.

1823 1824 1825 1826 1827
2000-05-15  Jesus Bravo Alvarez  <jba@pobox.com>

	* configure.in: Added gl (Galician) to ALL_LINGUAS
	* gnumeric.desktop.in: Added Galician translation

1828 1829 1830 1831 1832
2000-05-15  Jody Goldberg <jgoldberg@home.com>

	* src/functions/fn-math.c (gnumeric_floor) : Add some examples for
	  negatives.

Karl Eichwalder's avatar
Karl Eichwalder committed
1833 1834 1835 1836
2000-05-15  Karl Eichwalder  <ke@suse.de>

	* NEWS (Translations): Add de, no, and sv.

1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848
2000-05-14  Jody Goldberg <jgoldberg@home.com>

	* src/commands.h : Reformat.

	* src/commands.c (cmd_ins_del_row_col_{undo,redo}) : unant the
	  selection when the topology changes.

	* src/workbook.c (workbook_expr_relocate) : Fix typo.

	* src/sheet-view.c (sheet_view_{col,row}_selection_changed) : Call
	  sheet_update after a change.

1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867
2000-05-11  Michael Meeks  <michael@helixcode.com>

	* src/embeddable-grid.c (grid_view_activate): grab widget focus.

	* src/workbook-format-toolbar.c (workbook_feedback_set): make it
	cope with no format toolbar.

	* src/workbook.c (workbook_init): g_new0 for safety and to blank
	edit_line.

	* src/embeddable-grid.c (grid_view_new): set a sensible default
	size so we actually see something. (grid_view_activate): Fix with
	state boolean. (set_header_visibility): implement.
	(embeddable_grid_set_header_visibility): update.
	(grid_view_destroy): kill. (grid_view_new): kill evil private list
	of views.

	* gnumeric.oafinfo: another fix, evil bug from oaf conversion script.

1868 1869 1870 1871 1872
2000-05-11  Jon K Hellan  <hellan@acm.org>

	* src/workbook.c (workbook_rename_sheet): Don't make "Duplicate
	sheet name" message if sheet name did not change.

Michael Meeks's avatar
Michael Meeks committed
1873 1874 1875 1876 1877 1878 1879 1880
2000-05-11  Michael Meeks  <michael@helixcode.com>

	* src/Makefile.am (gnumeric_libs): kill libole2 libs kludge.

2000-05-10  Michael Meeks  <michael@helixcode.com>

	* configure.in: Add check for libole2 and add to gnome-config.

Karl Eichwalder's avatar
Typo.  
Karl Eichwalder committed
1881 1882 1883 1884
2000-05-10  Karl Eichwalder  <ke@suse.de>

	* Makefile.am: Typo.

1885 1886 1887 1888 1889 1890 1891 1892 1893
2000-05-10  Jody Goldberg <jgoldberg@home.com>

	* src/workbook-format-toolbar.c (workbook_format_toolbar) : Add
	  accelerators for Bold, Underline, and Italic.
	(workbook_create_format_toolbar) : Pass accel_group.

	* src/workbook.c (workbook_create_standard_toobar) : Pass the
	  acceleration group to the toolbar.

1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929
2000-05-10  Jon K Hellan  <hellan@acm.org>

	* src/dialogs/dialog-analysis-tools.c (dialog_data_analysis):
	Use gnumeric_clist_moveto to ensure that selected tool is visible.
	
	* src/dialogs/dialog-function-select.c (category_list_fill):
	s/current sheet/selected category/
	(function_list_fill): s/category/function/

	* src/dialogs/dialog-zoom.c (dialog_zoom_impl):
	s/selected function/current sheet/

	* src/dialogs/dialog-cell-format.c (fmt_dialog_init_format_page):
	Use gnumeric_clist_make_selection_visible to ensure that list rows
	are visible.

	* src/dialogs/dialog-sheet-order.c (dialog_sheet_order_impl): 
	s/list rows/current sheet/
	
	* src/gnumeric-util.c (clist_moveto): New helper function scroll
	list so that row becomes visible.
	(cb_clist_moveto): New callback function:
	Disconnect callback and use clist_moveto to make row visible.

	* src/gnumeric-util.[ch] (gnumeric_clist_moveto): New public
	function: Make given row visible in list - immediately if mapped,
	otherwise by attaching a signal handler.
	(gnumeric_clist_make_selection_visible): New public function: Make
	first selected row visible in list.
	
2000-05-10  Jon K Hellan  <hellan@acm.org>

	* src/func.c (tokenized_help_find): This segfaulted if no help was
	available. The test for no help failed because of
	signedness. Fixed it.

Michael Meeks's avatar
Michael Meeks committed
1930 1931
2000-05-10  Michael Meeks  <michael@helixcode.com>

1932 1933 1934 1935 1936 1937 1938 1939
	* gnumeric.oafinfo: fix borked magic sodding UUID's which suck.

	* src/corba-workbook-factory.c (_WorkbookFactory_init): update
	for oaf, but only the IID.

	* src/embeddable-grid.c (EmbeddableGridFactory_init): update
	for oaf. (embeddable_grid_factory): add failure warning.

Michael Meeks's avatar
Michael Meeks committed
1940 1941
	* Makefile.am: Install oafinfo.

Jacob Berkman's avatar
Jacob Berkman committed
1942 1943 1944 1945 1946 1947 1948 1949 1950
2000-05-10  Jacob Berkman  <jacob@helixcode.com>

	* configure.in (use_wm_icons): check for using window icons

	* src/main.c (gnumeric_main): use an icon if available in
	gnome-libs

	* src/Makefile.am (INCLUDES): add a -D for the icon dir

1951 1952 1953 1954
2000-05-10  Karl Eichwalder  <ke@suse.de>

	* src/dialogs/cell-format.glade: Typo.

Jody Goldberg's avatar
Jody Goldberg committed
1955 1956 1957 1958
2000-05-09  Jody Goldberg <jgoldberg@home.com>

	* Release 0.53

Morten Welinder's avatar
Typo.  
Morten Welinder committed
1959 1960 1961 1962
2000-05-09  Morten Welinder  <terra@diku.dk>

	* src/auto-format.c (do_af_suggest): Test right pointer for NULL.

1963 1964
2000-05-09  Jody Goldberg <jgoldberg@home.com>

1965 1966
	* configure.in : Tweak to produce a semi reasonable gnumericConf.sh
	  remove gnumeric-config.
1967 1968
	* Makefile.am : ditto.
	* gnumericConf.sh : ditto.
1969

1970 1971
	* src/sort.c (sort_range) : Use sheet_cell_remove_simple.

Jody Goldberg's avatar
Jody Goldberg committed
1972 1973
	* src/cell.c (cell_set_expr_internal) : Restore static.

1974 1975
	* src/commands.c (cmd_set_date_time_{undo,redo}) : Mark the changed cell for
	  status update.
Jody Goldberg's avatar
Jody Goldberg committed
1976
	(cmd_sort_destroy) : Leaks.
1977 1978 1979 1980 1981

	* src/Makefile.am (INCLUDES) : Remove extra '/' at end.

	* src/workbook.c (insert_current_time_cmd) : fix cut-n-paste-o.

Valek Frob's avatar
Valek Frob committed
1982 1983 1984 1985 1986
2000-05-09  Valek Filippov  <frob@df.ru>

	* src/functions/fn-financial.c: changed "NUM!" to "#NUM!".
	* src/functions/fn-logical.c: changed "'#VALUE!'" to "#VALUE!".

1987 1988 1989 1990 1991
2000-05-09  Jody Goldberg <jgoldberg@home.com>

	* src/xml-io.c (xml_probe) : Check versioning in descending order.
	(gnumeric_xml_read_workbook) : Add check for v3.

Valek Frob's avatar
Valek Frob committed
1992 1993 1994 1995 1996
2000-05-09  Valek Filippov  <frob@df.ru>

	* src/dialogs/cell-format.glade.h: inserted /* xgettext:no-c-format */
	  before "%" strings.

Jody Goldberg's avatar
Jody Goldberg committed
1997 1998
2000-05-08  Jody Goldberg <jgoldberg@home.com>

1999 2000 2001 2002
	* src/cell.c (cell_set_value) : When guessing what the entered text
	  was for a supplied string value prepend a \' to ensure that the
	  value stays a string, and so that blank cells work better.

Jody Goldberg's avatar
Jody Goldberg committed
2003 2004 2005 2006 2007 2008 2009
	* src/sheet.c (sheet_cell_calc_span) : redraw the bounding range when
	  interupting spans.
	(sheet_clear_region) : Respan ranges that were interupted by the
	  cleared region.
	(sheet_cell_remove_simple) : rename from sheet_cell_remove_internal and
	  export.

2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026
2000-05-08  Jon K Hellan  <hellan@acm.org>

	* src/file.c (cb_select): New callback: Make double click on list
	in import filter chooser works like "OK".
	(workbook_import): Back when we first started using glade, we used
	a hack to avoid flicker when popping up the filter chooser. We now
	know how to do it right, and remove the hack.
	(workbook_import): Connect callback to handle double click.
	(workbook_import): Fix bug: return value from import would clobber
	return value from dialog_run. We now close dialog after retrieving
	selection, but before importing.  We really should keep the dialog
	up until user either succeeds with import or explicitly
	cancels. But we let that wait. This behaviour should be
	implemented in a lot of places in a coordinated way.
	(workbook_import): Do not destroy workbook after WM close - it is
	already destroyed.

2027 2028 2029 2030 2031
2000-05-08  Morten Welinder  <terra@diku.dk>

	* configure.in (gnome-print): Survive version "0.19cvs".
	* *: include <config.h>

2032 2033
2000-05-08  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
2034 2035 2036 2037 2038
	* configure.in : Disable the perl plugin
	  Disable the plan perfect plugin
	  Disable the gdb plugin.
	These are not ready for prime time.

2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051
	* src/selection.c (sheet_selection_extend_to) : Call sheet_update
	  so that selection changes via mouse movement will update the status
	  areas.
	(sheet_selection_set) : Call sheet_flag_selection_change.

	* src/sheet.c (sheet_flag_selection_change) : New function to
	  flag that sheet_update should recalc the autoexpressions.

2000-05-07  Jody Goldberg <jgoldberg@home.com>

	* README : Update to require new gnome-print.
	* gnumeric.spec.in : Ditto.

2052 2053 2054 2055 2056 2057 2058 2059 2060 2061
2000-05-08  Jon K Hellan  <hellan@acm.org>

	This change was committed a week ago, but I forgot the changelog:
	
	* src/dialogs/dialog-goto-cell.c (cb_row_selected): Make double
	click on list work like "OK".

	* src/dialogs/dialog-goto-cell.c (dialog_goto_cell): Remove
	buttons which do not do anything yet.
 
2062 2063 2064 2065 2066 2067 2068 2069
2000-05-07  Jon K Hellan  <hellan@acm.org>

	* src/workbook.c (yield_focus): New callback: Give up focus when
	widget is destroyed. This gets rid of a warning when import is
	canceled.
	(workbook_attach_sheet): Connect callback.
	(workbook_set_focus): Do nothing if focus target argument is NULL.

2070 2071 2072 2073 2074
2000-05-07  Jody Goldberg <jgoldberg@home.com>

	* src/xml-io.c (xml_workbook_write) : Bump the xml version to v3.
	(xml_probe) : Handle v[123].

2075 2076 2077 2078 2079 2080 2081 2082 2083 2084
2000-05-07  Jon K Hellan  <hellan@acm.org>

        * src/dialogs/Makefile.am: dialog-printer.[ch] have been
        superseded by gnome-print dialogs. Remove.

	* src/print.c (sheet_print): Make print button default. Add
	accelerators. 

	* configure.in: Depend on gnome-print >= 0.19

2085 2086
2000-05-07  Jody Goldberg <jgoldberg@home.com>

2087 2088 2089
	* src/sheet-style.c (sheet_style_attach) : disable cache trash avoidance code.
	  None of the sample xls were loading.

Jody Goldberg's avatar
Jody Goldberg committed
2090 2091 2092 2093
	* src/workbook.c (workbook_do_destroy) : Empty the formula list before
	  the cell contents so that we can avoid searching the lists for each
	  cell.  This is a big time savings on exit.

2094 2095 2096 2097 2098 2099
	* src/sheet.c (sheet_cell_calc_span) : Size the content if
	  it has not yet been sized.

	* src/commands.c (cmd_area_set_text_redo) : Do not queue the
	  resize, rerender, and respan until after the recalc.

Jody Goldberg's avatar
Jody Goldberg committed
2100 2101
2000-05-06  Jody Goldberg <jgoldberg@home.com>

2102 2103
	* src/main.c (gnumeric_main) : Re-disable the style tests.

Jody Goldberg's avatar
Jody Goldberg committed
2104 2105 2106 2107
	* src/cell.c (cell_set_expr_unsafe) : Split from cell_set_expr.

	* src/eval.c (invalidate_refs) : Use cell_set_expr_unsafe.

2108 2109 2110 2111 2112 2113 2114 2115 2116 2117
2000-05-06  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/stf-parse.c (stf_parse_is_valid_data) : Add
	the form feed character (\f) as valid text character.
	(stf_parse_convert_to_unix) : In addition to CRLF and CR,
	remove form feeds (\f) from data.

	* src/stf.c (stf_read_workbook) : Add a workbook_recalc just
	to be sure.
	
2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139
2000-05-06  Michael Meeks  <michael@helixcode.com>

	* src/eval.c (handle_cell_range_deps): Add 3D dependency support.
	(cb_single_hash_to_list, cb_range_hash_to_list): Re-arrange handling of
	where the list is collated. (do_deps_destroy): update.
	(cell_drop_dependencies): remove cretinism here.
	(drop_cell_range_dep, handle_cell_single_dep): return on NULL deps structure.

	* src/sheet-style.c (sheet_style_attach): enable cache trash avoidance code.

	* src/sheet.c (sheet_cell_remove_internal): short circuit for NULL
	deps.

	* src/expr.c (expr_rewrite): update to handle workbook case.

	* src/eval.c (workbook_deps_destroy): update for speed.
	(sheet_deps_destroy): split body into (do_deps_destroy): here.

	* src/workbook.c (workbook_delete_sheet): destroy the sheet's
	dependencies here as well; very silly. (workbook_do_destroy): destroy
	deps of all sheets up front.

2140 2141
2000-05-06  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
2142 2143 2144
	* src/sheet.c (sheet_set_zoom_factor) : Depending on the order of
	  initialization we may also need to render some unrendered values.

2145 2146 2147
	* src/parse-util.c (parse_text_value_or_expr) : Be sure the clear the
	  expr if we are returning a value.

2148 2149
2000-05-05  Jody Goldberg <jgoldberg@home.com>

2150 2151 2152
	* src/sheet.c (sheet_set_zoom_factor) : Need to recalc cell
	  sizes when zooming changes.

2153 2154 2155 2156 2157 2158 2159 2160 2161
	* src/functions/fn-math.c (gnumeric_countif) :
	    Make code match comment.  We can safely ignore blanks.
	(gnumeric_sumif) : Code was correct.  Add a larger comment explaining
	  rationale.
	(gnumeric_sumx2my2) : Code was wrong.  We can not skip blank cells
	  if there are multiple ranges that need to be kept in sync.
	(gnumeric_sumx2py2) : Ditto.
	(gnumeric_sumxmy2) : Ditto.

2162 2163 2164 2165 2166
2000-05-05  Tuomas Kuosmanen  <tigert@tigert.gimp.org>

	* src/pixmaps/function_selector.xpm: Made the ()'s a bit higher
	to make the f(x) more clear.

Michael Meeks's avatar
Michael Meeks committed
2167 2168
2000-05-05  Michael Meeks  <michael@helixcode.com>

2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192
	* src/eval.c (cell_drop_dependencies): silence checks for sheet->deps.

	* src/workbook.c (workbook_expr_relocate): update for expr_rewrite.

	* src/sheet-autofill.c (autofill_cell): update for expr_rewrite.

	* src/sheet.c (sheet_destroy): use sheet_deps_destroy and hoist above
	destroy_contents.

	* src/cell.c (cell_relocate): update for expr_rewrite.

	* src/eval.c (dependancy_data_destroy): rename to (sheet_deps_destroy),
	(invalidate_refs): re-write. (dependency_single_destroy, dependency_range_destroy): 
	implement for non-intersheet deps. (workbook_deps_destroy): implement.

	* src/expr.c (expr_relocate): renamed to (expr_rewrite): update,
	add sheet re-writing. Fix serious bug with OPER_CONSTANT drop through
	to OPER_ARRAY. (cellrange_relocate): split out. (cellref_relocate): 
	update for structure pos.

	* src/expr.h: create ExprRewriteInfo.

	* src/gnumeric.h: add ExprRewriteInfo.

Michael Meeks's avatar
Michael Meeks committed
2193 2194 2195
	* src/sheet-object-container.c (sheet_object_container_realize): fix
	no brainer bug stopping menu's merging.

2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206
2000-05-04  Michael Meeks  <michael@helixcode.com>

	* src/sheet-style.c (sheet_style_delete_colrow): don't shrink.
	sheet sized ranges. (sheet_style_compute): add precondition for
	Norberts.

	* src/workbook.c (workbook_new_with_sheets): kill ' ' in
	sheet names.

	* corba-test/test-gnumeric-corba.c (do_test): ditto.

2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218
2000-05-04  Jody Goldberg <jgoldberg@home.com>

	* src/workbook.c : Fix typo that was calling undo for redo toolbar.
	({redo,undo}_cmd) : Use workbook_finish_editing directly.
	(cb_auto{function,sum}) : If we are already editing do not start.
	  When the wizard is in place bring it up.
	(workbook_start_editing_at_cursor) : Make the '=' insensitive while
	  editing.
	(workbook_finish_editing) : Make the '=' sensitive.
	(sheet_action_delete_sheet) : Fix typo and rename parm
	  'current_sheet' -> 'sheet' to avoid confision with
	  workbook->current_sheet.
2219 2220 2221 2222 2223 2224 2225
	(workbook_close_if_user_permits) : Documented, and use gboolean.
	(workbook_delete_event) : No need to invert the return value.
	(workbook_new) : connect to the 'delete_event' using
	  gtk_signal_connect_after so that we can influence the result.
	(workbook_delete_sheet) : NULL the undo, redo lists after they are
	  cleared.
	(workbook_do_destroy) : Ditto.
2226

2227 2228 2229 2230 2231 2232 2233
2000-05-04  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/rendered-value.c :
	(rendered_value_calc_size) : Check if
	cell->rendered_value is NULL. To avoid
	segfaulting.

2234 2235 2236 2237 2238
2000-05-04  Almer. S. Tigelaar.  <almer1@dds.nl>

	* doc/stf-export.txt :
	Added stf-exporter documentation

2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252
2000-05-04  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/gnumeric-util.[ch] :
	(gnumeric_combo_enters) : New, makes dialogs
	close when enter is pressed inside a gtkcombo.

	* src/dialogs/dialog-stf.c :
	(stf_dialog_editables_enter) : Modified to use
	the above function for combo boxes.

	* src/dialogs/dialog-stf-export.c :
	(stf_export_dialog_editables_enter) : Modified to
	use the above function for combo boxes.

Jody Goldberg's avatar
Jody Goldberg committed
2253 2254
2000-05-03  Jody Goldberg <jgoldberg@home.com>

Jody Goldberg's avatar
Jody Goldberg committed
2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265
	* src/command-context.c (gnumeric_error_invalid) : new function.
	* src/command-context-gui.c (ccg_error_invalid) : Handle.
	* src/command-context-corba.c (ccc_error_invalid) : Handle.

	* src/commands.c (cmd_rename_sheet_{undo,redo}) : Pass a context to
	  workbook_rename_sheet.

	* src/workbook.c (workbook_rename_sheet) : Sheet names can not be
	  empty.  Take a CommandContext and report the error.  Invert the
	  return value.

2266 2267 2268
	* src/format.c (pre_parse_format) : Fix old typo that was causing
	  bug 10001 by breaking AM/PM.

Jody Goldberg's avatar
Jody Goldberg committed
2269 2270 2271 2272 2273
	* src/cell.c (cell_set_array_formula) : Add some invariants to catch
	  inverted arrays.  The function should use the supplier's
	  reference.  It should not re-reference the supplied expression.
	  Document this.

Morten Welinder's avatar
Morten Welinder committed
2274 2275 2276 2277
2000-05-03  Morten Welinder  <terra@diku.dk>

	* autogen.sh (libtool): Add version check.

2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338
2000-05-03  Jody Goldberg <jgoldberg@home.com>

	* EvalPosition -> EvalPos
	  ParsePosition -> ParsePos
	  new struct RangeRef used in ValueRange

	  eval_pos_init* -> position.[ch]
	  parse_pos_init*
	  cell_ref_{get,make}*

	* src/workbook.c : Reorder the toolbar a bit.
	(workbook_foreach_cell_in_range) : New function.
	(cb_autofunction) : New routine.
	(workbook_set_auto_expr) : DO NOT put real code into pre/post
	  conditions.  It will be removed when debugging is eventually
	  disabled.

	* src/position.c (range_ref_normalize) : New function.

	* src/ranges.c (range_normalize) : New function.

	* src/expr.c (expr_implicit_intersection) : Use range_ref_normalize.

	* src/eval.c (cell_eval_content) : No need to release the value.
	  cell_assign_value already does that.
	(dependency_range_ctor) : Use range_normalize.

	* src/auto-format.c (do_af_suggest) : Use workbook_foreach_cell_in_range.

	* src/cell.c (cell_set_expr_and_value) : link the new expression but
	  do not queue it for recalc.
	(cell_assign_value) : Release the old value.
	(cell_copy) : Init the value to empty.

	* src/func.c (function_iterate_do_value) : Use
	  workbook_foreach_cell_in_range.

	* src/dialogs/dialog-function-wizard.c (create_description) : Use
	  a label rather than a text entry widget.  It looks better.

	* src/functions/fn-string.c (gnumeric_expression) : range is already
	  absolute.

	* src/functions/fn-stat.c (gnumeric_linest) : Handle inverted ranges.
	(gnumeric_logest) : Ditto.

	* src/functions/fn-information.c (gnumeric_countblank) : Use
	workbook_foreach_cell_in_range.
	(gnumeric_{row,column}) : Handle inversions.

	* src/functions/fn-lookup.c (gnumeric_offset) : No need to make
	  absolute.  The marshaller already did that.

2000-05-02  Jody Goldberg <jgoldberg@home.com>

	* src/eval.c (dependency_range_ctor) : normalize the range.

	* src/xml-io.c (xml_write_cell_and_position) : Suppress warning.

	* src/pixmaps.h : Add function wizard and equal sign.

2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350
2000-05-03  Michael Meeks  <michael@helixcode.com>

	* doc/Dependencies.txt: update to reflect changes.

	* src/eval.c: comment and const mending.	
	(handle_cell_range_deps): prune no inter-sheet singletons code,
	it is a sluggish anachronism. (handle_cell_single_dep): setup
	the correct sheet to enter data into.

	* src/eval.h: expunge redundant commenting, re-order,
	const kill.

2351 2352 2353 2354
2000-05-03  Almer. S. Tigelaar.  <almer1@dds.nl>

	* *.c: s/strcasecmp/g_strcasecmp/

2355 2356 2357 2358 2359 2360
2000-05-02  Almer. S. Tigelaar.  <almer1@dds.nl>

	* src/file.c (workbook_import) : We called gtk_widget_destroy
	_after_ gnome_dialog_close. This causes a weird "invalid cast"
	message each time something was successfully imported.

Michael Meeks's avatar
Michael Meeks committed
2361 2362 2363 2364
2000-05-01  Michael Meeks  <michael@helixcode.com>

	* src/corba-args.c (gnumeric_arg_parse): fixup popt for oaf.

Jody Goldberg's avatar
Jody Goldberg committed
2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377
2000-05-01  Jody Goldberg <jgoldberg@home.com>

	* src/expr.c (expr_tree_shared) : New function.

	* src/xml-io.c (gnumeric_xml_write_selection_clipboard) : Init and
	  destroy the expression hash.
	(gnumeric_xml_read_selection_clipboard) : Ditto.
	(gnumeric_xml_read_workbook) : Ditto.
	(gnumeric_xml_write_workbook) : Ditto.
	(xml_write_cell_and_position) : When saving cells that have expression
	  assign and store an ID for shared expressions.
	(xml_read_cell) : Use the ID to restore shared expressions.

2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394