Focus Mode "Secondary-Click" is misnamed
It must be misnamed. It makes absolutely no sense at all, the mode has nothing to do with clicking anything. Not primarily, not secondarily. It's a hover-focus mode, there are no clicks!
I'm convinced it happened one of two ways:
- It was an error in the 2017 interface mockups, that then became ensconced in the code.
- Or, it was a coding error that the mockups then unquestioningly reproduced.
The string "Secondary-Click" appears several times in the mockups/code for that panel, it's easy to see how it could've been copy/pasted into the wrong place from either side of the process.
In The Beginning™, in fact when the design updates were first applied (650494c9, "windows: Implement mockup from Design Team"), the three focus modes were:
-
"click"
(label: "Click to Focus") -
"sloppy"
(label: "Sloppy") -
"mouse"
(label: "Mouse")
tweak_group_windows.py@135-137:
Focus = GSettingsComboTweak(_("Focus Mode"), "org.gnome.desktop.wm.preferences", "focus-mode",
[("click", _("Click to Focus")), ("sloppy", _("Sloppy")), ("mouse", _("Mouse"))])
depends_how = lambda x,kn: x.get_string(kn) in ("mouse", "sloppy")
Then, shortly after, commit 409ba3a6 "windows: Convert Window Focus tweak to ListBox" reworked the code. In the process, the label for "mouse"
was inexplicably changed from _("Mouse")
to _("Secondary-Click")
, with no explanation for that change.
tweak_group_windows.py@102-112:
lbl = Gtk.Label(_("Secondary-Click"), xalign=0)
lbl.props.xalign = 0.0
desc = _("Window is focused when hovered with the pointer. Hovering the desktop removes focus from the previous window.")
lbl_desc = Gtk.Label()
lbl_desc.set_line_wrap(True)
lbl_desc.get_style_context().add_class("dim-label")
lbl_desc.set_markup("<span size='small'>"+GLib.markup_escape_text(desc)+"</span>")
self.check_mouse = Gtk.Image.new_from_icon_name("object-select-symbolic", Gtk.IconSize.LARGE_TOOLBAR);
self.check_mouse.set_no_show_all(True)
self.check_mouse.set_visible(self.settings[self.key_name] == "mouse")
Around a year later in 8948a146, "Sloppy" was renamed to "Focus on Hover", usurping a label most directly similar to the original long-description form of the "mouse"
mode ("Focus Follows Mouse"), perhaps indirectly cementing the wrongness of "Secondary-Click" by making it no longer seem as though there's a mode missing.
But there is, because AFAICT "Focus Mode: Secondary-Click" is a nonsense phrase. In terms of functionality it's still "Focus Mode: Focus Follows Mouse", no matter how it's labeled.