Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
gnome-todo
gnome-todo
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 171
    • Issues 171
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 13
    • Merge Requests 13
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • gnome-todognome-todo
  • Issues
  • #115

Closed
Open
Opened Oct 30, 2017 by Tobias Bernard@bertob🌱Developer7 of 7 tasks completed7/7 tasks

task row: more harmonic header margins

Currently, task rows are too slim to fit buttons and text inputs well, which makes them look awkward, because the focus border touches them. In addition, the expand/collapse button on the right is not the same distance from the border horizontally and vertically.

current-margins

In order to fix this, I propose slightly increasing the margins, and keeping them the same horizontally and vertically. I prototyped this by making the margin 6px all around the GtkBox inside the GtkBox inside the GtkRevealer. This looks a lot cleaner and more balanced, both for collapsed and expanded items.

more-margin

There are some issues with this, as the collapse/expand button is now no longer aligned horizontally with the items below. However, since there are other alignment issues in the detail pane, I'd leave that like it is for now and fix those separately.

Design Tasks

  • define new margins for widgets in task row header

Development Tasks

  • change margins in task row header
  • change "new task" row to have the same height as the task rows

QA Tasks

  • focus border does not touch header elements
  • margin is even horizontally and vertically around collapse/expand button
  • "new task" row has the same height as the task rows
  • no regressions
Edited Oct 31, 2017 by Tobias Bernard
Assignee
Assign to
GNOME 3.28.0
Milestone
GNOME 3.28.0 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: GNOME/gnome-todo#115