Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • GNOME Extra Themes GNOME Extra Themes
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 14
    • Issues 14
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GNOME Extra ThemesGNOME Extra Themes
  • Merge requests
  • !4

Do not set treeview colors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Kalev Lember requested to merge wip/kalev/do-not-set-treeview-colors into master Mar 23, 2018
  • Overview 6
  • Commits 1
  • Pipelines 1
  • Changes 1

A RHEL customer noticed a regression with overriding treeview colors from a GTK2 app when they updated from GNOME 3.14 to 3.22. @otte tracked this down to a change in gnome-themes-standard that regressed it. Would be nice to get this fix upstream as well.

From downstream bug report:

This seems to be happening because the updated Adwaita GTK2 theme decided to set the cell background color, which overrides the treeview's background color being used.

The code comments say that this was done for compatibility reasons with applications that look up these colors when drawing their own cell renderers. So I have no idea what the best way forward is in this case.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/kalev/do-not-set-treeview-colors