Remove "Set Character Encoding" menu?
In vte#3 (closed) we deprecated (almost removed) the handling of non-UTF-8.
Somewhat earlier (with the GMenu port IIRC) we removed the possibility of picking a few encodings to quickly switch among. Instead, "Set Character Encoding" became a flat list of all the supported ones. This makes it more cumbersome to pick a particular one. If someone often uses two or three encodings, configuring separate profiles for them and toggling between these profiles is probably a more convenient approach.
This is the only menu entry that allows to temporarily override a profile property (and by the way, it's unclear what happens if you choose an encoding in this menu first, and afterwards change the profile's one). There's no menu entry for one-shot switch of font, blinking, color scheme, larger scrollback, you name it, without altering the profile.
vte-0.54.0 crashed when changing back and forth between UTF-8 and a different encoding. This version was packaged for Ubuntu Cosmic beta for maybe a month. We discovered the bug and fixed for 0.54.1, I did not see any single user report about it. This suggests that changing encoding is a quite rare user action.
Changing the encoding on its own results in broken behavior of apps most of the time. Usually it should go hand-in-hand with the manual adjustment of the locale variables. Or the user can use luit, in which case the terminal's encoding should be left unchanged.
Forthcoming header bar's primary menu would have to structure the list into levels, since the popover always resides within the main window and GTK+ doesn't allow to scroll it if the contents do not fit.
Could we just not add it to the primary menu, and eventually drop it whenever the regular menu bar is removed? (Or even remove it straight away?)
Note that various encodings would still be available, as a profile setting.