Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gnome-terminal gnome-terminal
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 272
    • Issues 272
    • List
    • Boards
    • Service Desk
    • Milestones
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-terminalgnome-terminal
  • Issues
  • #7941
Closed
Open
Issue created Oct 21, 2022 by Pablo Correa Gomez@pabloyoyoista

`xmlns="https://specifications.freedesktop.org/metainfo/1.0"` tag in `data/org.gnome.Terminal.metainfo.xml.in` triggering wrong translations

Checking out metainfo data for applications in Alpine Linux, I bumped into a issue where the metadata was rendered invalid due to the metainfo_license node being translated, and that not being supported by the generator. I opened an issue in the appstream-generator and verified that the same problem was also happening in Debian.

However, it turns out the metainfo_license tag is unstranslatable and seems to not be translated in most other GNOME projects. Digging deeper, I found out that the xmlns="https://specifications.freedesktop.org/metainfo/1.0" tag in the top node of data/org.gnome.Terminal.metainfo.xml.in is confusing itstool, which prompts it to ignore the upstream metainfo.its and present all the strings as translatable to translators. Removing the said line and running meson compile gnome-terminal-update-po seems to generate the correct po files. This would have the consequence of reducing the translators' work and generating the proper metainfo data for distros to download.

The following patch would do:

diff --git i/data/org.gnome.Terminal.metainfo.xml.in w/data/org.gnome.Terminal.metainfo.xml.in
index df51e436..da3a0254 100644
--- i/data/org.gnome.Terminal.metainfo.xml.in
+++ w/data/org.gnome.Terminal.metainfo.xml.in
@@ -28,7 +28,6 @@
   If not, see <https://www.gnu.org/licenses/>.
 -->
 <component
-  xmlns="https://specifications.freedesktop.org/metainfo/1.0"
   xmlns:xi="http://www.w3.org/2001/XInclude"
   type="desktop-application">
   <id>org.gnome.Terminal.desktop</id>
Edited Oct 21, 2022 by Pablo Correa Gomez
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking