Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gnome-software
gnome-software
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 375
    • Issues 375
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 8
    • Merge Requests 8
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards

Getting colder with our second freeze... it's 3.31.91 release day and string freeze, upload a tarball and lock those strings 🏂

  • GNOME
  • gnome-softwaregnome-software
  • Merge Requests
  • !41

Open
Opened May 09, 2018 by Joaquim Rocha@jrocha
  • Report abuse
Report abuse

WIP: Do not invalidate OS upgrades in the Updates page

The Updates page resets the OS upgrades state to be available again if there's a change to the updates, or an app removal, etc.. The reason for this is that package-based systems need to make sure they have all the packages downloaded, so this would force the user to download any missing packages.

As a result, if the user has a downloaded OS upgrade in an ostree system, and restarts GNOME Software, or removes an app, in this state, the OS upgrade will show the Download button again, even if offline.

Any OS upgrade invalidation should be done by the plugins related to it and not by the Updates page, so this patch removes the mentioned code but the PR must NOT be merged until we have a way to invalidate pkgkit-based OS upgrades (WIP by @hughsie ).

(Issue in #384 )

Edited May 09, 2018 by Joaquim Rocha

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b wip/dont-invalidate-os-upgrades origin/wip/dont-invalidate-os-upgrades

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff wip/dont-invalidate-os-upgrades

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 0
  • Commits 1
  • Pipelines 1
  • Changes 1
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: GNOME/gnome-software!41