Skip to content

Refactor screenshots and hide those unavailable when offline

Philip Withnall requested to merge pwithnall/gnome-software:offline-screenshots into master

The details page displays a number of screenshots for regular apps and it works offline as long as the screenshots have been previously cached. However, if the screenshots have not been cached, an error screenshot placeholder is shown instead. This is a problem for many users who are constantly offline, as most of their apps will display the error screenshot and thus affect the UX negatively as every app appears to have an issue.

To help provide a cleaner UX, this patch hides screenshots if they cannot be loaded when the user is offline. In the process these changes also refactor the logic around showing the screenshots.

This doesn’t change the behaviour if the user is online.

This is a patch by @jrocha which I’m upstreaming.

Merge request reports