Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-software gnome-software
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 231
    • Issues 231
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-softwaregnome-software
  • Merge requests
  • !937

gs-app-context-bar: Present network access as neutral instead of warning

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philip Withnall requested to merge pwithnall/gnome-software:network-permissions into main Aug 19, 2021
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 2

Network access can be used to expand an existing local vulnerability into a remotely exploitable one, or can be used to leak information remotely.

However, it’s also needed by a significant proportion of apps for legitimate purposes.

Therefore, presenting it as a safety warning is not particularly helpful, as it means very few apps ever get labelled as ‘safe’, and most get labelled as ‘potentially unsafe’ due to their network permission. This reduces the utility of the labelling system to the user.

Instead, label the network access permission as ‘safe’ in the context tile, but neutral (grey) in the dialog.

This is similar to what Android does. In Android, apps are required to request the internet permission in their manifests if they access the internet, but the user is never prompted about that permission. It’s considered a ‘normal permission’. See https://developer.android.com/training/basics/network-ops/connecting.

Signed-off-by: Philip Withnall pwithnall@endlessos.org

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: network-permissions