Skip to content

gs-app-reviews-dialog: Ensure error messages in toast are translated

Philip Withnall requested to merge pwithnall/gnome-software:2709-reviews-error-messages into main

Currently the code passes through the error message from GsOdrsProvider unmodified, and those error messages are quite technical and completely untranslated.

Instead, format a translatable message based on the error code.

This was originally discussed in !1944 (comment 2236376), but having looked more closely at the possible error cases, I don’t think any of them are worth explaining to the user directly. They can’t do anything differently for an error 500 vs an error 404 from the ODRS server.

Signed-off-by: Philip Withnall pwithnall@gnome.org

Fixes: #2709 (closed)

Merge request reports