From e65a8b1d12b5edd1924d26acb42d1f9ffb7cbcba Mon Sep 17 00:00:00 2001 From: Michael Catanzaro Date: Thu, 8 Dec 2022 10:21:30 -0600 Subject: [PATCH] update-monitor: stop notifying about unprepared critical updates GNOME Software is supposed to notify about available updates if: * The setting to automatically download updates is disabled, or * The update is prepared In Software 40, this behavior regressed and Software began improperly notifying about updates before they were prepared. That was mostly fixed in 64585205437371c459d5de792d50af95e23ba346, except for critical updates. When an update is critical, Software notifies even if automatic downloads are enabled and the update is not yet prepared. This is wrong. If should_download is true and all_downloaded is false, we should never display a notification, regardless of update criticality. https://pagure.io/fedora-workstation/issue/107 --- src/gs-update-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gs-update-monitor.c b/src/gs-update-monitor.c index 292d2bc4b..d46f6d069 100644 --- a/src/gs-update-monitor.c +++ b/src/gs-update-monitor.c @@ -220,7 +220,7 @@ should_notify_about_pending_updates (GsUpdateMonitor *monitor, *out_title = _("Critical Software Update Ready to Install"); *out_body = _("An important software update is ready to be installed."); res = TRUE; - } else { + } else if (!should_download) { *out_title = _("Critical Software Updates Available to Download"); *out_body = _("Important: critical software updates are waiting."); res = TRUE; -- GitLab