Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-software gnome-software
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 249
    • Issues 249
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-softwaregnome-software
  • Merge requests
  • !1375

gs-overview-page: Clean up and speed up queries

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philip Withnall requested to merge pwithnall/gnome-software:query-cleanups into main May 24, 2022
  • Overview 5
  • Commits 6
  • Pipelines 2
  • Changes 4

See the individual commit messages.

This uses some of the new GsAppQuery functionality to push the remaining bits of sorting, filtering and truncation in gs-overview-page.c into the queries, so that they can be optimised a bit more.

In particular, this fixes a bug where the query would truncate the number of featured apps to 20 before then filtering them for hi-res icons. The filtering could potentially remove so many apps that the featured carousel would then have fewer than 5 apps in it.

This also reworks gs_app_list_randomize() to be more performant, especially in terms of temporary memory allocations.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: query-cleanups