Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-software gnome-software
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 236
    • Issues 236
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-softwaregnome-software
  • Merge requests
  • !1347

Drop GsPluginJobListInstalledApps in favour of GsPluginJobListApps

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philip Withnall requested to merge pwithnall/gnome-software:refactor-threads22 into main May 09, 2022
  • Overview 32
  • Commits 15
  • Pipelines 5
  • Changes 21

Their implementations were pretty similar. GsPluginJobListInstalledApps was added in 42 near the start of this refactoring work; GsPluginJobListApps came later (it hasn’t been in a release yet), and was based on the ListInstalledApps code, learning lessons from it.

The duplication isn’t necessary: this MR adds a GsAppQuery:is-installed tristate property, and callers can use that with GsPluginJobListApps to list all installed apps.

This should save on code, consolidate the query interface a bit more, and be functionally equivalent to before.

This does break API by dropping GsPluginJobListInstalledApps, which was first released in 42. We’ve already bumped the plugin API version this cycle (in commit 10962d70), so that should be OK.

Helps: #1472

Edited May 20, 2022 by Philip Withnall
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: refactor-threads22