gnome-software merge requestshttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests2021-08-11T11:23:41Zhttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/900repos-dialog: Polish its look2021-08-11T11:23:41ZAdrien Plazasrepos-dialog: Polish its lookPolishes and simplifies the look of `GsReposDialog`.
Fixes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1374
### Before
![Capture_d_écran_de_2021-08-10_08-58-01](/uploads/002718ea948c6a97f7685fb81a8d3828/Capture_d_écran_de_2...Polishes and simplifies the look of `GsReposDialog`.
Fixes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1374
### Before
![Capture_d_écran_de_2021-08-10_08-58-01](/uploads/002718ea948c6a97f7685fb81a8d3828/Capture_d_écran_de_2021-08-10_08-58-01.png)
![Capture_d_écran_de_2021-08-10_08-58-04](/uploads/29ce8685eb217dcd49a58fedc6bde6ca/Capture_d_écran_de_2021-08-10_08-58-04.png)
![Capture_d_écran_de_2021-08-10_08-58-08](/uploads/ff94aaae57a7824d17365e28203f78c8/Capture_d_écran_de_2021-08-10_08-58-08.png)
### After
![Capture_d_écran_de_2021-08-10_08-57-23](/uploads/a44d7d63925aa08e95b21e649a4f371c/Capture_d_écran_de_2021-08-10_08-57-23.png)
![Capture_d_écran_de_2021-08-10_08-57-27](/uploads/da99b9fb86c3488e14582117faa9e9da/Capture_d_écran_de_2021-08-10_08-57-27.png)
![Capture_d_écran_de_2021-08-10_08-57-36](/uploads/35bec52d410dcd11fcff38dd92473a46/Capture_d_écran_de_2021-08-10_08-57-36.png)41.betahttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/906gs-overview-page: Rename some section headings2021-08-11T10:10:43ZPhilip Withnallgs-overview-page: Rename some section headingsThis makes them match what’s on flathub, to make the experience a bit
more consistent across the two.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #1379
Closes #1379This makes them match what’s on flathub, to make the experience a bit
more consistent across the two.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #1379
Closes #137941.betahttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/892gs-app-context-bar: Add description to the storage tile2021-08-11T09:20:54ZPhilip Withnallgs-app-context-bar: Add description to the storage tileThis tells the user how much download is needed to get the app’s
runtime, or how much data is used for user data and cache.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #1352
Closes #1352This tells the user how much download is needed to get the app’s
runtime, or how much data is used for user data and cache.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #1352
Closes #135241.betaPhilip WithnallPhilip Withnallhttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/812Resolve "Repository dialog design updates"2021-08-10T05:33:40ZMilan CrhaResolve "Repository dialog design updates"Closes #1166Closes #116641.betaMilan CrhaMilan Crhahttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/891gs-details-page: Fix links not being updated2021-08-09T07:04:27ZPhilip Withnallgs-details-page: Fix links not being updatedI broke this in a later review cycle on 310158cd and didn’t notice.
The logic was short-circuiting calls to `update_action_row_from_link()`,
so no links after the first one to be shown would be updated.
Spotted by Allan Day in
https://g...I broke this in a later review cycle on 310158cd and didn’t notice.
The logic was short-circuiting calls to `update_action_row_from_link()`,
so no links after the first one to be shown would be updated.
Spotted by Allan Day in
https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1111#note_1243062.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>41.betahttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/872gs-category-tile: Update to match new design2021-08-06T16:50:53ZPhilip Withnallgs-category-tile: Update to match new designHere are some changes to make further progress on making the category tiles match the [new sidebarless design](https://gitlab.gnome.org/Teams/Design/software-mockups/-/blob/master/adaptive/sidebarless.png).
The changes make the category...Here are some changes to make further progress on making the category tiles match the [new sidebarless design](https://gitlab.gnome.org/Teams/Design/software-mockups/-/blob/master/adaptive/sidebarless.png).
The changes make the category tiles bigger and more padded, and implement per-category styling for them. The categories are moved up the overview page (to just below the carousel), but there’s currently no support for bigger category tiles (Play and Develop in the designs); that will follow in another MR once this one’s reviewed.
Open questions/issues to note:
* [x] The category icons don’t match the designs because I couldn’t find the icons that are in the designs; please point me towards better icons if what’s implemented needs changing
* [x] I’ve done a reasonable approximation of the gradients, colours, etc. from the designs, but without knowing exactly the colour stops and angles used in the design, I can’t make it exact, so CSS tweaking will probably be required — please suggest concrete changes, ideally as GitLab suggestions on the diff in this MR
* [x] I’m unsure what styling should be applied to the category tiles in HighContrast mode, since they’re visually quite different from normal buttons in the normal Adwaita theme (so currently styling in HighContrast is broken)
* [x] The background breaks on the Work tile when hovering over it and I haven’t investigated why (because the style is likely to be tweaked)
Screenshot:
![Screenshot_from_2021-07-29_17-02-40](/uploads/5afb63a4556729ed809a60627fd5fad5/Screenshot_from_2021-07-29_17-02-40.png)
/cc @aday, @bertob for design review
Helps: #111141.betaPhilip WithnallPhilip Withnallhttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/888Resolve "Drop ‘Recommended $category Apps’ sections from overview page"2021-08-06T13:35:11ZMilan CrhaResolve "Drop ‘Recommended $category Apps’ sections from overview page"Closes #1355Closes #135541.betaMilan CrhaMilan Crhahttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/887gs-details-page: Implement new details page header layout2021-08-06T13:33:04ZPhilip Withnallgs-details-page: Implement new details page header layoutThis implements the new layout.
It doesn’t make it adaptive, but I’ve tried to structure the `GtkBox` hierarchy so that should be straightforward in future by swapping out a `GtkBox` for an adaptive version which changes its orientation...This implements the new layout.
It doesn’t make it adaptive, but I’ve tried to structure the `GtkBox` hierarchy so that should be straightforward in future by swapping out a `GtkBox` for an adaptive version which changes its orientation from `horizontal` to `vertical` when its width is constrained.
It doesn’t change the buttons or how they behave, just their location. Changes to the appearance and behaviour of the buttons is #1351.
The ratings stars aren’t in the design, so I’ve shoved them in where I think is a reasonable place. Feedback welcome.
Fixes: #1350
Closes #135041.betaPhilip WithnallPhilip Withnallhttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/880gs-*-context-dialog: Use sentence case for dialogue titles2021-08-04T12:37:51ZPhilip Withnallgs-*-context-dialog: Use sentence case for dialogue titlesSee discussion on #1345 and
https://gitlab.gnome.org/Teams/Design/hig-www/-/issues/89.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Helps: #1345See discussion on #1345 and
https://gitlab.gnome.org/Teams/Design/hig-www/-/issues/89.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Helps: #134541.betahttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/845Add dialogues for context bar tiles2021-08-03T15:19:42ZPhilip WithnallAdd dialogues for context bar tilesFinally, here’s the MR to add the dialogues from the [context tiles design](https://gitlab.gnome.org/Teams/Design/software-mockups/-/raw/master/adaptive/context-tiles.png).
This is finished and tested, but there are probably a few areas...Finally, here’s the MR to add the dialogues from the [context tiles design](https://gitlab.gnome.org/Teams/Design/software-mockups/-/raw/master/adaptive/context-tiles.png).
This is finished and tested, but there are probably a few areas which need some attention before it’s merged, or as follow-ups:
* [x] The styling for the context tiles is a bit odd when you click them (I don’t know how to style completely flat buttons).
* [ ] I’m unsure whether the rows in the dialogues should be ordered by importance (colour) so the more important rows are at the top, or whether the order should always be the same regardless of the app. On the age rating dialogue the rows are sorted by importance since there are so many rows. On the other dialogues, their order is static. ⇒ [discussion here](https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/845#note_1213901)
* [x] I haven’t implemented highlighting when a runtime is out of date (on the safety dialogue, it’s the red warning triangle at the bottom of the right-most design for that dialogue) as the data currently isn’t available for that. It could be done as a follow-up, although I would suggest it’s not a priority for GNOME 41. ⇒ #1335
* [x] As always, some of the styling is probably off and people may disagree with my fairly arbitrary icon choices and wording choices. Specific suggestions for how to improve that are welcome.
* [x] Dialogue widths are inconsistent due to being calculated (as per the default) from the length of label text in the rows. Perhaps a width should be specified instead? ⇒ done with Adrien’s changes
Helps: #111141.betahttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/878picutre: Resize when setting the pixbuf2021-08-03T13:33:21ZAdrien Plazaspicutre: Resize when setting the pixbufRedrawing isn't enough, we need to take the new pixbuf's size into
account.
@mcrha This should fix the issue you encountered where you had tiny screenshots.Redrawing isn't enough, we need to take the new pixbuf's size into
account.
@mcrha This should fix the issue you encountered where you had tiny screenshots.41.betahttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/871Resolve "Calculate app space usage for download context tile"2021-08-02T17:46:39ZMilan CrhaResolve "Calculate app space usage for download context tile"Closes #1296Closes #129641.betaMilan CrhaMilan Crhahttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/873gs-shell: Move the notifications overlay to below the header bar2021-08-02T17:08:03ZPhilip Withnallgs-shell: Move the notifications overlay to below the header barSo that it doesn’t obscure the header bar and make navigation impossible
until it’s dismissed.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #1339
Closes #1339So that it doesn’t obscure the header bar and make navigation impossible
until it’s dismissed.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #1339
Closes #133941.betahttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/877Resolve "Deadlock on switch to the details page"2021-08-02T16:23:59ZMilan CrhaResolve "Deadlock on switch to the details page"Closes #1337Closes #133741.betaMilan CrhaMilan Crhahttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/869Resolve "installed-page: Empty sections not hidden"2021-08-02T15:01:36ZMilan CrhaResolve "installed-page: Empty sections not hidden"Closes #1307Closes #130741.betaMilan CrhaMilan Crha