gnome-software merge requestshttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests2021-03-09T10:17:50Zhttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/647gs-app: Use the libappstream function to check proprietary licenses2021-03-09T10:17:50ZPhilip Withnallgs-app: Use the libappstream function to check proprietary licensesThis should have equivalent behaviour, but saves us a bit of code and
maintenance.
Notably, it handles `LicenseRef-proprietary` with the same case as our
existing code, so this change doesn’t fix the underlying problem with
issue #1161....This should have equivalent behaviour, but saves us a bit of code and
maintenance.
Notably, it handles `LicenseRef-proprietary` with the same case as our
existing code, so this change doesn’t fix the underlying problem with
issue #1161. However, the underlying fix is for Steam Link to change its
appdata, and for the appstream spec to be consistent in its casing.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #116140.rchttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/649Release version 40.rc2021-03-12T07:27:55ZMilan CrhaRelease version 40.rcThe source data for this is (skipping the Translations):
```
* Bugs fixed:
- #1131 New Carousel
- #1132 Duplicate add-ons shown for VLC
- #1139 Version history: Followup issues
- #1141 flatpak: Remove of a repository doesn't remove i...The source data for this is (skipping the Translations):
```
* Bugs fixed:
- #1131 New Carousel
- #1132 Duplicate add-ons shown for VLC
- #1139 Version history: Followup issues
- #1141 flatpak: Remove of a repository doesn't remove it from the GUI
- #1142 GsApplication: Crash when run as root
- #1145 Release date not visible in version history
- #1147 Refactor icon/pixbuf handling
- #1148 Refactor app key colour generation
- #1151 flatpak: Not having latest commit is not a problem
- #1158 Missing context for permission and license strings
- #1159 Improve carousel button appearance on non-standard themes
- #1161 LicenseRef-proprietary only recognised case-sensitively
- !625 Minor README and RELEASE.md fixes
- !628 Honor G_MESSAGES_DEBUG env var
- !629 Update libhandy requirement
- !630 build: Bump plugin API version for recent GsApp API changes
- !631 GsDebug improvements
- !633 Make add-on rows not selectable
- !637 gs-folders: Remove some apps from Utilities folder
- !638 Add git commit to version in non-release builds
- !643 gs-plugin-loader: Reset online-updates-timestamp only when did the update
```
By the way, running `appstreamcli metainfo-to-news` regenerates the NEWS file quite a lot here. Maybe it's due to having used AppStream version 0.14.1, I do not know. For the comparison, the diff [is here](/uploads/30f0b7a23f953e18aa876877e06862be/gs.patch). It won't be a problem, but it just adds more places where one can make things wrong during the release process. I do not know whether it's caused by previous manual file editing or different versions of the appstreamcli producing different format.40.rchttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/645style: Hide border on carousel buttons for non-Adwaita themes2021-03-08T11:30:58ZPhilip Withnallstyle: Hide border on carousel buttons for non-Adwaita themesThis makes no difference to the carousel appearance using the default
theme (Adwaita), but should fix some glitches with other themes.
Investigated by Milan Crha.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #1159This makes no difference to the carousel appearance using the default
theme (Adwaita), but should fix some glitches with other themes.
Investigated by Milan Crha.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #115940.rchttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/644Refactor icon/pixbuf handling2021-03-10T15:03:50ZPhilip WithnallRefactor icon/pixbuf handlingSee the commit messages.
This branch is based on top of !636 because it touches some of the same code.
It doesn’t make any UI or translatable string changes.
Closes #1147See the commit messages.
This branch is based on top of !636 because it touches some of the same code.
It doesn’t make any UI or translatable string changes.
Closes #114740.rchttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/643gs-plugin-loader: Reset online-updates-timestamp only when did the update2021-04-06T17:44:56ZMilan Crhags-plugin-loader: Reset online-updates-timestamp only when did the updateThe gs_plugin_loader_generic_update() is used in two cases, when updating
the software and when downloading the software. The former case can reset
the online-updates-timestamp, but the later not, because it did not
update anything.
Thi...The gs_plugin_loader_generic_update() is used in two cases, when updating
the software and when downloading the software. The former case can reset
the online-updates-timestamp, but the later not, because it did not
update anything.
This blocks the update notifications from showing up after the first
run of the Software.
This had been found during the Fedora tests here:<br>
https://bugzilla.redhat.com/show_bug.cgi?id=193040140.rchttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/638Add git commit to version in non-release builds2021-02-26T18:40:45ZPhaedrus LeedsAdd git commit to version in non-release buildsThis is based on similar functionality in GNOME Builder. Having the git
commit in the version in the About dialog is useful for debugging.This is based on similar functionality in GNOME Builder. Having the git
commit in the version in the About dialog is useful for debugging.40.rchttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/636Refactor app key color generation to be faster2021-03-06T05:32:16ZPhilip WithnallRefactor app key color generation to be fasterSee the commit messages. ~~This goes most of the way to fixing #1148, but doesn’t yet do anything about contrast in featured app tiles. I’ll do that in a follow-up MR.~~ This now also adds an algorithm to choose the most appropriate key ...See the commit messages. ~~This goes most of the way to fixing #1148, but doesn’t yet do anything about contrast in featured app tiles. I’ll do that in a follow-up MR.~~ This now also adds an algorithm to choose the most appropriate key colour as a background colour for `GsFeatureTile`, fixing #1148 completely.
Fixes: #114840.rchttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/630build: Bump plugin API version for recent GsApp API changes2021-02-18T16:35:58ZPhilip Withnallbuild: Bump plugin API version for recent GsApp API changesSo out of tree plugins can be parallel installed in a way that means
gnome-software only loads the ones which use a compatible
libgnomesoftware ABI.
Spotted by Phaedrus Leeds.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
H...So out of tree plugins can be parallel installed in a way that means
gnome-software only loads the ones which use a compatible
libgnomesoftware ABI.
Spotted by Phaedrus Leeds.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Helps: #114640.rchttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/601lib: Build libgnomesoftware as a shared library as well as static2021-11-25T13:53:12ZPhilip Withnalllib: Build libgnomesoftware as a shared library as well as staticThis means it can be linked to the plugins dynamically. This reduces the
installed plugin size by 50% (and correspondingly the disk reads and
memory for loading them). It doesn’t measurably affect startup time, and
overall reduces memory...This means it can be linked to the plugins dynamically. This reduces the
installed plugin size by 50% (and correspondingly the disk reads and
memory for loading them). It doesn’t measurably affect startup time, and
overall reduces memory consumption by about 5% (although almost all of
that will be read-only mappings of the code).
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>40.rc