gnome-software merge requestshttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests2019-06-28T13:51:42Zhttps://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/242gs-details-page: Stop details grid vertically expanding2019-06-28T13:51:42ZPhilip Withnallgs-details-page: Stop details grid vertically expandingWhen there are very few rows in the details grid (due to not much
information being available for an app), it expands each row to fill the
available vertical area, which looks a bit weird.
Change the vertical alignment to stop doing tha...When there are very few rows in the details grid (due to not much
information being available for an app), it expands each row to fill the
available vertical area, which looks a bit weird.
Change the vertical alignment to stop doing that.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
https://phabricator.endlessm.com/T25367https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/244Make the main stack non-homogeneous2019-07-01T19:10:19ZPhilip WithnallMake the main stack non-homogeneousSome views apparently report a bigger size than they actually
require before they're mapped. Because of this, the window gets
bigger than needed, rendering Software unusable on low resolution
screens.
Fix that by making the main stack n...Some views apparently report a bigger size than they actually
require before they're mapped. Because of this, the window gets
bigger than needed, rendering Software unusable on low resolution
screens.
Fix that by making the main stack non-homogeneous.
---
Patch from downstream by @feaneron. I’ve tweaked the commit message, but haven’t modified it otherwise.https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/243Simplify app rows on installed apps and updates pages2019-07-12T19:32:36ZPhilip WithnallSimplify app rows on installed apps and updates pagesHere are three simplifications to the `GsAppRow` widget, up for discussion. Marking this as WIP, because if you agree with the UI changes, I can actually delete a fair amount more code (the use of the `GsStarWidget` widget, and the `fold...Here are three simplifications to the `GsAppRow` widget, up for discussion. Marking this as WIP, because if you agree with the UI changes, I can actually delete a fair amount more code (the use of the `GsStarWidget` widget, and the `folder_label`).
The changes are:
* Show the app’s short summary, rather than its description, because otherwise the installation page turns into a wall of text. The user should have a reasonable idea about what the apps they already have installed do.
* Remove the ratings from apps on the installed and updates pages. They are not helpful to the user after they initially choose to install an app.
* Remove the folder label from apps on the installed and updates pages. Very few apps have them set, and in practice they don’t seem to help users differentiate apps. Again, users should have a reasonable idea of what the apps are which they already have installed.
Screenshots before, after removing just the long description, and after removing all three things:
![before](/uploads/e6871ae5dff1c40936ac6ab4d9b4e463/before.png)
![middle](/uploads/66b94d0f8dfc464622901da1807f5cbf/middle.png)
![after](/uploads/eeed7823653faf8d8088432ea75ed913/after.png)
(The uninstall buttons are missing from these rows for unrelated reasons — we have a plugin in Endless which disables uninstallation of ‘system’ apps.)
Thoughts?https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/245Fix icon naming and replace the installed icon in the app tiles2019-07-15T13:52:16ZPhilip WithnallFix icon naming and replace the installed icon in the app tilesSee the commit messages.
The commit from @jrocha is unmodified from a commit of his in our g-s fork; I’ve just tweaked the commit message a bit.See the commit messages.
The commit from @jrocha is unmodified from a commit of his in our g-s fork; I’ve just tweaked the commit message a bit.https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/225Refactor screenshots and hide those unavailable when offline2019-08-26T06:28:03ZPhilip WithnallRefactor screenshots and hide those unavailable when offlineThe details page displays a number of screenshots for regular apps and
it works offline as long as the screenshots have been previously cached.
However, if the screenshots have not been cached, an error screenshot
placeholder is shown in...The details page displays a number of screenshots for regular apps and
it works offline as long as the screenshots have been previously cached.
However, if the screenshots have not been cached, an error screenshot
placeholder is shown instead. This is a problem for many users who are
constantly offline, as most of their apps will display the error
screenshot and thus affect the UX negatively as every app appears to
have an issue.
To help provide a cleaner UX, this patch hides screenshots if they
cannot be loaded when the user is offline. In the process these changes
also refactor the logic around showing the screenshots.
This doesn’t change the behaviour if the user is online.
---
This is a patch by @jrocha which I’m upstreaming.https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/310Only set the app row's buttons as destructive when they remove an app2019-09-25T07:01:54ZPhilip WithnallOnly set the app row's buttons as destructive when they remove an appIf the page is set as colorful, we should still not show the update
button as destructive. So it should only be set as such when the app
is installed (because the button will remove the app).
---
Upstreaming this patch from @jrocha whi...If the page is set as colorful, we should still not show the update
button as destructive. So it should only be set as such when the app
is installed (because the button will remove the app).
---
Upstreaming this patch from @jrocha which originally slipped through the cracks.https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/388Highlight destructive actions on buttons in confirmation dialogues2019-12-10T20:04:46ZPhilip WithnallHighlight destructive actions on buttons in confirmation dialoguesThis makes the remove/disable buttons in the confirmation dialogues for removing an app or removing a repo red.
Screenshots of the new behaviour:
![Screenshot_from_2019-12-10_12-19-33](/uploads/66a00feb308cc77a93b05198f7dfd202/Scre...This makes the remove/disable buttons in the confirmation dialogues for removing an app or removing a repo red.
Screenshots of the new behaviour:
![Screenshot_from_2019-12-10_12-19-33](/uploads/66a00feb308cc77a93b05198f7dfd202/Screenshot_from_2019-12-10_12-19-33.png)
![Screenshot_from_2019-12-10_12-26-17](/uploads/95feafa647e4138d6ddedbb6614a2fb1/Screenshot_from_2019-12-10_12-26-17.png)https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/339Metered data/Automatic updates warning bar2020-02-11T13:54:04ZPhilip WithnallMetered data/Automatic updates warning barThis is a continuation of the discussion (and patches) from [here](https://gitlab.gnome.org/GNOME/gnome-software/merge_requests/194#note_533377).
Here’s some screenshots of the UI changes in this branch for UX review (CC @aday). The c...This is a continuation of the discussion (and patches) from [here](https://gitlab.gnome.org/GNOME/gnome-software/merge_requests/194#note_533377).
Here’s some screenshots of the UI changes in this branch for UX review (CC @aday). The changes are:
* add the automatic updates bar to the ‘Updates’ page, showing whether the user has automatic updates enabled for any of their currently active network connections (i.e. this is true if they are connected to an unmetered connection, or connected to a metered connection which they’ve configured to allow ‘large’ downloads; it’s false if they’re connected to any other metered connection)
* hide the existing automatic updates setting from the preferences dialogue if Mogwai is enabled; configuration is in the control center instead (pending an MR for that in g-c-c)
![updates-page](/uploads/0c4f7aca2f21414b58506acb6521e7f7/updates-page.png)
![update-preferences](/uploads/a45c19c92cde9e77ac84dd0b24e5ff14/update-preferences.png)
There isn’t a control center MR yet, but the relevant downstream stuff is [here](https://github.com/endlessm/gnome-control-center/tree/master/panels/updates), and adds a new ‘Automatic Updates’ panel. Here’s what it looks like:
![automatic-updates](/uploads/970dd09621d1043f794b297ad2cafdb3/automatic-updates.png)
![automatic-updates-disabled](/uploads/0c301428aa835bc66d70fa6fa85f80f0/automatic-updates-disabled.png)
![scheduled-updates](/uploads/54481227b70e16444b6b2b88a5375466/scheduled-updates.png)
The metered status of the system is set per network connection, using the existing checkbox in the network panel:
![metered-network](/uploads/033b69406dc4ffc5b509b84726edac5e/metered-network.png)
I haven’t opened a merge request for the control center yet, since I don’t think discussing (roughly) the same change in two places in parallel is going to help. I can do so if you think that would be easier, though — or this MR could be moved to the design team’s area on GitLab as an issue, and we could open a new MR against gnome-software when a plan is ready.https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/524Resolve "gs-screenshot-image: Show spinner when load of image takes long time"2020-11-24T14:55:53ZMilan CrhaResolve "gs-screenshot-image: Show spinner when load of image takes long time"Closes #91Closes #91https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/540gs-details-page: Don’t show the origin box if not on the details page2020-12-02T21:58:13ZPhilip Withnallgs-details-page: Don’t show the origin box if not on the details pageThe different repos an app can be installed from are loaded
asynchronously, but the widget for them (the origin box) is in a global
header bar. That means it’s possible for the asynchronous load to
complete after the user has switched aw...The different repos an app can be installed from are loaded
asynchronously, but the widget for them (the origin box) is in a global
header bar. That means it’s possible for the asynchronous load to
complete after the user has switched away from the app details page, but
for the origin box to then still be shown.
Fix that by only showing the origin box if the details page is still
active when the asynchronous load completes.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #988https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/559Resolve "gs-repos-dialog: Hide empty frame"2020-12-03T16:46:08ZMilan CrhaResolve "gs-repos-dialog: Hide empty frame"Closes #801Closes #801https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/563Resolve "gs-details-page: Fully-sandboxed Flatpak apps have "High" permissions"2020-12-04T09:45:33ZMilan CrhaResolve "gs-details-page: Fully-sandboxed Flatpak apps have "High" permissions"Closes #1074Closes #1074https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/569app icon: more colorful bag2020-12-22T22:32:20ZTobias Bernardapp icon: more colorful bagUpdate bag icon to something more colorful, highlighting the apps/content rather than the bag itself.
![image](/uploads/997aa1802a1b1f1692cd3a51c19fe596/image.png)Update bag icon to something more colorful, highlighting the apps/content rather than the bag itself.
![image](/uploads/997aa1802a1b1f1692cd3a51c19fe596/image.png)https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/511Resolve "Support better the dark themes"2021-01-04T16:24:15ZMilan CrhaResolve "Support better the dark themes"Closes #80Closes #80https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/568gs-progress-button: Implement unknown progress handling2021-01-04T16:54:06ZMilan Crhags-progress-button: Implement unknown progress handlingThis implements unknown progress handling for the progress button
by a similar way as the GtkProgressBar does, which is by a "ping pong"
of the bar from the left to the right and back, until the progress
is known.
It also avoids unneces...This implements unknown progress handling for the progress button
by a similar way as the GtkProgressBar does, which is by a "ping pong"
of the bar from the left to the right and back, until the progress
is known.
It also avoids unnecessary memory allocations in the gs_progress_button_set_progress().https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/574Resolve "Make "Installed" text use text color"2021-01-08T23:01:45ZPhilip WithnallResolve "Make "Installed" text use text color"Drop the text colour, and also fix the icon/label alignment.
Fixes: #1031Drop the text colour, and also fix the icon/label alignment.
Fixes: #1031https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/573gs-first-run-dialog: Change ‘Let’s Go Shopping’ to ‘Browse Software’2021-01-08T23:06:17ZPhilip Withnallgs-first-run-dialog: Change ‘Let’s Go Shopping’ to ‘Browse Software’More boring, but a little more understandable. gnome-software doesn’t
currently support app purchases, so ‘going shopping’ doesn’t quite make
sense.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #872More boring, but a little more understandable. gnome-software doesn’t
currently support app purchases, so ‘going shopping’ doesn’t quite make
sense.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #872https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/564Resolve "flatpak: Origin UI string doesn't use repo Title"2021-01-11T14:59:12ZMilan CrhaResolve "flatpak: Origin UI string doesn't use repo Title"Closes #1082Closes #1082https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/584Overview: constrain maximum width with HdyClamp (updated)2021-01-12T12:09:04ZPhilip WithnallOverview: constrain maximum width with HdyClamp (updated)This supersedes !416, updated to incorporate review comments and call `hdy_init()` correctly for libhandy-1, and submitted as a new MR because I can’t push to the old one (@jsparber didn’t allow pushes from other g-s developers to the MR...This supersedes !416, updated to incorporate review comments and call `hdy_init()` correctly for libhandy-1, and submitted as a new MR because I can’t push to the old one (@jsparber didn’t allow pushes from other g-s developers to the MR; the default value for that checkbox in the MR options in GitLab is wrong).
Fixes: #890https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/541gs-category-page: Fix view scrolling if clicking tiles near the top2021-01-12T13:26:52ZPhilip Withnallgs-category-page: Fix view scrolling if clicking tiles near the topThis was introduced in commit a8e93c9caa and was supposed to scroll the
view to show the tile that had just been clicked on (or which was
focused by using the arrow keys on the keyboard). However, that
(specifically `gtk_container_set_fo...This was introduced in commit a8e93c9caa and was supposed to scroll the
view to show the tile that had just been clicked on (or which was
focused by using the arrow keys on the keyboard). However, that
(specifically `gtk_container_set_focus_vadjustment()`) only works if the
child widgets are in the same coordinate system as the container. That’s
not the case here, as `featured_grid` (and other widgets) are between
`scrolledwindow_category` and `category_detail_box` in the widget
hierarchy. That means the scrolling jumps to the wrong place, and the
tile isn’t activated.
It might be possible to reimplement the mechanics of
`gtk_container_set_focus_vadjustment()` in gnome-software, but that
seems like a lot of fragile code for a small feature. Instead, just drop
it.
Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
Fixes: #1040
Closes #1040