dummy plugin's key-colors test unreliable
I just saw a pipeline failure with this error:
# Gs-DEBUG: Considering icon of type GThemedIcon (drive-harddisk), width 0?1
(/builds/aplazas/gnome-software/_build/plugins/dummy/gs-self-test-dummy:2299): Gs-DEBUG: 05:58:19.546: Considering icon of type GThemedIcon (drive-harddisk), width 0?1
# Gs-DEBUG: Found no icons of the right size; checking themed icons
(/builds/aplazas/gnome-software/_build/plugins/dummy/gs-self-test-dummy:2299): Gs-DEBUG: 05:58:19.546: Found no icons of the right size; checking themed icons
Bail out! GsPluginDummy:ERROR:../plugins/dummy/gs-self-test.c:233:gs_plugins_dummy_key_colors_func: assertion failed (array->len >= 3): (1 >= 3)
Re-runing the pipeline makes it succeed.
When I run the test locally, it looks similar:
# Gs-DEBUG: Considering icon of type GThemedIcon (drive-harddisk), width 0?1
(./_build/plugins/dummy/gs-self-test-dummy:8001): Gs-DEBUG: 08:38:36.392: Considering icon of type GThemedIcon (drive-harddisk), width 0?1
# Gs-DEBUG: Found no icons of the right size; checking themed icons
(./_build/plugins/dummy/gs-self-test-dummy:8001): Gs-DEBUG: 08:38:36.392: Found no icons of the right size; checking themed icons
ok 3 /gnome-software/plugins/dummy/key-colors
From which I suppose the problem is not with the "Found no icons of the right size;", but somewhere else.
Edited by Milan Crha