Skip to content

Fix icon grid visibility after spring animation was cancelled

Jonas Dreßler requested to merge verdre/gnome-shell:fix-animation-regression into master

This is not a regression from the move to Clutters animation framework as I thought at first, it seems to be an older issue.

When cancelling the animations of the icon grid, right now we simply destroy all the clones without resetting the opacity and making the actor reactive again. So if the spring animation to show the grid is cancelled by pressing a key to start a search, the icon clones would be destroyed, but the icon-opacity would still be set to 0. Now if the Escape key is pressed, viewSelector will show the last active page (ie. the iconGrid) without a custom animation and only fade in the page, and because the icons still have an opacity of 0, they will be invisible.

Fix this by always restoring the opacity and reactive property of the original actors if the animation is cancelled instead of only destroying the clones.

Merge request reports