Skip to content

panel: Don't chain up to parent's allocate

Florian Müllner requested to merge wip/fmuellner/avoid-chain-up into master

The top bar handles allocating all its children itself, so there's little value in chaining up to st_widget_allocate() and get the default layout manager allocating all children again (and possibly differently).

If this happens, we end up with an infinite allocation cycle with corresponding performance penalty. Fix this by just doing and what Shell.GenericContainer did before commit 286ffbe2 replaced it, and not chain up to StWidget.

Thanks to Robert Mader for debugging the issue.

Fixes #1054 (closed)

Merge request reports