Skip to content

appFavorites: Don't add app explicitly

Florian Müllner requested to merge wip/fmuellner/duplicate-favs into master

When adding a favorite, we add the ID to the list of favorites, save the setting and add the new app to the favorites map. However as writing the settings value already results in reload() to update the favorites map, the new app is usually already in the map when we add it.

The only exception is when the ID was found in the RENAMED_DESKTOP_IDS map, in which case we end up adding both the renamed app and the original one. Fix this by simply relying on reload() to properly update the map, just like we already do in _removeFavorite().

Fixes #471 (closed)

Merge request reports