Skip to content

main: Don't override DesktopAppInfo desktop if already GNOME

Marco Trevisan requested to merge 3v1n0/gnome-shell:do-not-override-xdg-desktop into master

During the shell initialization we call the (deprecated) function to override the Desktop environment in Gio DesktopAppInfo to make sure that applications are correctly shown (as per commit b2fbf5a2), however this might break the cases in which $XDG_CURRENT_DESKTOP is already set and contains GNOME (given that is now a list).

In Ubuntu this is in fact set to: ubuntu:GNOME. Now, if an application contains NotShowIn=ubuntu, the key will be ignored by the shell, and the application is still listed everywhere.

So, override the DesktopAppInfo desktop environment only in the case that the current desktop is not already GNOME.

At the current date I think we could just safely get rid of this override at all, but there could be still cases where it still might be useful, like when running as nested in some other environment, so keeping it.

If we instead want to remove it completely, it's just fine, but let me know if there are some other rationales

Merge request reports