Skip to content

keyboard: Plug a leak of KeyboardControllers

Jonas Dreßler requested to merge wip/verdre/plug-leak into master

To make sure the GC really disposes the KeyboardController object we need to remove all references to the object, which means we have to disconnect signals the object connects to, too.

This also fixes a bug where keys remain pressed forever and thus also break that key on real keyboards. It happens if the OSK gets destroyed during an OSK-key is being held so the StButton of the key is not released. That means the key remains pressed in the MetaVirtualInputDevice that we are now leaking because KeyboardController isn't garbage collected.

Merge request reports