1. 21 Nov, 2019 10 commits
  2. 20 Nov, 2019 3 commits
  3. 19 Nov, 2019 3 commits
  4. 18 Nov, 2019 1 commit
  5. 16 Nov, 2019 3 commits
    • Florian Müllner's avatar
      keyboard: Try harder to find a matching layout · c1ec7b2f
      Florian Müllner authored
      While we support a reasonable list of layouts nowadays, we don't
      include many variants like `fr+oss`. Instead of directly falling
      back to the `us` layout, try stripping the variant first, as the
      base layout is likely closer to the expectation than `us`.
      
      #1907
      c1ec7b2f
    • verdre's avatar
      polkitAgent: Cancel session after disconnecting signal handlers · 45ebb94b
      verdre authored
      When cancelling the PolkitAgent session before disconnecting the signal
      handlers, we receive a "completed" signal where `gained_authorization`
      is set to FALSE, which means we show an error message inside
      `_onSessionCompleted()`.
      
      This in turn means we show an error message every time we cancel a
      session. In practice this wasn't really relevant so far since we only
      destroyed the session when an actual error occurred before. Now that the
      dialog supports empty passwords, we also call `_destroySession()` when
      the user changes and no longer has a password set, and in this case we
      want to cancel the current session without showing an error message.
      
      So to fix this, disconnect the signal handlers before cancelling the
      session, which makes sure we don't receive the last "completed" signal
      in case we cancelled the session ourselves. This change also allows
      removing `this._wasDismissed`.
      
      !829
      45ebb94b
    • Joaquim Rocha's avatar
      polkitAgent: Use dialog as confirmation when the user has no password · 89bf360b
      Joaquim Rocha authored
      When a user has no password and a polkit authentication is started,
      instead of blindly initiating the admin session, show the regular
      "Authentication Requested" dialog (but without the password entry). This
      makes sure that the user's admin session is only effectively started
      after the user chooses to proceed with the authentication, which
      provides an extra confirmation step that can be vital for critical
      tasks.
      
      To do this, we show the dialog inside `_onUserChanged()` right after the
      dialog was created instead of calling `performAuthentication()` from
      `_onInitiate()`. The bug mentioned in `_onInitiate()` is no longer an
      issue since we show the dialog in all cases now anyway.
      
      Ideally we should use a different wording than "authentication" when the
      user has no password set, and use "confirmation" instead. However polkit
      already sends the requests with such messages (e.g. "Authentication is
      required to configure software repositories"), and it's important to
      show those to the user, so this patch keeps the regular wording.
      
      !829
      89bf360b
  6. 15 Nov, 2019 1 commit
    • verdre's avatar
      polkitAgent: Only reset UI on session resets while opened · 3a7228cf
      verdre authored
      Since `_destroySession()` is not only called before we try to initiate a
      new authentication session with Polkit, but also when the dialog is
      closed, it's currently possible that key focus is grabbed by the close
      button after the dialog was dismissed and hidden. This is causing a bug
      where after dismissing one of multiple queued dialogs, key focus goes
      away and keyboard navigation with the new dialog is impossible.
      
      Fix this by only resetting the UI of the dialog if the dialog is still
      opened/visible at that point.
      
      !828
      3a7228cf
  7. 14 Nov, 2019 1 commit
  8. 12 Nov, 2019 1 commit
  9. 11 Nov, 2019 17 commits