1. 09 Jul, 2019 2 commits
  2. 08 Jul, 2019 4 commits
  3. 07 Jul, 2019 2 commits
    • Florian Müllner's avatar
      st: Consider non-background properties for ::style-changed · be40de5a
      Florian Müllner authored
      st_theme_node_paint_equal() was originally added to preserve paint state
      when a style change didn't affect any of StWidget's cached background
      resources.
      That's why using it for filtering out unneeded style changes as in commit
      f662864a misses any non-background related properties that are relevant
      for subclasses. Add additional tests to make sure we keep emitting the
      signal in those cases.
      
      #1212
      be40de5a
    • Florian Müllner's avatar
      st: Add st_icon_colors_equal() · 7359e431
      Florian Müllner authored
      This is a small convenience wrapper around clutter_color_equal()
      for the different color components, which also handles the case
      where one (or both) of the icon colors are %NULL.
      
      #1212
      7359e431
  4. 05 Jul, 2019 5 commits
    • Florian Müllner's avatar
      params: Fix regression · 8a5de327
      Florian Müllner authored
      The first parameter to Object.assign() is the same target object that
      will be returned. That is, since commit 46874eed Params.parse() modifies
      the @defaults object. Usually we pass that parameter as an object literal
      and this isn't an issue, but the change breaks spectacularly in the few
      cases where we use a re-usable variable.
      
      Restore the previous behavior by copying the object first.
      
      !615
      8a5de327
    • Florian Müllner's avatar
      tests: Add Params.parse() unit tests · 1778adae
      Florian Müllner authored
      Commit 46874eed accidentally changed the behavior of the function in
      an incompatible way. Before addressing the actual issue, add a reproducer
      to the unit tests to hopefully prevent future breakage.
      
      GNOME/gnome-shell!615
      1778adae
    • Florian Müllner's avatar
      cleanup: Prefer template strings · 0d035a4e
      Florian Müllner authored
      Template strings are much nicer than string concatenation, so use
      them where possible; this excludes translatable strings and any
      strings containing '/' (until we can depend on gettext >= 0.20[0]).
      
      [0] https://savannah.gnu.org/bugs/?50920
      
      !612
      0d035a4e
    • Florian Müllner's avatar
      params: Simplify code · 46874eed
      Florian Müllner authored
      Standard javascript now has Object.assign() which is very similar to
      Params.parse(), except that the latter by default disallows "extra"
      parameters. We can still leverage the standard API by simply
      implementing the error check, and then call out to Object.assign()
      for the actual parameter merging.
      
      !612
      46874eed
    • Florian Müllner's avatar
      ibusManager: Use Map to store engines · e95f3feb
      Florian Müllner authored
      This is a clear case of key->value mapping, so using the corresponding
      data type makes sense.
      
      !612
      e95f3feb
  5. 04 Jul, 2019 1 commit
    • verdre's avatar
      st/button: Ungrab device before calling st_button_release · 0bdd1b6f
      verdre authored
      Since priv->device gets set to NULL inside st_button_release, ungrab the
      input device before calling st_button_release and avoid
      clutter_input_device_ungrab failing with a critical error.
      
      This fixes a regression introduced with
      d5a1a888
      
      While at it, also remove the superfluous line resetting priv->device to
      NULL and move the check for priv->grabbed into an elseif block since
      there should be no case where StButton has both grabs at the same time.
      
      !614
      0bdd1b6f
  6. 03 Jul, 2019 1 commit
  7. 02 Jul, 2019 14 commits
  8. 01 Jul, 2019 11 commits