1. 19 Apr, 2019 1 commit
  2. 18 Apr, 2019 2 commits
  3. 17 Apr, 2019 22 commits
  4. 16 Apr, 2019 2 commits
  5. 13 Apr, 2019 2 commits
    • Florian Müllner's avatar
      dash: Fix messed up icon height · 4e5ca6d3
      Florian Müllner authored
      When determining the biggest icon size that fits the available height,
      we first subtract the additional space requirements of icons (spacing,
      padding, running indicator etc.) and then divide the result by the
      number of icons to get the maximum size available to each icon texture.
      
      In the above, the additional space requirement of each icon is taken
      from the first icon (as all icons are assumed to be the same), and
      calculated as the difference between the icon button's preferred height
      and the currently used icon size.
      
      To make sure that the icon is actually using the dash's current icon
      size (even while animating to a new icon size), we enforce its height
      during the size request and restore its original height afterwards.
      
      However after some recent changes, that step is causing troubles:
      For some reason, the original height may be 0, and when we restore it,
      we end up forcing a fixed non-height that bypasses the regular size
      request machinery.
      
      While it is unclear where exactly the zero height comes from (maybe
      waiting for a valid resource scale?), it is clear that it's best
      to avoid forcing a fixed height. So instead of making the icon
      texture comply with the assumed icon size, adjust the calculations
      to use its current height request.
      
      #1053
      4e5ca6d3
    • Florian Müllner's avatar
      dateMenu: Make clock offsets relative to local time · 2fab75f4
      Florian Müllner authored
      We recently added offsets to world clocks that represent the location's
      timezone as UTC offset. However for most users, that representation is
      overly technical and less helpful than the difference to their local time.
      
      #1157
      2fab75f4
  6. 12 Apr, 2019 1 commit
    • Florian Müllner's avatar
      dateMenu: Make sure we always display a clock name · 22883f2f
      Florian Müllner authored
      We currently use the city name for all location except named timezones.
      However locations only have a city name if they are of level CITY or
      DETACHED, or if they are of level WEATHER_STATION with a parent of level
      CITY.
      
      So when libgweather commit d7682676ac9 moved weather station locations from
      cities to countries, it broke their names in the world clocks section.
      
      To fix this, stop making assumptions about when we can use the city name
      and simply try it first for all locations and fall back to the plain name
      if its not available.
      
      #1150
      22883f2f
  7. 11 Apr, 2019 10 commits
    • Florian Müllner's avatar
      extensionPrefs: Fix pref button appearance · 5d9f80bc
      Florian Müllner authored
      After the Adwaita refresh, the button shows up oval rather than
      circular. To address this, make sure that the "image-button" class
      is applied as well by using the dedicated setter function.
      
      !482
      5d9f80bc
    • AsciiWolf's avatar
      appFavorites: Update RENAMED_DESKTOP_IDS · f7d11748
      AsciiWolf authored
      Fixes #1160
      f7d11748
    • Marco Trevisan's avatar
      boxpointer: Compute source allocation and work area just once · 244a329e
      Marco Trevisan authored
      Compute the source actor workarea and allocation when repositioning and keep it
      cached so that we've not to calculating it again in _calculateArrowSide.
      
      Since _calculateArrowSide only is called inside _updateFlip that is always
      called just after reposition, we can be sure that the computed values are still
      correct.
      
      !435
      244a329e
    • Marco Trevisan's avatar
      boxpointer: Use X/Y actor positioning instead of an anchor point · 044572cb
      Marco Trevisan authored
      Currently all the widgets using BoxPointer and so popup actors are always drawn
      at screen origin and then shifted at paint time in the proper position.
      
      This doesn't work when using resource scale, since the widgets need to know
      in which monitor they currently are in order to use properly scaled resources.
      
      So, basically revert commit 22c22e0d and go back using the actual actor
      coordinates for positioning and the actor translation for animating it, as the
      relayouting issues of the past seem to be gone now.
      
      #1008
      !435
      044572cb
    • Marco Trevisan's avatar
      layout: Use an invisible but mapped actor as dummy cursor · 74687525
      Marco Trevisan authored
      Since this could be used as boxpointer source, it should be marked as mapped,
      or it will be ignored.
      
      !435
      74687525
    • Marco Trevisan's avatar
      boxpointer: Compute arrowStride using sourceActor monitor as reference · 4892a87d
      Marco Trevisan authored
      I suppose this was also the goal of commit 96e14dcb, but because it was checking
      the value of the always-undefined this.sourceActor, it really never worked as
      expected.
      
      So, now since we assume that this._sourceActor is always defined just use it
      as reference to compute the monitor menu position.
      
      Fixes #1029
      !435
      4892a87d
    • Florian Müllner's avatar
      windowManager: Don't move sticky windows when inserting workspace · 8b9c8ddb
      Florian Müllner authored
      Inserting a workspace is implemented by appending a new workspace, then
      shifting all windows after the "new" workspace up. This has an unintended
      side effect on sticky windows, as changing its workspace will unstick it.
      
      Fix this by excluding sticky windows - there's little point in moving them
      anyway, given that they should be on all workspaces (including the original
      workspace and the target one).
      
      #1151
      8b9c8ddb
    • Benjamin Berg's avatar
      shellDBus: Accept connector to restrict OSD to one monitor · eb900057
      Benjamin Berg authored
      The monitor index is not something that gnome-shell and
      gnome-settings-daemon seem to be agreeing about. Using the connector
      string is a much more reliable method of identifying a specific screen
      and we are indeed using this already for monitor labling.
      
      So switch over to use the connector rather than the monitor index. If a
      user tries to use the old API, then the OSD will simply show up on all
      monitors (which is the status quo currently anyway).
      
      !489
      eb900057
    • Benjamin Berg's avatar
      shellDBus: Remove ShowMonitorLabels API · 862aaf34
      Benjamin Berg authored
      This API has been broken for quite some time now as the corresponding
      mutter function meta_monitor_manager_get_monitor_for_output was removed.
      If anyone tries to use it, we would just run into a backtrace.
      
      !490
      862aaf34
    • Florian Müllner's avatar
      screenshot: Don't pick up rubberband style from GTK · a5c75ff5
      Florian Müllner authored
      Selecting a screen area for a screenshot isn't the same as selecting
      items in an icon view, so there's no strong rationale for picking
      up the style from GTK. We stopped doing that for other elements like
      tile previews long ago, so just use our own style here too.
      
      !481
      a5c75ff5