1. 18 Jun, 2019 4 commits
    • Marco Trevisan's avatar
      keyboard: Add extended keys and language popups to top window group · 4e84b46c
      Marco Trevisan authored
      As per commit 2bd80579 important actors are added to the top window group
      using the layout's addTopChrome method.
      This group includes the on-screen keyboard, however its popups were not added
      and so they are now shown under the OSK and don't receive any input.
      Fix this by adding Language popup and extended keys popup to top chrome.
      Fixes #1396
    • Florian Müllner's avatar
      iconGrid: Fix animation glitch · b4797956
      Florian Müllner authored
      Since commit 520cea93, the opacity of icon grid children is used
      both to skip children outside the current viewport and to hide the
      real icons while animating icon clones.
      As a result, a grid animation during an animation now ends up showing the
      icons that are being animated. Avoid that glitch by leaving children's
      opacity alone when there's an ongoing animation.
    • Marco Trevisan's avatar
      appDisplay: Set Adjustment value after allocation · c1c45f95
      Marco Trevisan authored
      AllView's adaptToSize is called as part of viewStack allocation vfunc, and this
      makes the adjustment value to be reset while relayouting.
      So, fix this by delaying this using the Meta later that we already had for
      pageIndicators operations.
      Fixes: #1392
    • Iain Lane's avatar
      main, LoginManager: Call GDM's RegisterSession() · 0e37cd2e
      Iain Lane authored
      So that it can know if we started up properly and use that to (e.g.)
      kill its greeter.
  2. 17 Jun, 2019 5 commits
  3. 15 Jun, 2019 2 commits
    • Florian Müllner's avatar
      main: Use GLib's structured logging support · 07d25cd6
      Florian Müllner authored
      We still use our own copy of a libgsystem method for structured
      logging, but since then GLib has gained (introspectable) API for
      that functionality, so switch to that.
    • Marco Trevisan's avatar
      iconGrid: Don't hide children inside allocation loop · 520cea93
      Marco Trevisan authored
      Hiding a child implies a parent reallocation, and IconGrid does it for the
      children that doesn't fit in the available space, but this could lead to an
      allocation recursion cycle. This has been introduced by commit 0e0574a0 to
      reduce CPU usage not to using JS vfuncs.
      To avoid this, toggle the children opacity instead so that we can achieve the
      same visibility result, without any reallocation need.
      In this way we also fix the case where hidden children can be shown again,
      as _getVisibleChildren doesn't filter-out transparent ones, restoring the
      pre-commit 0e0574a0 behavior.
      Fixes #1336
  4. 14 Jun, 2019 2 commits
    • Marco Trevisan's avatar
      background: Group 'changed' signal emission · 7059e31f
      Marco Trevisan authored
      Background is monitoring the whole `org.gnome.desktop.background` gsettings keys
      for changes connecting to the non-specialized 'changed' signal and re-emitting
      this as-is.
      This means that when the background is changed via control-center, we get
      multiple 'changed' signal events from GSettings, and for each one of this we
      recreate a Background and a BackgroundActor.
      Avoid this by using an idle to delay the emission of the 'changed' signal
      grouping the events.
    • Marco Trevisan's avatar
      background: Use Garbage Collector to dispose background · a9234f76
      Marco Trevisan authored
      The same Meta.Background could be used by multiple instances of background
      actors, and so should not be disposed when the actor using it is destroyed.
      Instead of calling `run_dispose` directly on it, just nullify the reference
      on destroy method, leaving the job of doing the proper disposition to the
      gabage collector that keeps the proper reference count on the Meta.Background.
      Fixes #501
  5. 06 Jun, 2019 2 commits
  6. 05 Jun, 2019 4 commits
  7. 29 May, 2019 6 commits
    • Cosimo Cecchi's avatar
      search: reload search providers when installed applications change · 40c2a403
      Cosimo Cecchi authored
      Otherwise, a shell restart will be required after installing a new
      application, before its results can be seen in search.
    • Marco Trevisan's avatar
      grabHelper: Throw an error if the owner is not an actor · 238b87d3
      Marco Trevisan authored
      Starting from commit 7bb84dae, GrabHelper requires the owner to be an Actor as
      we pass this to pushModal that assumes it to be as well.
      So check that GrabHelper owner is an actor and throws an error if it is not the
      case. This helps in tracking down issues such as gnome-shell-extensions!68
    • Marco Trevisan's avatar
      PopupMenuManager: Remove unneeded _owner reference · 8c01d341
      Marco Trevisan authored
      Nothing inside PopupMenuManager is using the owner, while a reference of it is
      already owned by the GrabHelper, so remove this dead property.
    • Florian Müllner's avatar
      windowManager: Disable favorite shortcuts without overview · 866629b3
      Florian Müllner authored
      The `switch-to-application-n` shortcuts are essentially "launch the nth
      app in the dash" actions, so they are at the very least confusing when
      the dash isn't available because the overview itself is disabled (for
      example in initial-setup mode).
      So disable the shortcuts when the overview is disabled, but delegate the
      decision to a separate function so that extensions like 'panel-favorites'
      which expose favorites by some other means can easily re-enable them.
    • Marco Trevisan's avatar
      windowMenu: Do actions requiring grab once ungrabbed · 2b3ab3ec
      Marco Trevisan authored
      Resizing or moving a window needs starting a keyboard grab. However, if the
      action is triggered by a menu entry activation it might not work as we already
      have already an active grab on input devices to manage the menu itself.
      So, possibly wait maximum 100ms for the current grab operation to be completed
      before trying go start a new one.
      Needs mutter!596
      Fixes #1326
    • Marco Trevisan's avatar
      popupMenu: Connect after to item 'activate' signal · 759120b9
      Marco Trevisan authored
      A menu item activation might lead to a call to `itemActivated` which eventually
      will close the menu which leads to a `PopupMenu.removeAll` that destroys all the
      items, stopping the emission of the 'activate' signal for them.
      Before commit 4258ae3e this was not happening because destroy'ing a javascript
      object wasn't really disposing it and thus stopping the signal emissions.
      So, ensure that `itemActivated` is called after that all the other callbacks
      have been consumed, and so that the menu is closed as last thing.
      Fixes #1326
  8. 28 May, 2019 1 commit
  9. 27 May, 2019 2 commits
  10. 24 May, 2019 3 commits
  11. 22 May, 2019 1 commit
  12. 21 May, 2019 1 commit
  13. 20 May, 2019 3 commits
  14. 19 May, 2019 1 commit
  15. 16 May, 2019 2 commits
  16. 15 May, 2019 1 commit
    • verdre's avatar
      layout: Show important actors above top_window_group · 2bd80579
      verdre authored
      The top_window_group is used for windows like popup menus, which should
      appear above shell chrome like the panel.
      Since we want important actors such as the screen keyboard or modal
      dialogs to be shown above those windows, add their actors after adding
      global.top_window_group to this.uiGroup and provide a new function
      addTopChrome() to add important chrome above the top_window_group.
      Fixes #917