1. 13 Apr, 2019 1 commit
  2. 12 Apr, 2019 1 commit
    • Florian Müllner's avatar
      dateMenu: Make sure we always display a clock name · 22883f2f
      Florian Müllner authored
      We currently use the city name for all location except named timezones.
      However locations only have a city name if they are of level CITY or
      DETACHED, or if they are of level WEATHER_STATION with a parent of level
      So when libgweather commit d7682676ac9 moved weather station locations from
      cities to countries, it broke their names in the world clocks section.
      To fix this, stop making assumptions about when we can use the city name
      and simply try it first for all locations and fall back to the plain name
      if its not available.
  3. 11 Apr, 2019 16 commits
    • Florian Müllner's avatar
      extensionPrefs: Fix pref button appearance · 5d9f80bc
      Florian Müllner authored
      After the Adwaita refresh, the button shows up oval rather than
      circular. To address this, make sure that the "image-button" class
      is applied as well by using the dedicated setter function.
    • AsciiWolf's avatar
      appFavorites: Update RENAMED_DESKTOP_IDS · f7d11748
      AsciiWolf authored
      Fixes #1160
    • Marco Trevisan's avatar
      boxpointer: Compute source allocation and work area just once · 244a329e
      Marco Trevisan authored
      Compute the source actor workarea and allocation when repositioning and keep it
      cached so that we've not to calculating it again in _calculateArrowSide.
      Since _calculateArrowSide only is called inside _updateFlip that is always
      called just after reposition, we can be sure that the computed values are still
    • Marco Trevisan's avatar
      boxpointer: Use X/Y actor positioning instead of an anchor point · 044572cb
      Marco Trevisan authored
      Currently all the widgets using BoxPointer and so popup actors are always drawn
      at screen origin and then shifted at paint time in the proper position.
      This doesn't work when using resource scale, since the widgets need to know
      in which monitor they currently are in order to use properly scaled resources.
      So, basically revert commit 22c22e0d and go back using the actual actor
      coordinates for positioning and the actor translation for animating it, as the
      relayouting issues of the past seem to be gone now.
    • Marco Trevisan's avatar
      layout: Use an invisible but mapped actor as dummy cursor · 74687525
      Marco Trevisan authored
      Since this could be used as boxpointer source, it should be marked as mapped,
      or it will be ignored.
    • Marco Trevisan's avatar
      boxpointer: Compute arrowStride using sourceActor monitor as reference · 4892a87d
      Marco Trevisan authored
      I suppose this was also the goal of commit 96e14dcb, but because it was checking
      the value of the always-undefined this.sourceActor, it really never worked as
      So, now since we assume that this._sourceActor is always defined just use it
      as reference to compute the monitor menu position.
      Fixes #1029
    • Florian Müllner's avatar
      windowManager: Don't move sticky windows when inserting workspace · 8b9c8ddb
      Florian Müllner authored
      Inserting a workspace is implemented by appending a new workspace, then
      shifting all windows after the "new" workspace up. This has an unintended
      side effect on sticky windows, as changing its workspace will unstick it.
      Fix this by excluding sticky windows - there's little point in moving them
      anyway, given that they should be on all workspaces (including the original
      workspace and the target one).
    • Benjamin Berg's avatar
      shellDBus: Accept connector to restrict OSD to one monitor · eb900057
      Benjamin Berg authored
      The monitor index is not something that gnome-shell and
      gnome-settings-daemon seem to be agreeing about. Using the connector
      string is a much more reliable method of identifying a specific screen
      and we are indeed using this already for monitor labling.
      So switch over to use the connector rather than the monitor index. If a
      user tries to use the old API, then the OSD will simply show up on all
      monitors (which is the status quo currently anyway).
    • Benjamin Berg's avatar
      shellDBus: Remove ShowMonitorLabels API · 862aaf34
      Benjamin Berg authored
      This API has been broken for quite some time now as the corresponding
      mutter function meta_monitor_manager_get_monitor_for_output was removed.
      If anyone tries to use it, we would just run into a backtrace.
    • Florian Müllner's avatar
      screenshot: Don't pick up rubberband style from GTK · a5c75ff5
      Florian Müllner authored
      Selecting a screen area for a screenshot isn't the same as selecting
      items in an icon view, so there's no strong rationale for picking
      up the style from GTK. We stopped doing that for other elements like
      tile previews long ago, so just use our own style here too.
    • Florian Müllner's avatar
      perf: Stop using GTK · 4541fb98
      Florian Müllner authored
      Instead of going through GtkSettings, we can just as well use the
      underlying GSettings directly.
    • Florian Müllner's avatar
      panel: Remove left-over Gtk.Settings · 9f8edd98
      Florian Müllner authored
      It has been unused since commit c334aa2a.
    • Florian Müllner's avatar
      workspacesView: Support touch/touchpad gestures to switch workspaces · e5b90434
      Florian Müllner authored
      Now that the existing touch/touchpad gestures in windowManager only
      handle normal mode, add corresponding gestures for the overview and
      hook them up to the existing workspace scroll animations.
    • Florian Müllner's avatar
      windowManager: Limit switch gestures to normal mode · c0012c2e
      Florian Müllner authored
      The window group is hidden while in overview, so the stick-to-content
      animation isn't visible either. Worse, the gestures messes up the
      position of window actors in that case. Just limit the gesture to
      normal mode for now, we will soon add it back in the overview with
      its own animation handling.
    • Florian Müllner's avatar
      switchGestures: Do not hard-code allowed modes · b77e4975
      Florian Müllner authored
      The touch/touchpad gestures to switch workspace currently hard-code
      the modes in which we want the gestures to work. While these modes
      are correct, the existing switch animation only works in NORMAL mode,
      not in the overview where the window group is hidden. The easiest way
      to address this is to handle both cases completely separately, namely
      use separate actions in- and outside the overview.
      Make the existing usable in that way by making the list of allowed
      modes a constructor parameter.
    • Florian Müllner's avatar
      windowManager: Allow disabling touchpad workspace switch action · e83f2344
      Florian Müllner authored
      Just like actual ClutterActions, it can make sense to temporarily
      disable the touchpad action, so add an appropriate property.
  4. 08 Apr, 2019 2 commits
  5. 03 Apr, 2019 2 commits
    • Florian Müllner's avatar
      weather: Handle missing permission store · fea01927
      Florian Müllner authored
      Our weather integration is supposed to follow GNOME Weather's settings,
      including its permission to use location services. However there's a
      discrepancy in case xdg-desktop-portal is unavailable:
      While our geoclue agent grants all applications access to location
      services in that case, the weather integration treats it as if
      access was denied.
      Fix this by handling this case explicitly.
    • Florian Müllner's avatar
      ci: Use custom image for commit log check · f81ac498
      Florian Müllner authored
      We can speed up the check a little bit by using an image that
      already contains git, so do that.
  6. 02 Apr, 2019 3 commits
  7. 01 Apr, 2019 8 commits
  8. 31 Mar, 2019 2 commits
  9. 28 Mar, 2019 1 commit
    • Florian Müllner's avatar
      app: Consider "quit" action for quit · 1767cd0f
      Florian Müllner authored
      Just like we take a remote "new-window" action into account for
      opening new windows, we should call an explicit "quit" action
      before falling back to closing all the app's windows on quit.
  10. 27 Mar, 2019 4 commits
    • Marco Trevisan's avatar
      magnifier: Only connect to signals when ZoomRegion is active · 3e091552
      Marco Trevisan authored
      There's no need to listen signals when the zoom region is inactive, so let's
      just connect/disconnect them.
    • Marco Trevisan's avatar
      magnifier: Update screen position on activation · a298943f
      Marco Trevisan authored
      The default ZoomRegion is created at startup and only updated if it is active
      when the monitor setup changes. Thus when reactivating the magnifier after a
      display change, the viewport used is still the one that been computed with the
      old screen geometry values.
      Move screen update code inside a function and call it both when activating
      the zoom region and when the monitor changes during a zoom session.
      Fixes #1120
    • Florian Müllner's avatar
      iconGrid: Chain up in style-changed · df9ddf96
      Florian Müllner authored
      Commit 81ec8215 moved the handling of style changes from a signal
      handler to a vfunc without chaining up to the parent, losing propagating
      the change to children and queueing a paint update.
    • Florian Müllner's avatar
      network: Catch errors when reading devices · 4fa5d701
      Florian Müllner authored
      NetworkManager added support for a new device - NMDeviceWifiP2P - but
      did not add the corresponding enum value in NMDeviceType. The return
      value for nm_device_get_device_type() is therefore "illegal" for the
      newly added device, and gjs throws an exception.
      This should ultimately be fixed in libnm, but as errors when adding
      one device shouldn't interfere with adding any other devices, catching
      exception is a good idea anyway, so do just that.