Skip to content
  • Marco Trevisan's avatar
    iconGrid: Don't hide children inside allocation loop · 520cea93
    Marco Trevisan authored and Florian Müllner's avatar Florian Müllner committed
    Hiding a child implies a parent reallocation, and IconGrid does it for the
    children that doesn't fit in the available space, but this could lead to an
    allocation recursion cycle. This has been introduced by commit 0e0574a0 to
    reduce CPU usage not to using JS vfuncs.
    
    To avoid this, toggle the children opacity instead so that we can achieve the
    same visibility result, without any reallocation need.
    In this way we also fix the case where hidden children can be shown again,
    as _getVisibleChildren doesn't filter-out transparent ones, restoring the
    pre-commit 0e0574a0 behavior.
    
    Fixes #1336
    
    !559
    520cea93