Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,877
    • Issues 1,877
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 125
    • Merge requests 125
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !871

switcherPopup: Fix scrollable check

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Florian Müllner requested to merge fmuellner/gnome-shell:fix-switcher-arrow into master Nov 29, 2019
  • Overview 3
  • Commits 1
  • Pipelines 4
  • Changes 1

When commit c6cea277 replaced Shell.GenericContainer, the check whether the required width exceeds the avilable width was changed from using the minimum widths of items to the natural width of the scroll view.

That doesn't work correctly, as the natural width may well exceed the actually used width: Namely the width applied by the style can restrict labels to allocate a smaller width than they would request unellipsized.

Fix this by using the minimum width of the scroll view's child instead.

Fixes #1834 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-switcher-arrow