Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,052
    • Issues 2,052
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 150
    • Merge requests 150
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !84

window-tracker: check WM_CLASS for sandboxed apps before the app's ID

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mario Sanchez Prada requested to merge issue219 into master Apr 20, 2018
  • Overview 18
  • Commits 1
  • Pipelines 0
  • Changes 1

For sandboxed apps, the shell needs to consider the app's ID when matching its windows against the right .desktop file, but that check can't be done before having attempted to match using the WM_CLASS property of the app's window, otherwise apps installing multiple desktop files (e.g. LibreOffice) will always match every single window against the same .desktop file, ignoring hints such as the StartupWMClass key.

This commit moves the call to get_app_from_sandboxed_app_id() after get_app_from_window_wmclass() and before get_app_from_window_pid(), so that we only rely on the sandboxed app's ID when no match has succeed using the WM_CLASS property, but before checking by PID to prevent wrong groups that could be created when the PID of the app inside the sandbox matches the one from a process outside of it.

Closes: #219 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue219