Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,831
    • Issues 1,831
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !803

Bin bin props

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Florian Müllner requested to merge fmuellner/gnome-shell:bin-bin-props into master Nov 04, 2019
  • Overview 1
  • Commits 4
  • Pipelines 4
  • Changes 33

By now, all containers and layout managers except StBin (and its subclasses) use the generic ClutterActor expand/align properties to control how their children are laid out.

This is particularly confusing as two or the properties StBin uses for layout - x-align and y-align - shadow the generic ClutterActor ones, but work very differently: They use a different enum and determine how the bin lays out its child, instead of how the bin is laid out by its parent.

Address this by deprecating the StBin properties and using the same generic ClutterActor properties as everyone else.

Continuation from !780 (merged).

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bin-bin-props