Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
G
gnome-shell
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,260
    • Issues 1,260
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 102
    • Merge Requests 102
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • gnome-shell
  • Merge Requests
  • !590

Closed
Opened Jun 24, 2019 by verdre@verdreDeveloper
  • Report abuse
Report abuse

Polkit agent fixes + show dialog if admin user has empty password

  • Overview 9
  • Commits 9
  • Pipelines 8
  • Changes 1

Fix some bugs and usability issues in the polkit dialog:

  • Make the "Authenticate" button insensitive by default until polkit asks for a password
  • Make the "Authenticate" button insensitive if there's nothing in the password entry
  • Also show the avatar for the root user (design input might be needed)
  • Update the user name on user-changes
  • Set key focus to the "Cancel" button if there's no password entry
  • Fix a bug where the user avatar isn't visible on first run of the dialog

Including the changes from !30 (closed).

I know this is a bit of a "mixed-bag" MR that's not very beloved here, but it should still be reasonably quick to review and I figured splitting this up into smaller MRs would end us up with about 4 MRs dependent on each other.

The not completely sold on the last commit, but I can't think of a better way to prevent the visual annoyance.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: GNOME/gnome-shell!590
Source branch: small-polkit-agent-refactoring