Skip to content

FdoNotificationDaemon: prefer app name for source identification

The reason for this MR is that BackInTime DoS'ed my desktop several times.


All well-behaved apps should get matched via _getSourceForApp and are not affected by this change at all.

Not-so-well-behaved apps, like notify-send, are now grouped into one source per "appName". This means they are now limited by MAX_NOTIFICATIONS_PER_SOURCE like the well-behaved apps.

This prevents accidential notification DoS by runaway cli apps.

gnome-shell now survises

for i in $(seq 1000) ; do notify-send foo ; done

where it would stutter badly before.

Actively hostile apps may still bypass this by randomizing appName. To fix this, the number of sources could be limited.

Fixes: #209

Edited by Jakob Unterwurzacher

Merge request reports

Loading