Skip to content

Draft: overviewControls: Handle thumbnails box should-show changes during creation

Jonas Dreßler requested to merge verdre/gnome-shell:thumbnails-box-regression into main

overviewControls: Handle thumbnails box should-show changes during creation

We set the expand-fraction property of the workspace thumbnails on changes to their should-show property. The should-show property defaults to true, and the expand-fraction property defaults to 1. The should-show property gets updated in the constructor of the ThumbnailsBox though, and it might become false (that is the case when starting up the shell) during construction.

In this case we're not yet listening to "notify::should-show" in the ControlsManager, and therefore forget to update the expand-fraction accordingly. Fix that by updating the expand-fraction after creating the ThumbnailsBox just like we do on "notify::should-show" (avoiding the animation though).

This should be the proper fix for the problem that 9bf550da (which caused the workspace thumbnails to never show) originally tried to fix.

Fixes: 9bf550da ("overviewControls: Set expandFraction for ws thumbnails to 0 when hidden") Closes: #7668 (closed)

Depends on: !3354

Edited by Jonas Dreßler

Merge request reports