Skip to content

Disconnect a signal that should be disconnected but is not

Zacharie DUBRULLE requested to merge Rayzeq/gnome-shell:main-patch-bf44 into main

This fix a bug when an old target is destroyed, but nothing is being dragged.

The bug cause this message to be printed many times this message into the logs:

JS ERROR: TypeError: this._dragActor is null
_pickTargetActor@resource:///org/gnome/shell/ui/dnd.js:516:9
handleTargetActorDestroyClosure@resource:///org/gnome/shell/ui/dnd.js:535:27
destroy@resource:///org/gnome/shell/ui/popupMenu.js:806:20
destroy@resource:///org/gnome/shell/ui/popupMenu.js:954:15
setMenu@resource:///org/gnome/shell/ui/panelMenu.js:121:23
enable/<@/home/zacharie/.local/share/gnome-shell/extensions/quick-settings-audio-panel@rayzeq.github.io/libs/libpanel.js:476:20
unpatch_all@/home/zacharie/.local/share/gnome-shell/extensions/quick-settings-audio-panel@rayzeq.github.io/libs/libpanel.js:66:14
disable@/home/zacharie/.local/share/gnome-shell/extensions/quick-settings-audio-panel@rayzeq.github.io/libs/libpanel.js:491:19
disable@/home/zacharie/.local/share/gnome-shell/extensions/quick-settings-audio-panel@rayzeq.github.io/extension.js:298:18
_callExtensionDisable@resource:///org/gnome/shell/ui/extensionSystem.js:133:32
_onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:570:24
_loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:632:18
createCheckedMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:730:46
disableExtension@resource:///org/gnome/shell/ui/extensionSystem.js:239:29
DisableExtension@resource:///org/gnome/shell/ui/shellDBus.js:451:38
_handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:329:38
_wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34

Merge request reports