Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,075
    • Issues 2,075
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 160
    • Merge requests 160
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !2616

Revert "status/volume: Clear device menus when unsetting stream"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Florian Müllner requested to merge fmuellner/gnome-shell:audio-devices-take-2 into main Jan 26, 2023
  • Overview 1
  • Commits 2
  • Pipelines 4
  • Changes 2

Device additions/removals are tracked by GvcMixerControl, which doesn't change when unsetting the stream. So clearing the menu manually was a workaround, not a fix.

It's also worth noting that I failed to reproduce the original issue again, so it's possible that we were working around a pipewire bug that has since been fixed.

This reverts commit 1b62b7ea.

Fixes #6207 (closed)

Edited Jan 26, 2023 by Florian Müllner
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: audio-devices-take-2