Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 2.1k
    • Issues 2.1k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 149
    • Merge requests 149
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !2413

screenShield: Only wake up screen when active

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Florian Müllner requested to merge fmuellner/gnome-shell:lock-notification into main Aug 09, 2022
  • Overview 2
  • Commits 2
  • Pipelines 6
  • Changes 2

We treat wake up requests the same as user activity, as in general the two behave the same: Turn on the screen and reset the idle watch until the system becomes idle again.

The big exception is when the screen isn't locked yet. In that case user activity should interrupt the automatic screen lock, but a request to wake-up the screen (like showing a notification) should not.

Address this by ignoring wake-up requests while the screen shield isn't active, as we can expect the screen to still be turned on at that point.

Fixes #5719 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: lock-notification