Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,044
    • Issues 2,044
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 153
    • Merge requests 153
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !2409

bluetooth: Fix remembering set up devices

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Florian Müllner requested to merge fmuellner/gnome-shell:bt-fixes into main Aug 08, 2022
  • Overview 4
  • Commits 2
  • Pipelines 4
  • Changes 1

It is generally not possible to differentiate between systems without bluetooth support, and systems where a bluetooth adapter is powered down.

We work around that by tracking whether there are any set up devices, and keep the bluetooth visible in that case, even when no adapter is present.

However commit eeabdd15 moved updating the setting into the code that handles adapter changes, which is exactly the place where we carefully avoid changing the setting because it would be too unreliable (devices may have already disappeared, or not yet appeared).

Fix this by changing _setHadSetupDevices() to _syncHadSetupDevices() and call that everywhere _sync() used to be called, except on adapter changes.

Fixes #5714 (closed) Fixes #5722 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bt-fixes